foreign_key_validation 0.0.8 → 1.0.0

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    ZmIyZjgxODI4YjY3ZjBiMWE5YzAxMWY1OTU2MjBjMmM2NDY4ZTVlNA==
+    ZjUwMTlkNzAzZDliZTUxOGViNzJmNDA4YTVhNGY5NzEzNjdlYzJkZg==
   data.tar.gz: !binary |-
-    NGE0M2NkZDBmZDM0ODU0NWVjNzA4NWQ3NWFiNWNiOTYxMDZkOGYxZg==
+    OWJkZjlkM2I4NWIyYmY3Y2IyZDRjZDQ2NTk3MjBjZDQ0YzkyMjFmNw==
 SHA512:
   metadata.gz: !binary |-
-    OTRiYzRkNzFhMTI3MzllZTdiOWMwZjIyOWM5NDcyYjMzNjg5Y2U5YTZjMTZi
-    MDk0NzZhYjM0ZjE0NDM3ZTA5OWMyNTIwNGU0YjRmM2EwZjZlNzEzZGJiNmY1
-    OTgxMTU1YzQ0NzU2YjlmZDQxOGQ2OGQ3MmE2ZGEyYTM0YzkwNTg=
+    OTBmZmRhZDZlZDI5MDc1ZWM3Y2ExOWMxODIzZmQ1YjI3YmFkZjJkYTg2OTI3
+    NTYxNWNhZmJmOTAyYzI2NjhiNTY4ODYzYjdhNjIxM2JiZTEyNjhhNTI0ZTcx
+    MDEwZDc5ZDc1ZWE2M2EyZDUxMmQyNDMxYTdkYzk0M2M3ZGFlMTQ=
   data.tar.gz: !binary |-
-    NmY1ZjI1MDVmMmVhM2U4Yjk3MTg0OTE5NTZjYzg5ZjhkNzg5NTIzYjIxNzFh
-    ZWI4M2JkY2E4YjM3MTVjMTI1Y2IzZjFjNDY3ODQxODlkMWNlZTEyYzIzYTcy
-    ZmYwYzhkNGQ4M2M2Y2YyODg3ZDNlZThjYzRjNDhiMTgxMzY2ODM=
+    MmVhODBlOWU0MzQxNTRhYjIyN2U4MGJhNjViZDUwNzc3MTIyNDljY2M2MGE3
+    NjJjZjUwODEzNTJiMjM4ZGYwMTI2MTNmNWMwZmQ0YjhiY2FlMDVjOWM5OTFj
+    YmMwM2ZkN2NkZjMxOTc1Y2VlZDBhOThjNmI1YzZkZTMzMDJjNTk=

data/.coveralls.yml

@@ -0,0 +1,2 @@
+service_name: travis-ci
+repo_token: p5anrHEyw6IcvCwmbaQD4ohlizZOLEwIO

data/.gitignore

@@ -20,3 +20,4 @@ tmp
 *.o
 *.a
 mkmf.log
+gemfiles/*.lock

data/.travis.yml

@@ -0,0 +1,14 @@
+language: ruby
+
+script: "bundle exec rspec"
+
+rvm:
+  - 1.9.3
+  - 2.0.0
+  - 2.1.2
+
+gemfile:
+  - gemfiles/3.2.gemfile
+  - gemfiles/4.0.gemfile
+  - gemfiles/4.1.gemfile
+  - gemfiles/4.2.gemfile

data/Appraisals

@@ -0,0 +1,19 @@
+appraise "3.2" do
+  gem "rails", "~> 3.2.0"
+  gemspec
+end
+
+appraise "4.0" do
+  gem "rails", "~> 4.0.0"
+  gemspec
+end
+
+appraise "4.1" do
+  gem "rails", "~> 4.1.0"
+  gemspec
+end
+
+appraise "4.2" do
+  gem "rails", "~> 4.2.0.beta2"
+  gemspec
+end

data/README.md

@@ -1,11 +1,14 @@
 # foreign_key_validation
 
-Protect your models by specifying a collection of relations that should be tested for consistency with the `user_id` column. For example, when the `user_id` is used in all models we can check if the `user_id` of `model a` matches `user_id` of `model b` before saving the records - if the IDs are different, an error will be attached to the errors hash of `self`. 
+[![Coverage Status](https://coveralls.io/repos/marcusg/foreign_key_validation/badge.png?branch=master)](https://coveralls.io/r/marcusg/foreign_key_validation?branch=master)
+[![Code Climate](https://codeclimate.com/github/marcusg/foreign_key_validation/badges/gpa.svg)](https://codeclimate.com/github/marcusg/foreign_key_validation)
+[![Build Status](https://travis-ci.org/marcusg/foreign_key_validation.svg?branch=master)](https://travis-ci.org/marcusg/foreign_key_validation)
+
+Protect your models by specifying a collection of relations that should be tested for consistency with a predefined column (e.g. `user_id`).This is useful when the column `user_id` is used in multiple models. We can check if the `user_id` of *model A* matches `user_id` of *model B* before saving the records - if the IDs are different, an error will be attached to the errors hash of checked model.
 
 ## Requirements
-    ruby >= 1.9
-    rails
-    active_record
+    ruby >= 1.9.3
+    rails >= 3.2.0
 
 ## Installation
 
@@ -23,7 +26,7 @@ Or install it yourself as:
 
 ## Usage
 
-Call `validate_foreign_keys` below the association definitions (`belongs_to`, ...) in your model. By default it assumes that it should check all `belongs_to` relations against the `user_id` column. So any relation will be checked for a matching `user_id`. 
+Call `validate_foreign_keys` below the association definitions (`belongs_to`, ...) in your model. By default it assumes that it should check all `belongs_to` relations against the `user_id` column. So any relation will be checked for a matching `user_id`.
 
 Change behaviour by calling `validate_foreign_keys` with arguments hash.
 
@@ -35,6 +38,14 @@ This would only check `model.project.admin_user_id` to match `model.admin_user_i
 
 Only tested with ActiveRecord
 
+## Tests
+
+Use these commands to run the testsuite against different versions of Rails
+
+    bundle
+    appraisal install
+    appraisal rspec
+
 
 ## Contributing
 

data/foreign_key_validation.gemspec

@@ -4,25 +4,28 @@ $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'foreign_key_validation/version'
 
 Gem::Specification.new do |spec|
-  spec.name          = "foreign_key_validation"
+  spec.name          = 'foreign_key_validation'
   spec.version       = ForeignKeyValidation::VERSION
-  spec.authors       = ["Marcus Geißler"]
-  spec.email         = ["marcus3006@gmail.com"]
+  spec.authors       = ['Marcus Geißler']
+  spec.email         = ['marcus3006@gmail.com']
   spec.summary       = %q{Protect the foreign keys in your Rails models.}
   spec.description   = %q{Protect the foreign keys in your Rails models by checking the user_id of self against the user_id of all relations.}
-  spec.homepage      = "https://github.com/marcusg/foreign_key_validation"
-  spec.license       = "MIT"
+  spec.homepage      = 'https://github.com/marcusg/foreign_key_validation'
+  spec.license       = 'MIT'
 
   spec.files         = `git ls-files -z`.split("\x0")
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
-  spec.require_paths = ["lib"]
+  spec.require_paths = ['lib']
 
-  spec.add_development_dependency "rails", "~> 4.0"
-  spec.add_development_dependency "bundler", "~> 1.6"
-  spec.add_development_dependency "rake", "~> 10.1"
-  spec.add_development_dependency "rspec-rails", "~> 3.0"
-  spec.add_development_dependency "sqlite3", '~> 1.3'
-  spec.add_development_dependency "pry", '~> 0.10'
+  spec.add_runtime_dependency "rails", ">= 3.2"
 
+  spec.add_development_dependency 'appraisal', '~> 1.0'
+  spec.add_development_dependency 'coveralls', '~> 0.7'
+  spec.add_development_dependency 'bundler', '~> 1.6'
+  spec.add_development_dependency 'rake', '~> 10.1'
+  spec.add_development_dependency 'rspec-rails', '~> 3.0'
+  spec.add_development_dependency 'database_cleaner', '~> 1.3'
+  spec.add_development_dependency 'sqlite3', '~> 1.3'
+  spec.add_development_dependency 'pry', '~> 0.10'
 end

data/gemfiles/3.2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 3.2.0"
+
+gemspec :path => "../"

data/gemfiles/4.0.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.0.0"
+
+gemspec :path => "../"

data/gemfiles/4.1.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.1.0"
+
+gemspec :path => "../"

data/gemfiles/4.2.gemfile

@@ -0,0 +1,7 @@
+# This file was generated by Appraisal
+
+source "https://rubygems.org"
+
+gem "rails", "~> 4.2.0.beta2"
+
+gemspec :path => "../"

data/lib/foreign_key_validation/errors.rb

@@ -0,0 +1,25 @@
+module ForeignKeyValidation
+  module Errors
+
+    class NoReleationFoundError < StandardError
+      def initialize(name)
+        super("Can't find any belongs_to relations for #{name} class. Put validation call below association definitions!")
+      end
+    end
+
+    class NoForeignKeyFoundError < StandardError
+      def initialize(validate_against, table_name)
+        super("No foreign key for relation #{validate_against} on #{table_name} table!")
+      end
+    end
+
+    class UnknownRelationError < StandardError
+      def initialize(validate_with)
+        super("Unknown relation in #{validate_with}!")
+      end
+    end
+
+  end
+end
+
+

data/lib/foreign_key_validation/model_extension.rb

@@ -15,26 +15,19 @@ module ForeignKeyValidation
 
     module ClassMethods
       def validate_foreign_keys(opt={})
-        subclasses.map {|klass| klass.send(:validate_foreign_keys, opt) } if subclasses.any?
+        subclasses.map {|klass| klass.send(:validate_foreign_keys, opt)}
 
-        validate_against      = (opt[:on] || :user).to_s
-        reflections           = reflect_on_all_associations(:belongs_to)
-        reflection_names      = reflections.map(&:name).map(&:to_s)
-        validate_against_key  = reflections.select {|r| r.name.to_s == validate_against}.first.try(:foreign_key)
-        validate_with         = ((Array(opt[:with]).map(&:to_s) if opt[:with]) || reflection_names).reject {|n| n == validate_against}
+        validator = Validator.new(self, opt)
+        validator.check
 
-        raise ArgumentError, "Can't find any belongs_to relations for #{name} class. Put validation call below association definitions!" if reflection_names.empty?
-        raise ArgumentError, "No foreign key for relation #{validate_against} on #{table_name} table!" unless reflection_names.include?(validate_against)
-        raise ArgumentError, "Unknown relation in #{validate_with}!" unless validate_with.all? {|k| reflection_names.include?(k) }
-
-        define_method "validate_foreign_keys_on_#{validate_against}" do
-          validate_with.each do |reflection_name|
-            validate_foreign_key(validate_against_key, reflection_name)
+        define_method validator.filter_method_name do
+          validator.validate_with.each do |reflection_name|
+            validate_foreign_key(validator.validate_against_key, reflection_name)
           end
         end
-        private "validate_foreign_keys_on_#{validate_against}".to_sym
+        private validator.filter_method_name.to_sym
 
-        before_validation "validate_foreign_keys_on_#{validate_against}"
+        before_validation validator.filter_method_name
       end
     end
   end

data/lib/foreign_key_validation/validator.rb

@@ -0,0 +1,43 @@
+module ForeignKeyValidation
+
+  class Validator
+    attr_accessor :klass, :validate_against, :reflections, :reflection_names, :validate_against_key, :validate_with
+
+    DEFAULT_VALIDATE_AGAINST = :user
+
+    def initialize(klass, opt={})
+      self.klass                 = klass
+      self.validate_against      = find_validate_against(opt[:on])
+      self.reflections           = klass.reflect_on_all_associations(:belongs_to)
+      self.reflection_names      = reflections.map(&:name).map(&:to_s)
+      self.validate_against_key  = find_validate_against_key
+      self.validate_with         = find_validate_with(opt[:with])
+    end
+
+    def check
+      raise Errors::NoReleationFoundError.new(klass.name) if reflection_names.empty?
+      raise Errors::NoForeignKeyFoundError.new(validate_against, klass.table_name) unless reflection_names.include?(validate_against)
+      raise Errors::UnknownRelationError.new(validate_with) unless validate_with.all? {|k| reflection_names.include?(k)}
+    end
+
+    def filter_method_name
+      "validate_foreign_keys_on_#{validate_against}"
+    end
+
+    private
+
+    def find_validate_against(opt_on)
+      (opt_on || DEFAULT_VALIDATE_AGAINST).to_s
+    end
+
+    def find_validate_with(opt_with)
+      ((Array(opt_with).map(&:to_s) if opt_with) || reflection_names).reject {|n| n == validate_against}
+    end
+
+    def find_validate_against_key
+      reflections.select {|r| r.name.to_s == validate_against}.first.try(:foreign_key)
+    end
+
+  end
+
+end

data/lib/foreign_key_validation/version.rb

@@ -1,3 +1,3 @@
 module ForeignKeyValidation
-  VERSION = "0.0.8"
+  VERSION = "1.0.0"
 end

data/lib/foreign_key_validation.rb

@@ -1,2 +1,4 @@
 require "foreign_key_validation/version"
+require "foreign_key_validation/errors"
+require "foreign_key_validation/validator"
 require "foreign_key_validation/model_extension"

data/spec/models/model_spec.rb

@@ -5,55 +5,75 @@ describe ForeignKeyValidation::ModelExtension do
   # NOTE: it's important to not create the objects through relation (user.projects.create...)
   #       it looks like active_record is caching the classes - but we need to test different class configs
 
+  let(:user) { User.create }
+  let(:other_user) { User.create }
+
   context "without calling validation" do
 
-    let(:user) { User.create }
     let(:project) { Project.create user: user }
     let(:idea) { Idea.create user: user, project: project }
     let(:issue) { Issue.create user: user, project: project }
     let(:comment) { Comment.create user: user, issue: issue }
-    # sti model
     let(:manager) { Manager.create user: user }
+    let(:other_manager) { Manager.create user: User.create }
     let(:developer) { Developer.create user: user, boss: manager }
 
     it "uses same user ids by default" do
       expect(project.user_id).to eq(user.id)
       expect(idea.user_id).to eq(user.id)
+      expect(issue.user_id).to eq(user.id)
+      expect(comment.user_id).to eq(user.id)
+      expect(manager.user_id).to eq(user.id)
+      expect(developer.user_id).to eq(user.id)
     end
 
-    it "allow to rewrite user id of idea" do
+    it "allow to rewrite user id of idea with random id" do
       idea.user_id = 42
       idea.save
       idea.reload
       expect(idea.user_id).to eq(42)
     end
 
+    it "allow to rewrite user id of idea" do
+      idea.user_id = other_user.id
+      idea.save
+      idea.reload
+      expect(idea.user_id).to eq(other_user.id)
+    end
+
     it "allow to rewrite user id of project" do
-      project.user_id = 42
+      project.user_id = other_user.id
       project.save
       project.reload
-      expect(project.user_id).to eq(42)
+      expect(project.user_id).to eq(other_user.id)
     end
 
     it "allow to rewrite user id of issue" do
-      issue.user_id = 42
+      issue.user_id = other_user.id
       issue.save
       issue.reload
-      expect(issue.user_id).to eq(42)
+      expect(issue.user_id).to eq(other_user.id)
     end
 
     it "allow to rewrite user id of comment" do
-      comment.user_id = 42
+      comment.user_id = other_user.id
       comment.save
       comment.reload
-      expect(comment.user_id).to eq(42)
+      expect(comment.user_id).to eq(other_user.id)
     end
 
     it "allow to rewrite user id of developer" do
-      developer.user_id = 42
+      developer.user_id = other_user.id
       developer.save
       developer.reload
-      expect(developer.user_id).to eq(42)
+      expect(developer.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite boss id of developer" do
+      developer.custom_boss_id = other_user.id
+      developer.save
+      developer.reload
+      expect(developer.custom_boss_id).to eq(other_user.id)
     end
 
   end
@@ -64,58 +84,105 @@ describe ForeignKeyValidation::ModelExtension do
       Project.send :validate_foreign_keys
       Issue.send :validate_foreign_keys
       Comment.send :validate_foreign_keys
-      Member.send :validate_foreign_keys # sti model
+      Member.send :validate_foreign_keys
     end
 
-    let(:user) { User.create }
     let(:project) { Project.create user: user }
+    let(:other_project) { Project.create user: other_user }
     let(:idea) { Idea.create user: user, project: project }
     let(:issue) { Issue.create user: user, project: project }
+    let(:other_issue) { Issue.create user: other_user, project: other_project }
     let(:comment) { Comment.create user: user, issue: issue }
-    # sti model
     let(:manager) { Manager.create user: user }
+    let(:other_manager) { Manager.create user: User.create }
     let(:developer) { Developer.create user: user, boss: manager }
 
     it "uses same user ids by default" do
       expect(project.user_id).to eq(user.id)
       expect(idea.user_id).to eq(user.id)
+      expect(issue.user_id).to eq(user.id)
+      expect(comment.user_id).to eq(user.id)
+      expect(manager.user_id).to eq(user.id)
+      expect(developer.user_id).to eq(user.id)
     end
 
     it "does not allow to rewrite user id of idea" do
+      idea.user_id = other_user.id
+      idea.save
+      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
+      expect(idea.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite user id of idea with random id" do
       idea.user_id = 42
       idea.save
       expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
       expect(idea.reload.user_id).to_not eq(42)
     end
 
+    it "does not allow to rewrite project id of idea" do
+      idea.project_id = other_project.id
+      idea.save
+      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
+      expect(idea.reload.user_id).to_not eq(other_project.id)
+    end
+
     it "does not allow to rewrite user id of issue" do
-      issue.user_id = 42
+      issue.user_id = other_user.id
       issue.save
       expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
-      expect(issue.reload.user_id).to_not eq(42)
+      expect(issue.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite project id of issue" do
+      issue.project_id = other_project.id
+      issue.save
+      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
+      expect(issue.reload.user_id).to_not eq(other_project.id)
     end
 
     it "does not allow to rewrite user id of comment" do
-      comment.user_id = 42
+      comment.user_id = other_user.id
       comment.save
       expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
-      expect(comment.reload.user_id).to_not eq(42)
+      expect(comment.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite issue id of comment" do
+      comment.issue_id = other_issue.id
+      comment.save
+      expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
+      expect(comment.reload.user_id).to_not eq(other_issue.id)
     end
 
     it "does allow to rewrite user id of project" do
-      project.user_id = 42
+      project.user_id = other_user.id
       project.save
       expect(project.errors).to be_empty
-      expect(project.reload.user_id).to eq(42)
+      expect(project.reload.user_id).to eq(other_user.id)
     end
 
     it "does not allow to rewrite user id of developer" do
-      developer.user_id = 42
+      developer.user_id = other_user.id
+      developer.save
+      expect(developer.errors.messages.values.flatten).to include("user_id of boss does not match developers user_id.")
+      expect(developer.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite boss id of developer" do
+      developer.custom_boss_id = other_manager.id
       developer.save
       expect(developer.errors.messages.values.flatten).to include("user_id of boss does not match developers user_id.")
-      expect(developer.reload.user_id).to_not eq(42)
+      expect(developer.reload.custom_boss_id).to_not eq(other_manager.id)
     end
 
+  end
+
+  context "with calling private methods from model" do
+    before { Issue.send :validate_foreign_keys }
+
+    let(:issue) { Issue.create }
+
     it "does not allow to call private validate_foreign_key method" do
       expect{issue.validate_foreign_key("test", "unrat")}.to raise_exception(/private method `validate_foreign_key' called/)
     end
@@ -123,53 +190,65 @@ describe ForeignKeyValidation::ModelExtension do
     it "does not allow to call private validate_foreign_keys_on_* methods" do
       expect{issue.validate_foreign_keys_on_user}.to raise_exception(/private method `validate_foreign_keys_on_user' called/)
     end
-
   end
 
-  context "with calling validation with attributes hash" do
+  context "with calling validation with custom attributes hash" do
     before do
-      Idea.class_eval do
-        validate_foreign_keys on: :user, with: :project
+      Comment.class_eval do
+        validate_foreign_keys on: :user, with: :issue # member is not in list - should be editable
       end
     end
 
-    let(:user) { User.create }
     let(:project) { Project.create user: user }
-    let(:idea) { Idea.create user: user, project: project }
+    let(:other_project) { Project.create user: other_user }
     let(:issue) { Issue.create user: user, project: project }
+    let(:other_issue) { Issue.create user: other_user, project: other_project }
     let(:comment) { Comment.create user: user, issue: issue }
+    let(:manager) { Manager.create user: user }
+    let(:other_manager) { Manager.create user: User.create }
 
     it "uses same user ids by default" do
       expect(project.user_id).to eq(user.id)
-      expect(idea.user_id).to eq(user.id)
+      expect(issue.user_id).to eq(user.id)
+      expect(comment.user_id).to eq(user.id)
+      expect(manager.user_id).to eq(user.id)
     end
 
-    it "does not allow to rewrite user id of idea" do
-      idea.user_id = 42
-      idea.save
-      expect(idea.errors.messages.values.flatten).to include("user_id of project does not match ideas user_id.")
-      expect(idea.reload.user_id).to_not eq(42)
+    it "does not allow to rewrite issue id of comment" do
+      comment.issue_id = other_issue.id
+      comment.save
+      expect(comment.errors.messages.values.flatten).to include("user_id of issue does not match comments user_id.")
+      expect(comment.reload.issue_id).to_not eq(other_issue.id)
     end
 
-    it "allow to rewrite user id of project" do
-      project.user_id = 42
-      project.save
-      project.reload
-      expect(project.user_id).to eq(42)
+    # NOTE: this is possible here because Issue model is not configured to check ids
+    #       comment model can only check id against issue model if it is present
+    it "does allow to rewrite issue id of comment with random id" do
+      comment.issue_id = 42
+      comment.save
+      comment.reload
+      expect(comment.issue_id).to eq(42)
+    end
+
+    it "allow to rewrite member id of comment" do
+      comment.member_id = other_manager.id
+      comment.save
+      comment.reload
+      expect(comment.member_id).to eq(other_manager.id)
     end
 
     it "allow to rewrite user id of issue" do
-      issue.user_id = 42
+      issue.user_id = other_user.id
       issue.save
       issue.reload
-      expect(issue.user_id).to eq(42)
+      expect(issue.user_id).to eq(other_user.id)
     end
 
-    it "allow to rewrite user id of comment" do
-      comment.user_id = 42
-      comment.save
-      comment.reload
-      expect(comment.user_id).to eq(42)
+    it "allow to rewrite user id of manager" do
+      manager.user_id = other_user.id
+      manager.save
+      manager.reload
+      expect(manager.user_id).to eq(other_user.id)
     end
 
   end
@@ -180,6 +259,10 @@ describe ForeignKeyValidation::ModelExtension do
       expect{Idea.class_eval { validate_foreign_keys on: :not_existing }}.to raise_error("No foreign key for relation not_existing on ideas table!")
     end
 
+    it "raises error due to not related :on key" do
+      expect{Project.class_eval { validate_foreign_keys on: :comment }}.to raise_error("No foreign key for relation comment on projects table!")
+    end
+
     it "raises error due to wrong :with key" do
       expect{Idea.class_eval { validate_foreign_keys with: :not_existing }}.to raise_error('Unknown relation in ["not_existing"]!')
     end
@@ -188,7 +271,7 @@ describe ForeignKeyValidation::ModelExtension do
 
   context "with calling validation and missing relations" do
 
-    it "raises error due to wrong :on key" do
+    it "raises error due to no existing relations" do
       expect{Dummy.class_eval { validate_foreign_keys }}.to raise_error("Can't find any belongs_to relations for Dummy class. Put validation call below association definitions!")
     end
 
@@ -203,17 +286,24 @@ describe ForeignKeyValidation::ModelExtension do
       end
     end
 
-    let(:user) { User.create }
     let(:project) { Project.create user: user }
     let(:issue) { Issue.create project: project }
 
     it "does not allow to rewrite user id of issue" do
+      issue.user_id = other_user.id
+      issue.save
+      expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
+      expect(issue.reload.user_id).to_not eq(other_user.id)
+    end
+
+    it "does not allow to rewrite user id of issue with random id" do
       issue.user_id = 42
       issue.save
       expect(issue.errors.messages.values.flatten).to include("user_id of project does not match issues user_id.")
       expect(issue.reload.user_id).to_not eq(42)
     end
 
+
   end
 
   context "with calling validation and missing foreign key on relation" do
@@ -224,15 +314,22 @@ describe ForeignKeyValidation::ModelExtension do
       end
     end
 
-    let(:user) { User.create }
     let(:project) { Project.create }
+    let(:other_project) { Project.create }
     let(:issue) { Issue.create project: project, user: user }
 
     it "allow to rewrite user id of issue" do
-      issue.user_id = 42
+      issue.user_id = other_user.id
+      issue.save
+      issue.reload
+      expect(issue.user_id).to eq(other_user.id)
+    end
+
+    it "allow to rewrite project id of issue" do
+      issue.project_id = other_project.id
       issue.save
       issue.reload
-      expect(issue.user_id).to eq(42)
+      expect(issue.project_id).to eq(other_project.id)
     end
 
   end

data/spec/spec_helper.rb

@@ -1,6 +1,10 @@
+require 'coveralls'
+Coveralls.wear!
+
 require "rails/all"
 require 'foreign_key_validation'
 require 'rspec/rails'
+require 'database_cleaner'
 require 'pry'
 
 RSpec.configure do |config|
@@ -14,6 +18,18 @@ RSpec.configure do |config|
     load "support/load_models.rb"
   end
 
+  config.before(:suite) do
+    puts "Running specs against Rails #{Rails.version}" if defined?(Rails)
+    DatabaseCleaner.strategy = :transaction
+    DatabaseCleaner.clean_with(:truncation)
+  end
+
+  config.around(:each) do |example|
+    DatabaseCleaner.cleaning do
+      example.run
+    end
+  end
+
   config.order = 'random'
 end
 

data/spec/support/load_models.rb

@@ -31,6 +31,7 @@ end
 class Comment < ActiveRecord::Base
   belongs_to :issue
   belongs_to :user
+  belongs_to :member
 end
 
 class Dummy < ActiveRecord::Base
@@ -39,6 +40,7 @@ end
 class Member < ActiveRecord::Base
   belongs_to :user
   has_many :projects
+  has_many :comments
 end
 
 class Manager < Member

data/spec/support/reset_models.rb

@@ -1,8 +1,3 @@
-Object.send(:remove_const, :User)       if Object.constants.include?(:User)
-Object.send(:remove_const, :Project)    if Object.constants.include?(:Project)
-Object.send(:remove_const, :Idea)       if Object.constants.include?(:Idea)
-Object.send(:remove_const, :Issue)      if Object.constants.include?(:Issue)
-Object.send(:remove_const, :Comment)    if Object.constants.include?(:Comment)
-Object.send(:remove_const, :Member)     if Object.constants.include?(:Member)
-Object.send(:remove_const, :Developer)  if Object.constants.include?(:Developer)
-Object.send(:remove_const, :Manager)    if Object.constants.include?(:Manager)
+ActiveRecord::Base.descendants.each do |klass|
+  Object.send(:remove_const, klass.name.to_sym) if Object.constants.include?(klass.name.to_sym)
+end

data/spec/support/schema.rb

@@ -22,6 +22,7 @@ ActiveRecord::Schema.define do
   create_table "comments", force: true do |t|
     t.integer   "user_id"
     t.integer   "issue_id"
+    t.integer   "member_id"
   end
 
   create_table "dummies", force: true do |t|

metadata

@@ -1,29 +1,57 @@
 --- !ruby/object:Gem::Specification
 name: foreign_key_validation
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 1.0.0
 platform: ruby
 authors:
 - Marcus Geißler
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-09-01 00:00:00.000000000 Z
+date: 2014-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.2'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '3.2'
+- !ruby/object:Gem::Dependency
+  name: appraisal
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.0'
+- !ruby/object:Gem::Dependency
+  name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '0.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '0.7'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
@@ -66,6 +94,20 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: database_cleaner
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.3'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
@@ -102,17 +144,26 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gitignore
 - .rspec
 - .ruby-gemset
 - .ruby-version
+- .travis.yml
+- Appraisals
 - Gemfile
 - LICENSE
 - README.md
 - Rakefile
 - foreign_key_validation.gemspec
+- gemfiles/3.2.gemfile
+- gemfiles/4.0.gemfile
+- gemfiles/4.1.gemfile
+- gemfiles/4.2.gemfile
 - lib/foreign_key_validation.rb
+- lib/foreign_key_validation/errors.rb
 - lib/foreign_key_validation/model_extension.rb
+- lib/foreign_key_validation/validator.rb
 - lib/foreign_key_validation/version.rb
 - spec/models/model_spec.rb
 - spec/spec_helper.rb