foodcritic 4.0.0 → 5.0.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/CHANGELOG.md +47 -0
- data/README.md +7 -7
- data/bin/foodcritic +1 -1
- data/chef_dsl_metadata/chef_11.0.0.json +4 -0
- data/chef_dsl_metadata/chef_11.10.0.json +176 -1
- data/chef_dsl_metadata/chef_11.10.2.json +176 -1
- data/chef_dsl_metadata/chef_11.10.4.json +176 -1
- data/chef_dsl_metadata/chef_11.12.0.json +10861 -0
- data/chef_dsl_metadata/chef_11.12.2.json +10861 -0
- data/chef_dsl_metadata/chef_11.12.4.json +10800 -0
- data/chef_dsl_metadata/chef_11.12.8.json +10800 -0
- data/chef_dsl_metadata/chef_11.14.2.json +11172 -0
- data/chef_dsl_metadata/chef_11.14.6.json +11178 -0
- data/chef_dsl_metadata/chef_11.16.0.json +11236 -0
- data/chef_dsl_metadata/chef_11.16.2.json +11236 -0
- data/chef_dsl_metadata/chef_11.16.4.json +11236 -0
- data/chef_dsl_metadata/chef_11.18.0.json +11291 -0
- data/chef_dsl_metadata/chef_11.18.12.json +11291 -0
- data/chef_dsl_metadata/chef_11.18.6.json +11291 -0
- data/chef_dsl_metadata/chef_11.2.0.json +4 -0
- data/chef_dsl_metadata/chef_11.4.0.json +4 -0
- data/chef_dsl_metadata/chef_11.4.2.json +4 -0
- data/chef_dsl_metadata/chef_11.4.4.json +4 -0
- data/chef_dsl_metadata/chef_11.6.0.json +4 -0
- data/chef_dsl_metadata/chef_11.6.2.json +4 -0
- data/chef_dsl_metadata/chef_11.8.0.json +4 -0
- data/chef_dsl_metadata/chef_11.8.2.json +4 -0
- data/chef_dsl_metadata/chef_12.0.0.json +11855 -0
- data/chef_dsl_metadata/chef_12.0.1.json +11865 -0
- data/chef_dsl_metadata/chef_12.0.3.json +12054 -0
- data/chef_dsl_metadata/chef_12.1.0.json +12468 -0
- data/chef_dsl_metadata/chef_12.1.1.json +12468 -0
- data/chef_dsl_metadata/chef_12.1.2.json +12468 -0
- data/chef_dsl_metadata/chef_12.2.1.json +12645 -0
- data/chef_dsl_metadata/chef_12.3.0.json +12839 -0
- data/chef_dsl_metadata/chef_12.4.0.json +14625 -0
- data/chef_dsl_metadata/chef_12.4.1.json +14625 -0
- data/features/002_check_string_interpolation.feature +5 -0
- data/features/041_check_raw_download.feature +17 -9
- data/features/044_check_for_bare_attribute_keys.feature +10 -0
- data/features/048_check_for_shellout.feature +6 -1
- data/features/052_check_for_metadata_using_suggests_keyword.feature +15 -0
- data/features/053_check_for_metadata_using_recommends_keyword.feature +15 -0
- data/features/step_definitions/cookbook_steps.rb +66 -4
- data/features/support/command_helpers.rb +8 -2
- data/features/support/env.rb +7 -3
- data/lib/foodcritic/api.rb +5 -4
- data/lib/foodcritic/chef.rb +3 -7
- data/lib/foodcritic/command_line.rb +15 -0
- data/lib/foodcritic/domain.rb +14 -0
- data/lib/foodcritic/linter.rb +44 -4
- data/lib/foodcritic/rake_task.rb +15 -11
- data/lib/foodcritic/rules.rb +38 -6
- data/lib/foodcritic/version.rb +1 -1
- data/man/foodcritic.1 +8 -1
- data/man/foodcritic.1.ronn +7 -0
- data/misc/lucene.treetop +150 -0
- data/spec/foodcritic/command_line_spec.rb +10 -0
- data/spec/foodcritic/domain_spec.rb +19 -0
- data/spec/foodcritic/linter_spec.rb +13 -1
- data/spec/regression/cookbooks.txt +0 -60
- data/spec/regression/expected-output.txt +5 -445
- data/spec/regression_helpers.rb +5 -5
- data/spec/spec_helper.rb +7 -3
- metadata +38 -7
data/spec/regression_helpers.rb
CHANGED
@@ -22,16 +22,16 @@ end
|
|
22
22
|
|
23
23
|
def clone_cookbook(clone_path, cbk)
|
24
24
|
target_path = clone_path + cbk[:name]
|
25
|
-
unless Dir.
|
26
|
-
%x{git clone -q
|
27
|
-
raise
|
25
|
+
unless Dir.exist?(target_path)
|
26
|
+
%x{git clone -q git://github.com/chef-cookbooks/#{cbk[:name]}.git #{target_path}}
|
27
|
+
raise "Unable to clone git://github.com/chef-cookbooks/#{cbk[:name]}.git" unless $?.success?
|
28
28
|
end
|
29
29
|
%x{cd #{target_path} && git checkout -q #{cbk[:ref]}}
|
30
|
-
raise
|
30
|
+
raise "Unable to checkout revision for #{cbk[:name]}" unless $?.success?
|
31
31
|
end
|
32
32
|
|
33
33
|
def lint_cookbooks(cookbook_path)
|
34
34
|
result = %x{cd #{cookbook_path} && foodcritic .}
|
35
|
-
raise
|
35
|
+
raise "Unable to lint #{cookbook_path}" unless $?.success?
|
36
36
|
result
|
37
37
|
end
|
data/spec/spec_helper.rb
CHANGED
@@ -1,6 +1,10 @@
|
|
1
|
-
|
2
|
-
|
3
|
-
|
1
|
+
begin
|
2
|
+
require 'simplecov'
|
3
|
+
SimpleCov.start do
|
4
|
+
add_filter '/spec/'
|
5
|
+
end
|
6
|
+
rescue LoadError
|
7
|
+
warn 'warning: simplecov gem not found; skipping coverage'
|
4
8
|
end
|
5
9
|
|
6
10
|
require 'minitest/autorun'
|
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: foodcritic
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version:
|
4
|
+
version: 5.0.0
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Andrew Crump
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date:
|
11
|
+
date: 2015-09-17 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: gherkin
|
@@ -28,16 +28,22 @@ dependencies:
|
|
28
28
|
name: nokogiri
|
29
29
|
requirement: !ruby/object:Gem::Requirement
|
30
30
|
requirements:
|
31
|
-
- - "
|
31
|
+
- - ">="
|
32
32
|
- !ruby/object:Gem::Version
|
33
33
|
version: '1.5'
|
34
|
+
- - "<"
|
35
|
+
- !ruby/object:Gem::Version
|
36
|
+
version: '2.0'
|
34
37
|
type: :runtime
|
35
38
|
prerelease: false
|
36
39
|
version_requirements: !ruby/object:Gem::Requirement
|
37
40
|
requirements:
|
38
|
-
- - "
|
41
|
+
- - ">="
|
39
42
|
- !ruby/object:Gem::Version
|
40
43
|
version: '1.5'
|
44
|
+
- - "<"
|
45
|
+
- !ruby/object:Gem::Version
|
46
|
+
version: '2.0'
|
41
47
|
- !ruby/object:Gem::Dependency
|
42
48
|
name: rake
|
43
49
|
requirement: !ruby/object:Gem::Requirement
|
@@ -156,6 +162,18 @@ files:
|
|
156
162
|
- chef_dsl_metadata/chef_11.10.0.json
|
157
163
|
- chef_dsl_metadata/chef_11.10.2.json
|
158
164
|
- chef_dsl_metadata/chef_11.10.4.json
|
165
|
+
- chef_dsl_metadata/chef_11.12.0.json
|
166
|
+
- chef_dsl_metadata/chef_11.12.2.json
|
167
|
+
- chef_dsl_metadata/chef_11.12.4.json
|
168
|
+
- chef_dsl_metadata/chef_11.12.8.json
|
169
|
+
- chef_dsl_metadata/chef_11.14.2.json
|
170
|
+
- chef_dsl_metadata/chef_11.14.6.json
|
171
|
+
- chef_dsl_metadata/chef_11.16.0.json
|
172
|
+
- chef_dsl_metadata/chef_11.16.2.json
|
173
|
+
- chef_dsl_metadata/chef_11.16.4.json
|
174
|
+
- chef_dsl_metadata/chef_11.18.0.json
|
175
|
+
- chef_dsl_metadata/chef_11.18.12.json
|
176
|
+
- chef_dsl_metadata/chef_11.18.6.json
|
159
177
|
- chef_dsl_metadata/chef_11.2.0.json
|
160
178
|
- chef_dsl_metadata/chef_11.4.0.json
|
161
179
|
- chef_dsl_metadata/chef_11.4.2.json
|
@@ -164,6 +182,16 @@ files:
|
|
164
182
|
- chef_dsl_metadata/chef_11.6.2.json
|
165
183
|
- chef_dsl_metadata/chef_11.8.0.json
|
166
184
|
- chef_dsl_metadata/chef_11.8.2.json
|
185
|
+
- chef_dsl_metadata/chef_12.0.0.json
|
186
|
+
- chef_dsl_metadata/chef_12.0.1.json
|
187
|
+
- chef_dsl_metadata/chef_12.0.3.json
|
188
|
+
- chef_dsl_metadata/chef_12.1.0.json
|
189
|
+
- chef_dsl_metadata/chef_12.1.1.json
|
190
|
+
- chef_dsl_metadata/chef_12.1.2.json
|
191
|
+
- chef_dsl_metadata/chef_12.2.1.json
|
192
|
+
- chef_dsl_metadata/chef_12.3.0.json
|
193
|
+
- chef_dsl_metadata/chef_12.4.0.json
|
194
|
+
- chef_dsl_metadata/chef_12.4.1.json
|
167
195
|
- features/001_check_node_access.feature
|
168
196
|
- features/002_check_string_interpolation.feature
|
169
197
|
- features/003_check_for_chef_server.feature
|
@@ -212,6 +240,8 @@ files:
|
|
212
240
|
- features/049_check_for_role_name_mismatch_with_file_name.feature
|
213
241
|
- features/050_check_for_invalid_name.feature
|
214
242
|
- features/051_check_for_template_partial_loops.feature
|
243
|
+
- features/052_check_for_metadata_using_suggests_keyword.feature
|
244
|
+
- features/053_check_for_metadata_using_recommends_keyword.feature
|
215
245
|
- features/build_framework_support.feature
|
216
246
|
- features/checking_all_types_of_file.feature
|
217
247
|
- features/choose_rules_to_apply.feature
|
@@ -248,6 +278,7 @@ files:
|
|
248
278
|
- lib/foodcritic/xml.rb
|
249
279
|
- man/foodcritic.1
|
250
280
|
- man/foodcritic.1.ronn
|
281
|
+
- misc/lucene.treetop
|
251
282
|
- spec/foodcritic/api_spec.rb
|
252
283
|
- spec/foodcritic/chef_spec.rb
|
253
284
|
- spec/foodcritic/command_line_spec.rb
|
@@ -271,7 +302,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
|
|
271
302
|
requirements:
|
272
303
|
- - ">="
|
273
304
|
- !ruby/object:Gem::Version
|
274
|
-
version:
|
305
|
+
version: 2.0.0
|
275
306
|
required_rubygems_version: !ruby/object:Gem::Requirement
|
276
307
|
requirements:
|
277
308
|
- - ">="
|
@@ -279,8 +310,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
|
|
279
310
|
version: '0'
|
280
311
|
requirements: []
|
281
312
|
rubyforge_project:
|
282
|
-
rubygems_version: 2.
|
313
|
+
rubygems_version: 2.4.8
|
283
314
|
signing_key:
|
284
315
|
specification_version: 4
|
285
|
-
summary: foodcritic-
|
316
|
+
summary: foodcritic-5.0.0
|
286
317
|
test_files: []
|