foodcritic 3.0.3 → 4.0.0

data/lib/foodcritic/template.rb

@@ -1,9 +1,7 @@
 module FoodCritic
   module Template
-
     # Extract expressions <%= expr %> from Erb templates.
     class ExpressionExtractor
-
       include Erubis::Basic::Converter
 
       def initialize
@@ -18,24 +16,21 @@ module FoodCritic
 
       def add_expr(src, code, indicator)
         if indicator == '='
-          @expressions << {:type => :expression, :code => code.strip}
+          @expressions << { type: :expression, code: code.strip }
         end
       end
 
       def add_text(src, text)
-
       end
 
       def add_preamble(codebuf)
-
       end
 
       def add_postamble(codebuf)
-
       end
 
       def add_stmt(src, code)
-        @expressions << {:type => :statement, :code => code.strip}
+        @expressions << { type: :statement, code: code.strip }
       end
 
       private
@@ -43,15 +38,15 @@ module FoodCritic
       def expressions(template_code)
         expr_lines = expressions_with_lines(template_code)
         expr_lines.map do |expr, line|
-          e = @expressions.find{|e| e[:code] == expr}
-          {:code => expr, :type => e[:type], :line => line} if e
+          e = @expressions.find { |e| e[:code] == expr }
+          { code: expr, type: e[:type], line: line } if e
         end.compact
       end
 
       def expressions_with_lines(template_code)
         lines = lines_with_offsets(template_code)
         expression_offsets(template_code).map do |expr_offset, code|
-          [code, lines.find {|line, offset| offset >= expr_offset}.first]
+          [code, lines.find { |line, offset| offset >= expr_offset }.first]
         end
       end
 
@@ -68,10 +63,8 @@ module FoodCritic
         template_code.scan(/$/) do |m|
           line_offsets << Regexp.last_match.offset(0).first
         end
-        line_offsets.each_with_index.map{| pos, ln| [ln +1, pos]}
+        line_offsets.each_with_index.map { |pos, ln| [ln + 1, pos] }
       end
-
     end
-
   end
 end

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = '3.0.3'
+  VERSION = '4.0.0'
 end

data/lib/foodcritic/xml.rb

@@ -1,6 +1,5 @@
 module FoodCritic
   module XML
-
     private
 
     def xml_array_node(doc, xml_node, child)
@@ -30,11 +29,10 @@ module FoodCritic
     end
 
     def xml_position_node(doc, xml_node, child)
-      pos = Nokogiri::XML::Node.new("pos", doc)
+      pos = Nokogiri::XML::Node.new('pos', doc)
       pos['line'] = child.first.to_s
       pos['column'] = child[1].to_s
       xml_node.add_child(pos)
     end
   end
-
 end

data/man/foodcritic.1

@@ -1,7 +1,7 @@
 .\" generated with Ronn/v0.7.3
 .\" http://github.com/rtomayko/ronn/tree/0.7.3
 .
-.TH "FOODCRITIC" "1" "August 2013" "" ""
+.TH "FOODCRITIC" "1" "June 2014" "" ""
 .
 .SH "NAME"
 \fBfoodcritic\fR \- lint tool for chef cookbooks
@@ -19,7 +19,7 @@ Each \fBcookbook\fR path specified will be examined for common problems and poor
 .
 .TP
 \fB\-t\fR, \fB\-\-tags\fR \fITAGS\fR
-Only check against rules with the specified tags\.
+Only check against rules with the specified tags\. Prefix tags with a tilde \fB~\fR to exclude rules\.
 .
 .TP
 \fB\-f\fR, \fB\-\-epic\-fail\fR \fITAGS\fR
@@ -57,6 +57,10 @@ Specify grammar to use when validating search syntax\. (Default: the grammar of
 \fB\-V\fR, \fB\-\-version\fR
 Display the foodcritic version\.
 .
+.TP
+\fB\-X\fR, \fB\-\-exclude\fR \fIPATH\fR
+Exclude path(s) from being linted\.
+.
 .SH "RETURN VALUES"
 By default, \fBfoodcritic\fR will always return \fB0\fR\.
 .

data/man/foodcritic.1.ronn

@@ -19,7 +19,8 @@ poor style.
 ## OPTIONS
 
  * `-t`, `--tags` <TAGS>:
-   Only check against rules with the specified tags.
+   Only check against rules with the specified tags. Prefix
+   tags with a tilde `~` to exclude rules.
 
  * `-f`, `--epic-fail` <TAGS>:
    Exit non-zero if any of the specified tags are matched.
@@ -50,6 +51,8 @@ poor style.
  * `-V`, `--version`:
    Display the foodcritic version.
 
+ * `-X`, `--exclude` <PATH>:
+   Exclude path(s) from being linted.
 
 ## RETURN VALUES
 

data/spec/foodcritic/linter_spec.rb

@@ -11,7 +11,7 @@ describe FoodCritic::Linter do
 
   describe "chef version" do
     it "should be the latest stable version of Chef" do
-      FoodCritic::Linter::DEFAULT_CHEF_VERSION.must_equal "11.4.0"
+      FoodCritic::Linter::DEFAULT_CHEF_VERSION.must_equal "11.10.4"
     end
   end
 
@@ -44,7 +44,7 @@ describe FoodCritic::Linter do
 
   describe "#load_files!" do
     let(:default_rules_file) do
-      File.expand_path(File.join(File.dirname(__FILE__), '../../lib/foodcritic/rules.rb')) 
+      File.expand_path(File.join(File.dirname(__FILE__), '../../lib/foodcritic/rules.rb'))
     end
 
     let(:rule_dsl_load_mock) { MiniTest::Mock.new }

data/spec/regression/expected-output.txt

@@ -1,3 +1,299 @@
+FC001: Use strings in preference to symbols to access node attributes: ./ant/providers/library.rb:27
+FC001: Use strings in preference to symbols to access node attributes: ./ant/providers/library.rb:39
+FC001: Use strings in preference to symbols to access node attributes: ./apparmor/attributes/apparmor.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./apparmor/recipes/default.rb:21
+FC001: Use strings in preference to symbols to access node attributes: ./apparmor/recipes/default.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./application_php/templates/default/php.conf.erb:28
+FC001: Use strings in preference to symbols to access node attributes: ./application_php/templates/default/php.conf.erb:29
+FC001: Use strings in preference to symbols to access node attributes: ./application_php/templates/default/php.conf.erb:32
+FC001: Use strings in preference to symbols to access node attributes: ./application_ruby/templates/default/sv-unicorn-run.erb:6
+FC001: Use strings in preference to symbols to access node attributes: ./chef-server/libraries/omnitruck_client.rb:76
+FC001: Use strings in preference to symbols to access node attributes: ./chef-server/libraries/omnitruck_client.rb:77
+FC001: Use strings in preference to symbols to access node attributes: ./chef-server/libraries/omnitruck_client.rb:78
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:21
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:22
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:26
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:27
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:28
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:31
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:32
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:33
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:34
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:35
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:38
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:39
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:40
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:41
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:42
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:43
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:44
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:45
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:46
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:47
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:49
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/default.rb:50
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/server_proxy.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/server_proxy.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/server_proxy.rb:28
+FC001: Use strings in preference to symbols to access node attributes: ./chef/attributes/server_proxy.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./database/libraries/provider_database_postgresql.rb:113
+FC001: Use strings in preference to symbols to access node attributes: ./database/recipes/ebs_backup.rb:31
+FC001: Use strings in preference to symbols to access node attributes: ./database/recipes/ebs_volume.rb:22
+FC001: Use strings in preference to symbols to access node attributes: ./database/recipes/ebs_volume.rb:86
+FC001: Use strings in preference to symbols to access node attributes: ./dmg/attributes/default.rb:19
+FC001: Use strings in preference to symbols to access node attributes: ./dmg/attributes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:2
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:3
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:4
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:5
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:6
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:7
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/attributes/default.rb:8
+FC001: Use strings in preference to symbols to access node attributes: ./drbd/templates/default/res.erb:1
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:22
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:26
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:27
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:28
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/a_record.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/ec2.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/ec2.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/ec2.rb:26
+FC001: Use strings in preference to symbols to access node attributes: ./dynect/recipes/ec2.rb:40
+FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/mirror.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/mirror.rb:2
+FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/mirror.rb:3
+FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/server.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/server.rb:2
+FC001: Use strings in preference to symbols to access node attributes: ./gems/attributes/server.rb:3
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:36
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:41
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:44
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:45
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/mirror.rb:46
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:26
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:30
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:31
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:40
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:44
+FC001: Use strings in preference to symbols to access node attributes: ./gems/recipes/server.rb:50
+FC001: Use strings in preference to symbols to access node attributes: ./gems/templates/default/gem_server.conf.erb:6
+FC001: Use strings in preference to symbols to access node attributes: ./gems/templates/default/gem_server.conf.erb:29
+FC001: Use strings in preference to symbols to access node attributes: ./gems/templates/default/gem_server.conf.erb:35
+FC001: Use strings in preference to symbols to access node attributes: ./getting-started/attributes/default.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./getting-started/templates/default/chef-getting-started.txt.erb:3
+FC001: Use strings in preference to symbols to access node attributes: ./getting-started/templates/default/chef-getting-started.txt.erb:4
+FC001: Use strings in preference to symbols to access node attributes: ./getting-started/templates/default/chef-getting-started.txt.erb:5
+FC001: Use strings in preference to symbols to access node attributes: ./god/definitions/god_monitor.rb:32
+FC001: Use strings in preference to symbols to access node attributes: ./god/templates/default/master.god.erb:2
+FC001: Use strings in preference to symbols to access node attributes: ./god/templates/default/master.god.erb:7
+FC001: Use strings in preference to symbols to access node attributes: ./god/templates/default/master.god.erb:13
+FC001: Use strings in preference to symbols to access node attributes: ./god/templates/default/master.god.erb:18
+FC001: Use strings in preference to symbols to access node attributes: ./hadoop/templates/default/cloudera.list.erb:1
+FC001: Use strings in preference to symbols to access node attributes: ./hadoop/templates/default/cloudera.list.erb:2
+FC001: Use strings in preference to symbols to access node attributes: ./imagemagick/recipes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./iptables/recipes/default.rb:37
+FC001: Use strings in preference to symbols to access node attributes: ./jpackage/attributes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./jpackage/recipes/default.rb:22
+FC001: Use strings in preference to symbols to access node attributes: ./jpackage/recipes/default.rb:33
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/attributes/default.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/attributes/default.rb:2
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/attributes/default.rb:3
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/recipes/server.rb:38
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/recipes/server.rb:41
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/kickstart.conf.erb:14
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/kickstart.conf.erb:15
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/ks.cfg.erb:6
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/ks.cfg.erb:9
+FC001: Use strings in preference to symbols to access node attributes: ./kickstart/templates/default/ks.cfg.erb:10
+FC001: Use strings in preference to symbols to access node attributes: ./man/recipes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./maradns/attributes/default.rb:17
+FC001: Use strings in preference to symbols to access node attributes: ./maradns/recipes/default.rb:46
+FC001: Use strings in preference to symbols to access node attributes: ./maradns/recipes/default.rb:47
+FC001: Use strings in preference to symbols to access node attributes: ./maradns/templates/default/mararc.erb:8
+FC001: Use strings in preference to symbols to access node attributes: ./maradns/templates/default/mararc.erb:9
+FC001: Use strings in preference to symbols to access node attributes: ./maradns/templates/default/mararc.erb:31
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:2
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:3
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:4
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/attributes/default.rb:5
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/definitions/memcached_instance.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/definitions/memcached_instance.rb:30
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/definitions/memcached_instance.rb:31
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:39
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:47
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:48
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:49
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:50
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:51
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:62
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:63
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:64
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:65
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:66
+FC001: Use strings in preference to symbols to access node attributes: ./memcached/recipes/default.rb:72
+FC001: Use strings in preference to symbols to access node attributes: ./munin/attributes/default.rb:27
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/client.rb:36
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:24
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:28
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:46
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:49
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:51
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:54
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:57
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server.rb:64
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_apache.rb:10
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_apache.rb:13
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_apache.rb:15
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_apache.rb:18
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_apache.rb:21
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_apache.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_nginx.rb:14
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_nginx.rb:16
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_nginx.rb:19
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_nginx.rb:21
+FC001: Use strings in preference to symbols to access node attributes: ./munin/recipes/server_nginx.rb:24
+FC001: Use strings in preference to symbols to access node attributes: ./munin/templates/default/munin-node.conf.erb:30
+FC001: Use strings in preference to symbols to access node attributes: ./munin/templates/default/munin-node.conf.erb:31
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:2
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:3
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:4
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/attributes/default.rb:5
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/default.rb:28
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/default.rb:54
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/default.rb:59
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/mod_rails.rb:28
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/mod_rails.rb:37
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/recipes/mod_rails.rb:46
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger.conf.erb:1
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger.conf.erb:2
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger.conf.erb:3
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger.load.erb:1
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:17
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:18
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:21
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/web_app.conf.erb:17
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/web_app.conf.erb:18
+FC001: Use strings in preference to symbols to access node attributes: ./passenger_apache2/templates/default/web_app.conf.erb:21
+FC001: Use strings in preference to symbols to access node attributes: ./pdns/recipes/recursor.rb:36
+FC001: Use strings in preference to symbols to access node attributes: ./perl/definitions/cpan_module.rb:27
+FC001: Use strings in preference to symbols to access node attributes: ./perl/recipes/default.rb:26
+FC001: Use strings in preference to symbols to access node attributes: ./rabbitmq/attributes/default.rb:44
+FC001: Use strings in preference to symbols to access node attributes: ./radiant/libraries/radiant.rb:4
+FC001: Use strings in preference to symbols to access node attributes: ./radiant/recipes/db_bootstrap.rb:36
+FC001: Use strings in preference to symbols to access node attributes: ./radiant/recipes/db_bootstrap.rb:37
+FC001: Use strings in preference to symbols to access node attributes: ./radiant/recipes/db_bootstrap.rb:45
+FC001: Use strings in preference to symbols to access node attributes: ./radiant/recipes/default.rb:60
+FC001: Use strings in preference to symbols to access node attributes: ./radiant/recipes/default.rb:61
+FC001: Use strings in preference to symbols to access node attributes: ./radiant/templates/default/radiant.conf.erb:17
+FC001: Use strings in preference to symbols to access node attributes: ./radiant/templates/default/radiant.conf.erb:18
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/recipes/default.rb:80
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/recipes/default.rb:83
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/recipes/default.rb:93
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/templates/default/apt_repo.conf.erb:2
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/templates/default/apt_repo.conf.erb:3
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/templates/default/apt_repo.conf.erb:4
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/templates/default/distributions.erb:2
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/templates/default/distributions.erb:7
+FC001: Use strings in preference to symbols to access node attributes: ./reprepro/templates/default/distributions.erb:8
+FC001: Use strings in preference to symbols to access node attributes: ./rsyslog/recipes/client.rb:26
+FC001: Use strings in preference to symbols to access node attributes: ./runit/attributes/default.rb:22
+FC001: Use strings in preference to symbols to access node attributes: ./runit/attributes/default.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./runit/attributes/default.rb:24
+FC001: Use strings in preference to symbols to access node attributes: ./runit/attributes/default.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./runit/attributes/default.rb:27
+FC001: Use strings in preference to symbols to access node attributes: ./runit/attributes/default.rb:28
+FC001: Use strings in preference to symbols to access node attributes: ./runit/attributes/default.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./runit/attributes/default.rb:30
+FC001: Use strings in preference to symbols to access node attributes: ./runit/definitions/runit_service.rb:24
+FC001: Use strings in preference to symbols to access node attributes: ./runit/definitions/runit_service.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./runit/definitions/runit_service.rb:142
+FC001: Use strings in preference to symbols to access node attributes: ./runit/definitions/runit_service.rb:144
+FC001: Use strings in preference to symbols to access node attributes: ./runit/definitions/runit_service.rb:158
+FC001: Use strings in preference to symbols to access node attributes: ./runit/definitions/runit_service.rb:173
+FC001: Use strings in preference to symbols to access node attributes: ./runit/definitions/runit_service.rb:175
+FC001: Use strings in preference to symbols to access node attributes: ./runit/recipes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./runit/recipes/default.rb:64
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/attributes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/attributes/default.rb:21
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/attributes/default.rb:22
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/attributes/default.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/attributes/default.rb:24
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/attributes/default.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/definitions/sbuild_lv.rb:26
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/definitions/sbuild_lv.rb:31
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/definitions/sbuild_lv.rb:32
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/recipes/default.rb:41
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/templates/default/sbuildrc.erb:5
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/templates/default/sbuildrc.erb:7
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/templates/default/sbuildrc.erb:8
+FC001: Use strings in preference to symbols to access node attributes: ./sbuild/templates/default/sbuildrc.erb:10
+FC001: Use strings in preference to symbols to access node attributes: ./stompserver/templates/default/sv-stompserver-run.erb:2
+FC001: Use strings in preference to symbols to access node attributes: ./trac/recipes/default.rb:53
+FC001: Use strings in preference to symbols to access node attributes: ./ucspi-tcp/attributes/default.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./ucspi-tcp/attributes/default.rb:25
+FC001: Use strings in preference to symbols to access node attributes: ./ucspi-tcp/attributes/default.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./ucspi-tcp/attributes/default.rb:31
+FC001: Use strings in preference to symbols to access node attributes: ./ucspi-tcp/attributes/default.rb:34
+FC001: Use strings in preference to symbols to access node attributes: ./ucspi-tcp/attributes/default.rb:36
+FC001: Use strings in preference to symbols to access node attributes: ./ucspi-tcp/recipes/default.rb:55
+FC001: Use strings in preference to symbols to access node attributes: ./ucspi-tcp/recipes/default.rb:58
+FC001: Use strings in preference to symbols to access node attributes: ./ufw/attributes/default.rb:1
+FC001: Use strings in preference to symbols to access node attributes: ./ufw/attributes/default.rb:2
+FC001: Use strings in preference to symbols to access node attributes: ./vim/attributes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./vim/recipes/default.rb:33
+FC001: Use strings in preference to symbols to access node attributes: ./whitelist-node-attrs/attributes/default.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./windows/providers/reboot.rb:22
+FC001: Use strings in preference to symbols to access node attributes: ./windows/providers/reboot.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./windows/providers/reboot.rb:24
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:24
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:26
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:27
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:28
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:29
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:30
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:31
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:32
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:35
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:37
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:41
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/attributes/default.rb:49
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenbatchload.rb:105
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenbatchload.rb:106
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenbatchload.rb:107
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenbatchload.rb:109
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zendmd.rb:19
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zendmd.rb:20
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zendmd.rb:21
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zendmd.rb:23
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:40
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:41
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:42
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:44
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:57
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:58
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:59
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:61
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpack.rb:72
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpatch.rb:4
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpatch.rb:9
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/providers/zenpatch.rb:11
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/recipes/server.rb:22
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/recipes/server.rb:123
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/recipes/server.rb:173
+FC001: Use strings in preference to symbols to access node attributes: ./zenoss/recipes/server.rb:177
 FC002: Avoid string interpolation where not required: ./ant/resources/library.rb:29
 FC002: Avoid string interpolation where not required: ./application_php/templates/default/php.conf.erb:3
 FC002: Avoid string interpolation where not required: ./application_python/providers/gunicorn.rb:80
@@ -395,7 +691,6 @@ FC034: Unused template variables: ./activemq/templates/default/wrapper.conf.erb:
 FC034: Unused template variables: ./application_java/templates/default/context.xml.erb:1
 FC034: Unused template variables: ./application_python/templates/default/celeryconfig.py.erb:1
 FC034: Unused template variables: ./horizon/templates/default/local_settings.py.erb:1
-FC034: Unused template variables: ./nginx/templates/default/nginx.init.erb:1
 FC034: Unused template variables: ./nova/templates/default/libvirtd.conf.erb:1
 FC034: Unused template variables: ./sbuild/templates/default/mk_chroot.sh.erb:1
 FC041: Execute resource used to run curl or wget commands: ./hadoop/recipes/default.rb:33