foodcritic 2.2.0 → 3.0.0

data/spec/foodcritic/command_line_spec.rb

@@ -23,6 +23,19 @@ describe FoodCritic::CommandLine do
     end
   end
 
+  describe "#role_paths" do
+    it "returns an empty if no role paths are specified" do
+      FoodCritic::CommandLine.new([]).role_paths.must_be_empty
+    end
+    it "returns the provided role path" do
+      FoodCritic::CommandLine.new(['-R', 'roles']).role_paths.must_equal(%w{roles})
+    end
+    it "returns the provided role paths when there are multiple" do
+      FoodCritic::CommandLine.new(['-R', 'roles1',
+        '-R', 'roles2']).role_paths.must_equal(%w{roles1 roles2})
+    end
+  end
+
   describe "#valid_paths?" do
     it "returns false if no paths are specified" do
       refute FoodCritic::CommandLine.new([]).valid_paths?

data/spec/foodcritic/domain_spec.rb

@@ -2,23 +2,58 @@ require_relative '../spec_helper'
 
 describe FoodCritic::Review do
   it "is instantiable with no warnings" do
-    FoodCritic::Review.new('example', [], false)
+    FoodCritic::Review.new('example', [])
   end
   describe "#cookbook_paths" do
     it "returns the cookbook paths provided" do
-      FoodCritic::Review.new(['example'], [], false).cookbook_paths.must_equal ['example']
+      FoodCritic::Review.new(['example'], []).cookbook_paths.must_equal ['example']
     end
     it "returns the cookbook paths provided when there are multiple" do
-      FoodCritic::Review.new(['example', 'example2'], [], false).cookbook_paths.must_equal ['example', 'example2']
+      FoodCritic::Review.new(['example', 'example2'], []).cookbook_paths.must_equal ['example', 'example2']
     end
   end
   describe "#warnings" do
     it "returns empty when there are no warnings" do
-      FoodCritic::Review.new('example', [], false).warnings.must_be_empty
+      FoodCritic::Review.new('example', []).warnings.must_be_empty
     end
     it "makes the warnings available" do
       warning = 'Danger Will Robinson'
-      FoodCritic::Review.new('example', [warning], false).warnings.must_equal [warning]
+      FoodCritic::Review.new('example', [warning]).warnings.must_equal [warning]
+    end
+  end
+end
+
+describe FoodCritic::Rule do
+  let(:rule) { FoodCritic::Rule.new('FCTEST001', 'Test rule') }
+
+  describe '#matches_tags?' do
+    it "matches the rule's code" do
+      rule.matches_tags?(['FCTEST001']).must_equal true
+    end
+
+    it "doesn't match an unrelated code" do
+      rule.matches_tags?(['FCTEST999']).must_equal false
+    end
+  end
+
+  describe '#tags' do
+    it "returns any + the rule's code" do
+      rule.tags.must_equal ['any', 'FCTEST001']
+    end
+  end
+end
+
+describe FoodCritic::Warning do
+  let(:rule) { FoodCritic::Rule.new('FCTEST001', 'Test rule') }
+  let(:match_opts) { {:filename => 'foo/recipes.default.rb', :line => 5, :column=> 40} }
+
+  describe "failure indication" do
+    it 'is false if no fail_tags match' do
+      FoodCritic::Warning.new(rule, match_opts, {:fail_tags => []}).failed?.must_equal false
+    end
+
+    it 'is true if fail_tags do match' do
+      FoodCritic::Warning.new(rule, match_opts, {:fail_tags => ['any']}).failed?.must_equal true
     end
   end
 end

data/spec/foodcritic/linter_spec.rb

@@ -7,10 +7,6 @@ describe FoodCritic::Linter do
     it "is instantiable" do
       linter.wont_be_nil
     end
-
-    it "raises if a cookbook path is not provided" do
-      lambda {linter.check(nil, {})}.must_raise(ArgumentError)
-    end
   end
 
   describe "chef version" do
@@ -20,29 +16,30 @@ describe FoodCritic::Linter do
   end
 
   describe "#check" do
-    it "requires a cookbook_path to be provided" do
-      lambda{ linter.check(nil, {}) }.must_raise ArgumentError
-    end
-
-    it "requires an array of cookbook paths not to be empty" do
-      lambda{ linter.check([], {}) }.must_raise ArgumentError
-    end
-
-    it "accepts a scalar with a single cookbook path for backwards compatibility" do
-      linter.check('.', {})
-    end
 
-    it "accepts an array of cookbook paths" do
-      linter.check(['.'], {})
+    it "requires a cookbook_path, role_path or environment_path to be specified" do
+      lambda{ linter.check({}) }.must_raise ArgumentError
     end
 
-    it "returns a review" do
-      linter.check(['.'], {}).must_respond_to(:warnings)
+    [:cookbook, :role, :environment].each do |path_type|
+      key = "#{path_type}_paths".to_sym
+      it "requires a #{path_type}_path by itself not to be nil" do
+        lambda{ linter.check(key => nil) }.must_raise ArgumentError
+      end
+      it "requires a #{path_type}_path by itself not to be empty" do
+        lambda{ linter.check(key => []) }.must_raise ArgumentError
+      end
+      it "accepts a scalar with a single #{path_type} path" do
+        linter.check(key => '.')
+      end
+      it "accepts an array of #{path_type} paths" do
+        linter.check(key => ['.'])
+      end
+      it "returns a review when a #{path_type} path is provided" do
+        linter.check(key => ['.']).must_respond_to(:warnings)
+      end
     end
 
-    it "does not require an empty hash of options" do
-      linter.check(['.'])
-    end
   end
 
   describe "#load_files!" do

data/spec/foodcritic/template_spec.rb

@@ -16,7 +16,8 @@ describe FoodCritic::Template::ExpressionExtractor do
         <% if true %>
           Hello World!
         <% end %>
-      }).must_equal([{:type => :statement, :code => 'if true'}, {:type => :statement, :code => 'end'}])
+      }).must_equal([{:type => :statement, :code => 'if true', :line => 2},
+                     {:type => :statement, :code => 'end', :line => 4}])
     end
     it "does not evaluate erb statements" do
       extractor.extract(%q{
@@ -26,7 +27,7 @@ describe FoodCritic::Template::ExpressionExtractor do
     it "extracts an expression from within the template" do
       extractor.extract(%q{
         <%= foo %>
-      }).must_equal([{:type => :expression, :code => 'foo'}])
+      }).must_equal([{:type => :expression, :code => 'foo', :line => 2}])
     end
     it "does not evaluate erb expressions" do
       extractor.extract(%q{
@@ -40,10 +41,13 @@ describe FoodCritic::Template::ExpressionExtractor do
                    URIEncoding="UTF-8"
                    redirectPort="<%= node["tomcat"]["ssl_port"] %>" />
       }).must_equal([
-        {:type => :expression, :code => 'node["tomcat"]["port"]'},
-        {:type => :expression, :code => 'node["tomcat"]["ssl_port"]'}
+        {:type => :expression, :code => 'node["tomcat"]["port"]', :line => 2},
+        {:type => :expression, :code => 'node["tomcat"]["ssl_port"]', :line => 5}
       ])
     end
+    it "excludes comment-only expressions" do
+      extractor.extract('<%# A comment %>').must_be_empty
+    end
   end
 
 end

data/spec/regression/expected-output.txt

@@ -1,5 +1,5 @@
 FC002: Avoid string interpolation where not required: ./ant/resources/library.rb:29
-FC002: Avoid string interpolation where not required: ./application_php/templates/default/php.conf.erb:1
+FC002: Avoid string interpolation where not required: ./application_php/templates/default/php.conf.erb:3
 FC002: Avoid string interpolation where not required: ./application_python/providers/gunicorn.rb:80
 FC002: Avoid string interpolation where not required: ./ark/libraries/provider_ark.rb:247
 FC002: Avoid string interpolation where not required: ./ark/libraries/provider_ark.rb:249
@@ -21,8 +21,8 @@ FC002: Avoid string interpolation where not required: ./pacman/providers/aur.rb:
 FC002: Avoid string interpolation where not required: ./pacman/providers/aur.rb:31
 FC002: Avoid string interpolation where not required: ./pacman/providers/aur.rb:72
 FC002: Avoid string interpolation where not required: ./pacman/providers/aur.rb:90
-FC002: Avoid string interpolation where not required: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:1
-FC002: Avoid string interpolation where not required: ./passenger_apache2/templates/default/web_app.conf.erb:1
+FC002: Avoid string interpolation where not required: ./passenger_apache2/templates/default/passenger_web_app.conf.erb:3
+FC002: Avoid string interpolation where not required: ./passenger_apache2/templates/default/web_app.conf.erb:3
 FC002: Avoid string interpolation where not required: ./perl/recipes/default.rb:37
 FC002: Avoid string interpolation where not required: ./perl/recipes/default.rb:43
 FC002: Avoid string interpolation where not required: ./pxe_dust/recipes/bootstrap_template.rb:89
@@ -35,7 +35,7 @@ FC002: Avoid string interpolation where not required: ./python/providers/virtual
 FC002: Avoid string interpolation where not required: ./python/providers/virtualenv.rb:64
 FC002: Avoid string interpolation where not required: ./radiant/recipes/default.rb:57
 FC002: Avoid string interpolation where not required: ./radiant/recipes/default.rb:61
-FC002: Avoid string interpolation where not required: ./radiant/templates/default/radiant.conf.erb:1
+FC002: Avoid string interpolation where not required: ./radiant/templates/default/radiant.conf.erb:3
 FC002: Avoid string interpolation where not required: ./rsyslog/recipes/default.rb:24
 FC002: Avoid string interpolation where not required: ./rsyslog/recipes/default.rb:63
 FC002: Avoid string interpolation where not required: ./sbuild/definitions/sbuild_lv.rb:30
@@ -45,7 +45,7 @@ FC002: Avoid string interpolation where not required: ./windows/libraries/window
 FC002: Avoid string interpolation where not required: ./windows/libraries/windows_privileged.rb:56
 FC002: Avoid string interpolation where not required: ./wordpress/recipes/default.rb:66
 FC002: Avoid string interpolation where not required: ./wordpress/recipes/default.rb:148
-FC002: Avoid string interpolation where not required: ./wordpress/templates/default/wordpress.conf.erb:1
+FC002: Avoid string interpolation where not required: ./wordpress/templates/default/wordpress.conf.erb:3
 FC002: Avoid string interpolation where not required: ./zenoss/providers/zendmd.rb:4
 FC002: Avoid string interpolation where not required: ./zenoss/recipes/server.rb:164
 FC003: Check whether you are running with chef server before using server-specific features: ./application/libraries/default.rb:97
@@ -146,57 +146,126 @@ FC016: LWRP does not declare a default action: ./zenoss/resources/zenbatchload.r
 FC016: LWRP does not declare a default action: ./zenoss/resources/zendmd.rb:1
 FC016: LWRP does not declare a default action: ./zenoss/resources/zenpack.rb:1
 FC016: LWRP does not declare a default action: ./zenoss/resources/zenpatch.rb:1
-FC017: LWRP does not notify when updated: ./application/providers/default.rb:1
-FC017: LWRP does not notify when updated: ./application_java/providers/java_webapp.rb:1
-FC017: LWRP does not notify when updated: ./application_java/providers/tomcat.rb:1
-FC017: LWRP does not notify when updated: ./application_nginx/providers/nginx_load_balancer.rb:1
-FC017: LWRP does not notify when updated: ./application_php/providers/mod_php_apache2.rb:1
-FC017: LWRP does not notify when updated: ./application_php/providers/php.rb:1
-FC017: LWRP does not notify when updated: ./application_python/providers/celery.rb:1
-FC017: LWRP does not notify when updated: ./application_python/providers/django.rb:1
-FC017: LWRP does not notify when updated: ./application_python/providers/gunicorn.rb:1
-FC017: LWRP does not notify when updated: ./application_ruby/providers/memcached.rb:1
-FC017: LWRP does not notify when updated: ./application_ruby/providers/passenger_apache2.rb:1
-FC017: LWRP does not notify when updated: ./application_ruby/providers/rails.rb:1
-FC017: LWRP does not notify when updated: ./application_ruby/providers/unicorn.rb:1
-FC017: LWRP does not notify when updated: ./aws/providers/ebs_volume.rb:1
-FC017: LWRP does not notify when updated: ./aws/providers/elastic_ip.rb:1
-FC017: LWRP does not notify when updated: ./aws/providers/elastic_lb.rb:1
-FC017: LWRP does not notify when updated: ./aws/providers/resource_tag.rb:1
-FC017: LWRP does not notify when updated: ./chef_handler/providers/default.rb:1
-FC017: LWRP does not notify when updated: ./dmg/providers/package.rb:1
-FC017: LWRP does not notify when updated: ./heartbeat/providers/default.rb:1
-FC017: LWRP does not notify when updated: ./heartbeat/providers/null.rb:1
-FC017: LWRP does not notify when updated: ./homebrew/providers/tap.rb:1
-FC017: LWRP does not notify when updated: ./iis/providers/app.rb:1
-FC017: LWRP does not notify when updated: ./iis/providers/config.rb:1
-FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:1
-FC017: LWRP does not notify when updated: ./iis/providers/site.rb:1
-FC017: LWRP does not notify when updated: ./java/providers/ark.rb:1
-FC017: LWRP does not notify when updated: ./lvm/providers/physical_volume.rb:1
-FC017: LWRP does not notify when updated: ./pacman/providers/aur.rb:1
-FC017: LWRP does not notify when updated: ./php/providers/pear.rb:1
-FC017: LWRP does not notify when updated: ./php/providers/pear_channel.rb:1
-FC017: LWRP does not notify when updated: ./powershell/providers/default.rb:1
-FC017: LWRP does not notify when updated: ./python/providers/pip.rb:1
-FC017: LWRP does not notify when updated: ./supervisor/providers/fcgi.rb:1
-FC017: LWRP does not notify when updated: ./supervisor/providers/group.rb:1
-FC017: LWRP does not notify when updated: ./supervisor/providers/service.rb:1
-FC017: LWRP does not notify when updated: ./webpi/providers/product.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/auto_run.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/batch.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/feature_dism.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/feature_servermanagercmd.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/package.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/pagefile.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/path.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/reboot.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/shortcut.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/task.rb:1
-FC017: LWRP does not notify when updated: ./windows/providers/zipfile.rb:1
-FC017: LWRP does not notify when updated: ./zenoss/providers/zenbatchload.rb:1
-FC017: LWRP does not notify when updated: ./zenoss/providers/zendmd.rb:1
+FC017: LWRP does not notify when updated: ./application/providers/default.rb:23
+FC017: LWRP does not notify when updated: ./application/providers/default.rb:33
+FC017: LWRP does not notify when updated: ./application/providers/default.rb:43
+FC017: LWRP does not notify when updated: ./application_java/providers/java_webapp.rb:25
+FC017: LWRP does not notify when updated: ./application_java/providers/tomcat.rb:22
+FC017: LWRP does not notify when updated: ./application_java/providers/tomcat.rb:34
+FC017: LWRP does not notify when updated: ./application_nginx/providers/nginx_load_balancer.rb:23
+FC017: LWRP does not notify when updated: ./application_nginx/providers/nginx_load_balancer.rb:37
+FC017: LWRP does not notify when updated: ./application_php/providers/mod_php_apache2.rb:22
+FC017: LWRP does not notify when updated: ./application_php/providers/mod_php_apache2.rb:46
+FC017: LWRP does not notify when updated: ./application_php/providers/php.rb:22
+FC017: LWRP does not notify when updated: ./application_php/providers/php.rb:31
+FC017: LWRP does not notify when updated: ./application_python/providers/celery.rb:23
+FC017: LWRP does not notify when updated: ./application_python/providers/celery.rb:50
+FC017: LWRP does not notify when updated: ./application_python/providers/django.rb:25
+FC017: LWRP does not notify when updated: ./application_python/providers/django.rb:36
+FC017: LWRP does not notify when updated: ./application_python/providers/django.rb:44
+FC017: LWRP does not notify when updated: ./application_python/providers/django.rb:70
+FC017: LWRP does not notify when updated: ./application_python/providers/gunicorn.rb:25
+FC017: LWRP does not notify when updated: ./application_python/providers/gunicorn.rb:46
+FC017: LWRP does not notify when updated: ./application_python/providers/gunicorn.rb:91
+FC017: LWRP does not notify when updated: ./application_ruby/providers/memcached.rb:20
+FC017: LWRP does not notify when updated: ./application_ruby/providers/memcached.rb:26
+FC017: LWRP does not notify when updated: ./application_ruby/providers/passenger_apache2.rb:22
+FC017: LWRP does not notify when updated: ./application_ruby/providers/passenger_apache2.rb:40
+FC017: LWRP does not notify when updated: ./application_ruby/providers/rails.rb:21
+FC017: LWRP does not notify when updated: ./application_ruby/providers/rails.rb:44
+FC017: LWRP does not notify when updated: ./application_ruby/providers/rails.rb:54
+FC017: LWRP does not notify when updated: ./application_ruby/providers/rails.rb:108
+FC017: LWRP does not notify when updated: ./application_ruby/providers/unicorn.rb:23
+FC017: LWRP does not notify when updated: ./application_ruby/providers/unicorn.rb:54
+FC017: LWRP does not notify when updated: ./apt/providers/repository.rb:124
+FC017: LWRP does not notify when updated: ./cron/providers/d.rb:1
+FC017: LWRP does not notify when updated: ./dmg/providers/package.rb:27
+FC017: LWRP does not notify when updated: ./firewall/providers/rule_ufw.rb:23
+FC017: LWRP does not notify when updated: ./firewall/providers/rule_ufw.rb:27
+FC017: LWRP does not notify when updated: ./firewall/providers/rule_ufw.rb:31
+FC017: LWRP does not notify when updated: ./heartbeat/providers/default.rb:20
+FC017: LWRP does not notify when updated: ./homebrew/providers/tap.rb:13
+FC017: LWRP does not notify when updated: ./homebrew/providers/tap.rb:21
+FC017: LWRP does not notify when updated: ./iis/providers/app.rb:26
+FC017: LWRP does not notify when updated: ./iis/providers/app.rb:40
+FC017: LWRP does not notify when updated: ./iis/providers/app.rb:57
+FC017: LWRP does not notify when updated: ./iis/providers/config.rb:27
+FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:27
+FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:41
+FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:68
+FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:78
+FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:88
+FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:98
+FC017: LWRP does not notify when updated: ./iis/providers/pool.rb:106
+FC017: LWRP does not notify when updated: ./iis/providers/site.rb:26
+FC017: LWRP does not notify when updated: ./iis/providers/site.rb:50
+FC017: LWRP does not notify when updated: ./iis/providers/site.rb:84
+FC017: LWRP does not notify when updated: ./iis/providers/site.rb:94
+FC017: LWRP does not notify when updated: ./iis/providers/site.rb:104
+FC017: LWRP does not notify when updated: ./iis/providers/site.rb:114
+FC017: LWRP does not notify when updated: ./lvm/providers/physical_volume.rb:6
+FC017: LWRP does not notify when updated: ./maven/providers/default.rb:61
+FC017: LWRP does not notify when updated: ./maven/providers/default.rb:65
+FC017: LWRP does not notify when updated: ./pacman/providers/aur.rb:24
+FC017: LWRP does not notify when updated: ./pacman/providers/aur.rb:98
+FC017: LWRP does not notify when updated: ./php/providers/pear_channel.rb:31
+FC017: LWRP does not notify when updated: ./php/providers/pear_channel.rb:40
+FC017: LWRP does not notify when updated: ./php/providers/pear_channel.rb:69
+FC017: LWRP does not notify when updated: ./powershell/providers/default.rb:19
+FC017: LWRP does not notify when updated: ./rsync/providers/serve.rb:65
+FC017: LWRP does not notify when updated: ./rsync/providers/serve.rb:69
+FC017: LWRP does not notify when updated: ./sudo/providers/default.rb:102
+FC017: LWRP does not notify when updated: ./supervisor/providers/fcgi.rb:21
+FC017: LWRP does not notify when updated: ./supervisor/providers/fcgi.rb:38
+FC017: LWRP does not notify when updated: ./supervisor/providers/fcgi.rb:50
+FC017: LWRP does not notify when updated: ./supervisor/providers/fcgi.rb:56
+FC017: LWRP does not notify when updated: ./supervisor/providers/fcgi.rb:62
+FC017: LWRP does not notify when updated: ./supervisor/providers/fcgi.rb:68
+FC017: LWRP does not notify when updated: ./supervisor/providers/group.rb:21
+FC017: LWRP does not notify when updated: ./supervisor/providers/group.rb:38
+FC017: LWRP does not notify when updated: ./supervisor/providers/group.rb:50
+FC017: LWRP does not notify when updated: ./supervisor/providers/group.rb:56
+FC017: LWRP does not notify when updated: ./supervisor/providers/group.rb:62
+FC017: LWRP does not notify when updated: ./supervisor/providers/group.rb:68
+FC017: LWRP does not notify when updated: ./supervisor/providers/service.rb:21
+FC017: LWRP does not notify when updated: ./supervisor/providers/service.rb:38
+FC017: LWRP does not notify when updated: ./supervisor/providers/service.rb:50
+FC017: LWRP does not notify when updated: ./supervisor/providers/service.rb:56
+FC017: LWRP does not notify when updated: ./supervisor/providers/service.rb:62
+FC017: LWRP does not notify when updated: ./supervisor/providers/service.rb:68
+FC017: LWRP does not notify when updated: ./webpi/providers/product.rb:26
+FC017: LWRP does not notify when updated: ./windows/providers/auto_run.rb:21
+FC017: LWRP does not notify when updated: ./windows/providers/auto_run.rb:27
+FC017: LWRP does not notify when updated: ./windows/providers/batch.rb:24
+FC017: LWRP does not notify when updated: ./windows/providers/package.rb:35
+FC017: LWRP does not notify when updated: ./windows/providers/package.rb:53
+FC017: LWRP does not notify when updated: ./windows/providers/package.rb:64
+FC017: LWRP does not notify when updated: ./windows/providers/pagefile.rb:24
+FC017: LWRP does not notify when updated: ./windows/providers/pagefile.rb:66
+FC017: LWRP does not notify when updated: ./windows/providers/path.rb:21
+FC017: LWRP does not notify when updated: ./windows/providers/path.rb:29
+FC017: LWRP does not notify when updated: ./windows/providers/reboot.rb:21
+FC017: LWRP does not notify when updated: ./windows/providers/reboot.rb:27
+FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:27
+FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:31
+FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:35
+FC017: LWRP does not notify when updated: ./windows/providers/registry.rb:61
+FC017: LWRP does not notify when updated: ./windows/providers/task.rb:24
+FC017: LWRP does not notify when updated: ./windows/providers/task.rb:43
+FC017: LWRP does not notify when updated: ./windows/providers/task.rb:58
+FC017: LWRP does not notify when updated: ./windows/providers/task.rb:75
+FC017: LWRP does not notify when updated: ./windows/providers/zipfile.rb:27
+FC017: LWRP does not notify when updated: ./windows/providers/zipfile.rb:44
+FC017: LWRP does not notify when updated: ./yum/providers/key.rb:25
+FC017: LWRP does not notify when updated: ./yum/providers/repository.rb:28
+FC017: LWRP does not notify when updated: ./yum/providers/repository.rb:45
+FC017: LWRP does not notify when updated: ./zenoss/providers/zenbatchload.rb:2
+FC017: LWRP does not notify when updated: ./zenoss/providers/zendmd.rb:2
+FC017: LWRP does not notify when updated: ./zenoss/providers/zendmd.rb:33
+FC017: LWRP does not notify when updated: ./zenoss/providers/zendmd.rb:63
+FC017: LWRP does not notify when updated: ./zenoss/providers/zendmd.rb:77
+FC017: LWRP does not notify when updated: ./zenoss/providers/zendmd.rb:88
+FC017: LWRP does not notify when updated: ./zenoss/providers/zendmd.rb:97
 FC017: LWRP does not notify when updated: ./zenoss/providers/zenpatch.rb:1
 FC018: LWRP uses deprecated notification syntax: ./pacman/providers/aur.rb:94
 FC018: LWRP uses deprecated notification syntax: ./pacman/providers/aur.rb:104
@@ -277,9 +346,6 @@ FC019: Access node attributes in a consistent manner: runit/definitions/runit_se
 FC019: Access node attributes in a consistent manner: trac/recipes/default.rb:53
 FC019: Access node attributes in a consistent manner: ufw/attributes/default.rb:1
 FC019: Access node attributes in a consistent manner: ufw/attributes/default.rb:2
-FC019: Access node attributes in a consistent manner: windows/providers/reboot.rb:22
-FC019: Access node attributes in a consistent manner: windows/providers/reboot.rb:23
-FC019: Access node attributes in a consistent manner: windows/providers/reboot.rb:24
 FC019: Access node attributes in a consistent manner: zenoss/attributes/default.rb:33
 FC019: Access node attributes in a consistent manner: zenoss/recipes/server.rb:62
 FC019: Access node attributes in a consistent manner: zenoss/recipes/server.rb:86
@@ -332,7 +398,6 @@ FC034: Unused template variables: ./horizon/templates/default/local_settings.py.
 FC034: Unused template variables: ./nginx/templates/default/nginx.init.erb:1
 FC034: Unused template variables: ./nova/templates/default/libvirtd.conf.erb:1
 FC034: Unused template variables: ./sbuild/templates/default/mk_chroot.sh.erb:1
-FC037: Invalid notification action: ./wordpress/recipes/default.rb:125
 FC041: Execute resource used to run curl or wget commands: ./hadoop/recipes/default.rb:33
 FC042: Prefer include_recipe to require_recipe: ./postfix/recipes/aliases.rb:17
 FC043: Prefer new notification syntax: ./apache2/definitions/apache_module.rb:20
@@ -441,3 +506,17 @@ FC043: Prefer new notification syntax: ./zenoss/recipes/server.rb:155
 FC043: Prefer new notification syntax: ./zenoss/recipes/server.rb:164
 FC044: Avoid bare attribute keys: ./resolver/attributes/default.rb:20
 FC045: Consider setting cookbook name in metadata: ./maven/metadata.rb:1
+FC047: Attribute assignment does not specify precedence: ./jetty/recipes/cargo.rb:35
+FC047: Attribute assignment does not specify precedence: ./munin/recipes/server_apache.rb:1
+FC047: Attribute assignment does not specify precedence: ./python/recipes/package.rb:28
+FC047: Attribute assignment does not specify precedence: ./users/providers/manage.rb:55
+FC048: Prefer Mixlib::ShellOut: ./apt/providers/repository.rb:26
+FC048: Prefer Mixlib::ShellOut: ./chef-client/recipes/cron.rb:38
+FC048: Prefer Mixlib::ShellOut: ./chef-client/recipes/delete_validation.rb:20
+FC048: Prefer Mixlib::ShellOut: ./chef-client/recipes/service.rb:52
+FC048: Prefer Mixlib::ShellOut: ./chef-client/recipes/task.rb:42
+FC048: Prefer Mixlib::ShellOut: ./dmg/providers/package.rb:44
+FC048: Prefer Mixlib::ShellOut: ./dmg/providers/package.rb:47
+FC048: Prefer Mixlib::ShellOut: ./dmg/providers/package.rb:76
+FC048: Prefer Mixlib::ShellOut: ./nginx/recipes/passenger.rb:20
+FC048: Prefer Mixlib::ShellOut: ./windows/providers/task.rb:106

metadata

@@ -1,20 +1,18 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 2.2.0
-  prerelease: 
+  version: 3.0.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-07-10 00:00:00.000000000 Z
+date: 2013-09-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: gherkin
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -22,7 +20,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -30,7 +27,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -38,15 +34,27 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
         version: 1.5.4
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 10.1.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: 10.1.0
 - !ruby/object:Gem::Dependency
   name: treetop
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -54,7 +62,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -62,7 +69,6 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: yajl-ruby
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -70,7 +76,6 @@ dependencies:
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
@@ -78,17 +83,15 @@ dependencies:
 - !ruby/object:Gem::Dependency
   name: erubis
   requirement: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
-    none: false
     requirements:
-    - - '>='
+    - - ! '>='
       - !ruby/object:Gem::Version
         version: '0'
 description: Lint tool for Opscode Chef cookbooks.
@@ -131,6 +134,7 @@ files:
 - chef_dsl_metadata/chef_0.10.0.json
 - chef_dsl_metadata/chef_10.16.2.json
 - chef_dsl_metadata/chef_10.24.0.json
+- chef_dsl_metadata/chef_11.6.0.json
 - chef_dsl_metadata/chef_10.24.4.json
 - chef_dsl_metadata/chef_10.14.2.json
 - chef_dsl_metadata/chef_10.14.0.json
@@ -168,11 +172,13 @@ files:
 - features/choose_rules_to_apply.feature
 - features/030_check_for_debugger_breakpoints.feature
 - features/006_check_file_mode.feature
+- features/050_check_for_invalid_name.feature
 - features/029_check_for_no_leading_cookbook_name.feature
 - features/include_custom_rules.feature
 - features/031_check_for_metadata_existence.feature
 - features/checking_all_types_of_file.feature
 - features/021_check_for_dodgy_lwrp_conditions.feature
+- features/051_check_for_template_partial_loops.feature
 - features/015_check_for_definitions.feature
 - features/041_check_raw_download.feature
 - features/individual_file.feature
@@ -210,7 +216,9 @@ files:
 - features/042_check_for_deprecated_require_recipe.feature
 - features/024_check_for_missing_platforms.feature
 - features/command_line_help.feature
+- features/049_check_for_role_name_mismatch_with_file_name.feature
 - features/013_check_for_hardcoded_tmpdir.feature
+- features/047_check_for_attribute_assignment_without_precedence.feature
 - features/011_check_for_markdown_readme.feature
 - features/specify_search_grammar.feature
 - features/019_check_for_consistent_node_access.feature
@@ -219,6 +227,7 @@ files:
 - features/ignore_via_line_comments.feature
 - features/016_check_for_no_lwrp_default_action.feature
 - features/033_check_for_missing_template.feature
+- features/048_check_for_shellout.feature
 - features/040_check_raw_git_usage.feature
 - features/009_check_for_unrecognised_resource_attributes.feature
 - features/build_framework_support.feature
@@ -228,32 +237,28 @@ files:
 - LICENSE
 - man/foodcritic.1.ronn
 - man/foodcritic.1
-homepage: http://acrmp.github.com/foodcritic
+homepage: http://foodcritic.io
 licenses:
 - MIT
+metadata: {}
 post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
-  none: false
   requirements:
-  - - '>='
+  - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
-      segments:
-      - 0
-      hash: 2951702180016458639
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 2.0.7
 signing_key: 
-specification_version: 3
-summary: foodcritic-2.2.0
+specification_version: 4
+summary: foodcritic-3.0.0
 test_files: []