foodcritic 16.1.1 → 16.2.0

data/lib/foodcritic/rules/fc040.rb

@@ -5,7 +5,7 @@ rule "FC040", "Execute resource used to run git commands" do
     find_resources(ast, type: "execute").select do |cmd|
       cmd_str = (resource_attribute(cmd, "command") || resource_name(cmd)).to_s
 
-      actual_git_commands = cmd_str.scan(/git ([a-z]+)/).map { |c| c.first }
+      actual_git_commands = cmd_str.scan(/git ([a-z]+)/).map(&:first)
       (possible_git_commands & actual_git_commands).any?
     end
   end

data/lib/foodcritic/rules/fc044.rb

@@ -1,22 +1,18 @@
 rule "FC044", "Avoid bare attribute keys" do
   tags %w{style}
   attributes do |ast|
-    declared = ast.xpath("//descendant::var_field/ident/@value").map do |v|
-      v.to_s
-    end
+    declared = ast.xpath("//descendant::var_field/ident/@value").map(&:to_s)
 
     ast.xpath('//assign/*[self::vcall or self::var_ref]
               [count(child::kw) = 0]/ident').select do |v|
 
-      local_declared = v.xpath("ancestor::*[self::brace_block or self::do_block]
-                                /block_var/descendant::ident/@value").map do |val|
-        val.to_s
-      end
+                local_declared = v.xpath("ancestor::*[self::brace_block or self::do_block]
+                                          /block_var/descendant::ident/@value").map(&:to_s)
 
-      (v["value"] != "secure_password") &&
-        !(declared + local_declared).uniq.include?(v["value"]) &&
-        !v.xpath("ancestor::*[self::brace_block or self::do_block]/block_var/
-                  descendant::ident/@value='#{v['value']}'")
-    end
+                (v["value"] != "secure_password") &&
+                  !(declared + local_declared).uniq.include?(v["value"]) &&
+                  !v.xpath("ancestor::*[self::brace_block or self::do_block]/block_var/
+                            descendant::ident/@value='#{v["value"]}'")
+              end
   end
 end

data/lib/foodcritic/rules/fc048.rb

@@ -7,6 +7,7 @@ rule "FC048", "Prefer shell_out helper method to shelling out with Ruby" do
     ast.xpath('//*[self::command or self::fcall]/ident[@value="system"]').select do |x|
       resource_name = x.xpath("ancestor::do_block/preceding-sibling::command/ident/@value")
       next false if resource_name.any? && resource_name.all? { |r| resource_attribute?(r.to_s, "system") }
+
       next x.xpath('count(following-sibling::args_add_block/descendant::kw[@value="true" or @value="false"]) = 0')
     end
   end

data/lib/foodcritic/rules/fc123.rb

@@ -5,10 +5,11 @@ rule "FC123", "Content of a cookbook file is larger than 1MB" do
     files_path = File.join(path, "files")
     if File.exist?(files_path)
       Dir.foreach(files_path) do |file|
-        next if ['.', '..'].member?(file)
-        size = File.size(File.join(files_path,file))
-        if size > 1024*1024 # 1 megabyte
-          values += [file_match(File.join(files_path,file))]
+        next if [".", ".."].member?(file)
+
+        size = File.size(File.join(files_path, file))
+        if size > 1024 * 1024 # 1 megabyte
+          values += [file_match(File.join(files_path, file))]
         end
       end
     end

data/lib/foodcritic/template.rb

@@ -20,14 +20,11 @@ module FoodCritic
         end
       end
 
-      def add_text(src, text)
-      end
+      def add_text(src, text); end
 
-      def add_preamble(codebuf)
-      end
+      def add_preamble(codebuf); end
 
-      def add_postamble(codebuf)
-      end
+      def add_postamble(codebuf); end
 
       def add_stmt(src, code)
         @expressions << { type: :statement, code: code.strip }

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "16.1.1".freeze
+  VERSION = "16.2.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 16.1.1
+  version: 16.2.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-07-03 00:00:00.000000000 Z
+date: 2019-11-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -172,8 +172,8 @@ files:
 - Gemfile
 - LICENSE
 - bin/foodcritic
-- chef_dsl_metadata/chef_14.12.9.json
-- chef_dsl_metadata/chef_15.1.36.json
+- chef_dsl_metadata/chef_14.14.29.json
+- chef_dsl_metadata/chef_15.4.45.json
 - foodcritic.gemspec
 - lib/foodcritic.rb
 - lib/foodcritic/api.rb
@@ -325,5 +325,5 @@ requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: foodcritic-16.1.1
+summary: foodcritic-16.2.0
 test_files: []