foodcritic 16.0.0 → 16.1.0

data/lib/foodcritic/api.rb

@@ -254,14 +254,20 @@ module FoodCritic
         line: pos["line"].to_i, column: pos["column"].to_i }
     end
 
+    # Returns a global LRU cache holding the AST of a file
+    # @since 16.1
+    # @param size [Integer] the size of the cache (will be resized)
+    def ast_cache(size = nil)
+      @@ast_cache ||= Rufus::Lru::Hash.new(size || 5)
+      if size && @@ast_cache.maxsize != size
+        @@ast_cache.maxsize = size
+      end
+      @@ast_cache
+    end
+
     # Read the AST for the given Ruby source file
     def read_ast(file)
-      @ast_cache ||= Rufus::Lru::Hash.new(5)
-      if @ast_cache.include?(file)
-        @ast_cache[file]
-      else
-        @ast_cache[file] = uncached_read_ast(file)
-      end
+      ast_cache[file] ||= uncached_read_ast(file)
     end
 
     # Retrieve a single-valued attribute from the specified resource.
@@ -517,7 +523,7 @@ module FoodCritic
     # those exist in cookbooks, but are not longer part of chef 14+
     # this prevents false positives in FC019 anytime node.set is found
     def node_method?(meth, cookbook_dir)
-      chef_dsl_methods.include?(meth) || meth == :set || meth == :set_unless ||
+      chef_node_methods.include?(meth) || meth == :set || meth == :set_unless ||
         patched_node_method?(meth, cookbook_dir)
     end
 

data/lib/foodcritic/command_line.rb

@@ -24,6 +24,7 @@ module FoodCritic
         environment_paths: [],
         exclude_paths: ["test/**/*", "spec/**/*", "features/**/*"],
         progress: true,
+        ast_cache_size: 5,
       }
       @parser = OptionParser.new do |opts|
         opts.banner = "foodcritic [cookbook_paths]"
@@ -50,6 +51,10 @@ module FoodCritic
                 "Specify file with rules to be used or ignored ") do |c|
           @options[:rule_file] = c
         end
+        opts.on("-s", "--ast-cache-size NUM", Integer,
+                "Change the size of the AST cache.") do |s|
+          @options[:ast_cache_size] = s
+        end
         opts.on("-B", "--cookbook-path PATH",
                 "Cookbook path(s) to check.") do |b|
           @options[:cookbook_paths] << b

data/lib/foodcritic/linter.rb

@@ -9,7 +9,7 @@ module FoodCritic
 
     # The default version that will be used to determine relevant rules. This
     # can be over-ridden at the command line with the `--chef-version` option.
-    DEFAULT_CHEF_VERSION = "15.0.293".freeze
+    DEFAULT_CHEF_VERSION = "15.1.36".freeze
     attr_reader :chef_version
 
     # Perform a lint check. This method is intended for use by the command-line
@@ -68,6 +68,7 @@ module FoodCritic
       options = setup_defaults(options)
       @options = options
       @chef_version = options[:chef_version] || DEFAULT_CHEF_VERSION
+      ast_cache(options[:ast_cache_size])
 
       warnings = []; last_dir = nil; matched_rule_tags = Set.new
       load_rules

data/lib/foodcritic/rules/fc123.rb

@@ -0,0 +1,14 @@
+rule "FC123", "Content of files/ is larger than 1MB" do
+  tags %w{files}
+  cookbook do |path|
+    values = []
+    Dir.foreach(File.join(path, "files")) do |file|
+      next if ['.', '..'].member?(file)
+      size = File.size(File.join(path,'files',file))
+      if size > 1024*1024 # 1 megabyte
+        values += [file_match(File.join(path,'files',file))]
+      end
+    end
+    values
+  end
+end

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "16.0.0".freeze
+  VERSION = "16.1.0".freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 16.0.0
+  version: 16.1.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-14 00:00:00.000000000 Z
+date: 2019-07-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -173,7 +173,7 @@ files:
 - LICENSE
 - bin/foodcritic
 - chef_dsl_metadata/chef_14.12.9.json
-- chef_dsl_metadata/chef_15.0.293.json
+- chef_dsl_metadata/chef_15.1.36.json
 - foodcritic.gemspec
 - lib/foodcritic.rb
 - lib/foodcritic/api.rb
@@ -298,6 +298,7 @@ files:
 - lib/foodcritic/rules/fc120.rb
 - lib/foodcritic/rules/fc121.rb
 - lib/foodcritic/rules/fc122.rb
+- lib/foodcritic/rules/fc123.rb
 - lib/foodcritic/template.rb
 - lib/foodcritic/version.rb
 - lib/foodcritic/xml.rb
@@ -324,5 +325,5 @@ requirements: []
 rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
-summary: foodcritic-16.0.0
+summary: foodcritic-16.1.0
 test_files: []