foodcritic 14.3.0 → 15.0.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/Gemfile +1 -1
- data/Rakefile +3 -3
- data/chef_dsl_metadata/{chef_13.11.3.json → chef_13.12.3.json} +0 -0
- data/chef_dsl_metadata/{chef_14.5.33.json → chef_14.7.17.json} +1231 -191
- data/foodcritic.gemspec +1 -1
- data/lib/foodcritic/api.rb +2 -2
- data/lib/foodcritic/domain.rb +2 -2
- data/lib/foodcritic/linter.rb +1 -1
- data/lib/foodcritic/rules/fc024.rb +1 -1
- data/lib/foodcritic/rules/fc042.rb +1 -1
- data/lib/foodcritic/version.rb +1 -1
- data/spec/functional/fc009_spec.rb +2 -2
- data/spec/unit/api_spec.rb +190 -190
- data/spec/unit/domain_spec.rb +3 -3
- data/spec/unit/linter_spec.rb +5 -5
- data/spec/unit/template_spec.rb +5 -5
- metadata +6 -12
- data/CHANGELOG.md +0 -780
- data/README.md +0 -79
- data/chef_dsl_metadata/chef_14.1.12.json +0 -26882
- data/chef_dsl_metadata/chef_14.2.0.json +0 -26904
- data/chef_dsl_metadata/chef_14.3.37.json +0 -27870
- data/chef_dsl_metadata/chef_14.4.56.json +0 -29761
data/spec/unit/domain_spec.rb
CHANGED
@@ -64,15 +64,15 @@ end
|
|
64
64
|
|
65
65
|
describe FoodCritic::Warning do
|
66
66
|
let(:rule) { FoodCritic::Rule.new("FCTEST001", "Test rule") }
|
67
|
-
let(:match_opts) { { :
|
67
|
+
let(:match_opts) { { filename: "foo/recipes.default.rb", line: 5, column: 40 } }
|
68
68
|
|
69
69
|
describe "failure indication" do
|
70
70
|
it "is false if no fail_tags match" do
|
71
|
-
expect(FoodCritic::Warning.new(rule, match_opts, { :
|
71
|
+
expect(FoodCritic::Warning.new(rule, match_opts, { fail_tags: [] })).to_not be_failed
|
72
72
|
end
|
73
73
|
|
74
74
|
it "is true if fail_tags do match" do
|
75
|
-
expect(FoodCritic::Warning.new(rule, match_opts, { :
|
75
|
+
expect(FoodCritic::Warning.new(rule, match_opts, { fail_tags: ["any"] })).to be_failed
|
76
76
|
end
|
77
77
|
end
|
78
78
|
end
|
data/spec/unit/linter_spec.rb
CHANGED
@@ -12,7 +12,7 @@ describe FoodCritic::Linter do
|
|
12
12
|
|
13
13
|
describe "chef version" do
|
14
14
|
it "should be the latest stable version of Chef" do
|
15
|
-
expect(FoodCritic::Linter::DEFAULT_CHEF_VERSION).to eq "14.
|
15
|
+
expect(FoodCritic::Linter::DEFAULT_CHEF_VERSION).to eq "14.7.17"
|
16
16
|
end
|
17
17
|
end
|
18
18
|
|
@@ -70,11 +70,11 @@ describe FoodCritic::Linter do
|
|
70
70
|
end
|
71
71
|
|
72
72
|
it "does not require cookbook_path, role_path or environment_path to be specified" do
|
73
|
-
linter.list(:
|
73
|
+
linter.list(list: true)
|
74
74
|
end
|
75
75
|
|
76
76
|
it "returns a rule listing" do
|
77
|
-
expect(linter.list(:
|
77
|
+
expect(linter.list(list: true)).to respond_to :rules
|
78
78
|
end
|
79
79
|
end
|
80
80
|
|
@@ -94,14 +94,14 @@ describe FoodCritic::Linter do
|
|
94
94
|
expected_rules = [*default_rule_files, *gem_rules]
|
95
95
|
expect(FoodCritic::RuleDsl).to receive(:load).with(expected_rules, nil)
|
96
96
|
expect(linter).to receive(:rule_files_in_gems).and_return(gem_rules)
|
97
|
-
linter.load_rules!(:
|
97
|
+
linter.load_rules!(search_gems: true)
|
98
98
|
end
|
99
99
|
|
100
100
|
it "should include files found in :include_rules option" do
|
101
101
|
include_rules = ["/path/to/rules1.rb", "/path/to/rules2.rb"]
|
102
102
|
expected_rules = [*default_rule_files, *include_rules]
|
103
103
|
expect(FoodCritic::RuleDsl).to receive(:load).with(expected_rules, nil)
|
104
|
-
linter.load_rules!(:
|
104
|
+
linter.load_rules!(include_rules: include_rules)
|
105
105
|
end
|
106
106
|
end
|
107
107
|
end
|
data/spec/unit/template_spec.rb
CHANGED
@@ -16,8 +16,8 @@ describe FoodCritic::Template::ExpressionExtractor do
|
|
16
16
|
<% if true %>
|
17
17
|
Hello World!
|
18
18
|
<% end %>
|
19
|
-
})).to eq [{ :
|
20
|
-
{ :
|
19
|
+
})).to eq [{ type: :statement, code: "if true", line: 2 },
|
20
|
+
{ type: :statement, code: "end", line: 4 }]
|
21
21
|
end
|
22
22
|
it "does not evaluate erb statements" do
|
23
23
|
extractor.extract(%q{
|
@@ -27,7 +27,7 @@ describe FoodCritic::Template::ExpressionExtractor do
|
|
27
27
|
it "extracts an expression from within the template" do
|
28
28
|
expect(extractor.extract(%q{
|
29
29
|
<%= foo %>
|
30
|
-
})).to eq [{ :
|
30
|
+
})).to eq [{ type: :expression, code: "foo", line: 2 }]
|
31
31
|
end
|
32
32
|
it "does not evaluate erb expressions" do
|
33
33
|
extractor.extract(%q{
|
@@ -41,8 +41,8 @@ describe FoodCritic::Template::ExpressionExtractor do
|
|
41
41
|
URIEncoding="UTF-8"
|
42
42
|
redirectPort="<%= node["tomcat"]["ssl_port"] %>" />
|
43
43
|
})).to eq [
|
44
|
-
{ :
|
45
|
-
{ :
|
44
|
+
{ type: :expression, code: 'node["tomcat"]["port"]', line: 2 },
|
45
|
+
{ type: :expression, code: 'node["tomcat"]["ssl_port"]', line: 5 },
|
46
46
|
]
|
47
47
|
end
|
48
48
|
it "excludes comment-only expressions" do
|
metadata
CHANGED
@@ -1,14 +1,14 @@
|
|
1
1
|
--- !ruby/object:Gem::Specification
|
2
2
|
name: foodcritic
|
3
3
|
version: !ruby/object:Gem::Version
|
4
|
-
version:
|
4
|
+
version: 15.0.0
|
5
5
|
platform: ruby
|
6
6
|
authors:
|
7
7
|
- Andrew Crump
|
8
8
|
autorequire:
|
9
9
|
bindir: bin
|
10
10
|
cert_chain: []
|
11
|
-
date: 2018-
|
11
|
+
date: 2018-12-03 00:00:00.000000000 Z
|
12
12
|
dependencies:
|
13
13
|
- !ruby/object:Gem::Dependency
|
14
14
|
name: cucumber-core
|
@@ -169,18 +169,12 @@ executables:
|
|
169
169
|
extensions: []
|
170
170
|
extra_rdoc_files: []
|
171
171
|
files:
|
172
|
-
- CHANGELOG.md
|
173
172
|
- Gemfile
|
174
173
|
- LICENSE
|
175
|
-
- README.md
|
176
174
|
- Rakefile
|
177
175
|
- bin/foodcritic
|
178
|
-
- chef_dsl_metadata/chef_13.
|
179
|
-
- chef_dsl_metadata/chef_14.
|
180
|
-
- chef_dsl_metadata/chef_14.2.0.json
|
181
|
-
- chef_dsl_metadata/chef_14.3.37.json
|
182
|
-
- chef_dsl_metadata/chef_14.4.56.json
|
183
|
-
- chef_dsl_metadata/chef_14.5.33.json
|
176
|
+
- chef_dsl_metadata/chef_13.12.3.json
|
177
|
+
- chef_dsl_metadata/chef_14.7.17.json
|
184
178
|
- features/002_check_string_interpolation.feature
|
185
179
|
- features/005_check_for_resource_repetition.feature
|
186
180
|
- features/006_check_file_mode.feature
|
@@ -555,8 +549,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
|
|
555
549
|
version: '0'
|
556
550
|
requirements: []
|
557
551
|
rubyforge_project:
|
558
|
-
rubygems_version: 2.7.
|
552
|
+
rubygems_version: 2.7.8
|
559
553
|
signing_key:
|
560
554
|
specification_version: 4
|
561
|
-
summary: foodcritic-
|
555
|
+
summary: foodcritic-15.0.0
|
562
556
|
test_files: []
|
data/CHANGELOG.md
DELETED
@@ -1,780 +0,0 @@
|
|
1
|
-
# Foodcritic Changelog:
|
2
|
-
|
3
|
-
## [14.3.0](https://github.com/Foodcritic/foodcritic/tree/v14.3.0) (2018-10-23)
|
4
|
-
|
5
|
-
- Added Chef 13.11.3 metadata
|
6
|
-
- Removed Chef 13.5, 13.6, 13.7 and 13.9 metadata
|
7
|
-
- Disabled FC121 for now. This rule was causing a lot of confusion and resulting in authors dropping support for Chef 13 prematurely. This rule we get enabled again when Chef 13 goes EOL this coming April
|
8
|
-
|
9
|
-
## [14.2.0](https://github.com/Foodcritic/foodcritic/tree/v14.2.0) (2018-09-30)
|
10
|
-
|
11
|
-
- Add Chef 14.5 metadata with 14.4 being the new default
|
12
|
-
- Removed Chef 13.4 metadata
|
13
|
-
- Pin cucumber-core to prevent pulling in new breaking changes
|
14
|
-
|
15
|
-
## [14.1.0](https://github.com/Foodcritic/foodcritic/tree/v14.1.0) (2018-08-30)
|
16
|
-
|
17
|
-
- Add Chef 14.3 and 14.4 metadata with 14.4 being the new default
|
18
|
-
|
19
|
-
## [14.0.0](https://github.com/Foodcritic/foodcritic/tree/v14.0.0) (2018-06-28)
|
20
|
-
|
21
|
-
- Removed Chef 13.0, 13.1, and 13.3 metadata.
|
22
|
-
- Added Chef 13.9, 14.1, and 14.2 metadata and made 14.2 the new default, which adds property checking for all new Chef 14 resources to Foodcritic.
|
23
|
-
- Renamed FC048 from "Prefer Mixlib::ShellOut" to "Prefer shell_out helper method to shelling out with Ruby" since Chef includes a helpful shell_out helper that is the preferred way to shell out in resources or libraries.
|
24
|
-
- Removed FC012, which looked for legacy README.rdoc files. These haven't existed since the very early days of Chef and our existing check for README.MD files will catch any cookbooks still missing the proper format.
|
25
|
-
- Added the opensource tag to FC071: Missing LICENSE file. This lets you easily skip this by excluding any rules tagged with opensource.
|
26
|
-
- Added a new rule FC121: Cookbook depends on cookbook made obsolete by Chef 14\. This rule detects cookbook which depend on build-essential, dmg, chef_handler, chef_hostname, mac_os_x, swap, or sysctl cookbooks. The resources from these cookbooks now ship in Chef 14 and depending on the cookbooks is no longer necessary. Note removing these dependencies does increase the minimum required chef-client for
|
27
|
-
- The non-existent resource UnresolvedSubscribes has been removed from the metadata files slimming Foodcritic's install size by 1500 lines.
|
28
|
-
- Updated the list of SPDX licenses in FC069 and FC078 to the current list.
|
29
|
-
|
30
|
-
## [13.1.1](https://github.com/Foodcritic/foodcritic/tree/v13.1.1) (2018-04-12)
|
31
|
-
|
32
|
-
- Fixed an error in the detection of attributes.rb files when using root alias functionality
|
33
|
-
- Updated rules that used the 'deprecation' tag to instead use the 'deprecated' tag. All rules for deprecated functionality now have the same catch all tag.
|
34
|
-
|
35
|
-
## [13.1.0](https://github.com/Foodcritic/foodcritic/tree/v13.1.0) (2018-04-12)
|
36
|
-
|
37
|
-
### Speed improvements
|
38
|
-
|
39
|
-
Foodcritic now caches some of the information on cookbooks it previously calculated repeatedly. This results in a 10X reduction in some disk reads and a 7% improvement in runtime overall.
|
40
|
-
|
41
|
-
### Rule file improvements
|
42
|
-
|
43
|
-
The fetching and parsing of Foodcritic rule files (.foodcritic files) has been improved. If a non-existent file is specified on the CLI we will now fail instead of silently continuing. Additionally, if the .foodcritic file exists, but cannot be read/parsed we will also fail instead of silently continuing.
|
44
|
-
|
45
|
-
### Improved file detection
|
46
|
-
|
47
|
-
Several deficiencies in how Foodcritic detected files within a cookbook have been resolved. If you use the Chef 13+ root alias files such as attributes.rb or recipe.rb these will now be detected. Additionally we will detect template files not in the default directory, or deeply nested in directories within the templates directory.
|
48
|
-
|
49
|
-
### New Rules
|
50
|
-
|
51
|
-
- `FC116` - Cookbook depends on the deprecated compat_resource cookbook
|
52
|
-
- `FC120` - Do not set the name property directly on a resource
|
53
|
-
- `FC122` - Use the build_essential resource instead of the recipe
|
54
|
-
|
55
|
-
## [13.0.1](https://github.com/Foodcritic/foodcritic/tree/v13.0.1) (2018-04-11)
|
56
|
-
|
57
|
-
- Properly discover templates not in templates/default/. Templates in the root of the templates directory would be skipped previously
|
58
|
-
- Force encoding to UTF8 to prevent errors when encoding isn't set on the host
|
59
|
-
- Alert with the filename when an improperly encoded file is encountered instead of silently failing
|
60
|
-
- Removed the chef13 tag from FC085
|
61
|
-
|
62
|
-
## [13.0.0](https://github.com/Foodcritic/foodcritic/tree/v13.0.0) (2018-03-07)
|
63
|
-
|
64
|
-
### Chef 12 Support
|
65
|
-
|
66
|
-
As Chef 12 goes end of life next month this release makes several changes assuming Chef 13+:
|
67
|
-
|
68
|
-
Support for Ruby 2.2 has been removed
|
69
|
-
|
70
|
-
Chef 12 metadata files have been removed.
|
71
|
-
|
72
|
-
A new rule FC113: Resource declares deprecated use_inline_resources, which suggests a coding standard that requires Chef 13+. This rule is being introduced as use_inline_resources will begin throwing deprecation warnings in later Chef 14 releases and will eventually be removed from Chef.
|
73
|
-
|
74
|
-
Removed FC017: LWRP does not notify when updated. This is no longer applicable with Chef 13+ since inline resources are always used and notifications in resources happen automatically.
|
75
|
-
|
76
|
-
If full Chef 12 support is necessary then Foodcritic 12.2.2 is probably the best release to stick with. Keep in mind that later Foodcritic releases include rules that aid in Chef upgrades so sticking with an older release is not advised. Instead you should disable individual rules or tags that don't apply to your organization.
|
77
|
-
|
78
|
-
### New/Removed Rules
|
79
|
-
|
80
|
-
- Added FC113: Resource declares deprecated use_inline_resources.
|
81
|
-
- Added FC115: Custom resource contains a name_property that is required
|
82
|
-
- Added FC117: Do not use kind_of in custom resource properties
|
83
|
-
- Added FC118: Resource property setting name_attribute vs. name_property
|
84
|
-
- Added FC119: windows_task :change action no longer exists in Chef 13
|
85
|
-
- Removed FC017: LWRP does not notify when updated.
|
86
|
-
|
87
|
-
### Other Changes
|
88
|
-
|
89
|
-
- Updated the notification_action API to detect actions that aren't symbols
|
90
|
-
- Expand FC037 to detect notifying with actions as strings
|
91
|
-
- Incompatibilities with Ruby 2.5 and FC025/FC026 have been resolved
|
92
|
-
- Added Chef 13.7.16 metadata
|
93
|
-
- The chef12 tag has been removed from FC064/FC065 has issue_url and source_url metadata aren't actually required by chef 12\. This makes it seem as though users need to add this metadata to migrate to Chef 12, which isn't the case.
|
94
|
-
|
95
|
-
## [12.3.0](https://github.com/Foodcritic/foodcritic/tree/v12.3.0) (2018-01-18)
|
96
|
-
|
97
|
-
**Implemented enhancements:**
|
98
|
-
|
99
|
-
- Removed FC017, FC057, and FC059 as use_inline_resources is the default in Chef 13 and no longer required
|
100
|
-
- Added FC110: Script resources should use 'code' property not 'command' property
|
101
|
-
- Added FC111: search using deprecated sort flag
|
102
|
-
- Added FC112 Resource using deprecated dsl_name method
|
103
|
-
- Added FC113 Resource declares deprecated use_inline_resources
|
104
|
-
- Added FC114 Cookbook uses legacy Ohai config syntax
|
105
|
-
- Extended the find_resources method to allow accepting an array of resource names not just a single resource name
|
106
|
-
|
107
|
-
## [12.2.2](https://github.com/Foodcritic/foodcritic/tree/v12.2.2) (2017-12-13)
|
108
|
-
|
109
|
-
**Fixed bugs:**
|
110
|
-
|
111
|
-
- Don't require a space before the # in an ignore comment.
|
112
|
-
- FC009 should not alert on a raise in a resource
|
113
|
-
- Catch systemd service starts in FC004 and resolve several false positives
|
114
|
-
|
115
|
-
## [12.2.1](https://github.com/Foodcritic/foodcritic/tree/v12.2.1) (2017-11-14)
|
116
|
-
|
117
|
-
**Fixed bugs:**
|
118
|
-
|
119
|
-
- Fixed FC104 alerting for any resource with a :create action instead of just ruby_block resources
|
120
|
-
|
121
|
-
## [12.2.0](https://github.com/Foodcritic/foodcritic/tree/v12.2.0) (2017-11-14)
|
122
|
-
|
123
|
-
**Implemented enhancements:**
|
124
|
-
|
125
|
-
- Added Chef 13.6 resource metadata
|
126
|
-
- Added FC103: Deprecated :uninstall action in chocolatey_package used
|
127
|
-
- Added FC104: Use the :run action in ruby_block instead of :create
|
128
|
-
- Added FC105: Deprecated erl_call resource used
|
129
|
-
- Added FC106: Use the plist_hash property in launchd instead of hash
|
130
|
-
- Added FC107: Resource uses epic_fail instead of ignore_failure
|
131
|
-
- Added FC108: Resource should not define a property named 'name'
|
132
|
-
- Added FC109: Use platform-specific package resources instead of provider property
|
133
|
-
- Updated FC085 to also alert on @new_resource.updated_by_last_action
|
134
|
-
- Refactored multiple rules to simplify which files they trigger on
|
135
|
-
|
136
|
-
**Fixed bugs:**
|
137
|
-
|
138
|
-
- Updated FC086 to only alert if someone is using DataBagItem/EncryptedDataBagItem to load a data bag
|
139
|
-
|
140
|
-
## [12.1.0](https://github.com/Foodcritic/foodcritic/tree/v12.1.0) (2017-10-31)
|
141
|
-
|
142
|
-
**Implemented enhancements:**
|
143
|
-
|
144
|
-
- Updated FC094 and FC095 tags from chef15 -> chef14 as the deprecation timeline has been changed
|
145
|
-
- Updated FC087 to check for all deprecated Chef::Platform methods
|
146
|
-
- Added FC101: Cookbook uses the deprecated deploy resource
|
147
|
-
- Added FC102: Cookbook uses the deprecated Chef::DSL::Recipe::FullDSL class
|
148
|
-
|
149
|
-
## [12.0.1](https://github.com/Foodcritic/foodcritic/tree/v12.0.1) (2017-10-19)
|
150
|
-
|
151
|
-
**Fixed bugs:**
|
152
|
-
|
153
|
-
- Fixed the tags for new rules to correctly specify the version of Chef where the breaking change will occur, not the version of Chef were the deprecation warning was introduced
|
154
|
-
|
155
|
-
## [12.0.0](https://github.com/Foodcritic/foodcritic/tree/v12.0.0) (2017-10-18)
|
156
|
-
|
157
|
-
**Implemented enhancements:**
|
158
|
-
|
159
|
-
- Added FC093 - Generated README text needs updating
|
160
|
-
- Added FC094 - Deprecated filesystem2 ohai plugin data used
|
161
|
-
- Added FC095 - Deprecated cloud_v2 ohai plugin data used
|
162
|
-
- Added FC096 - Deprecated libvirt virtualization ohai data used
|
163
|
-
- Added FC097 - Deprecated Chef::Mixin::LanguageIncludeAttribute class used
|
164
|
-
- Added FC098 - Deprecated Chef::Mixin::RecipeDefinitionDSLCore class used
|
165
|
-
- Added FC099 - Deprecated Chef::Mixin::LanguageIncludeRecipe class used
|
166
|
-
- Added FC100 - Deprecated Chef::Mixin::Language class used
|
167
|
-
- Removed metadata for Chef versions 12.10, 12.11, 12.13, 12.14
|
168
|
-
- Added metadata for Chef 12.21 and 13.5
|
169
|
-
|
170
|
-
## [11.4.0](https://github.com/Foodcritic/foodcritic/tree/v11.4.0) (2017-09-13)
|
171
|
-
|
172
|
-
**Implemented enhancements:**
|
173
|
-
|
174
|
-
- Added metadata for Chef 13.3.42 and 13.4.19 to include the latest new resources shipped in chef-client
|
175
|
-
|
176
|
-
## [11.3.1](https://github.com/Foodcritic/foodcritic/tree/v11.3.1) (2017-08-17)
|
177
|
-
|
178
|
-
**Fixed bugs:**
|
179
|
-
|
180
|
-
- Allow EncryptedDataBagItem.load_secret in FC086
|
181
|
-
|
182
|
-
## [11.3.0](https://github.com/Foodcritic/foodcritic/tree/v11.3.0) (2017-07-12)
|
183
|
-
|
184
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v11.2.0...v11.3.0)
|
185
|
-
|
186
|
-
**Implemented enhancements:**
|
187
|
-
|
188
|
-
- The yajl-ruby dependency has been replaced with ffi-yajl which is used by Chef and is already present in ChefDK. A single usage of Ruby's JSON parser has also been replaced with ffi-yajl as well.
|
189
|
-
- FC033 logic has been slightly simplified.
|
190
|
-
|
191
|
-
**Fixed bugs:**
|
192
|
-
|
193
|
-
- FC001 will no longer alert when a user references the run_state, which is correctly accessed as a symbol and not a string.
|
194
|
-
|
195
|
-
## [11.2.0](https://github.com/Foodcritic/foodcritic/tree/v11.2.0) (2017-06-12)
|
196
|
-
|
197
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v11.1.0...v11.2.0)
|
198
|
-
|
199
|
-
**Implemented enhancements:**
|
200
|
-
|
201
|
-
- Added metadata for Chef 13.1 and made this the default. This means that FC009 will now alert on cookbooks using code that has been removed in Chef 13.
|
202
|
-
- Added FC091: Use property not attribute in custom resources.
|
203
|
-
- Added FC092: Custom resources should not define actions.
|
204
|
-
- Removed metadata for Chef 12.6, 12.7, and 12.8\. This only impacts users specifically setting these metadata versions via the command line.
|
205
|
-
- Disabled the `opensource` tag by default to simply use of Foodcritic for non-community cookbook developers. At the time of writing this only includes `FC078`. To enable it again: `foodcritic -t any .`
|
206
|
-
- Added a Dockerfile for running Foodcritic in Docker.
|
207
|
-
|
208
|
-
## [11.1.0](https://github.com/Foodcritic/foodcritic/tree/v11.1.0) (2017-05-18)
|
209
|
-
|
210
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v11.0.0...v11.1.0)
|
211
|
-
|
212
|
-
**Implemented enhancements:**
|
213
|
-
|
214
|
-
- Added `FC086` - Use databag helper methods to load data bag items. Tags: style
|
215
|
-
- Added `FC087` - Library maps provider with deprecated Chef::Platform.set. Tags: chef13 deprecated
|
216
|
-
- Added `FC088` - Prefer Mixlib::Shellout over deprecated Chef::Mixin::Command. Tags: chef13 deprecated
|
217
|
-
- Added `FC089` - Prefer Mixlib::Shellout over deprecated Chef::ShellOut. Tags: chef13 deprecated
|
218
|
-
- Added a new `--rule-file` flag to specify the path to your .foodcritic file
|
219
|
-
- Added metadata for Chef 12.20.3 and made it the default
|
220
|
-
- Updated several rule names to be more clear that we're checking for deprecated functionality
|
221
|
-
|
222
|
-
## [11.0.0](https://github.com/Foodcritic/foodcritic/tree/v11.0.0) (2017-04-24)
|
223
|
-
|
224
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.4.1...v11.0.0)
|
225
|
-
|
226
|
-
**Implemented enhancements:**
|
227
|
-
|
228
|
-
- Added `FC079` to detect the usage of the easy_install_package resource which is deprecated in Chef 13\. Tags: deprecated, chef13.
|
229
|
-
- Added `FC080` to detect user resources that include the supports property, which is deprecated in Chef 13\. Tags: deprecated, chef13.
|
230
|
-
- Added `FC081` to detect a cookbook that depends on the partial_search cookbook as partial search functionality is built into Chef 12 and later. Tags: chef12.
|
231
|
-
- Added `FC082` to detect the usage of node.set and node.set_unless which will be removed in Chef 14\. Tags: deprecated, chef14.
|
232
|
-
- Added `FC083` to detect execute resources that include the path property, which is deprecated in Chef 12\. Tags: deprecated, chef12.
|
233
|
-
- Added `FC084` to detect usage of the deprecated Chef::REST class. Tags: deprecated, chef13.
|
234
|
-
- Added `FC085` to detect usage of new_resource.updated_by_last_action to converge resources. Tags: deprecated, chef13.
|
235
|
-
- Updated and refactored API methods `declared_dependencies`, `supported_platforms`, and `word_list_values`
|
236
|
-
- Deprecated API methods `checks_for_chef_solo` and `chef_solo_search_supported?` have been removed.
|
237
|
-
- Added a new API method `json_file_to_hash` for loading json files as a hash.
|
238
|
-
- Added a new rake command to run the regression test on just a single cookbook
|
239
|
-
|
240
|
-
**Fixed bugs:**
|
241
|
-
|
242
|
-
- Multiple rules have been rewritten to use Foodcritic APIs instead of using XPATH queries directly. This avoids false positives created by overly simplistic queries.
|
243
|
-
- Fixed FC069 to skip if the license metadata is any formatting of 'All Rights Reserved'.
|
244
|
-
- Added the `license` and `supermarket` tag to FC078.
|
245
|
-
- Updated the `field` and `field_value` API methods to correctly recognize additional formats of data in the metdata.
|
246
|
-
|
247
|
-
## [10.4.1](https://github.com/Foodcritic/foodcritic/tree/v10.4.1) (2017-04-17)
|
248
|
-
|
249
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.4.0...v10.4.1)
|
250
|
-
|
251
|
-
**Implemented enhancements:**
|
252
|
-
|
253
|
-
- Removed the development dependency on github_changelog_generator
|
254
|
-
|
255
|
-
**Fixed bugs:**
|
256
|
-
|
257
|
-
- Fixed running cucumber tests using the cucumber CLI command
|
258
|
-
- Fixed FC016 incorrectly firing on custom resources that have no properties. FC016 will now skip over resources that have any actions as those are custom resources and custom resources don't need to declare a default_action.
|
259
|
-
- Added the missing chef13 tag to FC018
|
260
|
-
- Updated FC028 to detect both `node.platform_family?` in addition to the existing `node.platform?` usage. This rule has also been renamed and tags updated since the use of `node.platform?` is a style issue and not a correctness issue. Both `node.platform?` and `platform?` are acceptable in cookbooks.
|
261
|
-
- Fixed FC071 to not alert for cookbooks where the license is 'all rights reserved' in addition to the existing allowed 'All Rights Reserved' string
|
262
|
-
- Fixed FC071 to detect the LICENSE file if foodcritic is not running in the root of the cookbook
|
263
|
-
- Fixed FC070 to not alert when platform supports is defined through an array of platforms
|
264
|
-
|
265
|
-
## [10.4.0](https://github.com/Foodcritic/foodcritic/tree/v10.4.0) (2017-04-13)
|
266
|
-
|
267
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.3.1...v10.4.0)
|
268
|
-
|
269
|
-
**Implemented enhancements:**
|
270
|
-
|
271
|
-
- Added FC076 to alert when the deprecated `conflicts` metadata is used
|
272
|
-
- Added FC077 to alert when the deprecated `replaces` metadata is used
|
273
|
-
- Added FC078 to alert when a non-OSI-approved license is used in metadata. You can disable this rule turning off the new `opensource` tag. For example: `foodcritic -t ~opensource .`
|
274
|
-
|
275
|
-
**Fixed bugs:**
|
276
|
-
|
277
|
-
- Regression tests now ignore .foodcritic files so we see all possible failures
|
278
|
-
- FC053 / FC052 updated to properly refer the metadata as deprecated and not unimplemented
|
279
|
-
- FC071 no longer alerts when cookbooks are licensed as "All Rights Reserved"
|
280
|
-
|
281
|
-
## [10.3.1](https://github.com/Foodcritic/foodcritic/tree/v10.3.1) (2017-04-10)
|
282
|
-
|
283
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.3.0...v10.3.1)
|
284
|
-
|
285
|
-
**Implemented enhancements:**
|
286
|
-
|
287
|
-
- Added Chef 13.0.113 metadata, but retained 12.19.36 as the default
|
288
|
-
|
289
|
-
**Fixed bugs:**
|
290
|
-
|
291
|
-
- Resolved a regression when running Foodcritic as a Rake task
|
292
|
-
|
293
|
-
## [10.3.0](https://github.com/Foodcritic/foodcritic/tree/v10.3.0) (2017-04-10)
|
294
|
-
|
295
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.2.2...v10.3.0)
|
296
|
-
|
297
|
-
**Implemented enhancements:**
|
298
|
-
|
299
|
-
- Added `FC069` to ensure standardized licenses are defined in metadata
|
300
|
-
- Added `FC070` to detect invalid platform supports in metadata
|
301
|
-
- Added `FC071` to ensure a LICENSE file is included with the cookbook
|
302
|
-
- Added `FC072` to detect attributes defined in metadata
|
303
|
-
- Added `FC073` to detect root alias collisions with non-root alias files
|
304
|
-
- Added `FC074` to detect setting the default_action in a LWRP without using the default_action DSL
|
305
|
-
- Added `FC075` to detect node.save usage
|
306
|
-
- Updated `FC008` to fail if the ChefDK generated boilerplate is included
|
307
|
-
- Updated `FC024` to not recommend adding amazon as an equivalent platform to Redhat as Amazon is its own platform family in Chef 13
|
308
|
-
- Updated `FC045` to no longer fail if metadata.rb cannot be found
|
309
|
-
- Added support for the Chef 13 root alias cookbook structure changes defined in <https://github.com/chef/chef-rfc/blob/master/rfc033-root-aliases.md>
|
310
|
-
- Testing has been completed reworked to simplify testing and allow for far more robust functional tests. Minitest unit tests have been converted to rspec and a new functional testing framework has been added utilizing rspec. Tests for a large number of the existing rules have been converted to this new framework. The new testing framework allows for simple all-in-one tests that are easier to read and much simpler to write. Additionally the regression tests have been reworked, and are now enabled in Travis CI, which will require regeneration of the expected output if new tests are added using `rake regen_regression`. See the readme for additional details on running tests.
|
311
|
-
|
312
|
-
## [10.2.2](https://github.com/Foodcritic/foodcritic/tree/v10.2.2) (2017-03-31)
|
313
|
-
|
314
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.2.1...v10.2.2)
|
315
|
-
|
316
|
-
**Implemented enhancements:**
|
317
|
-
|
318
|
-
- Align rake setup better with CLI options to resolve bugs with tags in Rake [#533](https://github.com/Foodcritic/foodcritic/pull/533) ([tas50](https://github.com/tas50))
|
319
|
-
|
320
|
-
## [v10.2.1](https://github.com/Foodcritic/foodcritic/tree/v10.2.1) (2017-03-31)
|
321
|
-
|
322
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.2.0...v10.2.1)
|
323
|
-
|
324
|
-
**Implemented enhancements:**
|
325
|
-
|
326
|
-
- Add supermarket tag to FC067 and FC068 [#532](https://github.com/Foodcritic/foodcritic/pull/532) ([tas50](https://github.com/tas50))
|
327
|
-
|
328
|
-
## [v10.2.0](https://github.com/Foodcritic/foodcritic/tree/v10.2.0) (2017-03-30)
|
329
|
-
|
330
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.1.1...v10.2.0)
|
331
|
-
|
332
|
-
**Implemented enhancements:**
|
333
|
-
|
334
|
-
- Add FC066/FC067/FC068 to check metadata chef_version, license, and supports [#528](https://github.com/Foodcritic/foodcritic/pull/528) ([tas50](https://github.com/tas50))
|
335
|
-
|
336
|
-
**Fixed bugs:**
|
337
|
-
|
338
|
-
- Don't trigger FC007 on a shorthand recipe includes [#526](https://github.com/Foodcritic/foodcritic/pull/526) ([tas50](https://github.com/tas50))
|
339
|
-
- Fix already initialized constant warning with `--search-gems` [#529](https://github.com/Foodcritic/foodcritic/pull/529) ([nvwls](https://github.com/nvwls))
|
340
|
-
|
341
|
-
## [v10.1.1](https://github.com/Foodcritic/foodcritic/tree/v10.1.1) (2017-03-29)
|
342
|
-
|
343
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.1.0...v10.1.1)
|
344
|
-
|
345
|
-
**Fixed bugs:**
|
346
|
-
|
347
|
-
- Fix FC016 triggering on custom resources [#525](https://github.com/Foodcritic/foodcritic/pull/525) ([tas50](https://github.com/tas50))
|
348
|
-
|
349
|
-
## [v10.1.0](https://github.com/Foodcritic/foodcritic/tree/v10.1.0) (2017-03-29)
|
350
|
-
|
351
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v10.0.0...v10.1.0)
|
352
|
-
|
353
|
-
**Implemented enhancements:**
|
354
|
-
|
355
|
-
- Remove FC023 which is no longer considered best practice [#523](https://github.com/Foodcritic/foodcritic/pull/523) ([tas50](https://github.com/tas50))
|
356
|
-
- Add basic testing of the metadata_field api [#522](https://github.com/Foodcritic/foodcritic/pull/522) ([tas50](https://github.com/tas50))
|
357
|
-
- Add a more robust cookbook_base_path helper to the API [#520](https://github.com/Foodcritic/foodcritic/pull/520) ([tas50](https://github.com/tas50))
|
358
|
-
- Update various tags to better align the rules with the tag categories [#517](https://github.com/Foodcritic/foodcritic/pull/517) ([tas50](https://github.com/tas50))
|
359
|
-
|
360
|
-
## [v10.0.0](https://github.com/Foodcritic/foodcritic/tree/v10.0.0) (2017-03-14)
|
361
|
-
|
362
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v9.0.0...v10.0.0)
|
363
|
-
|
364
|
-
**Implemented enhancements:**
|
365
|
-
|
366
|
-
- Add 12.19 metadata as default and remove 12.0 - 12.5.1 [#516](https://github.com/Foodcritic/foodcritic/pull/516) ([tas50](https://github.com/tas50))
|
367
|
-
- Remove FC003 from Foodcritic [#512](https://github.com/Foodcritic/foodcritic/pull/512) ([tas50](https://github.com/tas50))
|
368
|
-
|
369
|
-
## [v9.0.0](https://github.com/Foodcritic/foodcritic/tree/v9.0.0) (2017-01-31)
|
370
|
-
|
371
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v8.2.0...v9.0.0)
|
372
|
-
|
373
|
-
**Implemented enhancements:**
|
374
|
-
|
375
|
-
- Add 12.18.31 metadata and make it the default [#508](https://github.com/Foodcritic/foodcritic/pull/508) ([tas50](https://github.com/tas50))
|
376
|
-
- Test on Ruby 2.4 and fix failing tests [#507](https://github.com/Foodcritic/foodcritic/pull/507) ([tas50](https://github.com/tas50))
|
377
|
-
- Support Chef RFC 17 compliant templates [#485](https://github.com/Foodcritic/foodcritic/pull/485) ([hagihala](https://github.com/hagihala))
|
378
|
-
- More sane default CLI values [#462](https://github.com/Foodcritic/foodcritic/pull/462) ([tas50](https://github.com/tas50))
|
379
|
-
|
380
|
-
## [v8.2.0](https://github.com/Foodcritic/foodcritic/tree/v8.2.0) (2017-01-09)
|
381
|
-
|
382
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v8.1.0...v8.2.0)
|
383
|
-
|
384
|
-
**Implemented enhancements:**
|
385
|
-
|
386
|
-
- Add 12.17.44 metadata (and make it the default) [#505](https://github.com/Foodcritic/foodcritic/pull/505) ([tas50](https://github.com/tas50))
|
387
|
-
- Add 12.16.42 metadata and make it the default [#497](https://github.com/Foodcritic/foodcritic/pull/497) ([tas50](https://github.com/tas50))
|
388
|
-
|
389
|
-
## [v8.1.0](https://github.com/Foodcritic/foodcritic/tree/v8.1.0) (2016-10-20)
|
390
|
-
|
391
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v8.0.0...v8.1.0)
|
392
|
-
|
393
|
-
**Implemented enhancements:**
|
394
|
-
|
395
|
-
- Add Chef client 12.15.19 metadata [#493](https://github.com/Foodcritic/foodcritic/pull/493) ([tas50](https://github.com/tas50))
|
396
|
-
- Clarify exclude path instructions in the CLI help [#489](https://github.com/Foodcritic/foodcritic/pull/489) ([unixorn](https://github.com/unixorn))
|
397
|
-
|
398
|
-
## [v8.0.0](https://github.com/Foodcritic/foodcritic/tree/v8.0.0) (2016-09-23)
|
399
|
-
|
400
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v7.1.0...v8.0.0)
|
401
|
-
|
402
|
-
**Implemented enhancements:**
|
403
|
-
|
404
|
-
- Require Ruby 2.2.2 [#487](https://github.com/Foodcritic/foodcritic/pull/487) ([tas50](https://github.com/tas50))
|
405
|
-
- Add 12.14.89 metadata and make it the default [#486](https://github.com/Foodcritic/foodcritic/pull/486) ([tas50](https://github.com/tas50))
|
406
|
-
- Remove Chef 11 metadata and rule support [#481](https://github.com/Foodcritic/foodcritic/pull/481) ([tas50](https://github.com/tas50))
|
407
|
-
|
408
|
-
## [v7.1.0](https://github.com/Foodcritic/foodcritic/tree/v7.1.0) (2016-08-17)
|
409
|
-
|
410
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v7.0.1...v7.1.0)
|
411
|
-
|
412
|
-
**Implemented enhancements:**
|
413
|
-
|
414
|
-
- Add Chef 12.13.37 metadata and make it the default [#479](https://github.com/Foodcritic/foodcritic/pull/479) ([tas50](https://github.com/tas50))
|
415
|
-
- Add 12.12.13 metadata and fix metadata generation [#472](https://github.com/Foodcritic/foodcritic/pull/472) ([tas50](https://github.com/tas50))
|
416
|
-
|
417
|
-
**Fixed bugs:**
|
418
|
-
|
419
|
-
- Add missing assigment attributes [#478](https://github.com/Foodcritic/foodcritic/pull/478) ([ofir-petrushka](https://github.com/ofir-petrushka))
|
420
|
-
|
421
|
-
## [v7.0.1](https://github.com/Foodcritic/foodcritic/tree/v7.0.1) (2016-07-06)
|
422
|
-
|
423
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v7.0.0...v7.0.1)
|
424
|
-
|
425
|
-
**Implemented enhancements:**
|
426
|
-
|
427
|
-
- Readme improvements [#468](https://github.com/Foodcritic/foodcritic/pull/468) ([tas50](https://github.com/tas50))
|
428
|
-
|
429
|
-
## [v7.0.0](https://github.com/Foodcritic/foodcritic/tree/v7.0.0) (2016-07-05)
|
430
|
-
|
431
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v6.3.0...v7.0.0)
|
432
|
-
|
433
|
-
**Implemented enhancements:**
|
434
|
-
|
435
|
-
- Remove support for Ruby 2.0 [#465](https://github.com/Foodcritic/foodcritic/pull/465) ([tas50](https://github.com/tas50))
|
436
|
-
- Remove chef version support for Chef 0.7, 0.8, 0.9, and 0.10 [#464](https://github.com/Foodcritic/foodcritic/pull/464) ([tas50](https://github.com/tas50))
|
437
|
-
- Add chef 12.11.18 metadata and make it the default [#461](https://github.com/Foodcritic/foodcritic/pull/461) ([tas50](https://github.com/tas50))
|
438
|
-
- FC032 allow the new :before timing on resource notifications in Chef >= 12.6.0 [#441](https://github.com/Foodcritic/foodcritic/pull/441) ([gnjack](https://github.com/gnjack))
|
439
|
-
- New cookbook_maintainer api methods [#248](https://github.com/Foodcritic/foodcritic/pull/248) ([miguelcnf](https://github.com/miguelcnf))
|
440
|
-
|
441
|
-
## [v6.3.0](https://github.com/Foodcritic/foodcritic/tree/v6.3.0) (2016-05-16)
|
442
|
-
|
443
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v6.2.0...v6.3.0)
|
444
|
-
|
445
|
-
**Implemented enhancements:**
|
446
|
-
|
447
|
-
- Add Chef 12.10.24 metadata and release 6.3.0 [#456](https://github.com/Foodcritic/foodcritic/pull/456) ([tas50](https://github.com/tas50))
|
448
|
-
|
449
|
-
## [v6.2.0](https://github.com/Foodcritic/foodcritic/tree/v6.2.0) (2016-04-26)
|
450
|
-
|
451
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v6.1.1...v6.2.0)
|
452
|
-
|
453
|
-
**Implemented enhancements:**
|
454
|
-
|
455
|
-
- Add 12.9.38 metadata and make it the default chef version [#452](https://github.com/Foodcritic/foodcritic/pull/452) ([tas50](https://github.com/tas50))
|
456
|
-
|
457
|
-
## [v6.1.1](https://github.com/Foodcritic/foodcritic/tree/v6.1.1) (2016-04-08)
|
458
|
-
|
459
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v6.1.0...v6.1.1)
|
460
|
-
|
461
|
-
**Implemented enhancements:**
|
462
|
-
|
463
|
-
- Use latest gherkin for faster installs [#447](https://github.com/Foodcritic/foodcritic/pull/447) ([jkeiser](https://github.com/jkeiser))
|
464
|
-
|
465
|
-
## [v6.1.0](https://github.com/Foodcritic/foodcritic/tree/v6.1.0) (2016-04-06)
|
466
|
-
|
467
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v6.0.1...v6.1.0)
|
468
|
-
|
469
|
-
**Implemented enhancements:**
|
470
|
-
|
471
|
-
- Don't require cucumber and rubocop to run rake [#444](https://github.com/Foodcritic/foodcritic/pull/444) ([jkeiser](https://github.com/jkeiser))
|
472
|
-
- Add 12.8.1 metadata + update metadata process [#438](https://github.com/Foodcritic/foodcritic/pull/438) ([tas50](https://github.com/tas50))
|
473
|
-
- Add metadata for Chef 12.7.2 and update instructions [#427](https://github.com/Foodcritic/foodcritic/pull/427) ([tas50](https://github.com/tas50))
|
474
|
-
|
475
|
-
**Fixed bugs:**
|
476
|
-
|
477
|
-
- Rake.last_comment was depreciated in Rake11\. [#434](https://github.com/Foodcritic/foodcritic/pull/434) ([gkuchta](https://github.com/gkuchta))
|
478
|
-
|
479
|
-
## [v6.0.1](https://github.com/Foodcritic/foodcritic/tree/v6.0.1) (2016-02-22)
|
480
|
-
|
481
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v6.0.0...v6.0.1)
|
482
|
-
|
483
|
-
**Implemented enhancements:**
|
484
|
-
|
485
|
-
- Check for URLs that are helpful to the Supermarket [#421](https://github.com/Foodcritic/foodcritic/pull/421) ([nathenharvey](https://github.com/nathenharvey))
|
486
|
-
|
487
|
-
**Fixed bugs:**
|
488
|
-
|
489
|
-
- Fix FC058 false positives [#423](https://github.com/Foodcritic/foodcritic/pull/423) ([jaym](https://github.com/jaym))
|
490
|
-
|
491
|
-
## [v6.0.0](https://github.com/Foodcritic/foodcritic/tree/v6.0.0) (2016-01-14)
|
492
|
-
|
493
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v5.0.0...v6.0.0)
|
494
|
-
|
495
|
-
**Implemented enhancements:**
|
496
|
-
|
497
|
-
- Cookbook version is specified in metadata [#347](https://github.com/Foodcritic/foodcritic/issues/347)
|
498
|
-
- FC035 - Templates, Style [#62](https://github.com/Foodcritic/foodcritic/issues/62)
|
499
|
-
- Add Chef 12.6.0 metadata [#417](https://github.com/Foodcritic/foodcritic/pull/417) ([tas50](https://github.com/tas50))
|
500
|
-
- New Rule 61 - valid cookbook version [#405](https://github.com/Foodcritic/foodcritic/pull/405) ([lamont-granquist](https://github.com/lamont-granquist))
|
501
|
-
- Require Oracle as a RHEL equiv [#404](https://github.com/Foodcritic/foodcritic/pull/404) ([tas50](https://github.com/tas50))
|
502
|
-
- Suggest updating from definitions to custom resources [#403](https://github.com/Foodcritic/foodcritic/pull/403) ([tas50](https://github.com/tas50))
|
503
|
-
- add checks for correct use of use_inline_resources [#402](https://github.com/Foodcritic/foodcritic/pull/402) ([lamont-granquist](https://github.com/lamont-granquist))
|
504
|
-
- Add new tags for rules [#401](https://github.com/Foodcritic/foodcritic/pull/401) ([tas50](https://github.com/tas50))
|
505
|
-
- Rename FC045 since Chef 12 requires name metadata [#399](https://github.com/Foodcritic/foodcritic/pull/399) ([tas50](https://github.com/tas50))
|
506
|
-
- Add Chef 12.5.1 metadata [#397](https://github.com/Foodcritic/foodcritic/pull/397) ([tas50](https://github.com/tas50))
|
507
|
-
- Add self-dependency warning [#328](https://github.com/Foodcritic/foodcritic/pull/328) ([lamont-granquist](https://github.com/lamont-granquist))
|
508
|
-
|
509
|
-
**Fixed bugs:**
|
510
|
-
|
511
|
-
- Time to cut a release? [#344](https://github.com/Foodcritic/foodcritic/issues/344)
|
512
|
-
- FC048: Warn within a provider block, refs #365 [#413](https://github.com/Foodcritic/foodcritic/pull/413) ([acrmp](https://github.com/Foodcritic))
|
513
|
-
- use_inline_resources checks apply to Chef 11+ [#410](https://github.com/Foodcritic/foodcritic/pull/410) ([tas50](https://github.com/tas50))
|
514
|
-
- fix for edge condition with 061 [#408](https://github.com/Foodcritic/foodcritic/pull/408) ([lamont-granquist](https://github.com/lamont-granquist))
|
515
|
-
- Rake options override default options [#382](https://github.com/Foodcritic/foodcritic/pull/382) ([pkang](https://github.com/pkang))
|
516
|
-
|
517
|
-
**Closed issues:**
|
518
|
-
|
519
|
-
- Chef Docs vs Foodcritic 4.x [#354](https://github.com/Foodcritic/foodcritic/issues/354)
|
520
|
-
- Github pages have drifted from foodcritic.io [#332](https://github.com/Foodcritic/foodcritic/issues/332)
|
521
|
-
- FC001 is re-enabled thus <http://www.foodcritic.io/> is out-of-date [#330](https://github.com/Foodcritic/foodcritic/issues/330)
|
522
|
-
|
523
|
-
## [v5.0.0](https://github.com/Foodcritic/foodcritic/tree/v5.0.0) (2015-09-17)
|
524
|
-
|
525
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v4.0.0...v5.0.0)
|
526
|
-
|
527
|
-
**Implemented enhancements:**
|
528
|
-
|
529
|
-
- Support for a magic comment to temporarily disable a rule [#259](https://github.com/Foodcritic/foodcritic/issues/259)
|
530
|
-
- FC007 false positive on depending on the cookbook currently being parsed [#242](https://github.com/Foodcritic/foodcritic/issues/242)
|
531
|
-
- Create a rule for "execute resource used to install packages" [#180](https://github.com/Foodcritic/foodcritic/issues/180)
|
532
|
-
- New Rule Proposal: uid/gid should be integer [#53](https://github.com/Foodcritic/foodcritic/issues/53)
|
533
|
-
- merge default options before check instead of during intialization [#321](https://github.com/Foodcritic/foodcritic/pull/321) ([ranjib](https://github.com/ranjib))
|
534
|
-
|
535
|
-
**Fixed bugs:**
|
536
|
-
|
537
|
-
- Fix FC031 and FC045 and metadata.rb vs metadata.json issues [#369](https://github.com/Foodcritic/foodcritic/issues/369)
|
538
|
-
- FC007 false positive on depending on the cookbook currently being parsed [#242](https://github.com/Foodcritic/foodcritic/issues/242)
|
539
|
-
- FC010 Test failures due to missing search support [#199](https://github.com/Foodcritic/foodcritic/issues/199)
|
540
|
-
- 'lazy' causes false-positive in FC009 - on previous line [#189](https://github.com/Foodcritic/foodcritic/issues/189)
|
541
|
-
- FC051 tries to validate temp files of the editors [#172](https://github.com/Foodcritic/foodcritic/issues/172)
|
542
|
-
|
543
|
-
## [v4.0.0](https://github.com/Foodcritic/foodcritic/tree/v4.0.0) (2014-06-11)
|
544
|
-
|
545
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v3.0.3...v4.0.0)
|
546
|
-
|
547
|
-
## [v3.0.3](https://github.com/Foodcritic/foodcritic/tree/v3.0.3) (2013-10-13)
|
548
|
-
|
549
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v3.0.2...v3.0.3)
|
550
|
-
|
551
|
-
## [v3.0.2](https://github.com/Foodcritic/foodcritic/tree/v3.0.2) (2013-10-05)
|
552
|
-
|
553
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v3.0.1...v3.0.2)
|
554
|
-
|
555
|
-
## [v3.0.1](https://github.com/Foodcritic/foodcritic/tree/v3.0.1) (2013-09-25)
|
556
|
-
|
557
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v3.0.0...v3.0.1)
|
558
|
-
|
559
|
-
**Implemented enhancements:**
|
560
|
-
|
561
|
-
- Roles rules [#19](https://github.com/Foodcritic/foodcritic/issues/19)
|
562
|
-
|
563
|
-
## [v3.0.0](https://github.com/Foodcritic/foodcritic/tree/v3.0.0) (2013-09-14)
|
564
|
-
|
565
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v2.2.0...v3.0.0)
|
566
|
-
|
567
|
-
**Implemented enhancements:**
|
568
|
-
|
569
|
-
- Provide a comprehensive list of `tags` somewhere on the docs [#63](https://github.com/Foodcritic/foodcritic/issues/63)
|
570
|
-
|
571
|
-
**Fixed bugs:**
|
572
|
-
|
573
|
-
- FC001, FC019 shouldn't match on node.run_state [#66](https://github.com/Foodcritic/foodcritic/issues/66)
|
574
|
-
|
575
|
-
## [v2.2.0](https://github.com/Foodcritic/foodcritic/tree/v2.2.0) (2013-07-10)
|
576
|
-
|
577
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v2.1.0...v2.2.0)
|
578
|
-
|
579
|
-
## [v2.1.0](https://github.com/Foodcritic/foodcritic/tree/v2.1.0) (2013-04-16)
|
580
|
-
|
581
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v2.0.1...v2.1.0)
|
582
|
-
|
583
|
-
**Implemented enhancements:**
|
584
|
-
|
585
|
-
- New Rule Proposal: ||= considered harmful with attributes [#52](https://github.com/Foodcritic/foodcritic/issues/52)
|
586
|
-
- Would like to be able to exempt rules in cookbooks [#10](https://github.com/Foodcritic/foodcritic/issues/10)
|
587
|
-
|
588
|
-
## [v2.0.1](https://github.com/Foodcritic/foodcritic/tree/v2.0.1) (2013-03-31)
|
589
|
-
|
590
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v2.0.0...v2.0.1)
|
591
|
-
|
592
|
-
## [v2.0.0](https://github.com/Foodcritic/foodcritic/tree/v2.0.0) (2013-03-24)
|
593
|
-
|
594
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.7.0...v2.0.0)
|
595
|
-
|
596
|
-
**Implemented enhancements:**
|
597
|
-
|
598
|
-
- New Rule: Check for existence of 'name' in metadata.rb [#64](https://github.com/Foodcritic/foodcritic/issues/64)
|
599
|
-
- New Rule: action ":none" vs ":nothing" [#61](https://github.com/Foodcritic/foodcritic/issues/61)
|
600
|
-
|
601
|
-
**Fixed bugs:**
|
602
|
-
|
603
|
-
- Incorrectly decoding attributes within a block [#76](https://github.com/Foodcritic/foodcritic/issues/76)
|
604
|
-
- FC003 doesn't match unless statements [#58](https://github.com/Foodcritic/foodcritic/issues/58)
|
605
|
-
- FC019 triggered on internal recipe hash key as symbol instead of node [#54](https://github.com/Foodcritic/foodcritic/issues/54)
|
606
|
-
|
607
|
-
## [v1.7.0](https://github.com/Foodcritic/foodcritic/tree/v1.7.0) (2012-12-27)
|
608
|
-
|
609
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.6.1...v1.7.0)
|
610
|
-
|
611
|
-
**Fixed bugs:**
|
612
|
-
|
613
|
-
- FC037 false positive for subscribes [#65](https://github.com/Foodcritic/foodcritic/issues/65)
|
614
|
-
- Foodcritic not being fully deterministic. [#55](https://github.com/Foodcritic/foodcritic/issues/55)
|
615
|
-
|
616
|
-
## [v1.6.1](https://github.com/Foodcritic/foodcritic/tree/v1.6.1) (2012-08-30)
|
617
|
-
|
618
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.6.0...v1.6.1)
|
619
|
-
|
620
|
-
## [v1.6.0](https://github.com/Foodcritic/foodcritic/tree/v1.6.0) (2012-08-28)
|
621
|
-
|
622
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.5.0...v1.6.0)
|
623
|
-
|
624
|
-
**Implemented enhancements:**
|
625
|
-
|
626
|
-
- Thoughts on more style-y lint checks [#15](https://github.com/Foodcritic/foodcritic/issues/15)
|
627
|
-
|
628
|
-
**Fixed bugs:**
|
629
|
-
|
630
|
-
- FC020 triggered on non-ruby shell command [#30](https://github.com/Foodcritic/foodcritic/issues/30)
|
631
|
-
- Incorrect FC019 alarms [#22](https://github.com/Foodcritic/foodcritic/issues/22)
|
632
|
-
|
633
|
-
## [v1.5.0](https://github.com/Foodcritic/foodcritic/tree/v1.5.0) (2012-08-20)
|
634
|
-
|
635
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.5.1...v1.5.0)
|
636
|
-
|
637
|
-
## [v1.5.1](https://github.com/Foodcritic/foodcritic/tree/v1.5.1) (2012-08-20)
|
638
|
-
|
639
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.4.0...v1.5.1)
|
640
|
-
|
641
|
-
**Fixed bugs:**
|
642
|
-
|
643
|
-
- FC007 should not be triggered by include_recipe "#{cookbook_name}::blah" [#44](https://github.com/Foodcritic/foodcritic/issues/44)
|
644
|
-
- FC022 block name check appears to be too simplistic [#29](https://github.com/Foodcritic/foodcritic/issues/29)
|
645
|
-
|
646
|
-
## [v1.4.0](https://github.com/Foodcritic/foodcritic/tree/v1.4.0) (2012-06-15)
|
647
|
-
|
648
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.3.1...v1.4.0)
|
649
|
-
|
650
|
-
## [v1.3.1](https://github.com/Foodcritic/foodcritic/tree/v1.3.1) (2012-06-09)
|
651
|
-
|
652
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.3.0...v1.3.1)
|
653
|
-
|
654
|
-
**Implemented enhancements:**
|
655
|
-
|
656
|
-
- catch pry breakpoints [#36](https://github.com/Foodcritic/foodcritic/issues/36)
|
657
|
-
|
658
|
-
**Fixed bugs:**
|
659
|
-
|
660
|
-
- resource_attributes should show all of the relevant part of the AST [#31](https://github.com/Foodcritic/foodcritic/issues/31)
|
661
|
-
- FC003 is triggered, despite being handled [#26](https://github.com/Foodcritic/foodcritic/issues/26)
|
662
|
-
|
663
|
-
## [v1.3.0](https://github.com/Foodcritic/foodcritic/tree/v1.3.0) (2012-05-21)
|
664
|
-
|
665
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.2.0...v1.3.0)
|
666
|
-
|
667
|
-
## [v1.2.0](https://github.com/Foodcritic/foodcritic/tree/v1.2.0) (2012-04-21)
|
668
|
-
|
669
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.1.0...v1.2.0)
|
670
|
-
|
671
|
-
## [v1.1.0](https://github.com/Foodcritic/foodcritic/tree/v1.1.0) (2012-03-25)
|
672
|
-
|
673
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.0.1...v1.1.0)
|
674
|
-
|
675
|
-
**Fixed bugs:**
|
676
|
-
|
677
|
-
- ruby segfault / foodcritic 1.0.0 / nokogiri 1.5.2 [#18](https://github.com/Foodcritic/foodcritic/issues/18)
|
678
|
-
|
679
|
-
## [v1.0.1](https://github.com/Foodcritic/foodcritic/tree/v1.0.1) (2012-03-15)
|
680
|
-
|
681
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v1.0.0...v1.0.1)
|
682
|
-
|
683
|
-
**Implemented enhancements:**
|
684
|
-
|
685
|
-
- rules in code? [#8](https://github.com/Foodcritic/foodcritic/issues/8)
|
686
|
-
|
687
|
-
## [v1.0.0](https://github.com/Foodcritic/foodcritic/tree/v1.0.0) (2012-03-04)
|
688
|
-
|
689
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.11.1...v1.0.0)
|
690
|
-
|
691
|
-
**Implemented enhancements:**
|
692
|
-
|
693
|
-
- Foodcritic doesn't have a -v [#16](https://github.com/Foodcritic/foodcritic/issues/16)
|
694
|
-
|
695
|
-
**Fixed bugs:**
|
696
|
-
|
697
|
-
- FC003: Recognise updated chef-solo-search [#17](https://github.com/Foodcritic/foodcritic/issues/17)
|
698
|
-
- foodcritic v10 and v11 have conflicting yajl-ruby dependencies with chef [#14](https://github.com/Foodcritic/foodcritic/issues/14)
|
699
|
-
|
700
|
-
## [v0.11.1](https://github.com/Foodcritic/foodcritic/tree/v0.11.1) (2012-02-29)
|
701
|
-
|
702
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.11.0...v0.11.1)
|
703
|
-
|
704
|
-
**Implemented enhancements:**
|
705
|
-
|
706
|
-
- Want "all" arg to '-f' option. [#11](https://github.com/Foodcritic/foodcritic/issues/11)
|
707
|
-
|
708
|
-
**Fixed bugs:**
|
709
|
-
|
710
|
-
- Epic fail fail? [#13](https://github.com/Foodcritic/foodcritic/issues/13)
|
711
|
-
|
712
|
-
## [v0.11.0](https://github.com/Foodcritic/foodcritic/tree/v0.11.0) (2012-02-22)
|
713
|
-
|
714
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.10.0...v0.11.0)
|
715
|
-
|
716
|
-
**Fixed bugs:**
|
717
|
-
|
718
|
-
- Numeric value for mode should be 5 digits (CHEF-174) [#9](https://github.com/Foodcritic/foodcritic/pull/9) ([aia](https://github.com/aia))
|
719
|
-
|
720
|
-
## [v0.10.0](https://github.com/Foodcritic/foodcritic/tree/v0.10.0) (2012-02-20)
|
721
|
-
|
722
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.9.0...v0.10.0)
|
723
|
-
|
724
|
-
## [v0.9.0](https://github.com/Foodcritic/foodcritic/tree/v0.9.0) (2012-01-26)
|
725
|
-
|
726
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.8.1...v0.9.0)
|
727
|
-
|
728
|
-
## [v0.8.1](https://github.com/Foodcritic/foodcritic/tree/v0.8.1) (2012-01-20)
|
729
|
-
|
730
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.8.0...v0.8.1)
|
731
|
-
|
732
|
-
## [v0.8.0](https://github.com/Foodcritic/foodcritic/tree/v0.8.0) (2012-01-19)
|
733
|
-
|
734
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.7.0...v0.8.0)
|
735
|
-
|
736
|
-
**Fixed bugs:**
|
737
|
-
|
738
|
-
- Don't raise FC003 warning if chef-solo-search is installed [#7](https://github.com/Foodcritic/foodcritic/issues/7)
|
739
|
-
|
740
|
-
## [v0.7.0](https://github.com/Foodcritic/foodcritic/tree/v0.7.0) (2011-12-31)
|
741
|
-
|
742
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.6.0...v0.7.0)
|
743
|
-
|
744
|
-
## [v0.6.0](https://github.com/Foodcritic/foodcritic/tree/v0.6.0) (2011-12-18)
|
745
|
-
|
746
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.5.2...v0.6.0)
|
747
|
-
|
748
|
-
**Fixed bugs:**
|
749
|
-
|
750
|
-
- Bundler fails to resolve JSON version [#6](https://github.com/Foodcritic/foodcritic/issues/6)
|
751
|
-
|
752
|
-
## [v0.5.2](https://github.com/Foodcritic/foodcritic/tree/v0.5.2) (2011-12-15)
|
753
|
-
|
754
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.5.1...v0.5.2)
|
755
|
-
|
756
|
-
## [v0.5.1](https://github.com/Foodcritic/foodcritic/tree/v0.5.1) (2011-12-14)
|
757
|
-
|
758
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.5.0...v0.5.1)
|
759
|
-
|
760
|
-
## [v0.5.0](https://github.com/Foodcritic/foodcritic/tree/v0.5.0) (2011-12-13)
|
761
|
-
|
762
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.4.0...v0.5.0)
|
763
|
-
|
764
|
-
## [v0.4.0](https://github.com/Foodcritic/foodcritic/tree/v0.4.0) (2011-12-10)
|
765
|
-
|
766
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.3.0...v0.4.0)
|
767
|
-
|
768
|
-
## [v0.3.0](https://github.com/Foodcritic/foodcritic/tree/v0.3.0) (2011-12-04)
|
769
|
-
|
770
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.2.0...v0.3.0)
|
771
|
-
|
772
|
-
## [v0.2.0](https://github.com/Foodcritic/foodcritic/tree/v0.2.0) (2011-12-01)
|
773
|
-
|
774
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/v0.1.0...v0.2.0)
|
775
|
-
|
776
|
-
## [v0.1.0](https://github.com/Foodcritic/foodcritic/tree/v0.1.0) (2011-11-30)
|
777
|
-
|
778
|
-
[Full Changelog](https://github.com/Foodcritic/foodcritic/compare/4257264aa0bf93e3d13851ac0343a6b25ca3d316...v0.1.0)
|
779
|
-
|
780
|
-
- _This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)_
|