foodcritic 12.2.0 → 12.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: e0213d1fd217d9749f2715447be5c129bbc79f3b
-  data.tar.gz: c162aa6f73f436caa900fa61ffadc8cc85236df7
+  metadata.gz: 8d7566bbb8e6c6bf3c8f3410e1a2bfc884becee4
+  data.tar.gz: f0e32659516e8f0f191fe0790626b3a6e073694f
 SHA512:
-  metadata.gz: 689328b2fe137925679a6954e06068e9f850d19299fc4cfa6647fea7769609474227c1f83000aedea8677aabbf44b1dccd0aa5542de817aec81f37c925ffbfb5
-  data.tar.gz: 8c3f67dbff1a1adf6ab13bd56b4d8b89788c9aa15106c6169d531e890438a4d6441a261ac03b3e4dbac72f96344978f5c58cbec8d97702117469020fe7f5afed
+  metadata.gz: da2b94c491d43fefed96decc3e375652d478856fef5ce9a770aa935524ba6f2c98ff28a5e2324de20f2e260241be36a3cba0a7264fa465d874a008b54b4b2c0a
+  data.tar.gz: 2da6b12cba8bc43443d6ca5cd888e1d433f595eacd9aa7d1824c0b7eceb2eed010365e5d59058755d07682a37ea6c921a531065395178ebb050e8a42ee474d7a

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Foodcritic Changelog:
 
+## [12.2.1](https://github.com/Foodcritic/foodcritic/tree/v12.2.0) (2017-11-14)
+
+**Fixed bugs:**
+
+- Fixed FC104 alerting for any resource with a :create action instead of just ruby_block resources
+
 ## [12.2.0](https://github.com/Foodcritic/foodcritic/tree/v12.2.0) (2017-11-14)
 
 **Implemented enhancements:**

data/lib/foodcritic/rules/fc104.rb

@@ -4,9 +4,7 @@ rule "FC104", "Use the :run action in ruby_block instead of :create" do
     matches = []
     find_resources(ast).each do |resource|
       # if it's a ruby_block check for the :create action
-      if ast.xpath('//method_add_block[command/ident[@value="ruby_block"]]')
-        matches << resource if resource_attribute(resource, "action") == :create
-      end
+      matches << resource if resource_attribute(resource, "action") == :create && resource_type(resource) == "ruby_block"
 
       # no matter what check notification
       notifications(resource).any? do |notification|

data/lib/foodcritic/version.rb

@@ -1,4 +1,4 @@
 module FoodCritic
   # The current version of foodcritic
-  VERSION = "12.2.0"
+  VERSION = "12.2.1"
 end

data/spec/functional/fc104_spec.rb

@@ -14,7 +14,7 @@ describe "FC104" do
   end
 
   context "with a cookbook with a recipe where ruby_block specifies a run action" do
-    library_file <<-EOF
+    recipe_file <<-EOF
     ruby_block 'puts' do
       block do
         puts "test test test"
@@ -26,7 +26,7 @@ describe "FC104" do
   end
 
   context "with a cookbook with a recipe that notifies :create on a ruby_block" do
-    library_file <<-EOF
+    recipe_file <<-EOF
     file 'foo' do
       notifies :create, 'ruby_block[bar]', :delayed
     end
@@ -35,11 +35,20 @@ describe "FC104" do
   end
 
   context "with a cookbook with a recipe that notifies :run on a ruby_block" do
-    library_file <<-EOF
+    recipe_file <<-EOF
     file 'foo' do
       notifies :run, 'ruby_block[bar]', :delayed
     end
     EOF
     it { is_expected.to_not violate_rule }
   end
+
+  context "with a cookbook with a recipe that has a non-ruby_block resource with :create action" do
+    recipe_file <<-EOF
+    directory 'foo' do
+      action :create
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 12.2.0
+  version: 12.2.1
 platform: ruby
 authors:
 - Andrew Crump
@@ -541,5 +541,5 @@ rubyforge_project:
 rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
-summary: foodcritic-12.2.0
+summary: foodcritic-12.2.1
 test_files: []