foodcritic 12.1.0 → 12.2.0

data/spec/functional/fc104_spec.rb

@@ -0,0 +1,45 @@
+require "spec_helper"
+
+describe "FC104" do
+  context "with a cookbook with a recipe where ruby_block specifies a create action" do
+    recipe_file <<-EOF
+    ruby_block 'puts' do
+      block do
+        puts "test test test"
+      end
+      action :create
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe where ruby_block specifies a run action" do
+    library_file <<-EOF
+    ruby_block 'puts' do
+      block do
+        puts "test test test"
+      end
+      action :run
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+
+  context "with a cookbook with a recipe that notifies :create on a ruby_block" do
+    library_file <<-EOF
+    file 'foo' do
+      notifies :create, 'ruby_block[bar]', :delayed
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that notifies :run on a ruby_block" do
+    library_file <<-EOF
+    file 'foo' do
+      notifies :run, 'ruby_block[bar]', :delayed
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+end

data/spec/functional/fc105_spec.rb

@@ -0,0 +1,36 @@
+require "spec_helper"
+
+describe "FC105" do
+  context "with a cookbook with a custom resource that includes an erl_call resource" do
+    resource_file <<-EOF
+    erl_call 'list names' do
+      code 'net_adm:names().'
+      distributed true
+      node_name 'chef@latte'
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that includes an erl_call resource" do
+    recipe_file <<-EOF
+    erl_call 'list names' do
+      code 'net_adm:names().'
+      distributed true
+      node_name 'chef@latte'
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a library that includes an erl_call resource" do
+    library_file <<-EOF
+    erl_call 'list names' do
+      code 'net_adm:names().'
+      distributed true
+      node_name 'chef@latte'
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+end

data/spec/functional/fc106_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+
+describe "FC106" do
+  context "with a cookbook with a recipe that uses hash in a launchd resource" do
+    recipe_file <<-EOF
+    launchd 'foo' do
+      hash {}
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that uses plist_hash in a launchd  resource" do
+    library_file <<-EOF
+    launchd 'foo' do
+      plist_hash {}
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+end

data/spec/functional/fc107_spec.rb

@@ -0,0 +1,22 @@
+require "spec_helper"
+
+describe "FC107" do
+  context "with a cookbook with a recipe that uses uses epic_fail in a resource" do
+    recipe_file <<-EOF
+    chocolatey_package 'name' do
+      epic_fail true
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that uses uses ignore_failure in a resource" do
+    library_file <<-EOF
+    chocolatey_package 'name' do
+      action :install
+      ignore_failure true
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+end

data/spec/functional/fc108_spec.rb

@@ -0,0 +1,43 @@
+require "spec_helper"
+
+describe "FC108" do
+  context "with a cookbook with a custom resource that defines a name property" do
+    resource_file <<-EOF
+    property :name, String, name_property: true
+
+        action :create do
+        end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a custom resource that does not defines a name property" do
+    recipe_file <<-EOF
+    property :not_name, String, name_property: true
+
+    action :create do
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+
+  context "with a cookbook with a custom resource where a property contains a name variable" do
+    recipe_file <<-EOF
+    property :home, String, default: lazy { ::File.join('/home/', name) }
+
+    action :create do
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+
+  context "with a cookbook with a custom resource where a property contains a name symbol" do
+    recipe_file <<-EOF
+    property :foo, Symbol, default: :name
+
+    action :create do
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+end

data/spec/functional/fc109_spec.rb

@@ -0,0 +1,22 @@
+require "spec_helper"
+
+describe "FC109" do
+  context "with a cookbook with a package resource that defines a provider" do
+    resource_file <<-EOF
+    package 'foo' do
+      provider Chef::Provider::Package::Rpm
+      action :install
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a package resource that doesn't define a provider" do
+    resource_file <<-EOF
+    package 'foo' do
+      action :install
+    end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+end

data/spec/regression/expected/database.txt

@@ -19,4 +19,3 @@ FC086: Use databag helper methods to load data bag items: ./recipes/ebs_backup.r
 FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:27
 FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:70
 FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:78
-FC086: Use databag helper methods to load data bag items: ./recipes/ebs_volume.rb:94

data/spec/unit/linter_spec.rb

@@ -12,7 +12,7 @@ describe FoodCritic::Linter do
 
   describe "chef version" do
     it "should be the latest stable version of Chef" do
-      expect(FoodCritic::Linter::DEFAULT_CHEF_VERSION).to eq "13.5.3"
+      expect(FoodCritic::Linter::DEFAULT_CHEF_VERSION).to eq "13.6.0"
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foodcritic
 version: !ruby/object:Gem::Version
-  version: 12.1.0
+  version: 12.2.0
 platform: ruby
 authors:
 - Andrew Crump
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-10-31 00:00:00.000000000 Z
+date: 2017-11-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: cucumber-core
@@ -181,6 +181,7 @@ files:
 - chef_dsl_metadata/chef_13.3.42.json
 - chef_dsl_metadata/chef_13.4.19.json
 - chef_dsl_metadata/chef_13.5.3.json
+- chef_dsl_metadata/chef_13.6.0.json
 - features/002_check_string_interpolation.feature
 - features/004_check_service_resource_used.feature
 - features/005_check_for_resource_repetition.feature
@@ -336,6 +337,13 @@ files:
 - lib/foodcritic/rules/fc100.rb
 - lib/foodcritic/rules/fc101.rb
 - lib/foodcritic/rules/fc102.rb
+- lib/foodcritic/rules/fc103.rb
+- lib/foodcritic/rules/fc104.rb
+- lib/foodcritic/rules/fc105.rb
+- lib/foodcritic/rules/fc106.rb
+- lib/foodcritic/rules/fc107.rb
+- lib/foodcritic/rules/fc108.rb
+- lib/foodcritic/rules/fc109.rb
 - lib/foodcritic/template.rb
 - lib/foodcritic/version.rb
 - lib/foodcritic/xml.rb
@@ -410,6 +418,13 @@ files:
 - spec/functional/fc100_spec.rb
 - spec/functional/fc101_spec.rb
 - spec/functional/fc102_spec.rb
+- spec/functional/fc103_spec.rb
+- spec/functional/fc104_spec.rb
+- spec/functional/fc105_spec.rb
+- spec/functional/fc106_spec.rb
+- spec/functional/fc107_spec.rb
+- spec/functional/fc108_spec.rb
+- spec/functional/fc109_spec.rb
 - spec/functional/root_aliases_spec.rb
 - spec/regression/cookbooks.txt
 - spec/regression/expected/activemq.txt
@@ -526,5 +541,5 @@ rubyforge_project:
 rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
-summary: foodcritic-12.1.0
+summary: foodcritic-12.2.0
 test_files: []