foodcritic 10.4.1 → 11.0.0

data/spec/functional/fc066_spec.rb

@@ -10,4 +10,24 @@ describe "FC066" do
     metadata_file "chef_version '>= 12.1'"
     it { is_expected.to_not violate_rule("FC066") }
   end
+
+  context "with a cookbook with a metadata file that specifies a chef_version with a guard" do
+    metadata_file "chef_version '>= 12.1' if defined?(chef_version)"
+    it { is_expected.to_not violate_rule("FC066") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a chef_version with parens" do
+    metadata_file "chef_version('>= 12.1')"
+    it { is_expected.to_not violate_rule("FC066") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a chef_version with multiple arguments" do
+    metadata_file "chef_version '>= 12.1', '< 14'"
+    it { is_expected.to_not violate_rule("FC066") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a chef_version with a splat" do
+    metadata_file "chef_version(*['>= 12.1', '< 14'])"
+    it { is_expected.to_not violate_rule("FC066") }
+  end
 end

data/spec/functional/fc069_spec.rb

@@ -20,4 +20,19 @@ describe "FC069" do
     metadata_file "license 'All Rights Reserved'"
     it { is_expected.to_not violate_rule("FC069") }
   end
+
+  context "with a cookbook with a metadata file that specifies ChefDK's non-SPDX all rights reserved string with a different casing" do
+    metadata_file "license 'All rights reserved'"
+    it { is_expected.to_not violate_rule("FC069") }
+  end
+
+  context "with a cookbook with a metadata file that specifies a license with parens" do
+    metadata_file "license('Apache-2.0')"
+    it { is_expected.to_not violate_rule }
+  end
+
+  context "with a cookbook with a metadata file that does not specifiy a license" do
+    metadata_file
+    it { is_expected.to violate_rule }
+  end
 end

data/spec/functional/fc070_spec.rb

@@ -53,4 +53,13 @@ describe "FC070" do
     EOH
     it { is_expected.to_not violate_rule("FC070") }
   end
+
+  context "with a word list and a version constraint" do
+    metadata_file <<-EOH
+      %w{ redhat centos scientific amazon }.each do |os|
+        supports os, ">= 5.0"
+      end
+    EOH
+    it { is_expected.to_not violate_rule("FC070") }
+  end
 end

data/spec/functional/fc076_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC076" do
   context "with a cookbook with a metadata file that does contain the conflicts keyword" do
     metadata_file "conflicts 'runit'"
-    it { is_expected.to violate_rule("FC076") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that does not contain the conflicts keyword" do
     metadata_file
-    it { is_expected.to_not violate_rule("FC076") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc077_spec.rb

@@ -3,11 +3,11 @@ require "spec_helper"
 describe "FC077" do
   context "with a cookbook with a metadata file that does contain the replaces keyword" do
     metadata_file "replaces 'runit'"
-    it { is_expected.to violate_rule("FC077") }
+    it { is_expected.to violate_rule }
   end
 
   context "with a cookbook with a metadata file that does not contain the replaces keyword" do
     metadata_file
-    it { is_expected.to_not violate_rule("FC077") }
+    it { is_expected.to_not violate_rule }
   end
 end

data/spec/functional/fc078_spec.rb

@@ -4,22 +4,32 @@ describe "FC078" do
   context "with a cookbook with a metadata file that specifies" do
     context "a license generated by knife cookbook create" do
       metadata_file "license 'Apache 2.0'"
-      it { is_expected.to violate_rule("FC078") }
+      it { is_expected.to violate_rule }
     end
 
     context "a license generated by chef generate cookbook" do
       metadata_file "license 'apache_2'"
-      it { is_expected.to violate_rule("FC078") }
+      it { is_expected.to violate_rule }
     end
 
     context "a valid OSI-approved open source license in SPDX format" do
       metadata_file "license 'Apache-2.0'"
-      it { is_expected.to_not violate_rule("FC078") }
+      it { is_expected.to_not violate_rule }
     end
 
     context "ChefDK's non-SPDX all rights reserved string" do
       metadata_file "license 'All Rights Reserved'"
-      it { is_expected.to violate_rule("FC078") }
+      it { is_expected.to violate_rule }
+    end
+
+    context "a license with parens" do
+      metadata_file "license('Apache-2.0')"
+      it { is_expected.to_not violate_rule }
+    end
+
+    context "no license" do
+      metadata_file
+      it { is_expected.to violate_rule }
     end
   end
 end

data/spec/functional/fc079_spec.rb

@@ -0,0 +1,21 @@
+require "spec_helper"
+
+describe "FC079" do
+  context "with a cookbook with a recipe that includes an easy_install_package resource" do
+    recipe_file <<-EOF
+      easy_install_package "foo" do
+        action :install
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that doesn't include an easy_install_package resource" do
+    recipe_file <<-EOF
+      package "foo" do
+        action :install
+      end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc080_spec.rb

@@ -0,0 +1,68 @@
+require "spec_helper"
+
+describe "FC080" do
+  context "with a cookbook with a recipe that includes a user resource using supports" do
+    recipe_file <<-EOF
+      user 'betty' do
+        action :create
+        supports({
+          manage_home: true,
+          non_unique: true
+        })
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that includes a user resource using supports w/o parens" do
+    recipe_file <<-EOF
+      user 'betty' do
+        action :create
+        supports manage_home: true
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that includes a user resource not using supports" do
+    recipe_file <<-EOF
+      user username do
+        shell '/bin/false'
+        home  deploy_path
+        system true
+        action :create
+      end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that includes a resource with supports" do
+    recipe_file <<-EOF
+      service 'foo' do
+        action :start
+        supports :restart
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that includes a user resource and other supports uses" do
+    recipe_file <<-EOF
+      user 'foo' do
+        system true
+        action :create
+      end
+
+      def supports(thing)
+        puts thing
+      end
+
+      supports('something')
+
+      service 'foo' do
+        supports restart: true, status: true
+        action [:enable, :start]
+      end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc081_spec.rb

@@ -0,0 +1,25 @@
+require "spec_helper"
+
+describe "FC081" do
+  context "with a cookbook with a metadata file that depends on partial_search cookbook" do
+    metadata_file <<-META
+     name 'my_cookbook'
+     depends 'partial_search'
+     META
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a metadata file that depends on partial_search cookbook and others" do
+    metadata_file <<-META
+     name 'my_cookbook'
+     depends 'partial_search'
+     depends 'windows'
+     META
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a metadata file that depends on no cookbooks" do
+    metadata_file "name 'my_cookbook'"
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc082_spec.rb

@@ -0,0 +1,23 @@
+require "spec_helper"
+
+describe "FC082" do
+  context "with a cookbook with a recipe that sets an attribute with node.set" do
+    recipe_file "node.set['foo']['bar'] = baz"
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that sets an attribute with node.set_unless" do
+    recipe_file "node.set_unless['foo']['bar'] = baz"
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that sets an attribute with node.normal" do
+    recipe_file "node.normal['foo']['bar'] = baz"
+    it { is_expected.to_not violate_rule }
+  end
+
+  context "with a cookbook with a recipe that reads a value using node.set" do
+    recipe_file "foo = node.set['foo']"
+    it { is_expected.to violate_rule }
+  end
+end

data/spec/functional/fc083_spec.rb

@@ -0,0 +1,34 @@
+require "spec_helper"
+
+describe "FC083" do
+  context "with a cookbook with a recipe that includes a execute resource specifying path" do
+    recipe_file <<-EOF
+      execute 'food' do
+        path '/some/path'
+        command 'build.sh'
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that includes a execute resource not specifying path" do
+    recipe_file <<-EOF
+      execute 'food' do
+        command 'build.sh'
+      end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that doesn't include an execute resource" do
+    recipe_file <<-EOF
+      directory '/tmp/something' do
+        owner 'root'
+        group 'root'
+        mode '0755'
+        action :create
+      end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc084_spec.rb

@@ -0,0 +1,49 @@
+require "spec_helper"
+
+describe "FC084" do
+  context "with a cookbook with a recipe that includes Chef::REST" do
+    recipe_file 'Chef::REST::RESTRequest.new(:GET, "http://foo.com", nil).call'
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a library that includes Chef::REST" do
+    recipe_file <<-EOF
+      def response
+        response = Chef::REST::RESTRequest.new(:GET, 'http://foo.com', nil).call
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a LWRP that includes Chef::REST" do
+    recipe_file <<-EOF
+      action :doit do
+        Chef::REST::RESTRequest.new(:GET, 'http://foo.com', nil).call
+      end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a recipe that includes Chef::ServerAPI" do
+    recipe_file "server_conn = Chef::ServerAPI.new"
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a library that includes Chef::ServerAPI" do
+    recipe_file <<-EOF
+      def server_conn
+        server_conn = Chef::ServerAPI.new
+      end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+
+  context "with a cookbook with a LWRP that includes Chef::ServerAPI" do
+    recipe_file <<-EOF
+      action :doit do
+        Chef::ServerAPI.new
+      end
+    EOF
+    it { is_expected.not_to violate_rule }
+  end
+end

data/spec/functional/fc085_spec.rb

@@ -0,0 +1,58 @@
+require "spec_helper"
+
+describe "FC085" do
+  context "with a cookbook with a custom resource that converges with updated_by_last_action" do
+    resource_file <<-EOF
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+
+      new_resource.updated_by_last_action(true)
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a LWRP that converges with updated_by_last_action" do
+    resource_file <<-EOF
+    use_inline_resources
+
+    action :create do
+      template "/etc/something.conf" do
+        notifies :restart, "service[something]"
+      end
+
+      new_resource.updated_by_last_action(true)
+    end
+    EOF
+    it { is_expected.to violate_rule }
+  end
+
+  context "with a cookbook with a custom resource that relies on resources for convergence" do
+    resource_file <<-EOF
+    action :create do
+      file "the_file" do
+        template "/etc/something.conf" do
+          notifies :restart, "service[something]"
+        end
+      end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+
+  context "with a cookbook with a LWRP that relies on resources for convergence" do
+    resource_file <<-EOF
+    use_inline_resources
+
+    action :create do
+      file "the_file" do
+        template "/etc/something.conf" do
+          notifies :restart, "service[something]"
+        end
+      end
+    EOF
+    it { is_expected.to_not violate_rule }
+  end
+
+end

data/spec/regression/expected/aix.txt

@@ -1,2 +1,3 @@
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC080: User resource uses supports property: ./recipes/default.rb:8

data/spec/regression/expected/aws.txt

@@ -15,3 +15,6 @@ FC075: Cookbook uses node.save to save partial node data to the chef-server mid-
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./providers/ebs_volume.rb:40
 FC075: Cookbook uses node.save to save partial node data to the chef-server mid-run: ./providers/ebs_volume.rb:60
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC082: node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:32
+FC082: node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:39
+FC082: node.set or node.set_unless used to set node attributes: ./providers/ebs_volume.rb:59

data/spec/regression/expected/chef-client.txt

@@ -12,3 +12,5 @@ FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC070: Ensure supports metadata defines valid platforms: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/service.rb:59
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/task.rb:49

data/spec/regression/expected/chef.txt

@@ -35,3 +35,70 @@ FC065: Ensure source_url is set in metadata: ./metadata.rb:1
 FC066: Ensure chef_version is set in metadata: ./metadata.rb:1
 FC069: Ensure standardized license defined in metadata: ./metadata.rb:1
 FC078: Ensure cookbook shared under an OSI-approved open source license: ./metadata.rb:1
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:27
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:28
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:29
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:30
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:31
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:32
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:33
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:34
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:35
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:36
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:37
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:38
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/bootstrap_server.rb:39
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:25
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:26
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:27
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:28
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:29
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:30
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:31
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:32
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:33
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:34
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client.rb:35
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:24
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:25
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:26
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:27
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:28
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:29
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:30
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:31
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:32
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:33
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/client_service.rb:34
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:25
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:26
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:27
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:28
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:29
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:30
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:31
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:32
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:33
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:34
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:35
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:36
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:37
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:38
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server.rb:39
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:23
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:24
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:25
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:26
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:27
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:28
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:29
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:30
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:31
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:32
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:33
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:34
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:35
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:36
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:37
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:38
+FC082: node.set or node.set_unless used to set node attributes: ./recipes/server_proxy.rb:39