foobara 0.6.4 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3417123e9edcf11d20e2d6355e1b63d7d25b33e957b42d32c64b4452d93f4463
-  data.tar.gz: 8b94bd6c61857d89eda1bcf667a408536cad9f2a5845f9a51a57e931a64ae28c
+  metadata.gz: 55727f8ba357338d057069b782e94dc171a87ce95ae4d1865c5df1e46252559a
+  data.tar.gz: 5aa4e8a6535fdaf3bc1b3dd968b5b00348ef00c723d4728e313f9076b4a02b5c
 SHA512:
-  metadata.gz: b57004203dabc6e0d305f17dfd470e7fe47878b0c1be28fb6ebd89b5c0cbf943e96b5efa8404ce929e7a59744e0a36385649448391830886a5042ec3d48ce822
-  data.tar.gz: 77d265ecf8b8c9f2fa8dcc30f996df4f237fda07eee821f7d85c67963ab42732a5dec786e2f0a2c6e273d1077215dac22ef4ad44c2ca8dc410e56658417ec599
+  metadata.gz: 239417815a5ead7dd367120cb67b50fb20d0750dacdd3f8519d76f2bc1e69f565f6217d7dd8d194bd199e6dbf9e7f1d2fd8783e081461da8888ee675f1fc9e7a
+  data.tar.gz: c06a234449b4ee52855f153277fe2440111f14873cc03dc9cc8c4c3a2fe558f811800ca6db8b0714d1e1fc2a54223290fb278c13c854b49dc2b708a5687f5ca2

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# [0.7.0] - 2026-10-09
+
+- Do not allow anything but domains (and orgs as a hack) to be children of orgs
+- Eliminate NoContextTypeSetError and add default context type of {}
+
+# [0.6.5] - 2026-10-04
+
+- Fix a problem where some nested sugary types don't expand correctly when using attributes dsl
+- Add command name to error message when a result can't be cast to the result type
+
 # [0.6.4] - 2026-09-11
 
 - Track which models instances ignore unsupported attributes to prevent various issues, including breaking domain mappers

data/projects/command/src/command_pattern_implementation/concerns/result.rb

@@ -4,7 +4,15 @@ module Foobara
       module Result
         include Concern
 
-        class CouldNotProcessResult < Outcome::UnsuccessfulOutcomeError; end
+        class CouldNotProcessResult < Outcome::UnsuccessfulOutcomeError;
+          attr_accessor :command
+
+          def initialize(command, errors)
+            self.command = command
+
+            super(errors, prefix: command.class.full_command_name)
+          end
+        end
 
         private
 
@@ -16,7 +24,7 @@ module Foobara
           if outcome.success?
             outcome.result
           else
-            raise CouldNotProcessResult, outcome.errors
+            raise CouldNotProcessResult.new(self, outcome.errors)
           end
         end
       end

data/projects/command_connectors/src/command_registry/exposed_command.rb

@@ -11,6 +11,8 @@ module Foobara
                     :result_transformers,
                     :errors_transformers,
                     :pre_commit_transformers,
+                    # Should we have separate success and error serializers so that serializers can be
+                    # more reusable?
                     :serializers,
                     :request_mutators,
                     :response_mutators,

data/projects/command_connectors/src/serializers/success_serializer.rb

@@ -5,6 +5,7 @@ module Foobara
     module Serializers
       class SuccessSerializer < Serializer
         def always_applicable?
+          # Why is the serializer coupled to a request???
           request.outcome&.success?
         end
       end

data/projects/entities_plumbing/src/serializers/aggregate_serializer.rb

@@ -1,6 +1,10 @@
 module Foobara
   module CommandConnectors
     module Serializers
+      # TODO: put an entity-free version of this in model_plumbing!
+      # TODO: can't this just inherit from Serializer??
+      # TODO: shouldn't this be a transformer? It's not really serializing anything
+      #       just preparing the data for serialization.
       class AggregateSerializer < SuccessSerializer
         def serialize(object)
           case object

data/projects/typesystem/projects/common/src/outcome.rb

@@ -3,10 +3,12 @@ module Foobara
     class UnsuccessfulOutcomeError < StandardError
       attr_accessor :errors, :backtrace_when_raised
 
-      def initialize(errors)
+      def initialize(errors, message: errors.map(&:message).join(", "), prefix: nil)
         self.errors = errors
 
-        message = errors.map(&:message).join(", ")
+        if prefix
+          message = "#{prefix}: #{message}"
+        end
 
         super(message)
       end

data/projects/typesystem/projects/domain/src/domain_module_extension.rb

@@ -234,12 +234,23 @@ module Foobara
             domain.foobara_manifest_reference
           end.sort
 
-          types = foobara_all_type(mode: Namespace::LookupMode::DIRECT).map do |type|
-            if to_include
-              to_include << type
+          types = []
+
+          # Using this to support deprecated Foobara.manifest without risking
+          # breakage elsewhere
+          if TypeDeclarations.foobara_manifest_context_include_unreachable?
+            foobara_all(mode: Namespace::LookupMode::DIRECT).each do |scoped|
+              to_include << scoped if to_include
+              types << scoped.foobara_manifest_reference if scoped.scoped_category == :type
             end
-            type.foobara_manifest_reference
-          end.sort
+          else
+            foobara_all_type(mode: Namespace::LookupMode::DIRECT).each do |scoped|
+              to_include << scoped if to_include
+              types << scoped.foobara_manifest_reference
+            end
+          end
+
+          types.sort!
 
           manifest = super.merge(types:)
 

data/projects/typesystem/projects/domain/src/extensions/foobara.rb

@@ -11,7 +11,7 @@ module Foobara
     private def debug_manifest
       to_include = Namespace.global.foobara_all_organization.to_set
 
-      TypeDeclarations.with_manifest_context(to_include:) do
+      TypeDeclarations.with_manifest_context(to_include:, include_unreachable: true) do
         included = {}
 
         h = {}

data/projects/typesystem/projects/domain/src/module_extension.rb

@@ -17,6 +17,8 @@ module Foobara
           # simplecov:enable
         end
 
+        include DomainModuleExtension
+
         unless is_a?(Namespace::IsNamespace)
           foobara_namespace!
           foobara_autoset_namespace!(default_namespace: Foobara::GlobalOrganization)
@@ -24,8 +26,6 @@ module Foobara
 
           foobara_parent_namespace.foobara_register(self)
         end
-
-        include(DomainModuleExtension)
       end
 
       def foobara_organization!

data/projects/typesystem/projects/namespace/src/namespace_helpers.rb

@@ -155,11 +155,15 @@ module Foobara
 
           while parent_mod
             if parent_mod.is_a?(Foobara::Namespace::IsNamespace)
-              mod.scoped_namespace = parent_mod
-              return
-            else
-              parent_mod = Util.module_for(parent_mod)
+              # Only domains can have an org as its parent
+              # Important that Foobara::GlobalOrganization's parent is Foobara or it breaks categories
+              if mod.foobara_organization? || mod.foobara_domain? || !parent_mod.foobara_organization?
+                mod.scoped_namespace = parent_mod
+                return
+              end
             end
+
+            parent_mod = Util.module_for(parent_mod)
           end
 
           mod.scoped_namespace = default_namespace if default_namespace
@@ -216,6 +220,13 @@ module Foobara
             adjusted_scoped_path << path_part unless mod.scoped_namespace&.scoped_ignore_module?(next_mod)
           end
 
+          if parent&.foobara_organization?
+            if !mod.foobara_domain? && !mod.foobara_organization?
+              parent = Foobara::GlobalDomain
+              adjusted_scoped_path = mod_name.split("::")
+            end
+          end
+
           mod.scoped_path_autoset = true
           mod.scoped_path = adjusted_scoped_path
 

data/projects/typesystem/projects/type_declarations/lib/foobara/type_declarations.rb

@@ -101,11 +101,15 @@ module Foobara
           }
         end
 
-        Value::DataError.singleton_class.define_method :context_type_declaration do
-          {
-            attribute_name: :symbol,
-            value: :duck
-          }
+        ::Foobara::Value::DataError.instance_exec do
+          class << self
+            def context_type_declaration
+              {
+                attribute_name: :symbol,
+                value: :duck
+              }.freeze
+            end
+          end
         end
       end
 

data/projects/typesystem/projects/type_declarations/src/dsl/attributes.rb

@@ -83,6 +83,17 @@ module Foobara
               end
             end
 
+            if type && !type.is_a?(::Symbol)
+              type = Domain.current.foobara_type_from_declaration(type)
+
+              type = if type.registered?
+                       type.reference_symbol
+                     else
+                       declaration = type.declaration_data.merge(declaration)
+                       declaration[:type]
+                     end
+            end
+
             processor_symbols.each do |processor_symbol|
               case processor_symbol
               when ::String

data/projects/typesystem/projects/type_declarations/src/error_extension.rb

@@ -22,36 +22,20 @@ module Foobara
     self.validate_error_context_enabled = true
 
     module ErrorExtension
-      class NoContextTypeSetError < StandardError
-        def initialize
-          super("No context type declaration set. Either set it or mark the error as abstract")
-        end
-      end
-
       include Concern
       # TODO: replace this with some kind of Foobara::TypeBuilder version
       include WithRegistries
 
       module ClassMethods
         def context_type
-          @context_type ||= begin
-            Foobara::Domain.foobara_type_from_declaration(self, context_type_declaration)
-          rescue NoContextTypeSetError
-            if abstract?
-              nil
-            else
-              # simplecov:disable
-              raise
-              # simplecov:enable
-            end
-          end
-        end
+          return @context_type if defined?(@context_type)
 
-        def context_type_declaration
-          # simplecov:disable
-          raise NoContextTypeSetError
-          # simplecov:enable
+          @context_type = unless abstract?
+                            Foobara::Domain.foobara_type_from_declaration(self, context_type_declaration)
+                          end
         end
+
+        def context_type_declaration = {}.freeze
       end
 
       def initialize(...)

data/projects/typesystem/projects/type_declarations/src/type_declarations.rb

@@ -82,7 +82,6 @@ module Foobara
         using_mode(Mode::STRINGIFIED, &)
       end
 
-      # TODO: use manifest context instead
       def using_mode(new_mode, &)
         with_manifest_context(mode: new_mode, &)
       end
@@ -116,8 +115,17 @@ module Foobara
         Thread.inheritable_thread_local_var_get("foobara_manifest_context")
       end
 
-      allowed_context_keys = [:detached, :to_include, :mode, :remove_sensitive, :include_processors]
-      booleans = [:detached, :remove_sensitive, :include_processors]
+      allowed_context_keys = [
+        :detached,
+        :to_include,
+        :mode,
+        :remove_sensitive,
+        :include_processors,
+        # This is just a flag to allow the deprecated Foobara.manifest to include
+        # everything without risk of breaking something in command connector manifests
+        :include_unreachable
+      ]
+      booleans = [:detached, :remove_sensitive, :include_processors, :include_unreachable]
 
       booleans.each do |context_item|
         define_method "foobara_manifest_context_#{context_item}?" do

data/projects/typesystem/projects/types/src/extensions/error.rb

@@ -5,22 +5,11 @@ module Foobara
         if args.size == 1
           context_type.types_depended_on(args[0])
         elsif args.empty?
-          begin
-            if context_type
-              context_type.types_depended_on
-            else
-              raise Foobara::TypeDeclarations::ErrorExtension::NoContextTypeSetError
-            end
-          rescue Foobara::TypeDeclarations::ErrorExtension::NoContextTypeSetError
-            if abstract?
-              []
-            else
-              # simplecov:disable
-              raise
-              # simplecov:enable
-            end
+          if abstract?
+            []
+          else
+            context_type.types_depended_on
           end
-
         else
           # simplecov:disable
           raise ArgumentError, "Too many arguments #{args}"

data/projects/typesystem/projects/types/src/type.rb

@@ -428,12 +428,7 @@ module Foobara
         remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
 
         if registered?
-          # TODO: we should just use the symbol and nothing else in this context instead of a hash with 1 element.
-          if scoped_unregistered?
-            unregistered_foobara_manifest_reference.to_sym
-          else
-            foobara_manifest_reference.to_sym
-          end
+          reference_symbol
         elsif remove_sensitive
           TypeDeclarations.remove_sensitive_types(declaration_data)
         else
@@ -441,6 +436,16 @@ module Foobara
         end
       end
 
+      def reference_symbol
+        raise "Not registered so no reference symbol" unless registered?
+
+        if scoped_unregistered?
+          unregistered_foobara_manifest_reference.to_sym
+        else
+          foobara_manifest_reference.to_sym
+        end
+      end
+
       def declaration_data_for_manifest
         data = declaration_data
 

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.6.4".freeze
+    VERSION = "0.7.0".freeze
     MINIMUM_RUBY_VERSION = [">= 3.4.0", "< 4.1"].freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.6.4
+  version: 0.7.0
 platform: ruby
 authors:
 - Miles Georgi