foobara 0.5.3 → 0.5.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2ee98e7512333f9d3e069e3fe8a6c7cbbe2c5f27f2d918a7397cdaeed64b077f
-  data.tar.gz: 6fd8d38c4a30d1b0721fc241b6d09ef890e719fccd795b40d8319a7d77a82c56
+  metadata.gz: 6527e62790180b1aeb2f98e069655d8ac72750fbff834fc63e9b75a01c35cb4e
+  data.tar.gz: a769dd2a642b71bd401dabe3c0917a1fa128069f2a7987ff79df633765ae93ad
 SHA512:
-  metadata.gz: 0b9e6f6ba2685ee2462811158fefc0d30f4c83122a3701e8b5ab06e2188d1d9c3ce5775846af2a4b4e15ffb7007d19947894fd9e6d4c3a98b92d2636b5b1bbc8
-  data.tar.gz: 14db098dc24293b84247e8a4d44913c902aae7f4058ca148698587c14c7d9f971d5d1e97b04ad94f4ae8b80007cac1b6881348c03d13b1ec41c4213b3a1c2892
+  metadata.gz: '0359999dd32f56220e88e3e860ff7e415a4fd2b978bf83768868b1e10b0013c9e02597731890d1a2abb2fd11c1e288e1c1e8056b3bd6bf7a11bc9589af371ae3'
+  data.tar.gz: 33cf7a4428854d3016c1ccda045820e6da47a268e34f5bb05505bcc878ecdeff909caf1c411505d97849f4ffd69cc6e9c1c51a046ee92f6ee7ac2afe1919b359

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+# [0.5.5] - 2026-02-19
+
+- Fix bug where WeakObjectSet#delete could fail after deactivation
+- Fix bug where arrays of allowed rules run in the wrong context
+- Remove awkward proc defaults from manifest
+
+# [0.5.4] - 2026-02-16
+
+- Fix bug where adding a desugarizer to a subclass had no effect
+- Add support for requiring allow_if: by default
+
 # [0.5.3] - 2026-02-12
 
 - Allow registering an allowed rule on an instance of a connector not just its class

data/projects/command/src/command_pattern_implementation/concerns/reflection.rb

@@ -60,16 +60,17 @@ module Foobara
               possible_errors:,
               depends_on:,
               # TODO: allow inputs type to be nil or really any type?
-              inputs_type: inputs_type&.reference_or_declaration_data || GlobalDomain.foobara_type_from_declaration(
-                type: "::attributes",
-                element_type_declarations: {},
-                required: []
-              ).declaration_data
+              inputs_type: inputs_type&.reference_or_declaration_data_for_manifest ||
+                GlobalDomain.foobara_type_from_declaration(
+                  type: "::attributes",
+                  element_type_declarations: {},
+                  required: []
+                ).declaration_data
             ).merge(description:)
 
             if result_type
               # TODO: find a way to represent literal types like "nil"
-              h[:result_type] = result_type.reference_or_declaration_data
+              h[:result_type] = result_type.reference_or_declaration_data_for_manifest
             end
 
             super.merge(h)

data/projects/command_connectors/spec/command_connector_spec.rb

@@ -488,6 +488,20 @@ RSpec.describe Foobara::CommandConnector do
       expect(response.body).to eq("8")
     end
 
+    context "when requires_allowed_rule" do
+      let(:command_connector) do
+        described_class.new(
+          authenticator:,
+          default_serializers:,
+          requires_allowed_rule: true
+        )
+      end
+
+      it "gives a relevant error" do
+        expect { response }.to raise_error(Foobara::CommandConnector::NoAllowedRuleGivenError)
+      end
+    end
+
     context "with default transformers" do
       before do
         identity = proc { |x| x }
@@ -2074,14 +2088,14 @@ RSpec.describe Foobara::CommandConnector do
       end
       let(:command_connector) do
         rule = allowed_rule_d
-        command_connector_class_d.new do
+        command_connector_class_d.new(requires_allowed_rule: true) do
           register_allowed_rule :d, rule
         end
       end
 
       it "puts the expected allowed rules on the command connector" do
         command_connector.connect(command_class, suffix: "A", allow_if: :a)
-        command_connector.connect(command_class, suffix: "B")
+        command_connector.connect(command_class, suffix: "B", allow_if: :always)
         command_connector.connect(command_class, suffix: "C", allowed_rule: :c)
         command_connector.connect(command_class, suffix: "D", allowed_rule: :d)
 
@@ -2091,7 +2105,7 @@ RSpec.describe Foobara::CommandConnector do
 
         response = command_connector.run(full_command_name: "ComputeExponentB", action:, inputs:)
         expect(response.status).to be(0)
-        expect(response.command.allowed_rule).to be_nil
+        expect(response.command.allowed_rule).to be(described_class.always_allowed_rule)
 
         response = command_connector.run(full_command_name: "ComputeExponentC", action:, inputs:)
         expect(response.status).to be(1)

data/projects/command_connectors/src/command_connector/concerns/desugarizers.rb

@@ -36,13 +36,13 @@ module Foobara
           end
 
           def desugarizers
-            @desugarizers ||= []
+            return @desugarizers if defined?(@desugarizers)
 
-            if superclass == Object
-              @desugarizers
-            else
-              @desugarizers + superclass.desugarizers
-            end
+            @desugarizers = if superclass == Object
+                              []
+                            else
+                              superclass.desugarizers.dup
+                            end
           end
         end
       end

data/projects/command_connectors/src/command_connector/no_allowed_rule_given_error.rb

@@ -0,0 +1,6 @@
+module Foobara
+  class CommandConnector
+    class NoAllowedRuleGivenError < StandardError
+    end
+  end
+end

data/projects/command_connectors/src/command_connector.rb

@@ -178,10 +178,19 @@ module Foobara
       def build_auth_mapper(to_type, &)
         TypeDeclarations::TypedTransformer.subclass(to: to_type, &).instance
       end
+
+      def always_allowed_rule
+        # maybe move AllowedRule to CommandConnector:: instead of
+        # CommandRegistry:: which is more of an implementation detail?
+        @always_allowed_rule ||= CommandRegistry::AllowedRule.new(
+          symbol: :always,
+          explanation: "This always passes. Used to override allowed_rule_missing."
+        ) { true }
+      end
     end
 
     attr_accessor :command_registry, :authenticator, :capture_unknown_error, :name,
-                  :auth_map
+                  :auth_map, :requires_allowed_rule
 
     def initialize(name: nil,
                    authenticator: nil,
@@ -190,6 +199,7 @@ module Foobara
                    default_pre_commit_transformers: nil,
                    auth_map: nil,
                    current_user: nil,
+                   requires_allowed_rule: false,
                    &block)
       authenticator = self.class.to_authenticator(authenticator)
 
@@ -214,6 +224,11 @@ module Foobara
         add_default_serializer(serializer)
       end
 
+      if requires_allowed_rule
+        self.requires_allowed_rule = requires_allowed_rule
+        register_allowed_rule(CommandConnector.always_allowed_rule)
+      end
+
       Util.array(default_pre_commit_transformers).each do |pre_commit_transformer|
         add_default_pre_commit_transformer(pre_commit_transformer)
       end
@@ -232,6 +247,7 @@ module Foobara
     end
 
     # TODO: should this be the official way to connect a command instead of #connect ?
+    # Probably not. But what about #export instead?
     def command(...) = connect(...)
 
     def connect(*args, **opts)
@@ -616,6 +632,16 @@ module Foobara
     def run_command(request)
       command = request.command
 
+      if requires_allowed_rule
+        unless command.allowed_rule
+          raise NoAllowedRuleGivenError,
+                "Must connect #{command.full_command_name} with an `allowed_if:` " \
+                "because `requires_allowed_rule` is true. You can use `allow_if: :always` if want to always allow " \
+                "this command to be ran or you can also use `requires_allowed_rule: false` " \
+                "when creating the connector if you don't want to enforce allowed_if: for all connected commands."
+        end
+      end
+
       unless command.outcome
         command.run
       end

data/projects/command_connectors/src/command_registry.rb

@@ -263,7 +263,7 @@ module Foobara
         procs = rules.map(&:block)
 
         block = proc do
-          procs.any?(&:call)
+          procs.any? { |p| instance_exec(&p) }
         end
 
         allowed_rule = AllowedRule.new(&block)

data/projects/command_connectors/src/transformed_command.rb

@@ -381,7 +381,7 @@ module Foobara
         end
 
         # TODO: This should support nil as an inputs_type but it breaks other projects for now
-        inputs_type = inputs_type_for_manifest&.reference_or_declaration_data ||
+        inputs_type = inputs_type_for_manifest&.reference_or_declaration_data_for_manifest ||
                       { type: :attributes, element_type_declarations: {} }
 
         # TODO: handle errors_types_depended_on!
@@ -390,7 +390,7 @@ module Foobara
           result_types_depended_on:,
           types_depended_on: types,
           inputs_type:,
-          result_type: result_type&.reference_or_declaration_data,
+          result_type: result_type&.reference_or_declaration_data_for_manifest,
           possible_errors: possible_errors_manifest,
           capture_unknown_error:,
           inputs_transformers:,

data/projects/entities/projects/weak_object_set/src/weak_object_set.rb

@@ -45,7 +45,7 @@ module Foobara
           loop do
             object_id = queue.pop
             if object_id
-              weak_object_set.delete(object_id)
+              weak_object_set&.delete(object_id)
             elsif queue.closed?
               self.queue = nil
               break

data/projects/typesystem/projects/types/src/type.rb

@@ -420,6 +420,10 @@ module Foobara
         scoped_full_name
       end
 
+      def reference_or_declaration_data_for_manifest
+        reference_or_declaration_data(declaration_data_for_manifest)
+      end
+
       def reference_or_declaration_data(declaration_data = self.declaration_data)
         remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
 
@@ -437,6 +441,30 @@ module Foobara
         end
       end
 
+      def declaration_data_for_manifest
+        data = declaration_data
+
+        if data.is_a?(::Hash) && data[:type] == :attributes
+          if data.key?(:defaults)
+            defaults = data[:defaults]
+
+            if defaults.is_a?(::Hash) && defaults.values.any? { it.is_a?(Proc) }
+              cleaned_defaults = defaults.transform_values do |value|
+                if value.is_a?(Proc)
+                  "[<Lazily Set>]"
+                else
+                  value
+                end
+              end
+
+              data = data.merge(defaults: cleaned_defaults)
+            end
+          end
+        end
+
+        data
+      end
+
       # TODO: put this somewhere else
       def foobara_manifest_reference
         scoped_full_name
@@ -462,7 +490,7 @@ module Foobara
           [possible_error.key.to_s, possible_error.foobara_manifest]
         end.sort.to_h
 
-        declaration_data = self.declaration_data
+        declaration_data = declaration_data_for_manifest
 
         if remove_sensitive
           declaration_data = TypeDeclarations.remove_sensitive_types(declaration_data)

data/projects/typesystem/spec/builtin_types/attributes_spec.rb

@@ -1,4 +1,6 @@
 RSpec.describe Foobara::BuiltinTypes::Attributes do
+  after { Foobara.reset_alls }
+
   let(:type) {
     Foobara::Domain.current.foobara_type_from_declaration(type_declaration)
   }
@@ -61,6 +63,26 @@ RSpec.describe Foobara::BuiltinTypes::Attributes do
       end
     end
 
+    context "when default is a proc" do
+      let(:type_declaration) do
+        {
+          type: :attributes,
+          element_type_declarations: {
+            a: :integer,
+            b: :integer
+          },
+          defaults: { a: -> { 10 }, b: 100 }
+        }
+      end
+
+      it "applies defaults and scrubs the value in the manifest data" do
+        expect(type.process_value!({})).to eq(a: 10, b: 100)
+
+        Foobara::GlobalDomain.foobara_register_type(:some_type, type)
+        expect(type.foobara_manifest[:declaration_data][:defaults]).to eq(a: "[<Lazily Set>]", b: 100)
+      end
+    end
+
     context "when defaults contains invalid attribute names" do
       let(:type_declaration) do
         {

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.5.3".freeze
+    VERSION = "0.5.5".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.5.3
+  version: 0.5.5
 platform: ruby
 authors:
 - Miles Georgi
@@ -138,6 +138,7 @@ files:
 - projects/command_connectors/src/command_connector/concerns/desugarizers.rb
 - projects/command_connectors/src/command_connector/concerns/reflection.rb
 - projects/command_connectors/src/command_connector/invalid_context_error.rb
+- projects/command_connectors/src/command_connector/no_allowed_rule_given_error.rb
 - projects/command_connectors/src/command_connector/no_command_found_error.rb
 - projects/command_connectors/src/command_connector/no_command_or_type_found_error.rb
 - projects/command_connectors/src/command_connector/no_type_found_error.rb