foobara 0.5.10 → 0.6.0

data/projects/entities/projects/persistence/src/entity_base/transaction/concerns/entity_callback_handling.rb

@@ -10,7 +10,7 @@ module Foobara
           module EntityCallbackHandling
             class << self
               def reset_all
-                Foobara.raise_if_production!("reset_all")
+                Foobara.raise_if_production!
                 install!
               end
 
@@ -25,10 +25,10 @@ module Foobara
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot modify #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   transaction.updated(record)
@@ -38,17 +38,17 @@ module Foobara
                   transaction = Transaction.open_transaction_for(record)
 
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot modify #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot modify #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   transaction.updated(record)
@@ -58,17 +58,17 @@ module Foobara
                   transaction = Transaction.open_transaction_for(record)
 
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot modify #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot modify #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   transaction.hard_deleted(record)
@@ -78,17 +78,17 @@ module Foobara
                   transaction = Transaction.open_transaction_for(record)
 
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot modify #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot modify #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   transaction.unhard_deleted(record)
@@ -97,17 +97,17 @@ module Foobara
                 Entity.after_initialized_loaded do |record:, **|
                   transaction = Persistence.current_transaction(record)
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot initialize #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot initialize #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
                   # TODO: we need a way to not blow up here in case of non-block form of transaction
                   transaction.track_loaded(record)
@@ -122,10 +122,10 @@ module Foobara
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot initialize #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
                   # TODO: we need a way to not blow up here in case of non-block form of transaction
                   transaction.track_created(record)
@@ -135,17 +135,17 @@ module Foobara
                   transaction = Persistence.current_transaction(record)
 
                   unless transaction
-                    # :nocov:
+                    # simplecov:disable
                     raise NoCurrentTransactionError,
                           "Cannot initialize #{record} because there's no current transaction"
-                    # :nocov:
+                    # simplecov:enable
                   end
 
                   unless transaction.open?
-                    # :nocov:
+                    # simplecov:disable
                     raise CurrentTransactionIsClosedError,
                           "Cannot initialize #{record} because current transaction is not open"
-                    # :nocov:
+                    # simplecov:enable
                   end
                   # TODO: we need a way to not blow up here in case of non-block form of transaction
                   transaction.track_unloaded_thunk(record)

data/projects/entities/projects/persistence/src/entity_base/transaction/concerns/state_transitions.rb

@@ -32,10 +32,10 @@ module Foobara
               end
               entity_attributes_crud_driver.flush_transaction(raw_tx)
             rescue => e
-              # :nocov:
+              # simplecov:disable
               rollback!(e)
               raise
-              # :nocov:
+              # simplecov:enable
             end
 
             # Should communicate somehow that this is only in-memory.
@@ -46,10 +46,10 @@ module Foobara
               end
               entity_attributes_crud_driver.revert_transaction(raw_tx)
             rescue => e
-              # :nocov:
+              # simplecov:disable
               rollback!(e)
               raise
-              # :nocov:
+              # simplecov:enable
             end
 
             def commit!
@@ -62,10 +62,10 @@ module Foobara
                 each_table(&:transaction_closed)
               end
             rescue => e
-              # :nocov:
+              # simplecov:disable
               rollback!(e)
               raise
-              # :nocov:
+              # simplecov:enable
             end
 
             def commit_nested!
@@ -75,10 +75,10 @@ module Foobara
                 each_table(&:transaction_closed)
               end
             rescue => e
-              # :nocov:
+              # simplecov:disable
               rollback!(e)
               raise
-              # :nocov:
+              # simplecov:enable
             end
 
             # TODO: this belongs elsewhere

data/projects/entities/projects/persistence/src/entity_base/transaction/concerns/transaction_tracking.rb

@@ -23,7 +23,7 @@ module Foobara
               end
 
               def reset_all
-                Foobara.raise_if_production!("reset_all")
+                Foobara.raise_if_production!
                 @open_transactions = nil
               end
 

data/projects/entities/projects/persistence/src/entity_base/transaction.rb

@@ -58,9 +58,9 @@ module Foobara
           end
 
           unless entity_base == entity_class.entity_base
-            # :nocov:
+            # simplecov:disable
             raise "#{entity_class} is from a different entity base! Cannot proceed."
-            # :nocov:
+            # simplecov:enable
           end
 
           table = tables[entity_class]
@@ -70,9 +70,9 @@ module Foobara
           else
             if defined?(@ordered_tables)
               # TODO: test this path
-              # :nocov:
+              # simplecov:disable
               remove_instance_variable(:@ordered_tables)
-              # :nocov:
+              # simplecov:enable
             end
 
             tables[entity_class] = TransactionTable.new(self, entity_class)
@@ -102,17 +102,17 @@ module Foobara
         def load(record_or_entity_class, record_id = nil)
           entity_or_id = if record_or_entity_class.is_a?(Entity)
                            if record_id
-                             # :nocov:
+                             # simplecov:disable
                              raise ArgumentError, "Do not give a record_id when also giving a record"
-                             # :nocov:
+                             # simplecov:enable
                            end
 
                            record_or_entity_class
                          else
                            unless record_id
-                             # :nocov:
+                             # simplecov:disable
                              raise ArgumentError, "Must give a record_id when passing in an entity class"
-                             # :nocov:
+                             # simplecov:enable
                            end
 
                            record_id
@@ -148,7 +148,7 @@ module Foobara
         end
 
         def load_aggregate(record)
-          load_aggregates([record]).first
+          load_aggregates([record])[0]
         end
 
         def track_unloaded_thunk(entity)

data/projects/entities/projects/persistence/src/entity_base/transaction_table/concerns/record_tracking.rb

@@ -16,9 +16,9 @@ module Foobara
 
             def loading(record)
               if loading?(record)
-                # :nocov:
+                # simplecov:disable
                 raise "Already loading #{record}"
-                # :nocov:
+                # simplecov:enable
               end
 
               begin
@@ -69,9 +69,9 @@ module Foobara
 
               # TODO: is this check redundant? Maybe have the entity explode directly instead?
               if hard_deleted?(record)
-                # :nocov:
+                # simplecov:disable
                 raise "Cannot update a hard deleted record"
-                # :nocov:
+                # simplecov:enable
               end
 
               unless created?(record)

data/projects/entities/projects/persistence/src/entity_base/transaction_table.rb

@@ -32,21 +32,21 @@ module Foobara
 
         def find_tracked(record_id)
           unless record_id
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Cannot use a blank primary key value"
-            # :nocov:
+            # simplecov:enable
           end
 
           if record_id.is_a?(::String) && record_id.empty?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Cannot use a blank primary key value"
-            # :nocov:
+            # simplecov:enable
           end
 
           if record_id.is_a?(::Symbol) && record_id.to_s.empty?
-            # :nocov:
+            # simplecov:disable
             raise ArgumentError, "Cannot use a blank primary key value"
-            # :nocov:
+            # simplecov:enable
           end
 
           tracked_records.find_by_key(record_id)
@@ -66,33 +66,33 @@ module Foobara
 
         def load(entity_or_record_id)
           if entity_or_record_id.nil?
-            # :nocov:
+            # simplecov:disable
             raise "Expected a record or record primary key but received nil"
-            # :nocov:
+            # simplecov:enable
           end
 
           if entity_or_record_id.is_a?(Entity)
             entity = if entity_or_record_id.persisted?
                        unless entity_or_record_id.primary_key
-                         # :nocov:
+                         # simplecov:disable
                          raise "Did not expect a record to be persisted but have no primary key"
-                         # :nocov:
+                         # simplecov:enable
                        end
 
                        tracked_records.find_by_key(entity_or_record_id.primary_key)
                      else
-                       # :nocov:
+                       # simplecov:disable
                        raise "Cannot load an unpersisted record!"
-                       # :nocov:
+                       # simplecov:enable
                      end
 
             # rubocop:disable Lint/IdentityComparison
             if entity &&
                (!entity.equal?(entity_or_record_id) || entity.object_id != entity_or_record_id.object_id)
-              # :nocov:
+              # simplecov:disable
               raise "This transaction is already tracking a different entity with the same primary key." \
                     "Try passing in the primary key instead of constructing an unloaded entity to pass in."
-              # :nocov:
+              # simplecov:enable
             end
             # rubocop:enable Lint/IdentityComparison
 
@@ -101,27 +101,27 @@ module Foobara
             record_id = entity_or_record_id
 
             if record_id.is_a?(::Hash)
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Unlikely that you meant to use a hash as a primary key"
-              # :nocov:
+              # simplecov:enable
             end
 
             unless record_id
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Cannot use a blank primary key value"
-              # :nocov:
+              # simplecov:enable
             end
 
             if record_id.is_a?(::String) && record_id.empty?
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Cannot use a blank primary key value"
-              # :nocov:
+              # simplecov:enable
             end
 
             if record_id.is_a?(::Symbol) && record_id.to_s.empty?
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Cannot use a blank primary key value"
-              # :nocov:
+              # simplecov:enable
             end
 
             entity = tracked_records.find_by_key(record_id)
@@ -136,9 +136,9 @@ module Foobara
               attributes = normalize_attributes(entity_attributes_crud_driver_table.find!(record_id))
 
               unless attributes
-                # :nocov:
+                # simplecov:disable
                 raise NoRecordFound, "could not find record for #{entity_class.full_entity_name}:#{record_id}"
-                # :nocov:
+                # simplecov:enable
               end
 
               entity.successfully_loaded(attributes)
@@ -147,9 +147,9 @@ module Foobara
             attributes = normalize_attributes(entity_attributes_crud_driver_table.find!(record_id))
 
             unless attributes
-              # :nocov:
+              # simplecov:disable
               raise NoRecordFound, "could not find record for #{entity_class.full_entity_name}:#{record_id}"
-              # :nocov:
+              # simplecov:enable
             end
 
             transaction.loaded(entity_class, attributes)
@@ -168,23 +168,23 @@ module Foobara
 
               entity = if entity_or_record_id.persisted?
                          unless entity_or_record_id.primary_key
-                           # :nocov:
+                           # simplecov:disable
                            raise "Did not expect a record to be persisted but have no primary key"
-                           # :nocov:
+                           # simplecov:enable
                          end
 
                          tracked_records.find_by_key(entity_or_record_id.primary_key)
                        else
-                         # :nocov:
+                         # simplecov:disable
                          raise "Cannot load an unpersisted record!"
-                         # :nocov:
+                         # simplecov:enable
                        end
 
               if entity && !entity.equal?(entity_or_record_id)
-                # :nocov:
+                # simplecov:disable
                 raise "This transaction is already tracking a different entity with the same primary key." \
                       "Try passing in the primary key instead of constructing an unloaded entity to pass in."
-                # :nocov:
+                # simplecov:enable
               end
 
               record_id = entity.primary_key
@@ -194,28 +194,28 @@ module Foobara
               record_id = entity_or_record_id
 
               if record_id.is_a?(::Hash)
-                # :nocov:
+                # simplecov:disable
                 raise ArgumentError, "Unlikely that you meant to use a hash as a primary key"
-                # :nocov:
+                # simplecov:enable
               end
 
               # TODO: encapsulate this record_id verification
               unless record_id
-                # :nocov:
+                # simplecov:disable
                 raise ArgumentError, "Cannot use a blank primary key value"
-                # :nocov:
+                # simplecov:enable
               end
 
               if record_id.is_a?(::String) && record_id.empty?
-                # :nocov:
+                # simplecov:disable
                 raise ArgumentError, "Cannot use a blank primary key value"
-                # :nocov:
+                # simplecov:enable
               end
 
               if record_id.is_a?(::Symbol) && record_id.to_s.empty?
-                # :nocov:
+                # simplecov:disable
                 raise ArgumentError, "Cannot use a blank primary key value"
-                # :nocov:
+                # simplecov:enable
               end
 
               entity = tracked_records.find_by_key(record_id)
@@ -323,9 +323,9 @@ module Foobara
                 # was already considered among tracked records if loaded? is true so do not return it as
                 # it has changed and no longer matches
                 # TODO: figure out how to test this code path
-                # :nocov:
+                # simplecov:disable
                 record = nil
-                # :nocov:
+                # simplecov:enable
               else
                 loading(record) do
                   record.successfully_loaded(found_attributes)
@@ -356,9 +356,9 @@ module Foobara
             when ::Array, Value::DataPath
               path_filters[attribute_name_or_path] = value
             else
-              # :nocov:
+              # simplecov:disable
               raise "Unexpected filter type: #{attribute_name_or_path.class}"
-              # :nocov:
+              # simplecov:enable
             end
           end
 
@@ -397,9 +397,9 @@ module Foobara
                   # was already considered among tracked records if loaded? is true so do not return it as
                   # it has changed and no longer matches
                   # TODO: figure out how to test this code path
-                  # :nocov:
+                  # simplecov:disable
                   record = nil
-                  # :nocov:
+                  # simplecov:enable
                 else
                   loading(record) do
                     record.successfully_loaded(found_attributes)
@@ -462,7 +462,7 @@ module Foobara
 
               if record
                 # TODO: test this code path
-                # :nocov:
+                # simplecov:disable
                 if record.loaded?
                   # was already considered among tracked records if loaded? is true so do not return it as
                   # it has changed and no longer matches
@@ -472,7 +472,7 @@ module Foobara
                     record.successfully_loaded(found_attributes)
                   end
                 end
-                # :nocov:
+                # simplecov:enable
               else
                 record = entity_class.loaded(found_attributes)
               end
@@ -526,7 +526,7 @@ module Foobara
 
               if record
                 # TODO: test this code path
-                # :nocov:
+                # simplecov:disable
                 if record.loaded?
                   # was already considered among tracked records if loaded? is true so do not return it as
                   # it has changed and no longer matches
@@ -536,7 +536,7 @@ module Foobara
                     record.successfully_loaded(found_attributes)
                   end
                 end
-                # :nocov:
+                # simplecov:enable
               else
                 record = entity_class.loaded(found_attributes)
               end
@@ -554,9 +554,9 @@ module Foobara
 
         def track_created(entity)
           if entity.persisted?
-            # :nocov:
+            # simplecov:disable
             raise "Cannot insert #{entity} because it's already persisted."
-            # :nocov:
+            # simplecov:enable
           end
 
           created(entity)

data/projects/entities/projects/persistence/src/entity_base.rb

@@ -10,7 +10,7 @@ module Foobara
           if existing_transactions.empty?
             block.call
           elsif existing_transactions.size == 1
-            existing_transaction = existing_transactions.first
+            existing_transaction = existing_transactions[0]
 
             existing_transaction.entity_base.using_transaction(existing_transaction, &block)
           else
@@ -127,9 +127,9 @@ module Foobara
 
       def transaction(mode = nil, existing_transaction: nil)
         unless VALID_MODES.include?(mode)
-          # :nocov:
+          # simplecov:disable
           raise ArgumentError, "Mode was #{mode} but expected one of #{VALID_MODES}"
-          # :nocov:
+          # simplecov:enable
         end
 
         old_transaction = current_transaction
@@ -151,16 +151,16 @@ module Foobara
             open_nested = true
           elsif mode == :open_new
             if existing_transaction
-              # :nocov:
+              # simplecov:disable
               raise ArgumentError, "Cannot use mode :open_new with existing_transaction:"
-              # :nocov:
+              # simplecov:enable
             end
           else
-            # :nocov:
+            # simplecov:disable
             raise "Transaction already open. " \
                   "Use mode :use_existing if you want to make use of the existing transaction. " \
                   "Use mode :open_nested if you are actually trying to nest transactions."
-            # :nocov:
+            # simplecov:enable
           end
         end