foobara 0.4.2 → 0.4.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 979ed0e27280b7f1183c77f8ca34eacaab8b232c719bf9f9ad4964ef309da64c
-  data.tar.gz: 819ad164acb49337551e91814f5faf3a78a825085c5b723d76fff701d4c1adcd
+  metadata.gz: 1bf3d5a0446977b9a62d890956d294cbe24761295f9f8c1c9ad6d4101a280532
+  data.tar.gz: 1d680e4acd71324924ffa28f75dc36d8c4f11b648dc1ff1d3c01b647d4e635c5
 SHA512:
-  metadata.gz: 488905b81c1b660af40b374cef9f34ebaf5548cae9202afdb2a90680abd78be9673a7b51de2431f1ce836b7815cf82ff1be245757e86da1ea0d4bcb4eed74294
-  data.tar.gz: 4a1d3377183c75ceea13be7d1501c686c97f9b6b29f76a01e9a9b9fa0e1addd18a0fdbef4bf6879e21f383aa3dc304d6ed2c1f9d1a3ac788be3db41ecc1793eb
+  metadata.gz: 7b76877ed83b42e1e625b04a5c3ede92e93627f772568524f3a9cec50868e0b44f8a06dadf4d65b882301866d82708a88827733f9e6da5f6b2f6833f18e0d5b7
+  data.tar.gz: d0f8710c28628a270409c5eb10ca4d71d07e8be9cf18b81d3319b12c5399cc6476cfca81c09ad83dcd774fcd11246a270ebf1149438eac89b6d5e0d57c9276ce

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+# [0.4.4] - 2026-01-20
+
+- Support authenticators that don't have relevant entity classes
+- Fix a bug where we don't look in the dependent domain for a model type to extend
+
+# [0.4.3] - 2026-01-19
+
+- Allow a request to handle auth mapper methods
+
 # [0.4.2] - 2026-01-15
 
 - Fix relaxed lookup bug for a symbol starting with a prefix

data/projects/command_connectors/spec/command_connector_spec.rb

@@ -2201,7 +2201,8 @@ RSpec.describe Foobara::CommandConnector do
         command_connector_b.connect(command_class, :auth)
         command_connector_c.connect(command_class, requires_authentication: true)
         command_connector_d.connect(command_class, requires_authentication: true)
-        command_connector_e.connect(command_class, requires_authentication: true, authenticator: [authenticator_e])
+        command_connector_e.connect(command_class, requires_authentication: true,
+                                                   authenticator: [authenticator_e])
 
         response = command_connector_a.run(full_command_name:, action:, inputs:)
         expect(response.status).to be(0)

data/projects/command_connectors/spec/request_spec.rb

@@ -92,4 +92,27 @@ RSpec.describe Foobara::CommandConnector::Request do
       end
     end
   end
+
+  context "with an auth-mapped method" do
+    let(:command_class) do
+      stub_class("SomeCommand", Foobara::Command) do
+        def self.requires_authentication = true
+      end
+    end
+
+    let(:request) do
+      foo_mapper = Foobara::TypeDeclarations::TypedTransformer.subclass(to: :symbol) { :bar }.instance
+      # TODO: make a block form of this
+      authenticator = Foobara::CommandConnector.to_authenticator(-> { :some_user })
+
+      described_class.new(authenticator:, auth_mappers: { foo: foo_mapper }).tap do |request|
+        request.command_class = command_class
+        request.authenticate
+      end
+    end
+
+    it "can access the auth-mapped method" do
+      expect(request.foo).to eq(:bar)
+    end
+  end
 end

data/projects/command_connectors/src/command_connector/request.rb

@@ -16,10 +16,12 @@ module Foobara
                     :action,
                     :response,
                     :authenticated_user,
-                    :authenticated_credential
+                    :authenticated_credential,
+                    :auth_mappers,
+                    :authenticator
 
       def initialize(**opts)
-        valid_keys = [:inputs, :full_command_name, :action, :serializers]
+        valid_keys = [:inputs, :full_command_name, :action, :serializers, :authenticator, :auth_mappers]
 
         invalid_keys = opts.keys - valid_keys
 
@@ -31,6 +33,8 @@ module Foobara
 
         self.inputs = opts[:inputs] if opts.key?(:inputs)
         self.action = opts[:action] if opts.key?(:action)
+        self.auth_mappers = opts[:auth_mappers] if opts.key?(:auth_mappers)
+        self.authenticator = opts[:authenticator] if opts.key?(:authenticator)
         self.full_command_name = opts[:full_command_name] if opts.key?(:full_command_name)
         self.serializers = Util.array(opts[:serializers]) if opts.key?(:serializers)
       end
@@ -59,15 +63,6 @@ module Foobara
         end
       end
 
-      def authenticator
-        command_class.authenticator
-      end
-
-      def auth_mappers
-        # TODO: make this consistent?
-        command_connector.auth_map
-      end
-
       def auth_mapped_method?(method_name)
         auth_mappers&.key?(method_name)
       end
@@ -88,6 +83,20 @@ module Foobara
         end
       end
 
+      def method_missing(method_name, ...)
+        if auth_mapped_method?(method_name)
+          auth_mapped_value_for(method_name)
+        else
+          # :nocov:
+          super
+          # :nocov:
+        end
+      end
+
+      def respond_to_missing?(method_name, private = false)
+        auth_mapped_method?(method_name) || super
+      end
+
       def serializer
         return @serializer if defined?(@serializer)
 
@@ -141,8 +150,12 @@ module Foobara
       # TODO: move this to entity_plumbing
       def relevant_entity_classes
         if command_class.is_a?(::Class) && command_class < TransformedCommand
-          entity_classes = authenticator&.relevant_entity_classes(self)
-          [*entity_classes, *relevant_entity_classes_from_inputs_transformer]
+          if authenticator.respond_to?(:relevant_entity_classes)
+            entity_classes = authenticator.relevant_entity_classes(self)
+            [*entity_classes, *relevant_entity_classes_from_inputs_transformer]
+          else
+            relevant_entity_classes_from_inputs_transformer
+          end
         end || EMPTY_ARRAY
       end
 

data/projects/command_connectors/src/command_connector.rb

@@ -206,6 +206,7 @@ module Foobara
 
       self.authenticator = authenticator
       self.command_registry = CommandRegistry.new(authenticator:)
+
       self.capture_unknown_error = capture_unknown_error
       self.name = name
 
@@ -556,7 +557,7 @@ module Foobara
 
     def build_request(...)
       self.class::Request.new(...).tap do |request|
-        # TODO: feels like a smell
+        # TODO: feels like a smell? Can we deprecate this somehow? Request no longer calls command_connector it seems...
         request.command_connector = self
       end
     end
@@ -566,6 +567,14 @@ module Foobara
       command_class = determine_command_class(request)
       request.command_class = command_class
 
+      if command_class.respond_to?(:requires_authentication) && command_class.requires_authentication
+        request.authenticator ||= command_class.authenticator || authenticator
+
+        if auth_map
+          request.auth_mappers ||= auth_map
+        end
+      end
+
       return build_response(request) unless command_class
 
       begin

data/projects/command_connectors/src/transformed_command.rb

@@ -540,7 +540,7 @@ module Foobara
             Value::Transformer.create(transform: transformer)
           else
             # :nocov:
-            raise "Not sure how to apply #{inputs_transformer}"
+            raise "Not sure how to apply #{transformer}"
             # :nocov:
           end
         end

data/projects/entities/projects/model/src/extensions/type_declarations/handlers/extend_registered_model_type_declaration/to_type_transformer.rb

@@ -16,8 +16,12 @@ module Foobara
 
           def declaration_to_type(strict_type_declaration)
             # TODO: cache this on a #base_type= helper
-            strict_type_declaration.type ||
-              lookup_type(strict_type_declaration[:type], mode: Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE)
+            type = strict_type_declaration.type
+            return type if type
+
+            type_symbol = strict_type_declaration[:type]
+
+            lookup_type(type_symbol, mode: Namespace::LookupMode::ABSOLUTE)
           end
         end
       end

data/projects/typesystem/projects/type_declarations/src/typed_transformer.rb

@@ -9,7 +9,14 @@ module Foobara
 
           klass.to(to) if to
           klass.from(from) if from
-          klass.define_method(:transform, &map_proc) if map_proc
+
+          if map_proc
+            if map_proc.arity.zero?
+              klass.define_method(:transform) { |_ignored| map_proc.call }
+            else
+              klass.define_method(:transform, &map_proc)
+            end
+          end
 
           klass
         end

data/projects/typesystem/projects/types/src/type/concerns/reflection.rb

@@ -11,6 +11,7 @@ module Foobara
 
             start = result.nil?
             result ||= Set.new
+
             return if result.include?(self)
 
             result << self

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.4.2".freeze
+    VERSION = "0.4.4".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.4
 platform: ruby
 authors:
 - Miles Georgi