foobara 0.4.1 → 0.4.3

data/projects/typesystem/projects/type_declarations/src/type_declaration.rb

@@ -38,19 +38,21 @@ module Foobara
     def handle_symbolic_declaration
       self.reference_checked = true
 
-      if declaration_data.is_a?(::Symbol)
-        symbol = declaration_data
-      elsif declaration_data.is_a?(::String) && TypeDeclarations.stringified?
-        symbol = declaration_data.to_sym
-      end
+      symbol = if declaration_data.is_a?(::Symbol)
+                 declaration_data
+               elsif declaration_data.is_a?(::String)
+                 declaration_data.to_sym
+               end
 
       if symbol
-        type = if absolutified?
-                 Domain.current.foobara_lookup_type(symbol, mode: Namespace::LookupMode::ABSOLUTE)
+        mode = if absolutified?
+                 Namespace::LookupMode::ABSOLUTE
                else
-                 Domain.current.foobara_lookup_type(symbol)
+                 Namespace::LookupMode::RELAXED
                end
 
+        type = Domain.current.foobara_lookup_type(symbol, mode:)
+
         if type
           unless strict?
             self.declaration_data = type.full_type_symbol
@@ -61,7 +63,6 @@ module Foobara
           self.is_strict = true
           self.is_deep_duped = true
           self.is_duped = true
-
         else
           if declaration_data.is_a?(::Symbol)
             self.is_duped = true
@@ -93,12 +94,14 @@ module Foobara
 
         if type_symbol
           if type_symbol.is_a?(::Symbol) || type_symbol.is_a?(::String)
-            type = if absolutified?
-                     Domain.current.foobara_lookup_type(type_symbol, mode: Namespace::LookupMode::ABSOLUTE)
+            mode = if absolutified?
+                     Namespace::LookupMode::ABSOLUTE
                    else
-                     Domain.current.foobara_lookup_type(type_symbol)
+                     Namespace::LookupMode::RELAXED
                    end
 
+            type = Domain.current.foobara_lookup_type(type_symbol, mode:)
+
             if type
               symbolize_keys!
               self[:type] = type.full_type_symbol

data/projects/typesystem/projects/type_declarations/src/typed_transformer.rb

@@ -1,8 +1,26 @@
 module Foobara
   module TypeDeclarations
     # TODO: this should instead be a processor and have its own possible_errors
+    # TODO: does it make sense that this is in this project? Seems to be more generic than TypeDeclarations
     class TypedTransformer < Value::Transformer
       class << self
+        def subclass(to: nil, from: nil, &map_proc)
+          klass = Class.new(self)
+
+          klass.to(to) if to
+          klass.from(from) if from
+
+          if map_proc
+            if map_proc.arity.zero?
+              klass.define_method(:transform) { |_ignored| map_proc.call }
+            else
+              klass.define_method(:transform, &map_proc)
+            end
+          end
+
+          klass
+        end
+
         def requires_declaration_data?
           false
         end
@@ -66,8 +84,8 @@ module Foobara
         @to_type = Domain.current.foobara_type_from_declaration(...)
       end
 
-      def initialize(from: nil, to: nil)
-        super()
+      def initialize(from: nil, to: nil, **)
+        super(**)
 
         if from
           self.from from

data/projects/typesystem/spec/common/data_path_spec.rb

@@ -1,5 +1,3 @@
-require "ostruct"
-
 RSpec.describe Foobara::DataPath do
   let(:key) { described_class.new(path) }
 
@@ -174,13 +172,14 @@ RSpec.describe Foobara::DataPath do
   end
 
   describe ".set_value_at" do
-    # rubocop:disable Style/OpenStructUse
+    let(:some_struct) { Struct.new(:z) }
+
     let(:object) do
       [
         {
           a: {
             b: [1, 2, { c: 4 }],
-            d: OpenStruct.new
+            d: some_struct.new("zz")
           }
         },
         "whatever"
@@ -198,7 +197,7 @@ RSpec.describe Foobara::DataPath do
             {
               a: {
                 b: [1, 2, { c: 100 }],
-                d: OpenStruct.new
+                d: some_struct.new("zz")
               }
             },
             "whatever"
@@ -235,7 +234,7 @@ RSpec.describe Foobara::DataPath do
             {
               a: {
                 b: [1, 100, { c: 4 }],
-                d: OpenStruct.new
+                d: some_struct.new("zz")
               }
             },
             "whatever"
@@ -257,7 +256,7 @@ RSpec.describe Foobara::DataPath do
             {
               a: {
                 b: [1, 2, { c: 4 }],
-                d: OpenStruct.new(z: 200)
+                d: some_struct.new(200)
               }
             },
             "whatever"
@@ -265,6 +264,5 @@ RSpec.describe Foobara::DataPath do
         )
       end
     end
-    # rubocop:enable Style/OpenStructUse
   end
 end

data/projects/typesystem/spec/spec_helper.rb

@@ -2,9 +2,11 @@ ENV["FOOBARA_ENV"] = "test"
 
 require "bundler/setup"
 
-unless ENV["SKIP_PRY"] == "true" || ENV["CI"] == "true"
+if ENV["RUBY_DEBUG"] == "true"
+  require "debug"
+elsif ENV["SKIP_PRY"] != "true" && ENV["CI"] != "true"
   require "pry"
-  require "pry-byebug"
+  require "pry-byebug" unless ENV["SKIP_BYEBUG"] == "true"
 end
 
 require "rspec/its"
@@ -16,7 +18,7 @@ SimpleCov.coverage_dir "coverage/typesystem"
 
 SimpleCov.start do
   add_filter "spec/support/"
-  # TODO: when we run rspec in the typesystem/ directory we sholud print this info out
+  # TODO: when we run rspec in the typesystem/ directory we should print this info out
   # This avoids printing out info about coverage generated by HTTPFormatter
   formatter Class.new { def format(_result) = nil }
 end

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.4.1".freeze
+    VERSION = "0.4.3".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.3
 platform: ruby
 authors:
 - Miles Georgi
@@ -106,6 +106,7 @@ files:
 - projects/command_connectors/Guardfile
 - projects/command_connectors/lib/foobara/command_connectors.rb
 - projects/command_connectors/spec/ambiguous_lookups_spec.rb
+- projects/command_connectors/spec/auth_mappers_spec.rb
 - projects/command_connectors/spec/command_connector_spec.rb
 - projects/command_connectors/spec/command_registry_spec.rb
 - projects/command_connectors/spec/commands/describe_spec.rb
@@ -257,7 +258,6 @@ files:
 - projects/entities/projects/model/src/extensions/builtin_types/model/casters/hash.rb
 - projects/entities/projects/model/src/extensions/builtin_types/model/supported_transformers/mutable.rb
 - projects/entities/projects/model/src/extensions/builtin_types/model/validators/model_instance_is_valid.rb
-- projects/entities/projects/model/src/extensions/domain/module_extension.rb
 - projects/entities/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration.rb
 - projects/entities/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/array_with_symbolic_elements.rb
 - projects/entities/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/attributes_handler_desugarizer.rb
@@ -327,6 +327,14 @@ files:
 - projects/entities/spec/support/rubyprof.rb
 - projects/entities/spec/support/term_trap.rb
 - projects/entities/spec/type_declarations/sensitive_type_removers_spec.rb
+- projects/entities_plumbing/Guardfile
+- projects/entities_plumbing/lib/foobara/entities_plumbing.rb
+- projects/entities_plumbing/spec/auth_mappers_spec.rb
+- projects/entities_plumbing/spec/spec_helper.rb
+- projects/entities_plumbing/spec/support/rubyprof.rb
+- projects/entities_plumbing/spec/support/term_trap.rb
+- projects/entities_plumbing/src/command_connectors_extension.rb
+- projects/entities_plumbing/src/extensions/authenticator.rb
 - projects/manifest/lib/foobara/manifest.rb
 - projects/manifest/spec/manifest_spec.rb
 - projects/manifest/spec/model_spec.rb
@@ -654,6 +662,7 @@ require_paths:
 - projects/command/lib
 - projects/command_connectors/lib
 - projects/domain_mapper/lib
+- projects/entities_plumbing/lib
 - projects/manifest/lib
 - projects/model_plumbing/lib
 required_ruby_version: !ruby/object:Gem::Requirement

data/projects/entities/projects/model/src/extensions/domain/module_extension.rb

@@ -1,20 +0,0 @@
-module Foobara
-  module Domain
-    module ModuleExtension
-      private
-
-      def foobara_set_types_mod_constant(types_mod, name, value)
-        new_value = if value.extends?(BuiltinTypes[:model])
-                      value.target_class
-                    else
-                      # TODO: test this path or delete it if unreachable
-                      # :nocov:
-                      value
-                      # :nocov:
-                    end
-
-        types_mod.const_set(name, new_value)
-      end
-    end
-  end
-end