foobara 0.2.6 → 0.2.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a3b6525afdbf01d8f0d56dce1f067430111781670ebac06dc4a90297e5fb1188
-  data.tar.gz: fc79448ff4613758061b9c6336855fed97b6328356d510b77eb438097d55c99d
+  metadata.gz: 4f5b2b0f1316a7d5530778566c64df6cffafb44dfdb99e5fd4797de2fbe3b0a2
+  data.tar.gz: 9819421a3b7dafcb39ac4d3dadb3b7a8ee2967648abf9adad4cc2fd094769bf3
 SHA512:
-  metadata.gz: 46d2df3884c269014f64a0b040d867e63bf65bd4c0822a4d810e07a506f296a2c6a967be2437542e7d6b56af8080094f1510da9d8143e94880428bd816bf32ad
-  data.tar.gz: 878e815dad1a261fa6bf9fc64525d06ea6cef4c499770fa6f621487a1fce011a2781750e53b75c40f8f8d1d3db57ef4cd17e4c542fba899c2474ca3576e239ab
+  metadata.gz: 388210bea30291de942b1b42b80c5105c31a8f74a039e33ac42700c85f8052e7f229390eb57214a15d7cda3ba76767fa4934cf8c8bb2dae187dbce22ee72a631
+  data.tar.gz: bfb8114f0b127c60389fa83d0d6145178a6b3e6e28418ec2a7faaf645c16ff31d5075688edcd6005ea33fb67e02a76155286dc0cc4a93b5ad710787b2d93ad4d

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# [0.2.7] - 2025-11-10
+
+- Fix CommandConnector authorization bug that can fail to close transactions
+
 # [0.2.6] - 2025-10-30
 
 - Add a set inputs transformer

data/projects/command_connectors/src/command_connector.rb

@@ -443,12 +443,10 @@ module Foobara
           end
         end
       ensure
-        request.use_transaction do
-          if (request.response || request).outcome&.success?
-            request.commit_transaction_if_open
-          else
-            request.rollback_transaction
-          end
+        if (request.response || request).outcome&.success?
+          request.commit_transaction_if_open
+        else
+          request.rollback_transaction
         end
       end
 

data/projects/command_connectors/src/serializers/atomic_serializer.rb

@@ -4,8 +4,11 @@ module Foobara
       # This seems to interpret "Atomic" as load the first entity you hit but not deeper entities.
       # Other interpretations it could have been:
       # 1) If top-level is an entity, load it and convert all nested entities to primary keys,
-      #   otherwise, convert all entities to primary keys
+      #    otherwise, convert all entities to primary keys
       # 2) Once past the first model, all entities are cast to primary keys
+      #
+      # However, in the typescript-remote-command-generator, the logic is a little different...
+      # There, AtomModelGenerator always uses primary keys for all entities.
       class AtomicSerializer < SuccessSerializer
         def serialize(object)
           case object

data/projects/detached_entity/lib/foobara/detached_entity.rb

@@ -13,6 +13,8 @@ module Foobara
 
         model = Namespace.global.foobara_lookup_type!(:model)
         BuiltinTypes.build_and_register!(:detached_entity, model, nil)
+
+        TypeDeclarations::RemoveSensitiveValuesTransformer.include(RemoveSensitiveValuesTransformerExtensions)
       end
 
       def reset_all

data/projects/detached_entity/src/remove_sensitive_values_transformer_extensions.rb

@@ -0,0 +1,64 @@
+module Foobara
+  class DetachedEntity < Model
+    module RemoveSensitiveValuesTransformerExtensions
+      def from(...)
+        super.tap do
+          create_all_association_types_in_current_namespace(from_type)
+        end
+      end
+
+      def to(...)
+        super.tap do
+          create_all_association_types_in_current_namespace(to_type)
+        end
+      end
+
+      def create_all_association_types_in_current_namespace(type)
+        already_sanitized = Set.new
+
+        associations = Foobara::DetachedEntity.construct_deep_associations(type)
+
+        associations&.values&.reverse&.each do |entity_type|
+          next if already_sanitized.include?(entity_type)
+
+          next if entity_type.sensitive?
+
+          unless entity_type.has_sensitive_types?
+            already_sanitized << entity_type
+            next
+          end
+
+          ns = Namespace.current
+
+          declaration = entity_type.declaration_data
+          sanitized_type_declaration = TypeDeclarations.remove_sensitive_types(declaration)
+
+          existing_type = ns.foobara_lookup(
+            entity_type.full_type_symbol,
+            mode: Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE
+          )
+
+          if existing_type
+            if existing_type.declaration_data == sanitized_type_declaration
+              already_sanitized << entity_type
+              already_sanitized << existing_type
+              next
+            else
+              # :nocov:
+              raise "Did not expect to be re-sanitizing #{entity_type.full_type_symbol}"
+              # :nocov:
+            end
+
+          end
+
+          # We want to make sure that any types that change due to having sensitive types
+          # has a corresponding registered type in the command registry domain if needed
+          # TODO: this all feels so messy and brittle.
+          Domain.current.foobara_type_from_declaration(sanitized_type_declaration)
+
+          already_sanitized << entity_type
+        end
+      end
+    end
+  end
+end

data/projects/domain/src/domain_module_extension.rb

@@ -310,27 +310,6 @@ module Foobara
           type
         end
 
-        def foobara_register_model(model_class)
-          type = model_class.model_type
-
-          full_name = type.scoped_full_name
-
-          if model_class.full_model_name.size > full_name.size
-            # TODO: why does this happen exactly??
-            full_name = model_class.full_model_name
-          end
-
-          if type.scoped_path_set? && foobara_registered?(full_name, mode: Namespace::LookupMode::DIRECT)
-            # :nocov:
-            raise AlreadyRegisteredError, "Already registered: #{type.inspect}"
-            # :nocov:
-          end
-
-          foobara_register(type)
-
-          type.target_class
-        end
-
         def foobara_register_and_deanonymize_entity(name, *, &)
           entity_class = foobara_register_entity(name, *, &)
           Foobara::Model.deanonymize_class(entity_class)

data/projects/model/src/concerns/types.rb

@@ -208,6 +208,7 @@ module Foobara
             delegates[attribute_name] = delegate_manifest
 
             delegated_type_declaration = model_type.type_at_path(data_path).reference_or_declaration_data
+            # TODO: add defaults and required for the delegated declaration!
             attributes(type: :attributes, element_type_declarations: { attribute_name => delegated_type_declaration })
 
             define_method attribute_name do

data/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/to_type_transformer.rb

@@ -118,7 +118,7 @@ module Foobara
 
                   model_class.description type.declaration_data[:description]
 
-                  domain.foobara_register_model(model_class)
+                  domain.foobara_register(type)
 
                   if type.declaration_data[:delegates]
                     model_class.delegate_attributes type.declaration_data[:delegates]

data/projects/persistence/src/entity_base/transaction/concerns/state_transitions.rb

@@ -7,8 +7,6 @@ module Foobara
 
         module Concerns
           module StateTransitions
-            foobara_delegate :close, to: :state_machine
-
             def currently_open?
               state_machine.currently_open?
             end

data/projects/persistence/src/entity_base.rb

@@ -188,6 +188,7 @@ module Foobara
           if tx.currently_open? && !existing_transaction
             tx.commit!
           end
+
           result
         rescue Foobara::Persistence::EntityBase::Transaction::RolledBack # rubocop:disable Lint/SuppressedException
         rescue => e

data/projects/type_declarations/lib/foobara/type_declarations.rb

@@ -46,8 +46,10 @@ module Foobara
           Namespace.global.foobara_register(scoped)
         end
 
+        children = Namespace.global.foobara_children
+
         @original_children.each do |child|
-          Namespace.global.foobara_children << child
+          children.foobara_children << child unless children.include?(child)
         end
 
         GlobalOrganization.foobara_register(GlobalDomain)

data/projects/type_declarations/src/remove_sensitive_values_transformer.rb

@@ -3,65 +3,6 @@ require_relative "typed_transformer"
 module Foobara
   module TypeDeclarations
     class RemoveSensitiveValuesTransformer < TypedTransformer
-      def from(...)
-        super.tap do
-          create_all_association_types_in_current_namespace(from_type)
-        end
-      end
-
-      def to(...)
-        super.tap do
-          create_all_association_types_in_current_namespace(to_type)
-        end
-      end
-
-      def create_all_association_types_in_current_namespace(type)
-        already_sanitized = Set.new
-
-        associations = Foobara::DetachedEntity.construct_deep_associations(type)
-
-        associations&.values&.reverse&.each do |entity_type|
-          next if already_sanitized.include?(entity_type)
-
-          next if entity_type.sensitive?
-
-          unless entity_type.has_sensitive_types?
-            already_sanitized << entity_type
-            next
-          end
-
-          ns = Namespace.current
-
-          declaration = entity_type.declaration_data
-          sanitized_type_declaration = TypeDeclarations.remove_sensitive_types(declaration)
-
-          existing_type = ns.foobara_lookup(
-            entity_type.full_type_symbol,
-            mode: Namespace::LookupMode::ABSOLUTE_SINGLE_NAMESPACE
-          )
-
-          if existing_type
-            if existing_type.declaration_data == sanitized_type_declaration
-              already_sanitized << entity_type
-              already_sanitized << existing_type
-              next
-            else
-              # :nocov:
-              raise "Did not expect to be re-sanitizing #{entity_type.full_type_symbol}"
-              # :nocov:
-            end
-
-          end
-
-          # We want to make sure that any types that change due to having sensitive types
-          # has a corresponding registered type in the command registry domain if needed
-          # TODO: this all feels so messy and brittle.
-          Domain.current.foobara_type_from_declaration(sanitized_type_declaration)
-
-          already_sanitized << entity_type
-        end
-      end
-
       def to_type_declaration
         TypeDeclarations.remove_sensitive_types(from_type.declaration_data)
       end

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.2.6".freeze
+    VERSION = "0.2.7".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 0.2.7
 platform: ruby
 authors:
 - Miles Georgi
@@ -274,6 +274,7 @@ files:
 - projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration/validate_primary_key_is_symbol.rb
 - projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration/validate_primary_key_present.rb
 - projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration/validate_primary_key_references_attribute.rb
+- projects/detached_entity/src/remove_sensitive_values_transformer_extensions.rb
 - projects/detached_entity/src/sensitive_type_removers/detached_entity.rb
 - projects/detached_entity/src/sensitive_value_removers/detached_entity.rb
 - projects/domain/lib/foobara/domain.rb