foobara 0.1.6 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b3eea1befe835410f5c6ecc372c5db94e3641f90711a773b0a7685a18afe677f
-  data.tar.gz: 7fe5e33084023a8d475e0fe491520a179d9123b5109c0ebc2ad52ed5643752bd
+  metadata.gz: c106dcffef98c13b230ca60f3433638583db9c1d6a9779995baa073cc1ddff00
+  data.tar.gz: 4159835c178cf602fd7fdedd20d5ed030f37dfb5721b6806847f12dbaa7379cd
 SHA512:
-  metadata.gz: 67bbdfab3b295bbe38f39d978f2855a239092f9feba4a417bbb853759dae9527dcbd0ba3a34647925f2b90fc15693c03ddb56a5d5e9247678c22c236deedba2c
-  data.tar.gz: bc09a9a484f9c1e6487a7ce112e33aabb5132b77071f195ed06cafb79895c070ee895be8e3cdd01abf75c4fc4eb54c51dd23d0bd4b22f7d1e0ef3b584c5874d7
+  metadata.gz: d352b2e66aa89e993a741da14506decbc13bcde49a71d23225349b409f8871aaf9216c4a6ec38e325adace318ef01a90b078b596bed15df39cc3422fd2b59dbf
+  data.tar.gz: 3bf9fd820cddfaf432c704df09797ce100084507b450df4de8d2bcc4c0294ca77f5009ba51d750a7fb66161108e953a323fa7482ef35b56e6139e1acc8d90948

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+# [0.1.7] - 2025-08-25
+
+- Go back to using :detached_entity for entities that have had sensitive types removed to
+  avoid casting problems with multiple entities with the same name
+- Remove private attributes as if they were sensitive attributes when exposing models
+
 # [0.1.6] - 2025-08-25
 
 - Allow constructing a thunk-like record when removing sensitive values from a thunk

data/projects/entity/src/sensitive_type_removers/entity.rb

@@ -7,14 +7,13 @@ module Foobara
 
           if strict_type_declaration != new_type_declaration
             if new_type_declaration[:type] == :entity
-              if Namespace.current.foobara_root_namespace == Namespace.global.foobara_root_namespace
-                # Nervous about creating two entities with the same name in the same namespace
-                # So going to create a detached entity instead
-                new_type_declaration[:type] = :detached_entity
+              # It's important that we don't create another entity with different attributes
+              # or various things like crud drivers or type transformers can become confused.
+              # So we will create it as a detached_entity instead.
+              new_type_declaration[:type] = :detached_entity
 
-                if new_type_declaration[:model_base_class] == "Foobara::Entity"
-                  new_type_declaration[:model_base_class] = "Foobara::DetachedEntity"
-                end
+              if new_type_declaration[:model_base_class] == "Foobara::Entity"
+                new_type_declaration[:model_base_class] = "Foobara::DetachedEntity"
               end
             end
           end

data/projects/entity/src/sensitive_value_removers/entity.rb

@@ -8,7 +8,7 @@ module Foobara
           elsif record.persisted?
             # We will assume that we do not need to clean up the primary key itself as
             # we will assume we don't allow sensitive primary keys for now.
-            thunkish = to_type.target_class.build(record.class.primary_key_attribute => record.primary_key)
+            thunkish = to_type.target_class.send(build_method, record.class.primary_key_attribute => record.primary_key)
             thunkish.skip_validations = true
             thunkish.mutable = false
             thunkish
@@ -20,7 +20,14 @@ module Foobara
         end
 
         def build_method
-          :build
+          if to_type.extends?(BuiltinTypes[:entity])
+            # TODO: figure out a way to test this path
+            # :nocov:
+            :build
+            # :nocov:
+          else
+            :new
+          end
         end
       end
     end

data/projects/types/src/type.rb

@@ -116,6 +116,12 @@ module Foobara
       def has_sensitive_types?
         return true if sensitive?
 
+        # TODO: this is a hack... come up with a better/separate way to detect types with private attributes
+        if declaration_data.is_a?(::Hash)
+          private = declaration_data[:private]
+          return true if private.is_a?(::Array) && !private.empty?
+        end
+
         if element_type
           return true if element_type.has_sensitive_types?
         end

data/version.rb

@@ -1,6 +1,6 @@
 module Foobara
   module Version
-    VERSION = "0.1.6".freeze
+    VERSION = "0.1.7".freeze
     MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.1.6
+  version: 0.1.7
 platform: ruby
 authors:
 - Miles Georgi