foobara 0.1.4 → 0.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5ff971dedd276b649d7ceb9b184734a47074357ab20b517b01a377bf7dfedfaa
-  data.tar.gz: a1b07c225fdddebd6dd859650db155a7e20aca66fe0647211d5daede966b305f
+  metadata.gz: c106dcffef98c13b230ca60f3433638583db9c1d6a9779995baa073cc1ddff00
+  data.tar.gz: 4159835c178cf602fd7fdedd20d5ed030f37dfb5721b6806847f12dbaa7379cd
 SHA512:
-  metadata.gz: 1d797ddc6c22d97617ffe9c1c951d66257f305dceedccaa5df80f0da3283a902a3c7acfd086dd4603957e3efa2a9f2b06a0851bb6cc420884839f79f19c70816
-  data.tar.gz: f57df9169e0da18ffc23d57e9fd8b2c5d218714938e4b37f1d4de1b19344774756915702d152b19ace97302b481df9bf6b9e4467db590b34f606cae2861cf44f
+  metadata.gz: d352b2e66aa89e993a741da14506decbc13bcde49a71d23225349b409f8871aaf9216c4a6ec38e325adace318ef01a90b078b596bed15df39cc3422fd2b59dbf
+  data.tar.gz: 3bf9fd820cddfaf432c704df09797ce100084507b450df4de8d2bcc4c0294ca77f5009ba51d750a7fb66161108e953a323fa7482ef35b56e6139e1acc8d90948

data/CHANGELOG.md

@@ -1,3 +1,19 @@
+# [0.1.7] - 2025-08-25
+
+- Go back to using :detached_entity for entities that have had sensitive types removed to
+  avoid casting problems with multiple entities with the same name
+- Remove private attributes as if they were sensitive attributes when exposing models
+
+# [0.1.6] - 2025-08-25
+
+- Allow constructing a thunk-like record when removing sensitive values from a thunk
+- Undo automatically converting connected entities to detached entities
+- Honor imported builtin types in manifest
+- Add Foobara version to manifest metadata
+- Add RootManifest#detached_entities
+- Remove some items from the manifest that should be safe to remove
+- Let's use GlobalDomain in the manifest for objects scoped to Foobara::Value
+
 # [0.1.4] - 2025-08-24
 
 - Fix TransformedCommand#foobara_manifest bug that failed to overwrite transformed possible_errors

data/projects/builtin_types/src/builtin_types.rb

@@ -5,7 +5,9 @@ module Foobara
 
   module BuiltinTypes
     class << self
-      foobara_delegate :global_type_declaration_handler_registry, to: TypeDeclarations
+      def global_type_declaration_handler_registry
+        TypeDeclarations.global_type_declaration_handler_registry
+      end
 
       # TODO: break this up
       # TODO: much of this behavior is helpful to non-builtin types as well.

data/projects/callback/src/registry/chained_conditioned.rb

@@ -6,7 +6,13 @@ module Foobara
       class ChainedConditioned < Conditioned
         attr_accessor :other_conditions_registry
 
-        foobara_delegate :possible_conditions, :possible_condition_keys, to: :other_conditions_registry
+        def possible_conditions
+          other_conditions_registry.possible_conditions
+        end
+
+        def possible_condition_keys
+          other_conditions_registry.possible_condition_keys
+        end
 
         def initialize(other_conditions_registry)
           self.other_conditions_registry = other_conditions_registry

data/projects/callback/src/registry/chained_multiple_action.rb

@@ -8,7 +8,13 @@ module Foobara
 
         class InvalidConditions < StandardError; end
 
-        foobara_delegate :possible_actions, :allowed_types, to: :other_multiple_actions_registry
+        def possible_actions
+          other_multiple_actions_registry.possible_actions
+        end
+
+        def allowed_types
+          other_multiple_actions_registry.allowed_types
+        end
 
         def initialize(other_multiple_actions_registry)
           self.other_multiple_actions_registry = other_multiple_actions_registry

data/projects/callback/src/registry/joined_conditioned.rb

@@ -6,7 +6,13 @@ module Foobara
       class JoinedConditioned < Conditioned
         attr_accessor :first, :second
 
-        foobara_delegate :possible_conditions, :possible_condition_keys, to: :first
+        def possible_conditions
+          first.possible_conditions
+        end
+
+        def possible_condition_keys
+          first.possible_condition_keys
+        end
 
         def initialize(first, second)
           self.first = first

data/projects/command/src/command_pattern_implementation/concerns/errors.rb

@@ -53,7 +53,9 @@ module Foobara
           super
         end
 
-        foobara_delegate :has_errors?, to: :error_collection
+        def has_errors?
+          error_collection.has_errors?
+        end
 
         private
 

data/projects/command/src/command_pattern_implementation/concerns/inputs_type.rb

@@ -61,7 +61,9 @@ module Foobara
           end
         end
 
-        foobara_delegate :inputs_type, to: :class
+        def inputs_type
+          self.class.inputs_type
+        end
       end
     end
   end

data/projects/command/src/command_pattern_implementation/concerns/result_type.rb

@@ -18,7 +18,9 @@ module Foobara
           end
         end
 
-        foobara_delegate :result_type, :raw_result_type_declaration, to: :class
+        def result_type
+          self.class.result_type
+        end
       end
     end
   end

data/projects/command_connectors/src/command_connector/commands/describe.rb

@@ -1,3 +1,5 @@
+require_relative "../../../../../version"
+
 module Foobara
   class CommandConnector
     module Commands
@@ -20,7 +22,7 @@ module Foobara
         end
 
         def stamp_request_metadata
-          manifest[:metadata] = { when: Time.now }
+          manifest[:metadata] = { when: Time.now, foobara_version: Foobara::Version::VERSION }
         end
       end
     end

data/projects/command_connectors/src/command_connector.rb

@@ -352,7 +352,9 @@ module Foobara
           args = args[1..]
           connected = []
 
-          registerable.foobara_each_command(mode: Namespace::LookupMode::DIRECT) do |command_class|
+          registerable = registerable.foobara_all_command(mode: Namespace::LookupMode::DIRECT)
+
+          registerable.each do |command_class|
             unless command_class.abstract?
               connected << connect(command_class, *args, **opts)
             end
@@ -567,29 +569,6 @@ module Foobara
                       additional_to_include << exposed_organization
                     end
                   end
-
-                  if o.extends_type?(BuiltinTypes[:entity])
-                    declaration_data = o.declaration_data
-
-                    if declaration_data.is_a?(::Hash) && declaration_data[:type] == :entity
-                      if o.foobara_root_namespace != command_registry.foobara_root_namespace
-                        # Let's swap it out with a detached type
-                        detached_entity = command_registry.foobara_lookup_type(o.scoped_full_name, mode:)
-
-                        unless detached_entity
-                          declaration_data = o.declaration_data.merge(
-                            type: :detached_entity,
-                            model_base_class: "Foobara::DetachedEntity"
-                          )
-
-                          detached_entity = exposed_domain.foobara_type_from_declaration(declaration_data)
-                        end
-
-                        additional_to_include << detached_entity
-                        next
-                      end
-                    end
-                  end
                 end
               end
 
@@ -637,7 +616,6 @@ module Foobara
       end
 
       h = normalize_manifest(h)
-
       patch_up_broken_parents_for_errors_with_missing_command_parents(h)
     end
 

data/projects/command_connectors/src/transformed_command.rb

@@ -61,10 +61,11 @@ module Foobara
         end
       end
 
-      foobara_delegate :description,
-                       :domain,
-                       :organization,
-                       to: :command_class
+      foobara_delegate :domain, :organization, to: :command_class
+
+      def description
+        command_class.description
+      end
 
       def result_transformers
         return @result_transformers if @considered_sensitive_value_remover
@@ -350,7 +351,7 @@ module Foobara
         response_mutators = processors_to_manifest_symbols(self.response_mutators)
         request_mutators = processors_to_manifest_symbols(self.request_mutators)
 
-        authenticator_details = if authenticator
+        authenticator_details = if requires_authentication && authenticator
                                   {
                                     symbol: authenticator.symbol,
                                     explanation: authenticator.explanation
@@ -395,16 +396,30 @@ module Foobara
 
         manifest = manifest.dup
 
+        # TODO: we should remove all blank valued keys but keeping many for now for stability
+        safe_to_remove = [
+          :pre_commit_transformers,
+          :response_mutators,
+          :request_mutators,
+          :capture_unknown_error,
+          :inputs_transformers,
+          :result_transformers,
+          :errors_transformers,
+          :requires_authentication,
+          :authenticator
+        ]
+
         to_merge.each_pair do |key, value|
           # TODO: we could probably remove empty strings and nils, too, and from the whole hash
-          # if (value.is_a?(::Hash) || value.is_a?(::Array)) && value.empty?
-          #   manifest.delete(key)
-          # else
-          #   manifest[key] = value
-          # end
-          # TODO: for now, just including everything for stability
-          # But we should remove all empty values in a future version
-          manifest[key] = value
+          if value.nil? || ((value.is_a?(::Hash) || value.is_a?(::Array)) && value.empty?)
+            if safe_to_remove.include?(key)
+              manifest.delete(key)
+            else
+              manifest[key] = value
+            end
+          else
+            manifest[key] = value
+          end
         end
 
         manifest

data/projects/command_connectors/src/transformers/entity_to_primary_key_inputs_transformer.rb

@@ -54,6 +54,7 @@ module Foobara
 
               description = "#{to_type.target_class.model_name} #{to_type.target_class.primary_key_attribute}"
 
+              # TODO: doesn't everything that extends :entity also extend :detached_entity?
               unless to_type.extends_directly?(Foobara::BuiltinTypes[:detached_entity]) ||
                      to_type.extends_directly?(Foobara::BuiltinTypes[:entity])
 

data/projects/common/src/outcome.rb

@@ -55,11 +55,15 @@ module Foobara
       end
     end
 
-    foobara_delegate :has_errors?,
-                     :has_error?,
-                     :add_error,
-                     :add_errors,
-                     to: :error_collection
+    foobara_delegate :has_error, :add_errors, to: :error_collection
+
+    def has_errors?
+      error_collection.has_errors?
+    end
+
+    def add_errors(...)
+      error_collection.add_errors(...)
+    end
 
     def errors
       error_collection

data/projects/detached_entity/src/concerns/associations.rb

@@ -157,13 +157,11 @@ module Foobara
             result = {},
             initial: true
           )
-            if initial && type.extends?(BuiltinTypes[:detached_entity])
-              return construct_associations(type.element_types, path, result, initial: false)
-            end
-
             remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
 
-            if type.extends?(BuiltinTypes[:entity])
+            if initial && type.extends?(BuiltinTypes[:detached_entity])
+              construct_associations(type.target_class.foobara_attributes_type, path, result, initial: false)
+            elsif type.extends?(BuiltinTypes[:entity])
               result[path.to_s] = type
             elsif type.extends?(BuiltinTypes[:tuple])
               element_types = type.element_types

data/projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration/to_type_transformer.rb

@@ -3,6 +3,7 @@ module Foobara
     module Handlers
       class ExtendDetachedEntityTypeDeclaration < ExtendModelTypeDeclaration
         class ToTypeTransformer < ExtendModelTypeDeclaration::ToTypeTransformer
+          # TODO: use constants for these arrays for performance reasons
           def non_processor_keys
             [:primary_key, *super]
           end

data/projects/entity/src/concerns/callbacks.rb

@@ -35,7 +35,9 @@ module Foobara
           end
         end
 
-        foobara_delegate :register_callback, to: :callback_registry
+        def register_callback(...)
+          callback_registry.register_callback(...)
+        end
 
         module ClassMethods
           def class_callback_registry
@@ -68,7 +70,13 @@ module Foobara
             end
           end
 
-          foobara_delegate :register_callback, :possible_actions, to: :class_callback_registry
+          def register_callback(...)
+            class_callback_registry.register_callback(...)
+          end
+
+          def possible_actions
+            class_callback_registry.possible_actions
+          end
         end
 
         on_include do

data/projects/entity/src/extensions/builtin_types/entity/validators/model_instance_is_valid.rb

@@ -4,7 +4,7 @@ module Foobara
       module Validators
         class ModelInstanceIsValid < DetachedEntity::Validators::ModelInstanceIsValid
           def applicable?(record)
-            record && (record.created? || record.built?)
+            record && (record.created? || record.built?) && !record.skip_validations
           end
 
           def expected_type_symbol

data/projects/entity/src/sensitive_type_removers/entity.rb

@@ -7,6 +7,9 @@ module Foobara
 
           if strict_type_declaration != new_type_declaration
             if new_type_declaration[:type] == :entity
+              # It's important that we don't create another entity with different attributes
+              # or various things like crud drivers or type transformers can become confused.
+              # So we will create it as a detached_entity instead.
               new_type_declaration[:type] = :detached_entity
 
               if new_type_declaration[:model_base_class] == "Foobara::Entity"

data/projects/entity/src/sensitive_value_removers/entity.rb

@@ -8,11 +8,10 @@ module Foobara
           elsif record.persisted?
             # We will assume that we do not need to clean up the primary key itself as
             # we will assume we don't allow sensitive primary keys for now.
-            # We use .new because the target_class should be a detached entity
-            to_type.target_class.new(
-              { record.class.primary_key_attribute => record.primary_key },
-              { mutable: false, skip_validations: true }
-            )
+            thunkish = to_type.target_class.send(build_method, record.class.primary_key_attribute => record.primary_key)
+            thunkish.skip_validations = true
+            thunkish.mutable = false
+            thunkish
           else
             # :nocov:
             raise "Not sure what to do with a record that isn't loaded, created, or persisted"
@@ -21,8 +20,8 @@ module Foobara
         end
 
         def build_method
-          if to_type.extends_type?(BuiltinTypes[:entity])
-            # TODO: test this code path
+          if to_type.extends?(BuiltinTypes[:entity])
+            # TODO: figure out a way to test this path
             # :nocov:
             :build
             # :nocov:

data/projects/manifest/src/foobara/manifest/organization.rb

@@ -21,6 +21,10 @@ module Foobara
         domains.map(&:types).flatten
       end
 
+      def detached_entities
+        domains.map(&:detached_entities).flatten
+      end
+
       def entities
         domains.map(&:entities).flatten
       end

data/projects/manifest/src/foobara/manifest/root_manifest.rb

@@ -31,6 +31,10 @@ module Foobara
         end
       end
 
+      def detached_entities
+        organizations.map(&:detached_entities).flatten
+      end
+
       def entities
         organizations.map(&:entities).flatten
       end

data/projects/manifest/src/foobara/manifest/type.rb

@@ -72,7 +72,7 @@ module Foobara
 
       # TODO: replace this with primitive?
       def builtin?
-        BuiltinTypes.builtin_reference?(reference)
+        BuiltinTypes.builtin_reference?(reference) || self[:builtin]
       end
 
       def primitive?

data/projects/persistence/src/entity_base/transaction/concerns/state_transitions.rb

@@ -7,7 +7,11 @@ module Foobara
 
         module Concerns
           module StateTransitions
-            foobara_delegate :close!, :currently_open?, to: :state_machine
+            foobara_delegate :close, to: :state_machine
+
+            def currently_open?
+              state_machine.currently_open?
+            end
 
             def open!
               state_machine.open! do

data/projects/persistence/src/entity_base/transaction.rb

@@ -14,7 +14,9 @@ module Foobara
           self.tables = {}
         end
 
-        foobara_delegate :entity_attributes_crud_driver, to: :entity_base
+        def entity_attributes_crud_driver
+          entity_base.entity_attributes_crud_driver
+        end
 
         def create(entity_class, attributes = {})
           Persistence.to_base(entity_class).transaction(existing_transaction: self) do

data/projects/types/src/type.rb

@@ -116,6 +116,12 @@ module Foobara
       def has_sensitive_types?
         return true if sensitive?
 
+        # TODO: this is a hack... come up with a better/separate way to detect types with private attributes
+        if declaration_data.is_a?(::Hash)
+          private = declaration_data[:private]
+          return true if private.is_a?(::Array) && !private.empty?
+        end
+
         if element_type
           return true if element_type.has_sensitive_types?
         end

data/version.rb

@@ -0,0 +1,6 @@
+module Foobara
+  module Version
+    VERSION = "0.1.7".freeze
+    MINIMUM_RUBY_VERSION = ">= 3.4.0".freeze
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.7
 platform: ruby
 authors:
 - Miles Georgi
@@ -491,6 +491,7 @@ files:
 - projects/value/src/validator.rb
 - projects/weak_object_set/lib/foobara/weak_object_set.rb
 - projects/weak_object_set/src/weak_object_set.rb
+- version.rb
 homepage: https://foobara.com
 licenses:
 - MPL-2.0