foobara 0.1.2 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 772c1b159a33ecf7e3f63a1a2a70d8574d986be541bf3ac88cd00a87c8fc8036
-  data.tar.gz: 94ccbde2bafcb9860d7275083659cd8f62f76f8d7bc27b03fcfa2d63e3e085ff
+  metadata.gz: 5ff971dedd276b649d7ceb9b184734a47074357ab20b517b01a377bf7dfedfaa
+  data.tar.gz: a1b07c225fdddebd6dd859650db155a7e20aca66fe0647211d5daede966b305f
 SHA512:
-  metadata.gz: a78ea31d30819836a421d49413f2ce379262dac03bf2cc4db2d779c74cc98ea4580f48bd7b472e5d473e3edf269f31af17927adc0248f1ecd7436127585b4e21
-  data.tar.gz: cf07fcd19587a5820afb06f4cba5d783f2f340f552f64fdb8a577bd5794f139e513828ddb97a8263f41c1d31c104b1d34bb1dfec751da3aa0da43d75c78d660d
+  metadata.gz: 1d797ddc6c22d97617ffe9c1c951d66257f305dceedccaa5df80f0da3283a902a3c7acfd086dd4603957e3efa2a9f2b06a0851bb6cc420884839f79f19c70816
+  data.tar.gz: f57df9169e0da18ffc23d57e9fd8b2c5d218714938e4b37f1d4de1b19344774756915702d152b19ace97302b481df9bf6b9e4467db590b34f606cae2861cf44f

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+# [0.1.4] - 2025-08-24
+
+- Fix TransformedCommand#foobara_manifest bug that failed to overwrite transformed possible_errors
+  if the new possible errors is empty
+- Make sure we set nil inputs_type in TransformedCommand#foobara_manifest to empty attributes
+  for compatibility with other projects
+- Sets the parent for various Foobara::Value children to be GlobalDomain in manifests
+
+# [0.1.3] - 2025-08-24
+
+- Add Command#abstract and exclude abstract commands from CommandConnector#connect when connecting domains/orgs
+
 # [0.1.2] - 2025-08-24
 
 - Exclude processor/processor_class categories from manifest by default

data/projects/command/src/command_pattern_implementation/concerns/namespace.rb

@@ -9,6 +9,14 @@ module Foobara
         end
 
         module ClassMethods
+          def abstract
+            @abstract = true
+          end
+
+          def abstract?
+            @abstract
+          end
+
           def type_for_declaration(...)
             domain.foobara_type_from_declaration(...)
           end

data/projects/command_connectors/src/command_connector.rb

@@ -344,13 +344,21 @@ module Foobara
         command_registry.register(*args, **opts)
       when Module
         if registerable.foobara_organization?
+          args = args[1..]
           registerable.foobara_domains.map do |domain|
-            connect(domain, *args[1..], **opts)
+            connect(domain, *args, **opts)
           end.flatten
         elsif registerable.foobara_domain?
-          registerable.foobara_all_command(mode: Namespace::LookupMode::DIRECT).map do |command_class|
-            Util.array(connect(command_class, *args[1..], **opts))
-          end.flatten
+          args = args[1..]
+          connected = []
+
+          registerable.foobara_each_command(mode: Namespace::LookupMode::DIRECT) do |command_class|
+            unless command_class.abstract?
+              connected << connect(command_class, *args, **opts)
+            end
+          end
+
+          connected.flatten
         else
           # :nocov:
           raise "Don't know how to register #{registerable} (#{registerable.class})"

data/projects/command_connectors/src/transformed_command.rb

@@ -369,27 +369,45 @@ module Foobara
           command_class.foobara_manifest
         end
 
+        # TODO: This should support nil as an inputs_type but it breaks other projects for now
+        inputs_type = inputs_type_for_manifest&.reference_or_declaration_data ||
+                      { type: :attributes, element_type_declarations: {} }
+
         # TODO: handle errors_types_depended_on!
-        manifest.merge(
-          Util.remove_blank(
-            inputs_types_depended_on:,
-            result_types_depended_on:,
-            types_depended_on: types,
-            inputs_type: inputs_type_for_manifest&.reference_or_declaration_data,
-            result_type: result_type&.reference_or_declaration_data,
-            possible_errors: possible_errors_manifest,
-            capture_unknown_error:,
-            inputs_transformers:,
-            result_transformers:,
-            errors_transformers:,
-            pre_commit_transformers:,
-            serializers:,
-            response_mutators:,
-            request_mutators:,
-            requires_authentication:,
-            authenticator: authenticator_details
-          )
-        )
+        to_merge = {
+          inputs_types_depended_on:,
+          result_types_depended_on:,
+          types_depended_on: types,
+          inputs_type:,
+          result_type: result_type&.reference_or_declaration_data,
+          possible_errors: possible_errors_manifest,
+          capture_unknown_error:,
+          inputs_transformers:,
+          result_transformers:,
+          errors_transformers:,
+          pre_commit_transformers:,
+          serializers:,
+          response_mutators:,
+          request_mutators:,
+          requires_authentication:,
+          authenticator: authenticator_details
+        }
+
+        manifest = manifest.dup
+
+        to_merge.each_pair do |key, value|
+          # TODO: we could probably remove empty strings and nils, too, and from the whole hash
+          # if (value.is_a?(::Hash) || value.is_a?(::Array)) && value.empty?
+          #   manifest.delete(key)
+          # else
+          #   manifest[key] = value
+          # end
+          # TODO: for now, just including everything for stability
+          # But we should remove all empty values in a future version
+          manifest[key] = value
+        end
+
+        manifest
       end
 
       def processors_to_manifest_symbols(processors)

data/projects/domain/src/is_manifestable.rb

@@ -63,16 +63,26 @@ module Foobara
 
         if parent_category
           if include_processors || (parent_category != :processor && parent_category != :processor_class)
-            if candidate != Foobara::Value
-              parent = candidate
-              break
-            end
+            parent = if candidate == Foobara::Value
+                       GlobalDomain
+                     else
+                       candidate
+                     end
+            break
           end
         end
 
         candidate = candidate.scoped_namespace
       end
 
+      if parent == GlobalDomain
+        h[:scoped_path] = scoped_full_path
+        h[:scoped_name] = scoped_full_name
+        h[:scoped_prefix] = scoped_full_path[..-2]
+        h[:domain] = parent.foobara_manifest_reference
+        h[:organization] = parent.foobara_organization.foobara_manifest_reference
+      end
+
       if parent
         to_include << parent
         h[:parent] = [parent_category, parent.foobara_manifest_reference]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.4
 platform: ruby
 authors:
 - Miles Georgi
@@ -538,7 +538,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.7.1
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A command-centric and discoverable software framework with a focus on domain
   concepts and abstracting away integration code