foobara 0.0.94 → 0.0.95

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 481928c28115c1b97adee6f5caa284b559ca954ee57f337bbb456ab80972b4eb
-  data.tar.gz: 2d083d6fb702f82dd920e4de4a7ac9bc6e82dd3fa87d874cb89f49d495d4b780
+  metadata.gz: 10cd2a997729a02fc1b6f3ea24a4694a7ec3a0e5908eb3fd37f2f90fd7e56c71
+  data.tar.gz: 2568a8ffbc4885f8a1edc70c4a7f41582631b0e8f55e6ff6100166814d579a8e
 SHA512:
-  metadata.gz: 2c9a25149a21e5d8aa851e4a8776f5f3d8a3e44635598544a4d9da2e8e9709ec61c812e286ecedacd6376e7a928c94993567a5dd00d0c67d829d4f6a4d9848f6
-  data.tar.gz: 9561f972da6f0c94e40adc04d23ef33e7eea856b045248c4e04f057365543eaf82b6810592221e64e1ecb9e3a31530edb2f7beefa2ab3845a117197bd0b6c6af
+  metadata.gz: d41fffe3ecdb08e1c6366ce4bf58cf7733bebcf595f16745ef6b3cd3a1ddfa67a19934934b73aff8e225e03205c73ade43b5ee92d429ba9f1a3d832de1856667
+  data.tar.gz: 61dba1a73fb5cb3399b68f2a8f00586f79268495106393b3083beb505d6fecd5c896dfb74beec941e3e4d8c8521e212bc6f499889c68f28c37b56c91c10c4260

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# [0.0.95] - 2025-04-07
+
+- Split up #run and #build_request_and_command in CommandConnector to help subclasses
+
 # [0.0.94] - 2025-04-07
 
 - Support capture_unknown_errors at the command connector level

data/projects/command_connectors/src/command_connector/request.rb

@@ -7,6 +7,7 @@ module Foobara
       attr_accessor :command,
                     :error,
                     :command_connector,
+                    # Why aren't there serializers on the response?
                     :serializers,
                     :inputs,
                     :full_command_name,
@@ -15,7 +16,7 @@ module Foobara
       attr_reader :command_class
 
       def initialize(**opts)
-        valid_keys = %i[inputs full_command_name action]
+        valid_keys = %i[inputs full_command_name action serializers]
 
         invalid_keys = opts.keys - valid_keys
 
@@ -28,6 +29,7 @@ module Foobara
         self.inputs = opts[:inputs] if opts.key?(:inputs)
         self.action = opts[:action] if opts.key?(:action)
         self.full_command_name = opts[:full_command_name] if opts.key?(:full_command_name)
+        self.serializers = Util.array(opts[:serializers]) if opts.key?(:serializers)
       end
 
       def command_class=(klass)

data/projects/command_connectors/src/command_connector.rb

@@ -325,17 +325,23 @@ module Foobara
     end
 
     def build_request(...)
-      self.class::Request.new(...)
+      self.class::Request.new(...).tap do |request|
+        # TODO: feels like a smell
+        request.command_connector = self
+      end
     end
 
     # TODO: maybe introduce a Runner interface?
-    def run(*, **)
+    def run(...)
       process_delayed_connections
 
-      request, command = build_request_and_command(*, **)
+      request = build_request(...)
+
+      run_request(request)
+    end
 
-      # TODO: feels like a smell
-      request.command_connector = self
+    def run_request(request)
+      command = build_command(request)
 
       if command.respond_to?(:requires_authentication?) && command.requires_authentication?
         authenticate(request)
@@ -379,15 +385,13 @@ module Foobara
       end
     end
 
-    def build_request_and_command(...)
-      request = build_request(...)
-
+    def build_command(request)
       unless request.error
         command = request_to_command(request)
         request.command = command
       end
 
-      [request, command]
+      command
     end
 
     def build_response(request)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.94
+  version: 0.0.95
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-04-07 00:00:00.000000000 Z
+date: 2025-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal