foobara 0.0.93 → 0.0.95

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 447d11c02182fce4303fe2db74bbc322e0589d51161756496b2c5d8390a26eab
-  data.tar.gz: 3a1ce551119b74488a5fe9fc86651ab914eec93f87f1d806da8f4b58135d8de7
+  metadata.gz: 10cd2a997729a02fc1b6f3ea24a4694a7ec3a0e5908eb3fd37f2f90fd7e56c71
+  data.tar.gz: 2568a8ffbc4885f8a1edc70c4a7f41582631b0e8f55e6ff6100166814d579a8e
 SHA512:
-  metadata.gz: cf4413d689bef2063e5a43d8c88cc8f70b3d6158f722419fb613ee4a2c13560d8fff23addd5cc34d4f18ad7c6437435d5382f205b6aa53904888354e6cb0de04
-  data.tar.gz: 761d8e8de14d04d5ca8c2916c23ead8cc261ca8b641584083ef2cb25e9fc9a621515be5a5524d41c97b0a867d829ae8b8cd802b6935b152b9ae8ef55ec9c6944
+  metadata.gz: d41fffe3ecdb08e1c6366ce4bf58cf7733bebcf595f16745ef6b3cd3a1ddfa67a19934934b73aff8e225e03205c73ade43b5ee92d429ba9f1a3d832de1856667
+  data.tar.gz: 61dba1a73fb5cb3399b68f2a8f00586f79268495106393b3083beb505d6fecd5c896dfb74beec941e3e4d8c8521e212bc6f499889c68f28c37b56c91c10c4260

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+# [0.0.95] - 2025-04-07
+
+- Split up #run and #build_request_and_command in CommandConnector to help subclasses
+
+# [0.0.94] - 2025-04-07
+
+- Support capture_unknown_errors at the command connector level
+
 # [0.0.93] - 2025-04-06
 
 - Add delegated attributes to models

data/projects/command_connectors/src/command_connector/request.rb

@@ -7,6 +7,7 @@ module Foobara
       attr_accessor :command,
                     :error,
                     :command_connector,
+                    # Why aren't there serializers on the response?
                     :serializers,
                     :inputs,
                     :full_command_name,
@@ -15,7 +16,7 @@ module Foobara
       attr_reader :command_class
 
       def initialize(**opts)
-        valid_keys = %i[inputs full_command_name action]
+        valid_keys = %i[inputs full_command_name action serializers]
 
         invalid_keys = opts.keys - valid_keys
 
@@ -28,6 +29,7 @@ module Foobara
         self.inputs = opts[:inputs] if opts.key?(:inputs)
         self.action = opts[:action] if opts.key?(:action)
         self.full_command_name = opts[:full_command_name] if opts.key?(:full_command_name)
+        self.serializers = Util.array(opts[:serializers]) if opts.key?(:serializers)
       end
 
       def command_class=(klass)
@@ -74,7 +76,13 @@ module Foobara
       end
 
       def outcome
-        command.outcome
+        outcome = command&.outcome
+
+        if outcome
+          outcome
+        elsif error
+          Outcome.error(error)
+        end
       end
 
       def result

data/projects/command_connectors/src/command_connector/response.rb

@@ -11,7 +11,13 @@ module Foobara
         self.body = body
       end
 
-      foobara_delegate :command, :error, to: :request
+      def command
+        request.command
+      end
+
+      def success?
+        request.success?
+      end
     end
   end
 end

data/projects/command_connectors/src/command_connector.rb

@@ -86,6 +86,18 @@ module Foobara
       end
     end
 
+    attr_accessor :command_registry, :authenticator, :capture_unknown_error
+
+    def initialize(authenticator: nil, capture_unknown_error: nil, default_serializers: nil)
+      self.command_registry = CommandRegistry.new(authenticator:)
+      self.authenticator = authenticator
+      self.capture_unknown_error = capture_unknown_error
+
+      Util.array(default_serializers).each do |serializer|
+        add_default_serializer(serializer)
+      end
+    end
+
     def find_builtin_command_class(command_class_name)
       self.class.find_builtin_command_class(command_class_name)
     end
@@ -104,8 +116,6 @@ module Foobara
                      :all_transformed_command_classes,
                      to: :command_registry
 
-    attr_accessor :command_registry, :authenticator
-
     def lookup_command(name)
       command_registry.foobara_lookup_command(name)
     end
@@ -237,13 +247,11 @@ module Foobara
     end
 
     def set_response_status(response)
-      outcome = response.request.outcome
-      response.status = outcome.success? ? 0 : 1
+      response.status = response.success? ? 0 : 1
     end
 
     def set_response_body(response)
       outcome = response.request.outcome
-      # response.body = outcome.success? ? outcome.result : outcome.error_collection
       response.body = outcome.success? ? outcome.result : outcome.error_collection
     end
 
@@ -263,15 +271,6 @@ module Foobara
       end
     end
 
-    def initialize(authenticator: nil, default_serializers: nil)
-      self.command_registry = CommandRegistry.new(authenticator:)
-      self.authenticator = authenticator
-
-      Util.array(default_serializers).each do |serializer|
-        add_default_serializer(serializer)
-      end
-    end
-
     def connect_delayed(registerable_name, *args, **opts)
       delayed_connections[registerable_name] = { args:, opts: }
     end
@@ -326,24 +325,30 @@ module Foobara
     end
 
     def build_request(...)
-      self.class::Request.new(...)
+      self.class::Request.new(...).tap do |request|
+        # TODO: feels like a smell
+        request.command_connector = self
+      end
     end
 
     # TODO: maybe introduce a Runner interface?
-    def run(*, **)
+    def run(...)
       process_delayed_connections
 
-      request, command = build_request_and_command(*, **)
+      request = build_request(...)
+
+      run_request(request)
+    end
 
-      # TODO: feels like a smell
-      request.command_connector = self
+    def run_request(request)
+      command = build_command(request)
 
       if command.respond_to?(:requires_authentication?) && command.requires_authentication?
         authenticate(request)
       end
 
       if command
-        command.run
+        run_command(request)
         # :nocov:
       elsif !request.error
         raise "No command returned from #request_to_command"
@@ -353,6 +358,16 @@ module Foobara
       build_response(request)
     end
 
+    def run_command(request)
+      request.command.run
+    rescue => e
+      if capture_unknown_error
+        request.error = CommandConnector::UnknownError.new(e)
+      else
+        raise
+      end
+    end
+
     def authenticate(request)
       request_command = request.command
 
@@ -370,15 +385,13 @@ module Foobara
       end
     end
 
-    def build_request_and_command(...)
-      request = build_request(...)
-
+    def build_command(request)
       unless request.error
         command = request_to_command(request)
         request.command = command
       end
 
-      [request, command]
+      command
     end
 
     def build_response(request)

data/projects/command_connectors/src/command_registry/exposed_command.rb

@@ -113,6 +113,7 @@ module Foobara
       def transformed_command_class
         @transformed_command_class ||= if Util.all_blank_or_false?(
           [
+            capture_unknown_error,
             inputs_transformers,
             result_transformers,
             errors_transformers,

data/projects/command_connectors/src/serializers/errors_serializer.rb

@@ -4,8 +4,10 @@ module Foobara
   module CommandConnectors
     module Serializers
       class ErrorsSerializer < Serializer
-        def always_applicable?
-          !request.outcome.success?
+        def applicable?(error_collection)
+          if request.outcome.nil? || !request.outcome.success?
+            error_collection.has_errors?
+          end
         end
 
         def serialize(error_collection)

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.93
+  version: 0.0.95
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-04-06 00:00:00.000000000 Z
+date: 2025-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -487,7 +487,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.6
+rubygems_version: 3.6.2
 specification_version: 4
 summary: A command-centric and discoverable software framework with a focus on domain
   concepts and abstracting away integration code