foobara 0.0.91 → 0.0.93

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: afa85ac4f9b3b8a144859108c7d4273fc290449bcf831cc6a3ff6c9445530f10
-  data.tar.gz: 918c40b8fd082cc4982d984716b7f7e0fbaac6f2110d445bc248d4985dfa2726
+  metadata.gz: 447d11c02182fce4303fe2db74bbc322e0589d51161756496b2c5d8390a26eab
+  data.tar.gz: 3a1ce551119b74488a5fe9fc86651ab914eec93f87f1d806da8f4b58135d8de7
 SHA512:
-  metadata.gz: 2aca63aa3477913c4289896d64b62a53065951da6d7c24982fa7ec8569a97bfc490320ffa002a1f219b97ee205dc2230bd3c5a66def92932da42df133a600ced
-  data.tar.gz: 26546b93d55db31c3c88a322dcc1cd472ab2be4392b8410f1a1206a25f060f86b3be2db2628d2cf3897c0b461844acff52bd063a299ab917c0c05c22119cb4ac
+  metadata.gz: cf4413d689bef2063e5a43d8c88cc8f70b3d6158f722419fb613ee4a2c13560d8fff23addd5cc34d4f18ad7c6437435d5382f205b6aa53904888354e6cb0de04
+  data.tar.gz: 761d8e8de14d04d5ca8c2916c23ead8cc261ca8b641584083ef2cb25e9fc9a621515be5a5524d41c97b0a867d829ae8b8cd802b6935b152b9ae8ef55ec9c6944

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+# [0.0.93] - 2025-04-06
+
+- Add delegated attributes to models
+- Add private attributes to models
+- Pass manifest construction context through thread_parent instead of passing it everywhere
+- Various namespace lookup bugfixes
+- Various bugfixes for .find_all/many type of methods in both Model and crud drivers
+
+# [0.0.92] - 2025-04-01
+
+- Improve error call stacks in calls like #run!
+- Fix bug preventing first call to CommandConnector#foobara_manifest from returning all its domains
+
 # [0.0.91] - 2025-03-31
 
 - Fix bug that was including removed types in command manifest's inputs_types_depended_on
@@ -16,7 +29,7 @@
 - Implement response mutator concept
 - Break up #request_to_response for easier overriding/extension
 - Add AttributesTransformers::Reject
-- Fix problem causing downcase/regex processors to explode on allows_nil types
+- Fix problem causing downcase/regex processors to explode on allow_nil types
 
 # [0.0.87] - 2025-03-26
 
@@ -271,7 +284,7 @@
 
 ## [0.0.13] - 2024-11-13
 
-- Do not fail :one_of if it is nil and :allows_nil
+- Do not fail :one_of if it is nil and :allow_nil
 
 ## [0.0.12] - 2024-10-30
 

data/projects/builtin_types/src/email/validator_base.rb

@@ -73,7 +73,7 @@ module Foobara
 
             Util.make_class(class_name, ValidatorBase) do
               define_method :applicable? do |value|
-                # TODO: hmmm, I wonder how we can short-circuit these checks if :allows_nil matches??
+                # TODO: hmmm, I wonder how we can short-circuit these checks if :allow_nil matches??
                 value.is_a?(::String)
               end
 

data/projects/command/src/command_pattern_implementation/concerns/reflection.rb

@@ -19,36 +19,48 @@ module Foobara
             remove_instance_variable("@all") if instance_variable_defined?("@all")
           end
 
-          def foobara_manifest(to_include: Set.new, remove_sensitive: false)
+          def foobara_manifest
+            to_include = TypeDeclarations.foobara_manifest_context_to_include
+
             depends_on = self.depends_on.map do |command_name|
               other_command = Foobara::Namespace.global.foobara_lookup!(command_name,
                                                                         mode: Foobara::Namespace::LookupMode::ABSOLUTE)
-              to_include << other_command
+              if to_include
+                to_include << other_command
+              end
               other_command.foobara_manifest_reference
             end.sort
 
-            types = types_depended_on(remove_sensitive:).map do |t|
-              to_include << t
+            types = types_depended_on.map do |t|
+              if to_include
+                to_include << t
+              end
               t.foobara_manifest_reference
             end.sort
 
             inputs_types_depended_on = self.inputs_types_depended_on.map do |t|
-              to_include << t
+              if to_include
+                to_include << t
+              end
               t.foobara_manifest_reference
             end.sort
 
             result_types_depended_on = self.result_types_depended_on.map do |t|
-              to_include << t
+              if to_include
+                to_include << t
+              end
               t.foobara_manifest_reference
             end.sort
 
             errors_types_depended_on = self.errors_types_depended_on.map do |t|
-              to_include << t
+              if to_include
+                to_include << t
+              end
               t.foobara_manifest_reference
             end.sort
 
             possible_errors = self.possible_errors.map do |possible_error|
-              [possible_error.key.to_s, possible_error.foobara_manifest(to_include:)]
+              [possible_error.key.to_s, possible_error.foobara_manifest]
             end.sort.to_h
 
             h = Util.remove_blank(
@@ -78,15 +90,18 @@ module Foobara
             Util.non_full_name(self)
           end
 
-          def types_depended_on(remove_sensitive: false)
+          def types_depended_on
+            remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
+
             if defined?(@types_depended_on) && @types_depended_on.key?(remove_sensitive)
               return @types_depended_on[remove_sensitive]
             end
 
             @types_depended_on ||= {}
             @types_depended_on[remove_sensitive] = begin
-              types = inputs_types_depended_on(remove_sensitive:) | result_types_depended_on(remove_sensitive:) |
-                      errors_types_depended_on(remove_sensitive:)
+              types = inputs_types_depended_on |
+                      result_types_depended_on |
+                      errors_types_depended_on
 
               unless depends_on_entities.empty?
                 entity_types = depends_on_entities.map(&:entity_type)
@@ -96,14 +111,16 @@ module Foobara
                 end
 
                 types |= entity_types
-                types |= entity_types.map { |t| t.types_depended_on(remove_sensitive:) }.inject(:|)
+                types |= entity_types.map(&:types_depended_on).inject(:|)
               end
 
               types
             end
           end
 
-          def inputs_types_depended_on(remove_sensitive: false)
+          def inputs_types_depended_on
+            remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
+
             if defined?(@inputs_types_depended_on) && @inputs_types_depended_on.key?(remove_sensitive)
               return @inputs_types_depended_on[remove_sensitive]
             end
@@ -121,14 +138,16 @@ module Foobara
                                                               end
                                                               # :nocov:
                                                             else
-                                                              inputs_type.types_depended_on(remove_sensitive:)
+                                                              inputs_type.types_depended_on
                                                             end
                                                           else
                                                             Set.new
                                                           end
           end
 
-          def result_types_depended_on(remove_sensitive: false)
+          def result_types_depended_on
+            remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
+
             if defined?(@result_types_depended_on) && @result_types_depended_on.key?(remove_sensitive)
               return @result_types_depended_on[remove_sensitive]
             end
@@ -138,14 +157,16 @@ module Foobara
                                                             if result_type.registered?
                                                               Set[result_type]
                                                             else
-                                                              result_type.types_depended_on(remove_sensitive:)
+                                                              result_type.types_depended_on
                                                             end
                                                           else
                                                             Set.new
                                                           end
           end
 
-          def errors_types_depended_on(remove_sensitive: false)
+          def errors_types_depended_on
+            remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
+
             if defined?(@errors_types_depended_on) && @errors_types_depended_on.key?(remove_sensitive)
               return @errors_types_depended_on[remove_sensitive]
             end
@@ -153,7 +174,7 @@ module Foobara
             @errors_types_depended_on ||= {}
             @errors_types_depended_on[remove_sensitive] = begin
               error_classes = possible_errors.map(&:error_class)
-              error_classes.map { |e| e.types_depended_on(remove_sensitive:) }.inject(:|) || Set.new
+              error_classes.map(&:types_depended_on).inject(:|) || Set.new
             end
           end
         end

data/projects/command/src/transformed_command.rb

@@ -174,28 +174,48 @@ module Foobara
         @possible_errors ||= error_context_type_map.values
       end
 
-      def possible_errors_manifest(to_include:, remove_sensitive: true)
-        possible_errors.map do |possible_error|
-          [possible_error.key.to_s, possible_error.foobara_manifest(to_include:, remove_sensitive:)]
-        end.sort.to_h
+      def possible_errors_manifest
+        errors_proc = -> do
+          possible_errors.map do |possible_error|
+            [possible_error.key.to_s, possible_error.foobara_manifest]
+          end.sort.to_h
+        end
+
+        if TypeDeclarations.manifest_context_set?(:remove_sensitive)
+          errors_proc.call
+        else
+          TypeDeclarations.with_manifest_context(remove_sensitive: true, &errors_proc)
+        end
       end
 
       def inputs_types_depended_on
-        inputs_type&.types_depended_on || []
+        TypeDeclarations.with_manifest_context(remove_sensitive: false) do
+          inputs_type_for_manifest&.types_depended_on || []
+        end
       end
 
-      def result_types_depended_on(remove_sensitive: true)
-        result_type&.types_depended_on(remove_sensitive:) || []
+      def result_types_depended_on
+        type_proc = -> { result_type_for_manifest&.types_depended_on || [] }
+
+        if TypeDeclarations.manifest_context_set?(:remove_sensitive)
+          type_proc.call
+        else
+          TypeDeclarations.with_manifest_context(remove_sensitive: true, &type_proc)
+        end
       end
 
-      def types_depended_on(remove_sensitive: true)
+      def types_depended_on
+        # Seems to be not necessary?
+        # types = command_class.types_depended_on
+
+        types = Set.new
+
         # TODO: memoize this
         # TODO: this should not delegate to command since transformers are in play
-        types = command_class.types_depended_on(remove_sensitive:)
 
         type = inputs_type
 
-        if type != command_class.inputs_type
+        if type
           if type.registered?
             # TODO: if we ever change from attributes-only inputs type
             # then this will be handy
@@ -207,73 +227,98 @@ module Foobara
           types |= type.types_depended_on
         end
 
-        type = result_type
+        types_proc = proc do
+          type = result_type
 
-        if type != command_class.result_type
-          if type.registered?
-            # TODO: if we ever change from attributes-only inputs type
-            # then this will be handy
-            # :nocov:
-            types |= [type]
-            # :nocov:
+          if type
+            if type.registered?
+              # TODO: if we ever change from attributes-only inputs type
+              # then this will be handy
+              # :nocov:
+              types |= [type]
+              # :nocov:
+            end
+
+            types |= type.types_depended_on
           end
 
-          types |= type.types_depended_on(remove_sensitive:)
-        end
+          possible_errors.each do |possible_error|
+            error_class = possible_error.error_class
+            types |= error_class.types_depended_on
+          end
 
-        possible_errors.each do |possible_error|
-          error_class = possible_error.error_class
-          types |= error_class.types_depended_on(remove_sensitive:)
+          types
         end
 
-        types
+        if TypeDeclarations.manifest_context_set?(:remove_sensitive)
+          types_proc.call
+        else
+          TypeDeclarations.with_manifest_context(remove_sensitive: true, &types_proc)
+        end
       end
 
-      def foobara_manifest(to_include: Set.new, remove_sensitive: true)
+      def foobara_manifest
+        to_include = TypeDeclarations.foobara_manifest_context_to_include
+
         types = types_depended_on.select(&:registered?).map do |t|
-          to_include << t
+          if to_include
+            to_include << t
+          end
           t.foobara_manifest_reference
         end.sort
 
-        inputs_transformers = self.inputs_transformers.map { |t| t.foobara_manifest(to_include:) }
-        result_transformers = self.result_transformers.map { |t| t.foobara_manifest(to_include:) }
-        errors_transformers = self.errors_transformers.map { |t| t.foobara_manifest(to_include:) }
-        pre_commit_transformers = self.pre_commit_transformers.map { |t| t.foobara_manifest(to_include:) }
+        inputs_transformers = TypeDeclarations.with_manifest_context(remove_sensitive: false) do
+          self.inputs_transformers.map(&:foobara_manifest)
+        end
+        result_transformers = self.result_transformers.map(&:foobara_manifest)
+        errors_transformers = self.errors_transformers.map(&:foobara_manifest)
+        pre_commit_transformers = self.pre_commit_transformers.map(&:foobara_manifest)
         serializers = self.serializers.map do |s|
           if s.respond_to?(:foobara_manifest)
-            to_include << s
+            if to_include
+              to_include << s
+            end
             s.foobara_manifest_reference
           else
             { proc: s.to_s }
           end
         end
 
-        response_mutators = self.response_mutators.map { |t| t.foobara_manifest(to_include:) }
-        request_mutators = self.request_mutators.map { |t| t.foobara_manifest(to_include:) }
+        response_mutators = self.response_mutators.map(&:foobara_manifest)
+        request_mutators = TypeDeclarations.with_manifest_context(remove_sensitive: false) do
+          self.request_mutators.map(&:foobara_manifest)
+        end
 
         authenticator_manifest = if authenticator
                                    if authenticator.respond_to?(:foobara_manifest)
                                      # TODO: test this path
                                      # :nocov:
-                                     authenticator.foobara_manifest(to_include:)
+                                     authenticator.foobara_manifest
                                      # :nocov:
                                    else
                                      true
                                    end
                                  end
 
-        inputs_types_depended_on = self.inputs_types_depended_on.map(&:foobara_manifest_reference).sort
-        result_types_depended_on = self.result_types_depended_on(remove_sensitive:).map(&:foobara_manifest_reference)
+        inputs_types_depended_on =  TypeDeclarations.with_manifest_context(remove_sensitive: false) do
+          self.inputs_types_depended_on.map(&:foobara_manifest_reference).sort
+        end
+
+        result_types_depended_on = self.result_types_depended_on.map(&:foobara_manifest_reference)
         result_types_depended_on = result_types_depended_on.sort
 
-        command_class.foobara_manifest(to_include:, remove_sensitive:).merge(
+        # TODO: Do NOT defer to command_class.foobara_manifest because it might process types that
+        # might not have an exposed command and might not need one due to transformers/mutators/remove_sensitive flag
+        command_class.foobara_manifest.merge(
           Util.remove_blank(
             inputs_types_depended_on:,
             result_types_depended_on:,
             types_depended_on: types,
-            inputs_type: inputs_type_for_manifest&.reference_or_declaration_data,
-            result_type: result_type_for_manifest&.reference_or_declaration_data(remove_sensitive:),
-            possible_errors: possible_errors_manifest(to_include:, remove_sensitive:),
+            inputs_type: TypeDeclarations.with_manifest_context(remove_sensitive: false) do
+              inputs_type_for_manifest&.reference_or_declaration_data
+            end,
+            result_type: result_type_for_manifest&.reference_or_declaration_data,
+            possible_errors: possible_errors_manifest,
             capture_unknown_error:,
             inputs_transformers:,
             result_transformers:,

data/projects/command_connectors/src/command_connector/commands/describe.rb

@@ -16,11 +16,7 @@ module Foobara
         attr_accessor :manifest
 
         def build_manifest
-          self.manifest = if manifestable.is_a?(CommandConnector)
-                            manifestable.foobara_manifest
-                          else
-                            manifestable.foobara_manifest(to_include: Set.new)
-                          end
+          self.manifest = manifestable.foobara_manifest
         end
 
         def stamp_request_metadata

data/projects/command_connectors/src/command_connector.rb

@@ -396,10 +396,9 @@ module Foobara
       Foobara.foobara_lookup_type(name, mode: Namespace::LookupMode::RELAXED)
     end
 
-    def foobara_manifest(remove_sensitive: true)
+    def foobara_manifest
       process_delayed_connections
 
-      # Drive all of this off of the list of exposed commands...
       to_include = Set.new
 
       to_include << command_registry.global_organization
@@ -423,73 +422,84 @@ module Foobara
         processor_class: {}
       }
 
-      until to_include.empty? && additional_to_include.empty?
-        object = nil
-
-        if to_include.empty?
-          until additional_to_include.empty?
-            o = additional_to_include.first
-            additional_to_include.delete(o)
-
-            if o.is_a?(::Module)
-              if o.foobara_domain? || o.foobara_organization?
-                unless o.foobara_root_namespace == command_registry
+      TypeDeclarations.with_manifest_context(to_include: additional_to_include, remove_sensitive: true) do
+        until to_include.empty? && additional_to_include.empty?
+          object = nil
+
+          if to_include.empty?
+            until additional_to_include.empty?
+              o = additional_to_include.first
+              additional_to_include.delete(o)
+
+              if o.is_a?(::Module)
+                if o.foobara_domain? || o.foobara_organization?
+                  unless o.foobara_root_namespace == command_registry
+                    next
+                  end
+                elsif o.is_a?(::Class) && o < Foobara::Command
                   next
                 end
-              elsif o.is_a?(::Class) && o < Foobara::Command
-                next
-              end
-            elsif o.is_a?(Types::Type)
-              if remove_sensitive && o.sensitive?
+              elsif o.is_a?(Types::Type)
+                if o.sensitive?
+                  # :nocov:
+                  raise UnexpectedSensitiveTypeInManifestError,
+                        "Unexpected sensitive type in manifest: #{o.scoped_full_path}. " \
+                        "Make sure these are not included."
                 # :nocov:
-                raise UnexpectedSensitiveTypeInManifestError,
-                      "Unexpected sensitive type in manifest: #{o.scoped_full_path}. Make sure these are not included."
-              # :nocov:
-              else
-                domain_name = o.foobara_domain.scoped_full_name
-
-                unless command_registry.foobara_registered?(domain_name)
-                  domain = command_registry.build_and_register_exposed_domain(domain_name)
-                  additional_to_include << domain
-                  additional_to_include << domain.foobara_organization
+                else
+                  domain_name = o.foobara_domain.scoped_full_name
+
+                  unless command_registry.foobara_registered?(domain_name)
+                    command_registry.build_and_register_exposed_domain(domain_name)
+
+                    # Since we don't know which other domains/orgs creating this domain might have created,
+                    # we will just add them all to be included just in case
+                    command_registry.foobara_all_domain.each do |exposed_domain|
+                      additional_to_include << exposed_domain
+                    end
+
+                    command_registry.foobara_all_organization.each do |exposed_organization|
+                      additional_to_include << exposed_organization
+                    end
+                  end
                 end
               end
-            end
 
-            object = o
-            break
+              object = o
+              break
+            end
+          else
+            object = to_include.first
+            to_include.delete(object)
           end
-        else
-          object = to_include.first
-          to_include.delete(object)
-        end
 
-        break unless object
-        next if included.include?(object)
+          break unless object
+          next if included.include?(object)
 
-        manifest_reference = object.foobara_manifest_reference.to_sym
+          manifest_reference = object.foobara_manifest_reference.to_sym
 
-        category_symbol = command_registry.foobara_category_symbol_for(object)
+          category_symbol = command_registry.foobara_category_symbol_for(object)
 
-        unless category_symbol
-          # :nocov:
-          raise "no category symbol for #{object}"
-          # :nocov:
-        end
+          unless category_symbol
+            # :nocov:
+            raise "no category symbol for #{object}"
+            # :nocov:
+          end
 
-        namespace = if object.is_a?(Types::Type)
-                      object.created_in_namespace
-                    else
-                      Foobara::Namespace.current
-                    end
+          namespace = if object.is_a?(Types::Type)
+                        object.created_in_namespace
+                      else
+                        Foobara::Namespace.current
+                      end
 
-        cat = h[category_symbol] ||= {}
-        # TODO: do we really need to enter the namespace here for this?
-        cat[manifest_reference] = Foobara::Namespace.use namespace do
-          object.foobara_manifest(to_include: additional_to_include, remove_sensitive:)
-        end
+          cat = h[category_symbol] ||= {}
+          # TODO: do we really need to enter the namespace here for this?
+          cat[manifest_reference] = Foobara::Namespace.use namespace do
+            object.foobara_manifest
+          end
 
-        included << object
+          included << object
+        end
       end
 
       h[:domain].each_value do |domain_manifest|

data/projects/command_connectors/src/command_registry/exposed_command.rb

@@ -100,8 +100,8 @@ module Foobara
         @full_command_symbol ||= Util.underscore_sym(full_command_name)
       end
 
-      def foobara_manifest(to_include: Set.new, remove_sensitive: true)
-        transformed_command_class.foobara_manifest(to_include:, remove_sensitive:).merge(super).merge(
+      def foobara_manifest
+        transformed_command_class.foobara_manifest.merge(super).merge(
           Util.remove_blank(
             scoped_category: :command,
             domain: command_class.domain.foobara_manifest_reference,

data/projects/command_connectors/src/command_registry/exposed_domain.rb

@@ -9,10 +9,17 @@ module Foobara
       end
 
       # TODO: unable to address types here so it is handled as a hack higher up...
-      def foobara_manifest(to_include: Set.new, remove_sensitive: true)
-        to_include << foobara_organization
+      def foobara_manifest
+        to_include = TypeDeclarations.foobara_manifest_context_to_include
+
+        if to_include
+          to_include << foobara_organization
+        end
+
+        domain_manifest = TypeDeclarations.with_manifest_context(to_include: Set.new) do
+          unexposed_domain.foobara_manifest
+        end
 
-        domain_manifest = unexposed_domain.foobara_manifest(to_include: Set.new, remove_sensitive:)
         mode = Foobara::Namespace::LookupMode::DIRECT
         commands = foobara_all_command(mode:).map(&:foobara_manifest_reference).sort
 

data/projects/command_connectors/src/command_registry/exposed_organization.rb

@@ -9,8 +9,8 @@ module Foobara
       end
 
       # TODO: unable to address types here so it is handled as a hack higher up...
-      def foobara_manifest(to_include: Set.new, remove_sensitive: true)
-        organization_manifest = unexposed_organization.foobara_manifest(to_include: Set.new, remove_sensitive:)
+      def foobara_manifest
+        organization_manifest = unexposed_organization.foobara_manifest
         mode = Foobara::Namespace::LookupMode::DIRECT
         domains = foobara_all_domain(mode:).map(&:foobara_manifest_reference).sort
 

data/projects/command_connectors/src/command_registry.rb

@@ -86,6 +86,15 @@ module Foobara
       exposed_organization.foobara_register(exposed_domain)
       exposed_domain.foobara_parent_namespace = exposed_organization
 
+      domain_module.foobara_depends_on.each do |domain_name|
+        # TODO: test this code path!!
+        # :nocov:
+        unless foobara_organization_registered?(domain_name)
+          build_and_register_exposed_domain(domain_name)
+        end
+        # :nocov:
+      end
+
       exposed_domain
     end
 

data/projects/command_connectors/src/serializers/atomic_serializer.rb

@@ -8,7 +8,7 @@ module Foobara
               object.class.load(object)
             end
 
-            object = object.attributes
+            object = object.attributes_with_delegates
           end
 
           entities_to_primary_keys_serializer.serialize(object)