foobara 0.0.90 → 0.0.92

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5aef9e716ddfe89cbe85867f6bb5a0af642b3af7e1dab9fb502116380eb4e44e
-  data.tar.gz: 80f58463fdbc26ee8bdf90cfe56eeca95ecb56dd2d8fb8c4d4014a12d9f98d55
+  metadata.gz: ad04851e6936963ef7ad60f1d6e7ab34241993abb2107b14a26d8cbc8d73663e
+  data.tar.gz: 178614a7f7b288a13ca290a14f702348e47d43e4d675611c7953bcdd033bdf5f
 SHA512:
-  metadata.gz: 12a9d4519ac42c3b159b35260e768b67cfafe7811a83d3027ec7f7e278306a48ae5e4185b5416f94b915d1ea4b6dc4f65c1056b7a5c12c229f00d807436b3188
-  data.tar.gz: 1cb99a0a5e64de8585e578d50845118ffd817abcceafc37d04aeb9b892aebc74c11737560d8adb3656af4ed912dbc27aa3cc762888673114f6018068da1a43cc
+  metadata.gz: 13112e8c68e48a51e442ce485c5fbcc89ab5974df3f1349012e2e646cecdf1742096bc5d42a9edb4c5dd825b06adabca6302f8a4c9ec44857c98338c8cc4b210
+  data.tar.gz: a48dcd6f4ec1f36feba216fab63711ea37a2378f819cc450a8e08bb15ea62a4f4463970f666b7d61fabd7aee871e01112abe2afceb915fbd0bc2cade4994b4b3

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# [0.0.92] - 2025-04-01
+
+- Improve error call stacks in calls like #run!
+- Fix bug preventing first call to CommandConnector#foobara_manifest from returning all its domains
+
+# [0.0.91] - 2025-03-31
+
+- Fix bug that was including removed types in command manifest's inputs_types_depended_on
+- Hoist authentication check up into command connector further from transformed command
+
 # [0.0.90] - 2025-03-29
 
 - Implement request mutator concept
@@ -11,7 +21,7 @@
 - Implement response mutator concept
 - Break up #request_to_response for easier overriding/extension
 - Add AttributesTransformers::Reject
-- Fix problem causing downcase/regex processors to explode on allows_nil types
+- Fix problem causing downcase/regex processors to explode on allow_nil types
 
 # [0.0.87] - 2025-03-26
 
@@ -266,7 +276,7 @@
 
 ## [0.0.13] - 2024-11-13
 
-- Do not fail :one_of if it is nil and :allows_nil
+- Do not fail :one_of if it is nil and :allow_nil
 
 ## [0.0.12] - 2024-10-30
 

data/projects/builtin_types/src/email/validator_base.rb

@@ -73,7 +73,7 @@ module Foobara
 
             Util.make_class(class_name, ValidatorBase) do
               define_method :applicable? do |value|
-                # TODO: hmmm, I wonder how we can short-circuit these checks if :allows_nil matches??
+                # TODO: hmmm, I wonder how we can short-circuit these checks if :allow_nil matches??
                 value.is_a?(::String)
               end
 

data/projects/command/src/transformed_command.rb

@@ -180,6 +180,14 @@ module Foobara
         end.sort.to_h
       end
 
+      def inputs_types_depended_on
+        inputs_type_for_manifest&.types_depended_on || []
+      end
+
+      def result_types_depended_on(remove_sensitive: true)
+        result_type_for_manifest&.types_depended_on(remove_sensitive:) || []
+      end
+
       def types_depended_on(remove_sensitive: true)
         # TODO: memoize this
         # TODO: this should not delegate to command since transformers are in play
@@ -188,29 +196,29 @@ module Foobara
         type = inputs_type
 
         if type != command_class.inputs_type
-          types |= if type.registered?
-                     # TODO: if we ever change from attributes-only inputs type
-                     # then this will be handy
-                     # :nocov:
-                     [type]
-                     # :nocov:
-                   else
-                     type.types_depended_on(remove_sensitive:)
-                   end
+          if type.registered?
+            # TODO: if we ever change from attributes-only inputs type
+            # then this will be handy
+            # :nocov:
+            types |= [type]
+            # :nocov:
+          end
+
+          types |= type.types_depended_on
         end
 
         type = result_type
 
         if type != command_class.result_type
-          types |= if type.registered?
-                     # TODO: if we ever change from attributes-only inputs type
-                     # then this will be handy
-                     # :nocov:
-                     [type]
-                     # :nocov:
-                   else
-                     type.types_depended_on(remove_sensitive:)
-                   end
+          if type.registered?
+            # TODO: if we ever change from attributes-only inputs type
+            # then this will be handy
+            # :nocov:
+            types |= [type]
+            # :nocov:
+          end
+
+          types |= type.types_depended_on(remove_sensitive:)
         end
 
         possible_errors.each do |possible_error|
@@ -243,8 +251,27 @@ module Foobara
         response_mutators = self.response_mutators.map { |t| t.foobara_manifest(to_include:) }
         request_mutators = self.request_mutators.map { |t| t.foobara_manifest(to_include:) }
 
+        authenticator_manifest = if authenticator
+                                   if authenticator.respond_to?(:foobara_manifest)
+                                     # TODO: test this path
+                                     # :nocov:
+                                     authenticator.foobara_manifest(to_include:)
+                                     # :nocov:
+                                   else
+                                     true
+                                   end
+                                 end
+
+        inputs_types_depended_on = self.inputs_types_depended_on.map(&:foobara_manifest_reference).sort
+        result_types_depended_on = self.result_types_depended_on(remove_sensitive:).map(&:foobara_manifest_reference)
+        result_types_depended_on = result_types_depended_on.sort
+
+        # TODO: Do NOT defer to command_class.foobara_manifest because it might process types that
+        # might not have an exposed command and might not need one due to transformers/mutators/remove_sensitive flag
         command_class.foobara_manifest(to_include:, remove_sensitive:).merge(
           Util.remove_blank(
+            inputs_types_depended_on:,
+            result_types_depended_on:,
             types_depended_on: types,
             inputs_type: inputs_type_for_manifest&.reference_or_declaration_data,
             result_type: result_type_for_manifest&.reference_or_declaration_data(remove_sensitive:),
@@ -258,7 +285,7 @@ module Foobara
             response_mutators:,
             request_mutators:,
             requires_authentication:,
-            authenticator: authenticator&.manifest
+            authenticator: authenticator_manifest
           )
         )
       end
@@ -394,7 +421,6 @@ module Foobara
                      to: :class
 
     def run
-      authenticate if requires_authentication?
       apply_allowed_rule
       apply_pre_commit_transformers
       run_command
@@ -482,19 +508,6 @@ module Foobara
       self.command = command_class.new(transformed_inputs)
     end
 
-    def authenticate
-      command.after_load_records do |command:, **|
-        self.authenticated_user = instance_eval(&:authenticator)
-
-        unless authenticated_user
-          self.outcome = Outcome.error(CommandConnector::UnauthenticatedError.new)
-
-          command.state_machine.error!
-          command.halt!
-        end
-      end
-    end
-
     def apply_allowed_rule
       rule = allowed_rule
 

data/projects/command_connectors/src/command_connector.rb

@@ -338,6 +338,10 @@ module Foobara
       # TODO: feels like a smell
       request.command_connector = self
 
+      if command.respond_to?(:requires_authentication?) && command.requires_authentication?
+        authenticate(request)
+      end
+
       if command
         command.run
         # :nocov:
@@ -349,6 +353,23 @@ module Foobara
       build_response(request)
     end
 
+    def authenticate(request)
+      request_command = request.command
+
+      request_command.after_load_records do |command:, **|
+        authenticated_user = request.instance_eval(&authenticator)
+
+        request_command.authenticated_user = authenticated_user
+
+        unless authenticated_user
+          request_command.outcome = Outcome.error(CommandConnector::UnauthenticatedError.new)
+
+          command.state_machine.error!
+          command.halt!
+        end
+      end
+    end
+
     def build_request_and_command(...)
       request = build_request(...)
 
@@ -428,9 +449,17 @@ module Foobara
                 domain_name = o.foobara_domain.scoped_full_name
 
                 unless command_registry.foobara_registered?(domain_name)
-                  domain = command_registry.build_and_register_exposed_domain(domain_name)
-                  additional_to_include << domain
-                  additional_to_include << domain.foobara_organization
+                  command_registry.build_and_register_exposed_domain(domain_name)
+
+                  # Since we don't know which other domains/orgs creating this domain might have created,
+                  # we will just add them all to be included just in case
+                  command_registry.foobara_all_domain.each do |exposed_domain|
+                    additional_to_include << exposed_domain
+                  end
+
+                  command_registry.foobara_all_organization.each do |exposed_organization|
+                    additional_to_include << exposed_organization
+                  end
                 end
               end
             end

data/projects/command_connectors/src/command_registry.rb

@@ -86,6 +86,15 @@ module Foobara
       exposed_organization.foobara_register(exposed_domain)
       exposed_domain.foobara_parent_namespace = exposed_organization
 
+      domain_module.foobara_depends_on.each do |domain_name|
+        # TODO: test this code path!!
+        # :nocov:
+        unless foobara_organization_registered?(domain_name)
+          build_and_register_exposed_domain(domain_name)
+        end
+        # :nocov:
+      end
+
       exposed_domain
     end
 

data/projects/common/src/error.rb

@@ -5,7 +5,7 @@ module Foobara
     include Manifestable
 
     # TODO: rename :path to data_path
-    attr_accessor :error_key, :message, :context, :is_fatal
+    attr_accessor :error_key, :message, :context, :is_fatal, :backtrace_when_initialized, :backtrace_when_raised
 
     # Need to do this early so doing it here... not sure if this is OK as it couples namespaces and errors
 
@@ -219,6 +219,30 @@ module Foobara
         # :nocov:
       end
 
+      backtrace_when_initialized = caller[1..]
+      index = 1
+
+      has_build_error = false
+
+      1.upto(10) do |i|
+        if backtrace_when_initialized[i].end_with?("#build_error'")
+          index = i + 1
+          has_build_error = true
+          break
+        end
+      end
+
+      if has_build_error
+        index.upto(10) do |i|
+          unless backtrace_when_initialized[i].end_with?("#build_error'")
+            index = i
+            break
+          end
+        end
+      end
+
+      self.backtrace_when_initialized = backtrace_when_initialized[index..]
+
       super(message)
     end
 

data/projects/common/src/outcome.rb

@@ -1,7 +1,7 @@
 module Foobara
   class Outcome
     class UnsuccessfulOutcomeError < StandardError
-      attr_accessor :errors
+      attr_accessor :errors, :backtrace_when_raised
 
       def initialize(errors)
         self.errors = errors
@@ -74,11 +74,17 @@ module Foobara
     def raise!
       return if success?
 
-      if errors.size == 1
-        raise errors.first
-      else
-        raise UnsuccessfulOutcomeError, errors
+      error = errors.first
+      original_backtrace = error.backtrace_when_initialized
+
+      if errors.size > 1
+        error = UnsuccessfulOutcomeError.new(errors)
       end
+
+      error.set_backtrace(original_backtrace)
+      error.backtrace_when_raised = caller
+
+      raise error
     end
 
     def result!

data/projects/manifest/src/foobara/manifest/command.rb

@@ -3,6 +3,10 @@ module Foobara
     class Command < BaseManifest
       self.category_symbol = :command
 
+      def requires_authentication?
+        !!self[:requires_authentication]
+      end
+
       def command_manifest
         relevant_manifest
       end

data/projects/type_declarations/src/remove_sensitive_values_transformer.rb

@@ -8,9 +8,15 @@ module Foobara
           associations = Foobara::DetachedEntity.construct_deep_associations(from_type)
 
           associations&.values&.reverse&.each do |entity_type|
+            next if entity_type.sensitive?
+            next unless entity_type.has_sensitive_types?
+
             declaration = entity_type.declaration_data
             sanitized_type_declaration = TypeDeclarations.remove_sensitive_types(declaration)
 
+            # We want to make sure that any types that change due to having sensitive types
+            # has a corresponding registered type in the command registry domain if needed
+            # TODO: this all feels so messy and brittle.
             Domain.current.foobara_type_from_declaration(sanitized_type_declaration)
           end
         end

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.90
+  version: 0.0.92
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-03-30 00:00:00.000000000 Z
+date: 2025-04-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal