foobara 0.0.9 → 0.0.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: da90f5634c4dd8b25e3e4025aba385db5a05fb905de0eab32a87dfc75758fbb5
-  data.tar.gz: 558ce219e510e8dc3fa21c625d2c0350efe32636114015d070cbfcb07818b133
+  metadata.gz: b7077a308e6717ee928b02783aa216a17eadda9f29f1f5a831449a038ac0e864
+  data.tar.gz: 387d8d37306f936d9be1eda46ba150b8de93fc14ee5ef6e2780466200fa48abd
 SHA512:
-  metadata.gz: 9385c980625d21deee50b0bb88ecaf9b9fcea1557c2fe8effc162a33ea465e914a6f3f4fb21d373f322e7939ad6048aaf0e15c3081de3412f01e185cd07c02c1
-  data.tar.gz: 349e0c8bb94463e29c7b1515b0fa1add2aca04b1866262c45fa3a9345d9fb16068717df11c1e57cb55b47c4e2dc4dfffc56319bc2cb1840abc3d4e8c4fcc1c7b
+  metadata.gz: b503fc97d9d287cffc3fd70a70de32ad158e6aebd41a1fcb1700a6bbdd1fde1b6f2e07431d7cd58afe57e4225b265107e746a627a12fb84c38f410c13d3ba342
+  data.tar.gz: f2e2efc432d279ae402f90dd57039a25dda7e4728fc1ff7be1c7882de37890737070beac97584cb9bafa7479d8e9fb9f9aa012e43865ddc033357b9bebaafa57

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.10] - 2024-10-26
+
+- Extract http command connector to a different repostiory
+
 ## [0.0.9] - 2024-09-11
 
 - Add CommandRegistry#size

data/projects/command/src/transformed_command.rb

@@ -442,9 +442,9 @@ module Foobara
       end
     end
 
-    def method_missing(method_name, *, **, &)
+    def method_missing(method_name, ...)
       if command.respond_to?(method_name)
-        command.send(method_name, *, **, &)
+        command.send(method_name, ...)
       else
         # :nocov:
         super

data/projects/command_connectors/lib/foobara/command_connectors.rb

@@ -8,5 +8,5 @@ module Foobara
     foobara_domain!
   end
 
-  Monorepo.project :command_connectors
+  Monorepo.project "command_connectors"
 end

data/projects/command_connectors/src/{commands → command_connector/commands}/describe.rb

@@ -1,5 +1,5 @@
 module Foobara
-  module CommandConnectors
+  class CommandConnector
     module Commands
       class Describe < Foobara::Command
         inputs manifestable: :duck,
@@ -24,11 +24,7 @@ module Foobara
         end
 
         def stamp_request_metadata
-          manifest[:metadata] = {
-            # TODO: why is this here instead of in Http ??
-            url: request.url,
-            when: Time.now
-          }
+          manifest[:metadata] = { when: Time.now }
         end
       end
     end

data/projects/command_connectors/src/{commands → command_connector/commands}/list_commands.rb

@@ -1,5 +1,5 @@
 module Foobara
-  module CommandConnectors
+  class CommandConnector
     module Commands
       class ListCommands < Command
         inputs request: :duck, # TODO: have some way to specify by Ruby class...

data/projects/command_connectors/src/{commands → command_connector/commands}/ping.rb

@@ -1,5 +1,5 @@
 module Foobara
-  module CommandConnectors
+  class CommandConnector
     module Commands
       class Ping < Foobara::Command
         result :datetime

data/projects/command_connectors/src/{commands → command_connector/commands}/query_git_commit_info.rb

@@ -1,5 +1,5 @@
 module Foobara
-  module CommandConnectors
+  class CommandConnector
     module Commands
       # NOTE: this assumes that the following has been executed to generate the `git_commit_info.json` file:
       #

data/projects/command_connectors/src/{request.rb → command_connector/request.rb}

@@ -1,21 +1,32 @@
 module Foobara
-  module CommandConnectors
+  class CommandConnector
     class Request
       include TruncatedInspect
 
       # TODO: this feels like a smell of some sort...
-      attr_accessor :command_class, :command, :error, :command_connector, :serializers
-
-      def full_command_name
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
-      end
+      attr_accessor :command_class,
+                    :command,
+                    :error,
+                    :command_connector,
+                    :serializers,
+                    :inputs,
+                    :full_command_name,
+                    :action
+
+      def initialize(**opts)
+        valid_keys = %i[inputs full_command_name action]
+
+        invalid_keys = opts.keys - valid_keys
+
+        unless invalid_keys.empty?
+          # :nocov:
+          raise ArgumentError, "invalid keys: #{invalid_keys} expected only #{valid_keys}"
+          # :nocov:
+        end
 
-      def inputs
-        # :nocov:
-        raise "subclass responsibility"
-        # :nocov:
+        self.inputs = opts[:inputs] if opts.key?(:inputs)
+        self.action = opts[:action] if opts.key?(:action)
+        self.full_command_name = opts[:full_command_name] if opts.key?(:full_command_name)
       end
 
       def serializer
@@ -74,7 +85,7 @@ module Foobara
           when Value::Processor
             object
           when ::Symbol, ::String
-            klass = Serializer.serializer_from_symbol(object)
+            klass = Foobara::CommandConnectors::Serializer.serializer_from_symbol(object)
 
             unless klass
               # :nocov:

data/projects/command_connectors/src/{response.rb → command_connector/response.rb}

@@ -1,5 +1,5 @@
 module Foobara
-  module CommandConnectors
+  class CommandConnector
     class Response
       attr_accessor :status,
                     :body,

data/projects/command_connectors/src/command_connector.rb

@@ -78,6 +78,16 @@ module Foobara
     class NoTypeFoundError < NotFoundError; end
     class NoCommandOrTypeFoundError < NotFoundError; end
 
+    class << self
+      def find_builtin_command_class(command_class_name)
+        Util.find_constant_through_class_hierarchy(self, "Commands::#{command_class_name}")
+      end
+    end
+
+    def find_builtin_command_class(command_class_name)
+      self.class.find_builtin_command_class(command_class_name)
+    end
+
     foobara_delegate :add_default_inputs_transformer,
                      :add_default_result_transformer,
                      :add_default_errors_transformer,
@@ -126,7 +136,7 @@ module Foobara
           # :nocov:
         end
 
-        command_class = Foobara::CommandConnectors::Commands::Describe
+        command_class = find_builtin_command_class("Describe")
         full_command_name = command_class.full_command_name
 
         inputs = { manifestable:, request: }
@@ -141,7 +151,7 @@ module Foobara
           # :nocov:
         end
 
-        command_class = Foobara::CommandConnectors::Commands::Describe
+        command_class = find_builtin_command_class("Describe")
         full_command_name = command_class.full_command_name
 
         inputs = { manifestable: transformed_command_class, request: }
@@ -156,49 +166,41 @@ module Foobara
           # :nocov:
         end
 
-        command_class = Foobara::CommandConnectors::Commands::Describe
+        command_class = find_builtin_command_class("Describe")
         full_command_name = command_class.full_command_name
 
         inputs = { manifestable: type, request: }
         transformed_command_class = transformed_command_from_name(full_command_name) ||
                                     transform_command_class(command_class)
       when "manifest"
-        command_class = Foobara::CommandConnectors::Commands::Describe
+        command_class = find_builtin_command_class("Describe")
         full_command_name = command_class.full_command_name
 
         inputs = { manifestable: self, request: }
         transformed_command_class = transformed_command_from_name(full_command_name) ||
                                     transform_command_class(command_class)
       when "ping"
-        command_class = Foobara::CommandConnectors::Commands::Ping
+        command_class = find_builtin_command_class("Ping")
         full_command_name = command_class.full_command_name
 
         transformed_command_class = transformed_command_from_name(full_command_name) ||
                                     transform_command_class(command_class)
       when "query_git_commit_info"
         # TODO: this feels out of control... should just accomplish this through run I think instead. Same with ping.
-        command_class = Foobara::CommandConnectors::Commands::QueryGitCommitInfo
+        command_class = find_builtin_command_class("QueryGitCommitInfo")
         full_command_name = command_class.full_command_name
 
         transformed_command_class = transformed_command_from_name(full_command_name) ||
                                     transform_command_class(command_class)
       when "help"
-        command_class = self.class::Commands::Help
+        command_class = find_builtin_command_class("Help")
         full_command_name = command_class.full_command_name
 
         inputs = { request: }
         transformed_command_class = transformed_command_from_name(full_command_name) ||
                                     transform_command_class(command_class)
       when "list"
-        mod = self.class::Commands
-        command_class = if mod.const_defined?(:ListCommands)
-                          # TODO: test this
-                          # :nocov:
-                          mod::ListCommands
-                          # :nocov:
-                        else
-                          CommandConnectors::Commands::ListCommands
-                        end
+        command_class = find_builtin_command_class("ListCommands")
 
         full_command_name = command_class.full_command_name
 
@@ -226,10 +228,17 @@ module Foobara
       command_registry.create_exposed_command_without_domain(klass).transformed_command_class
     end
 
-    def request_to_response(_command)
-      # :nocov:
-      raise "subclass responsibility"
-      # :nocov:
+    def request_to_response(request)
+      command = request.command
+      outcome = command.outcome
+
+      status = outcome.success? ? 0 : 1
+
+      # TODO: feels awkward to call this here... Maybe use result/errors transformers instead??
+      # Or call the serializer here??
+      body = command.respond_to?(:serialize_result) ? command.serialize_result : request.response_body
+
+      self.class::Response.new(request:, status:, body:)
     end
 
     def initialize(authenticator: nil, default_serializers: nil)

data/projects/domain/src/domain_module_extension.rb

@@ -104,6 +104,8 @@ module Foobara
                   break if child.foobara_domain?
 
                   break if child.foobara_organization?
+
+                  # TODO: unclear why we need this check, hmmm, figure it out and document it (or delete if not needed)
                   break if child.constants(false).any? do |constant|
                     value = child.const_get(constant)
 

data/projects/domain/src/module_extension.rb

@@ -15,8 +15,6 @@ module Foobara
           # :nocov:
         end
 
-        include(DomainModuleExtension)
-
         unless is_a?(Namespace::IsNamespace)
           foobara_namespace!
           foobara_autoset_namespace!(default_namespace: Foobara::GlobalOrganization)
@@ -28,6 +26,8 @@ module Foobara
           self.foobara_parent_namespace = parent
         end
 
+        include(DomainModuleExtension)
+
         children = foobara_children
         children = children.sort_by { |child| child.scoped_path.size }
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Miles Georgi
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-09-12 00:00:00.000000000 Z
+date: 2024-10-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foobara-util
@@ -137,17 +137,17 @@ files:
 - projects/command/src/transformed_command.rb
 - projects/command_connectors/lib/foobara/command_connectors.rb
 - projects/command_connectors/src/command_connector.rb
+- projects/command_connectors/src/command_connector/commands/describe.rb
+- projects/command_connectors/src/command_connector/commands/list_commands.rb
+- projects/command_connectors/src/command_connector/commands/ping.rb
+- projects/command_connectors/src/command_connector/commands/query_git_commit_info.rb
+- projects/command_connectors/src/command_connector/request.rb
+- projects/command_connectors/src/command_connector/response.rb
 - projects/command_connectors/src/command_registry.rb
 - projects/command_connectors/src/command_registry/allowed_rule.rb
 - projects/command_connectors/src/command_registry/exposed_command.rb
 - projects/command_connectors/src/command_registry/exposed_domain.rb
 - projects/command_connectors/src/command_registry/exposed_organization.rb
-- projects/command_connectors/src/commands/describe.rb
-- projects/command_connectors/src/commands/list_commands.rb
-- projects/command_connectors/src/commands/ping.rb
-- projects/command_connectors/src/commands/query_git_commit_info.rb
-- projects/command_connectors/src/request.rb
-- projects/command_connectors/src/response.rb
 - projects/command_connectors/src/serializer.rb
 - projects/command_connectors/src/serializers/aggregate_serializer.rb
 - projects/command_connectors/src/serializers/atomic_serializer.rb
@@ -160,33 +160,6 @@ files:
 - projects/command_connectors/src/serializers/yaml_serializer.rb
 - projects/command_connectors/src/transformers/auth_errors_transformer.rb
 - projects/command_connectors/src/transformers/load_aggregates_pre_commit_transformer.rb
-- projects/command_connectors_http/lib/foobara/command_connectors_http.rb
-- projects/command_connectors_http/src/http.rb
-- projects/command_connectors_http/src/http/commands/get_options.rb
-- projects/command_connectors_http/src/http/commands/help.rb
-- projects/command_connectors_http/src/http/commands/help/presenter.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/command.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/domain.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/entity.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/error.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/model.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/organization.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/processor.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/processor_class.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/root.rb
-- projects/command_connectors_http/src/http/commands/help/presenter/type.rb
-- projects/command_connectors_http/src/http/commands/help/templates/command.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/domain.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/entity.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/error.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/model.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/organization.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/processor.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/processor_class.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/root.html.erb
-- projects/command_connectors_http/src/http/commands/help/templates/type.html.erb
-- projects/command_connectors_http/src/http/request.rb
-- projects/command_connectors_http/src/http/response.rb
 - projects/common/lib/foobara/common.rb
 - projects/common/src/data_path.rb
 - projects/common/src/error.rb
@@ -395,7 +368,6 @@ require_paths:
 - "./projects/callback/lib"
 - "./projects/command/lib"
 - "./projects/command_connectors/lib"
-- "./projects/command_connectors_http/lib"
 - "./projects/common/lib"
 - "./projects/concerns/lib"
 - "./projects/delegate/lib"
@@ -427,7 +399,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.18
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: Implements command pattern for encapsulating and managing domain complexity

data/projects/command_connectors_http/lib/foobara/command_connectors_http.rb

@@ -1,6 +0,0 @@
-module Foobara
-  module CommandConnectorsHttp
-  end
-
-  Monorepo.project :command_connectors_http
-end

data/projects/command_connectors_http/src/http/commands/get_options.rb

@@ -1,16 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        # TODO: this is a bit of a hack, just a total no-op... shouldn't really need this command at all ideally
-        class GetOptions < Foobara::Command
-          result :string
-
-          def execute
-            ""
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/command.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Command < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/domain.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Domain < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/entity.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Entity < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/error.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Error < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/model.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Model < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/organization.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Organization < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/processor.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Processor < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/processor_class.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class ProcessorClass < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/root.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Root < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter/type.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class Type < Presenter
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/presenter.rb

@@ -1,178 +0,0 @@
-require_relative "presenter/command"
-require_relative "presenter/entity"
-require_relative "presenter/error"
-require_relative "presenter/model"
-require_relative "presenter/organization"
-require_relative "presenter/domain"
-require_relative "presenter/processor"
-require_relative "presenter/processor_class"
-require_relative "presenter/root"
-require_relative "presenter/type"
-
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          class Presenter
-            class << self
-              def for(manifest)
-                case manifest
-                when Manifest::RootManifest
-                  Presenter::Root
-                when Manifest::Command
-                  Presenter::Command
-                when Manifest::Entity
-                  Presenter::Entity
-                when Manifest::Model
-                  Presenter::Model
-                when Manifest::Type
-                  Presenter::Type
-                when Manifest::Error
-                  Presenter::Error
-                when Manifest::Domain
-                  Presenter::Domain
-                when Manifest::Organization
-                  Presenter::Organization
-                when Manifest::Processor
-                  Presenter::Processor
-                when Manifest::ProcessorClass
-                  Presenter::ProcessorClass
-                else
-                  # :nocov:
-                  raise "No presenter found for #{manifest.path}"
-                  # :nocov:
-                end.new(manifest)
-              end
-
-              def template_symbol
-                Util.underscore(Util.non_full_name(self))
-              end
-
-              def template_path
-                template_path = File.join(
-                  __dir__,
-                  "templates",
-                  "#{template_symbol}.html.erb"
-                )
-                Pathname.new(template_path).cleanpath.to_s
-              end
-            end
-
-            attr_accessor :manifest
-
-            def initialize(manifest)
-              self.manifest = manifest
-            end
-
-            def render_html_list(data, skip_wrapper: false)
-              html = ""
-
-              case data
-              when ::Hash
-                html << "<ul>" unless skip_wrapper
-                data.each do |key, value|
-                  html << "<li>#{key}"
-                  html << "<ul>"
-                  html << render_html_list(value, skip_wrapper: true)
-                  html << "</ul>"
-                  html << "</li>"
-                end
-                html << "</ul>" unless skip_wrapper
-              when ::Array
-                html << "<ul>" unless skip_wrapper
-                data.each do |item|
-                  html << render_html_list(item)
-                end
-                html << "</ul>" unless skip_wrapper
-              when Manifest::Attributes
-                html << "<ul>" unless skip_wrapper
-                data.relevant_manifest.each_pair do |key, value|
-                  if key.to_s == "type"
-                    next
-                  end
-
-                  if key.to_s == "element_type_declarations"
-                    key = :attributes
-                    value = data.attribute_declarations
-                  end
-                  html << "<li>#{key}"
-                  html << "<ul>"
-                  html << render_html_list(value, skip_wrapper: true)
-                  html << "</ul>"
-                  html << "</li>"
-                end
-                html << "</ul>" unless skip_wrapper
-              when Manifest::Array
-                html << "<ul>" unless skip_wrapper
-                data.relevant_manifest.each_pair do |key, value|
-                  next if key == :element_type_declaration
-
-                  if key.to_s == "type"
-                    value = root_manifest.lookup_path(key, value)
-                  end
-                  html << "<li>#{key}"
-                  html << "<ul>"
-                  html << render_html_list(value, skip_wrapper: true)
-                  html << "</ul>"
-                  html << "</li>"
-                end
-                html << render_html_list({ element_type: data.element_type }, skip_wrapper: true)
-                html << "</ul>" unless skip_wrapper
-              when Manifest::TypeDeclaration
-                html << "<ul>" unless skip_wrapper
-                data.relevant_manifest.each_pair do |key, value|
-                  if key.to_s == "type"
-                    value = root_manifest.lookup_path(key, value)
-                  end
-                  html << "<li>#{key}"
-                  html << "<ul>"
-                  html << render_html_list(value, skip_wrapper: true)
-                  html << "</ul>"
-                  html << "</li>"
-                end
-                html << "</ul>" unless skip_wrapper
-              when Manifest::Type, Manifest::Command, Manifest::Error
-                html << foobara_reference_link(data)
-              when Manifest::PossibleError
-                html << render_html_list(data.error)
-              else
-                html << "<li>#{data}</li>"
-              end
-
-              html
-            end
-
-            def foobara_reference_link(manifest)
-              path = "/help/#{manifest.reference}"
-
-              "<a href=\"#{path}\">#{manifest.reference.split("::").last}</a>"
-            end
-
-            def root_manifest
-              @root_manifest ||= Manifest::RootManifest.new(manifest.root_manifest)
-            end
-
-            def template_path
-              self.class.template_path
-            end
-
-            def method_missing(method_name, *, &)
-              if manifest.respond_to?(method_name)
-                manifest.send(method_name, *, &)
-              else
-                # :nocov:
-                super
-                # :nocov:
-              end
-            end
-
-            def respond_to_missing?(method_name, include_private = false)
-              manifest.respond_to?(method_name, include_private)
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/commands/help/templates/command.html.erb

@@ -1,11 +0,0 @@
-<h1><%= full_command_name %></h1>
-<p><%= description %></p>
-
-<h2>Inputs</h2>
-<%= render_html_list(inputs_type) %>
-
-<h2>Result</h2>
-<%= render_html_list(result_type) %>
-
-<h2>Possible Errors</h2>
-<%= render_html_list(possible_errors) %>

data/projects/command_connectors_http/src/http/commands/help/templates/domain.html.erb

@@ -1 +0,0 @@
-<%= full_domain_name %>

data/projects/command_connectors_http/src/http/commands/help/templates/entity.html.erb

@@ -1,11 +0,0 @@
-<h1><%= full_entity_name %></h1>
-<p><%= description %></p>
-
-<h2>Attributes</h2>
-<%= render_html_list(attributes_type) %>
-
-<h2>Primary Key</h2>
-<%= primary_key_attribute %>
-
-<h2>Possible Errors</h2>
-<%= render_html_list(possible_errors) %>

data/projects/command_connectors_http/src/http/commands/help/templates/error.html.erb

@@ -1 +0,0 @@
-<%= full_error_name %>

data/projects/command_connectors_http/src/http/commands/help/templates/model.html.erb

@@ -1,8 +0,0 @@
-<h1><%= full_model_name %></h1>
-<p><%= description %></p>
-
-<h2>Attributes</h2>
-<%= render_html_list(attributes_type) %>
-
-<h2>Possible Errors</h2>
-<%= render_html_list(possible_errors) %>

data/projects/command_connectors_http/src/http/commands/help/templates/organization.html.erb

@@ -1 +0,0 @@
-<%= full_organization_name %>

data/projects/command_connectors_http/src/http/commands/help/templates/processor.html.erb

@@ -1 +0,0 @@
-<%= full_processor_name %>

data/projects/command_connectors_http/src/http/commands/help/templates/processor_class.html.erb

@@ -1 +0,0 @@
-<%= full_processor_class_name %>

data/projects/command_connectors_http/src/http/commands/help/templates/root.html.erb

@@ -1,3 +0,0 @@
-<h1>Commands</h1>
-
-<%= render_html_list(commands) %>

data/projects/command_connectors_http/src/http/commands/help/templates/type.html.erb

@@ -1 +0,0 @@
-<%= full_type_name %>

data/projects/command_connectors_http/src/http/commands/help.rb

@@ -1,98 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      module Commands
-        class Help < Command
-          description "Will extract items from the request to help with. Assumes the help is desired in HTML format"
-          inputs request: Request
-          result :string
-          possible_error CommandConnector::NotFoundError
-
-          def execute
-            load_manifest
-            determine_object_to_help_with
-            build_presenter
-            load_template
-            generate_html_from_template
-            set_header_to_html
-
-            html
-          end
-
-          attr_accessor :raw_manifest, :root_manifest, :object_to_help_with, :template, :html, :presenter
-
-          def load_manifest
-            self.raw_manifest = command_connector.foobara_manifest
-            self.root_manifest = Manifest::RootManifest.new(raw_manifest)
-          end
-
-          def determine_object_to_help_with(mode: Namespace::LookupMode::ABSOLUTE)
-            arg = request.argument
-
-            if arg
-              result = command_connector.command_registry.foobara_lookup(arg, mode:)
-
-              if result
-                self.object_to_help_with = result
-              else
-                result = GlobalOrganization.foobara_lookup(arg, mode:)
-
-                if result && root_manifest.contains?(result.foobara_manifest_reference,
-                                                     result.scoped_category)
-                  self.object_to_help_with = result
-                elsif mode == Namespace::LookupMode::ABSOLUTE
-                  determine_object_to_help_with(mode: Namespace::LookupMode::GENERAL)
-                elsif mode == Namespace::LookupMode::GENERAL
-                  determine_object_to_help_with(mode: Namespace::LookupMode::RELAXED)
-                else
-                  # TODO: add an input error instead for missing record to trigger 404
-                  add_runtime_error(CommandConnector::NotFoundError.new(arg))
-                end
-              end
-            else
-              self.object_to_help_with = root_manifest
-            end
-          end
-
-          def build_presenter
-            self.presenter = Help::Presenter.for(manifest_to_help_with)
-          end
-
-          def template_path
-            presenter.template_path
-          end
-
-          def load_template
-            template_body = File.read(template_path)
-
-            erb = ERB.new(template_body)
-            erb.filename = template_path
-
-            self.template = erb
-          end
-
-          def generate_html_from_template
-            self.html = template.result(presenter.instance_eval { binding })
-          end
-
-          def set_header_to_html
-            request.response_headers ||= {}
-            request.response_headers = request.response_headers.merge("content-type" => "text/html")
-          end
-
-          def manifest_to_help_with
-            @manifest_to_help_with ||= if object_to_help_with.is_a?(Manifest::BaseManifest)
-                                         object_to_help_with
-                                       else
-                                         root_manifest.lookup(object_to_help_with.foobara_manifest_reference)
-                                       end
-          end
-
-          def command_connector
-            request.command_connector
-          end
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/request.rb

@@ -1,98 +0,0 @@
-require "uri"
-
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      class Request < CommandConnectors::Request
-        attr_accessor :path,
-                      :method,
-                      :headers,
-                      :query_string,
-                      :body,
-                      :scheme,
-                      :host,
-                      :port,
-                      :cookies,
-                      :remote_ip,
-                      :response_headers
-
-        def initialize(
-          path:,
-          method: nil,
-          headers: {},
-          query_string: "",
-          body: "",
-          scheme: nil,
-          host: nil,
-          port: nil,
-          cookies: nil,
-          remote_ip: nil
-        )
-          self.path = path
-          self.method = method
-          self.headers = headers
-          self.query_string = query_string
-          self.body = body
-          self.scheme = scheme
-          self.host = host
-          self.port = port
-          self.cookies = cookies
-          self.remote_ip = remote_ip
-
-          super()
-        end
-
-        def url
-          URI::Generic.build(
-            scheme:,
-            host:,
-            port:,
-            path:,
-            query: query_string.nil? || query_string.empty? ? nil : query_string
-          ).to_s
-        end
-
-        def inputs
-          @inputs ||= parsed_body.merge(parsed_query_string)
-        end
-
-        def full_command_name
-          unless defined?(@full_command_name)
-            set_action_and_command_name
-          end
-
-          @full_command_name
-        end
-
-        def parsed_body
-          body.empty? ? {} : JSON.parse(body)
-        end
-
-        def parsed_query_string
-          if query_string.nil? || query_string.empty?
-            {}
-          else
-            # TODO: override this in rack connector to use better rack utils
-            CGI.parse(query_string).transform_values!(&:first)
-          end
-        end
-
-        def action
-          unless defined?(@action)
-            set_action_and_command_name
-          end
-
-          @action
-        end
-
-        def argument
-          path.split("/")[2]
-        end
-
-        def set_action_and_command_name
-          @action, @full_command_name = path[1..].split("/")
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http/response.rb

@@ -1,14 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      class Response < CommandConnectors::Response
-        attr_accessor :headers
-
-        def initialize(headers:, **)
-          self.headers = headers
-          super(**)
-        end
-      end
-    end
-  end
-end

data/projects/command_connectors_http/src/http.rb

@@ -1,93 +0,0 @@
-module Foobara
-  module CommandConnectors
-    class Http < CommandConnector
-      include TruncatedInspect
-
-      def request_to_command(context)
-        if context.method == "OPTIONS"
-          # TODO: this feels a bit hacky and like overkill...
-          return Foobara::CommandConnectors::Http::Commands::GetOptions.new
-        end
-
-        command = super
-
-        if context.action == "help"
-          # Let's unwrap the transformed command to avoid serialization
-          # TODO: maybe instead register Help without serializers?
-          command = command.command
-        end
-
-        command
-      end
-
-      # TODO: eliminate passing the command here...
-      def request_to_response(request)
-        command = request.command
-        outcome = command.outcome
-
-        # TODO: feels awkward to call this here... Maybe use result/errors transformers instead??
-        # Or call the serializer here??
-        body = command.respond_to?(:serialize_result) ? command.serialize_result : outcome.result
-
-        status = if outcome.success?
-                   200
-                 else
-                   errors = outcome.errors
-
-                   if errors.size == 1
-                     error = errors.first
-
-                     case error
-                     when CommandConnector::UnknownError
-                       500
-                     when CommandConnector::NotFoundError, Foobara::Entity::NotFoundError
-                       # TODO: we should not be coupled to Entities here...
-                       body ||= "Not found"
-                       404
-                     when CommandConnector::UnauthenticatedError
-                       401
-                     when CommandConnector::NotAllowedError
-                       403
-                     end
-                   end || 422
-                 end
-
-        headers = headers_for(request)
-
-        Response.new(status:, headers:, body:, request:)
-      end
-
-      def headers_for(request)
-        response_headers = request.response_headers
-
-        if response_headers.nil? || !response_headers.key?("content-type")
-          if request.command.respond_to?(:serialize_result)
-            # TODO: we should ask the request this not the command.
-            if request.command.serializers.include?(Serializers::JsonSerializer)
-              response_headers = (response_headers || {}).merge("content-type" => "application/json")
-            end
-          end
-        end
-
-        if response_headers
-          static_headers.merge(response_headers)
-        else
-          static_headers.dup
-        end
-      end
-
-      private
-
-      def static_headers
-        @static_headers ||= ENV.each_with_object({}) do |(key, value), headers|
-          match = key.match(/\AFOOBARA_HTTP_RESPONSE_HEADER_(.*)\z/)
-
-          if match
-            header_name = match[1].downcase.tr("_", "-")
-            headers[header_name] = value
-          end
-        end.freeze
-      end
-    end
-  end
-end