foobara 0.0.73 → 0.0.74

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1326856ed75154d47fbe351c8d7a4ba08dafd269d5dcdd8e3c305dd3f047c7b3
-  data.tar.gz: 4d000b83ad506c73cc4f0cfb4822bf5f624ad311a37c3afc56450b1d3b68d794
+  metadata.gz: 354b23b90ef7ec29ac1126a3ee0ddda231253be5e33731041f80d77414c64e66
+  data.tar.gz: 2270ba278df777156963416623bb69418b596490cdbda7d40a2464322c17afd0
 SHA512:
-  metadata.gz: 967a37b97638d59fe862a6712a952808ee90bbd9d79c32aea83ebb87abe0c77ff7c0cca955b0935b1b0c134729189254b27bf627367302aab217396cbca0ce99
-  data.tar.gz: 5d06f9149366ed0d1fe8fe5a72ea7aca5f4f9c33c837d000ebbb1b40d83bf1da90c01a9ba7aa9236e6d79de432d1570d21597a5c5d6c98936f51db9526a7fc67
+  metadata.gz: bed611a57a66223eeba89f046a2aefdcaaca8ba7afadcd2a77a63817104c7bb39c449148109f6d0d2a3061fa00fb4665c7c0ca06384ecb0cd81ca7738101d268
+  data.tar.gz: 7463d91432204996f68590e23d79ffba7d0b067d946a37462a5da7a50f4e726383075f0d4d15d6a8639ae8387b24d5d867ba7b8cf74e66705c02287978d2ca75

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# [0.0.74] - 2025-03-15
+
+- fix bug where a command connector won't expose the non-global domain of a type if the command it depends on
+  is in the global domain
+
 # [0.0.73] - 2025-03-11
 
 - Fix bug preventing false from being used as a default in the Attributes::Dsl

data/README.md

@@ -1052,7 +1052,7 @@ Let's install foobara-remote-imports:
 $ gem install foobara-remote-imports
 ```
 
-And lLet's create a new script and import our various Capybara commands over HTTP:
+And let's create a new script and import our various Capybara commands over HTTP:
 
 ```ruby
 #!/usr/bin/env ruby

data/projects/command_connectors/src/command_connector.rb

@@ -354,8 +354,6 @@ module Foobara
 
       # Drive all of this off of the list of exposed commands...
       to_include = Set.new
-      to_include << command_registry.exposed_global_organization
-      to_include << command_registry.exposed_global_domain
 
       command_registry.foobara_each do |exposed_whatever|
         to_include << exposed_whatever

data/projects/command_connectors/src/command_registry/exposed_command.rb

@@ -94,7 +94,26 @@ module Foobara
         @full_command_symbol ||= Util.underscore_sym(full_command_name)
       end
 
+      def root_registry
+        parent = scoped_namespace
+        parent = parent.scoped_namespace while parent.scoped_namespace
+        parent
+      end
+
       def foobara_manifest(to_include: Set.new)
+        # A bit of a hack here. We don't have an exposed type class to encapsulate including exposed domains/orgs
+        # which leads to a bug when a global command is exposed that depends on a type in a non-global domain
+        # but there being no other reason to include that non-global domain.
+        transformed_command_class.types_depended_on.select(&:registered?).each do |type|
+          full_domain_name = type.foobara_domain.scoped_full_name
+
+          unless root_registry.foobara_lookup_domain(full_domain_name)
+            exposed_domain = root_registry.build_and_register_exposed_domain(full_domain_name)
+            to_include << exposed_domain
+            to_include << exposed_domain.foobara_organization
+          end
+        end
+
         transformed_command_class.foobara_manifest(to_include:).merge(super).merge(
           Util.remove_blank(
             scoped_category: :command,

data/projects/command_connectors/src/command_registry/exposed_domain.rb

@@ -15,6 +15,8 @@ module Foobara
 
       # TODO: unable to address types here so it is handled as a hack higher up...
       def foobara_manifest(to_include: Set.new)
+        to_include << foobara_organization
+
         domain_manifest = domain_module.foobara_manifest(to_include: Set.new)
         mode = Foobara::Namespace::LookupMode::DIRECT
         commands = foobara_all_command(mode:).map(&:foobara_manifest_reference).sort
@@ -22,6 +24,17 @@ module Foobara
         domain_manifest.merge(commands:)
       end
 
+      def foobara_organization
+        full_org_name = domain_module.foobara_organization.scoped_full_name
+        root_registry.foobara_lookup_organization(full_org_name)
+      end
+
+      def root_registry
+        parent = scoped_namespace
+        parent = parent.scoped_namespace while parent.scoped_namespace
+        parent
+      end
+
       def foobara_manifest_reference
         domain_module.foobara_manifest_reference
       end

data/projects/command_connectors/src/command_registry.rb

@@ -100,16 +100,6 @@ module Foobara
       exposed_organization
     end
 
-    def exposed_global_domain
-      exposed_global_organization.foobara_lookup_domain("") ||
-        build_and_register_exposed_domain("")
-    end
-
-    def exposed_global_organization
-      foobara_lookup_organization("") ||
-        build_and_register_exposed_organization("")
-    end
-
     def [](name)
       if name.is_a?(Class)
         name.full_command_name

data/projects/model/src/model.rb

@@ -182,7 +182,8 @@ module Foobara
 
       if options[:ignore_unexpected_attributes]
         Thread.foobara_with_var(:foobara_ignore_unexpected_attributes, true) do
-          return initialize(attributes, options.except(:ignore_unexpected_attributes))
+          initialize(attributes, options.except(:ignore_unexpected_attributes))
+          return
         end
       end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.73
+  version: 0.0.74
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-03-12 00:00:00.000000000 Z
+date: 2025-03-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal