foobara 0.0.63 → 0.0.65

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 51f412dd4ee9050badd64dfc8e1ec04e82f500ca4b11108ac87ec7303df68cdf
-  data.tar.gz: 3c6a97a2c94639a964a728ffdf3a11cab2c1cd7bc3e966f2eb37b5b5de2a8af0
+  metadata.gz: 21197ef384605690acb82fc34c7e05508e876b9659ff7aeb3cb068b9f3d2e43f
+  data.tar.gz: 9fa7bb5281ce36f1b62b57860e29b618d58d1ae18b3a6e9212e370549d1b0f6f
 SHA512:
-  metadata.gz: 62575b0f550c8dd9128f2d49d7b48fbda69af9f207533db1ca7a16c37981994506dcd4ba81b43efea51407bf14258bf7fa1f96e81a76aa006a0041641430a2d7
-  data.tar.gz: 345c92a3db7720d4b8710296e15c8a1ead1a445f87820120f0874a8940ac48ea4fbac83fafdb8af6e4de7e0c60c40e352be1cdf7061e89fe8f35d52e5c584267
+  metadata.gz: 43f5d7f1caf9380fd20d3b68a277e43c1a2efbcf226096892c2cc9cfaed8dbfc7591a16024f01a4e57f6e3c0bb590f04e8bfb823007b353dbe15ca735e4a9d1b
+  data.tar.gz: 97bbe6d2d1c24827ca1210713b7e65e3f63dfb69bf7a312aab4f3631b4bf867b41dcdd2a9692cb626d563ad4166e433955dbf5bfd1d1154ac950b902bb0df0ce

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## [0.0.65] - 2025-02-26
+
+- Fix a problem when looking up domain mappers with a symbol value that doesn't represent a type
+
+## [0.0.64] - 2025-02-25
+
+- Fix bug where DomainMappers created after commands have ran wouldn't be detected
+- Expose Enumerated::Values#value?
+- Allow passing a hash to DomainMapper#new
+
 ## [0.0.63] - 2025-02-25
 
 - Allow creating an Enumerated from a list of value strings that contain colons

data/projects/domain/src/domain_module_extension.rb

@@ -133,7 +133,25 @@ module Foobara
           super
         end
 
-        def foobara_domain_map(value, to: nil, strict: false, criteria: nil, should_raise: false, **opts)
+        def foobara_domain_map(*args, to: nil, strict: false, criteria: nil, should_raise: false, **opts)
+          case args.size
+          when 1
+            value = args.first
+          when 0
+            if opts.empty?
+              # :nocov:
+              raise ArgumentError, "Expected at least one argument"
+              # :nocov:
+            else
+              value = opts
+              opts = {}
+            end
+          else
+            # :nocov:
+            raise ArgumentError, "Expected 1 argument but got #{args.size}"
+            # :nocov:
+          end
+
           invalid_keys = opts.keys - [:from]
 
           if invalid_keys.any?
@@ -145,17 +163,11 @@ module Foobara
           from = if opts.key?(:from)
                    opts[:from]
                  else
-                   try_nil = true
                    value
                  end
 
           mapper = lookup_matching_domain_mapper(from:, to:, criteria:, strict:)
 
-          if try_nil
-            from = nil
-            mapper = lookup_matching_domain_mapper(from:, to:, criteria:, strict:)
-          end
-
           if mapper
             mapper.map!(value)
           elsif should_raise
@@ -163,8 +175,8 @@ module Foobara
           end
         end
 
-        def foobara_domain_map!(value, from: nil, to: nil, criteria: nil, strict: false)
-          foobara_domain_map(value, from:, to:, criteria:, strict:, should_raise: true)
+        def foobara_domain_map!(*, **, &)
+          foobara_domain_map(*, should_raise: true, **, &)
         end
 
         def foobara_domain_name

data/projects/domain_mapper/src/domain_mapper.rb

@@ -6,6 +6,10 @@ module Foobara
     include CommandPatternImplementation
 
     class << self
+      def foobara_on_register
+        foobara_domain.new_mapper_registered!
+      end
+
       def map(value)
         new(from: value).run
       end
@@ -54,7 +58,7 @@ module Foobara
 
         type = object_to_type(type_indicator)
 
-        return 1 if type.nil?
+        return 0 if type.nil?
         return 9 if type == value
 
         return 5 if type.applicable?(value) && type.process_value(value).success?
@@ -100,7 +104,7 @@ module Foobara
             when Types::Type
               object
             when ::Symbol
-              domain.foobara_lookup_type!(object)
+              domain.foobara_lookup_type(object)
             end
           end
         end

data/projects/domain_mapper/src/domain_mapper_lookups.rb

@@ -40,6 +40,12 @@ module Foobara
     include Concern
 
     module ClassMethods
+      def new_mapper_registered!
+        if defined?(@mappers) && !@mappers.empty?
+          remove_instance_variable("@mappers")
+        end
+      end
+
       def lookup_matching_domain_mapper!(from: nil, to: nil, strict: false, criteria: nil)
         result = lookup_matching_domain_mapper(from:, to:, strict:, criteria:)
 

data/projects/enumerated/src/values.rb

@@ -125,7 +125,7 @@ module Foobara
         mod = Module.new
         enumerated = self
 
-        %i[all all_names all_values].each do |method_name|
+        %i[all all_names all_values value?].each do |method_name|
           mod.singleton_class.define_method method_name do |*args, **opts, &block|
             enumerated.send(method_name, *args, **opts, &block)
           end

data/projects/namespace/src/is_namespace.rb

@@ -78,6 +78,10 @@ module Foobara
         foobara_registry.register(scoped)
         # awkward??
         scoped.scoped_namespace = self
+
+        if scoped.respond_to?(:foobara_on_register)
+          scoped.foobara_on_register
+        end
       rescue PrefixlessRegistry::RegisteringScopedWithPrefixError,
              BaseRegistry::WouldMakeRegistryAmbiguousError => e
         _upgrade_registry(e)

data/projects/types/src/type.rb

@@ -154,6 +154,10 @@ module Foobara
       def target_class
         if target_classes.empty?
           # :nocov:
+          # TODO: We really need a better error message when we hit this point in the code path.
+          # One thing that can cause this is if you create a custom type called :model but it isn't loaded
+          # yet and we accidentally are referring to the builtin :model type.  This error message doesn't reveal
+          # that you need to require the custom :model.
           raise "No target classes"
           # :nocov:
         elsif target_classes.size > 1

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.63
+  version: 0.0.65
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-02-25 00:00:00.000000000 Z
+date: 2025-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal