foobara 0.0.46 → 0.0.48

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60195fb6137fde10c6e482bbdb9c6845571ba1267fbb4c3721f4f5c131b3d778
-  data.tar.gz: 7918eb25d72cab1718160c65e0f1ed4b90c4ee70bb0ae5f44176b918d81b55f3
+  metadata.gz: 7c661c32185af433ba2355ce71bf37524893d00901a6e885ab5bd874339e48b6
+  data.tar.gz: 8ab10b8b9191bc81548d07269ca8c4906515164aa87a702ac7b944170e2420a7
 SHA512:
-  metadata.gz: 0cc9c5ed39003bcd9b4553341a047f617287555e5000d356282a1f0438da6aacbb876db56c3464590bde0b43998af2969ad14715edfc2562a00d3d2557ce20e5
-  data.tar.gz: 0aa89dab1a24bdf943e7caec711caa1ffec58f6769a0d543a97b2a7e839c82cd9559a90e6d9e2f4e51895f862ed3cfa7bbeff19eadb43977a2081359a465dd1f
+  metadata.gz: 3aaff8aa022ea5cf95ab300430576fbf08d813ccd2344630b035bf54372826fda4de76e5b7d9937e70278fcc7b0c23973d4499be25ad1531401b8b82004c153a
+  data.tar.gz: ffbc1887647b08588f218798cb99ab27af30ece05d4540926cb521a429c3dc9a4d992163802528f9f3a8022a52558e5158ee4b5b13dbe297a2e6036393ec49dd

data/CHANGELOG.md

@@ -1,8 +1,11 @@
-## [0.0.46] - 2025-01-03
+## [0.0.48] - 2025-01-17
+
+- Add support for foobara_attributes_type to allow ActiveRecordType gem to work
+
+## [0.0.47] - 2025-01-03
 
 - Bumped Ruby from 3.2.2 to 3.4.1
 - Allow passing in a module when registering a "builtin" type
-- Fix AttributesHandlerDesugarizer and PrimaryKeyDesugarizer bugs
 
 ## [0.0.42] - 2024-12-23
 

data/projects/command/src/concerns/errors.rb

@@ -91,7 +91,7 @@ module Foobara
 
                     error_class = self.class.lookup_input_error_class(symbol, path)
                     error_class.new(**error_args, path:)
-                  elsif args.size == 2 || args.size == 3
+                  elsif [2, 3].include?(args.size)
                     input, symbol, message = args
                     context = opts
 
@@ -143,7 +143,7 @@ module Foobara
 
                     error_class = self.class.lookup_runtime_error_class(symbol)
                     error_class.new(**error_args)
-                  elsif args.is_a?(::Array) && (args.size == 1 || args.size == 2)
+                  elsif args.is_a?(::Array) && [1, 2].include?(args.size)
                     symbol, message = args
                     context = opts
 

data/projects/command/src/concerns/inputs.rb

@@ -2,6 +2,8 @@ module Foobara
   class Command
     module Concerns
       module Inputs
+        class UnexpectedInputValidationError < StandardError; end
+
         include Concern
 
         attr_reader :inputs
@@ -41,9 +43,8 @@ module Foobara
               if error.is_a?(Value::DataError)
                 add_input_error(error)
               else
-                # TODO: raise a real error
                 # :nocov:
-                raise "wtf"
+                raise UnexpectedInputValidationError, "Unexpected input validation error: #{error}"
                 # :nocov:
               end
             end

data/projects/detached_entity/src/concerns/associations.rb

@@ -109,6 +109,8 @@ module Foobara
             end
           end
 
+          # TODO: this big switch is a problem. Hard to create new types in other projects without being able
+          # to modify this switch.  Figure out what to do.
           def construct_associations(
             type = attributes_type,
             path = DataPath.new,
@@ -135,7 +137,12 @@ module Foobara
                 construct_associations(element_type, path.append(attribute_name), result)
               end
             elsif type.extends?(BuiltinTypes[:model])
-              construct_associations(type.target_class.attributes_type, path, result)
+              target_class = type.target_class
+
+              method = target_class.respond_to?(:foobara_attributes_type) ? :foobara_attributes_type : :attributes_type
+              attributes_type = target_class.send(method)
+
+              construct_associations(attributes_type, path, result)
             elsif type.extends?(BuiltinTypes[:associative_array])
               # not going to bother testing this for now
               # :nocov:

data/projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration/primary_key_desugarizer.rb

@@ -4,11 +4,9 @@ module Foobara
       class ExtendDetachedEntityTypeDeclaration < ExtendModelTypeDeclaration
         class PrimaryKeyDesugarizer < Desugarizer
           def applicable?(sugary_type_declaration)
-            if sugary_type_declaration.is_a?(::Hash)
-              primary_key = sugary_type_declaration[:primary_key]
+            primary_key = sugary_type_declaration[:primary_key]
 
-              primary_key.is_a?(::String)
-            end
+            primary_key.is_a?(::String)
           end
 
           def desugarize(sugary_type_declaration)

data/projects/manifest/src/foobara/manifest/type.rb

@@ -53,7 +53,7 @@ module Foobara
       end
 
       def model?
-        return false if reference == "entity" || reference == "detached_entity"
+        return false if %w[entity detached_entity].include?(reference)
 
         type = base_type
 

data/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/attributes_handler_desugarizer.rb

@@ -4,7 +4,7 @@ module Foobara
       class ExtendModelTypeDeclaration < ExtendRegisteredTypeDeclaration
         class AttributesHandlerDesugarizer < TypeDeclarations::Desugarizer
           def applicable?(sugary_type_declaration)
-            sugary_type_declaration.is_a?(::Hash) && sugary_type_declaration[:type] == expected_type_symbol
+            sugary_type_declaration[:type] == expected_type_symbol
           end
 
           def expected_type_symbol

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.46
+  version: 0.0.48
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-01-03 00:00:00.000000000 Z
+date: 2025-01-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal