foobara 0.0.38 → 0.0.39

data/projects/builtin_types/src/builtin_types.rb

@@ -20,29 +20,50 @@ module Foobara
 
         builtin_type_module = const_get(module_symbol, false)
 
+        processor_classes_requiring_type = []
+
         casters_module = Util.constant_value(builtin_type_module, :Casters)
         caster_classes = if casters_module
                            Util.constant_values(casters_module, extends: Value::Processor)
                          end
-        casters = caster_classes&.map do |caster_class|
-          caster_class.new_with_agnostic_args(parent_declaration_data: declaration_data)
+        casters = []
+        caster_classes&.each do |caster_class|
+          if caster_class.respond_to?(:requires_type?) && caster_class.requires_type?
+            processor_classes_requiring_type << caster_class
+          else
+            casters << caster_class.new_with_agnostic_args(parent_declaration_data: declaration_data)
+          end
         end
 
         transformers_module = Util.constant_value(builtin_type_module, :Transformers)
         transformer_classes = if transformers_module
                                 Util.constant_values(transformers_module, extends: Value::Processor)
                               end
-        transformers = transformer_classes&.map do |transformer_class|
-          transformer_class.new_with_agnostic_args(parent_declaration_data: declaration_data)
-        end || []
+        transformers = []
+        transformer_classes&.each do |transformer_class|
+          if transformer_class.respond_to?(:requires_type?) && transformer_class.requires_type?
+            # :nocov:
+            processor_classes_requiring_type << transformer_class
+            # :nocov:
+          else
+            transformers << transformer_class.new_with_agnostic_args(parent_declaration_data: declaration_data)
+          end
+        end
 
         validators_module = Util.constant_value(builtin_type_module, :Validators)
         validator_classes = if validators_module
                               Util.constant_values(validators_module, extends: Value::Processor)
                             end
-        validators = validator_classes&.map do |validator_class|
-          validator_class.new_with_agnostic_args(parent_declaration_data: declaration_data)
-        end || []
+        validators = []
+        validator_classes&.each do |validator_class|
+          if validator_class.respond_to?(:requires_type?) && validator_class.requires_type?
+            # :nocov:
+            processor_classes_requiring_type << validator_class
+            # :nocov:
+          else
+            validators << validator_class.new_with_agnostic_args(parent_declaration_data: declaration_data)
+          end
+        end
 
         type = Foobara::Types::Type.new(
           declaration_data,
@@ -54,7 +75,8 @@ module Foobara
           # TODO: this is for controlling casting or not casting but could give the wrong information from a
           # reflection point of view...
           target_classes:,
-          description:
+          description:,
+          processor_classes_requiring_type:
         )
 
         add_builtin_type(type)

data/projects/detached_entity/src/extensions/type_declarations/handlers/extend_detached_entity_type_declaration/to_type_transformer.rb

@@ -13,6 +13,7 @@ module Foobara
                 type = outcome.result
                 entity_class = type.target_class
 
+                # TODO: is this duplicated??
                 unless entity_class.primary_key_attribute
                   entity_class.primary_key(strict_declaration_type[:primary_key])
                 end

data/projects/entity/src/extensions/builtin_types/entity/casters/primary_key.rb

@@ -0,0 +1,39 @@
+module Foobara
+  module BuiltinTypes
+    module Entity
+      module Casters
+        class PrimaryKey < Value::Caster
+          class << self
+            def requires_declaration_data?
+              true
+            end
+
+            def requires_type?
+              true
+            end
+          end
+
+          def entity_class
+            declaration_data.target_class
+          end
+
+          def primary_key_type
+            entity_class.primary_key_type
+          end
+
+          def applicable?(value)
+            primary_key_type.applicable?(value)
+          end
+
+          def transform(primary_key)
+            entity_class.thunk(primary_key)
+          end
+
+          def applies_message
+            primary_key_type.value_caster.applies_message
+          end
+        end
+      end
+    end
+  end
+end

data/projects/entity/src/extensions/type_declarations/handlers/extend_entity_type_declaration/to_type_transformer.rb

@@ -3,35 +3,6 @@ module Foobara
     module Handlers
       class ExtendEntityTypeDeclaration < ExtendDetachedEntityTypeDeclaration
         class ToTypeTransformer < ExtendDetachedEntityTypeDeclaration::ToTypeTransformer
-          # TODO: move this to a more appropriate place
-          class EntityPrimaryKeyCaster < Value::Caster
-            class << self
-              def requires_declaration_data?
-                true
-              end
-            end
-
-            def entity_class
-              declaration_data
-            end
-
-            def primary_key_type
-              entity_class.primary_key_type
-            end
-
-            def applicable?(value)
-              primary_key_type.applicable?(value)
-            end
-
-            def transform(primary_key)
-              entity_class.thunk(primary_key)
-            end
-
-            def applies_message
-              primary_key_type.value_caster.applies_message
-            end
-          end
-
           def process_value(strict_declaration_type)
             super.tap do |outcome|
               if outcome.success?
@@ -43,8 +14,6 @@ module Foobara
                     caster.is_a?(Foobara::BuiltinTypes::Entity::Casters::Hash)
                   end
                 end
-
-                type.casters << EntityPrimaryKeyCaster.new(entity_class)
               end
             end
           end

data/projects/model/src/extensions/builtin_types/model/{transformers → supported_transformers}/mutable.rb

@@ -2,9 +2,13 @@ module Foobara
   module BuiltinTypes
     module Model
       # TODO: Create Mutations/SupportedMutations concept
-      class Transformers
+      class SupportedTransformers
         class Mutable < TypeDeclarations::Transformer
           class << self
+            def requires_declaration_data?
+              true
+            end
+
             def requires_parent_declaration_data?
               true
             end

data/projects/model/src/extensions/builtin_types/model/validators/attributes_declaration.rb

@@ -7,6 +7,10 @@ module Foobara
             def requires_parent_declaration_data?
               true
             end
+
+            def requires_declaration_data?
+              false
+            end
           end
 
           def always_applicable?

data/projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/to_type_transformer.rb

@@ -16,7 +16,7 @@ module Foobara
           # TODO: create declaration validator for name and the others
           # TODO: seems like a smell that we don't have processors for these?
           def non_processor_keys
-            [:name, :model_class, :model_base_class, :model_module, :attributes_declaration, :mutable, *super]
+            [:name, :model_class, :model_base_class, :model_module, :attributes_declaration, *super]
           end
 
           def process_value(...)

data/projects/model/src/extensions/type_declarations/handlers/extend_registered_model_type_declaration/to_type_transformer.rb

@@ -16,10 +16,6 @@ module Foobara
           def declaration_to_type(strict_type_declaration)
             type_for_declaration(strict_type_declaration[:type])
           end
-
-          def non_processor_keys
-            [:mutable, *super]
-          end
         end
       end
     end

data/projects/types/src/type.rb

@@ -25,7 +25,8 @@ module Foobara
                     :raw_declaration_data,
                     :name,
                     :target_classes,
-                    :description
+                    :description,
+                    :processor_classes_requiring_type
       attr_reader :type_symbol
 
       def initialize(
@@ -41,6 +42,7 @@ module Foobara
         element_type: nil,
         element_types: nil,
         structure_count: nil,
+        processor_classes_requiring_type: nil,
         **opts
       )
         self.base_type = base_type
@@ -56,12 +58,57 @@ module Foobara
         self.element_type = element_type
         self.name = name
         self.target_classes = Util.array(target_classes)
+        self.processor_classes_requiring_type = processor_classes_requiring_type
 
         super(*, **opts.merge(processors:, prioritize: false))
 
+        apply_all_processors_needing_type!
+
         validate_processors!
       end
 
+      def apply_all_processors_needing_type!
+        each_processor_class_requiring_type do |processor_class|
+          # TODO: is this a smell?
+          processor = processor_class.new(self)
+
+          category = case processor
+                     when Value::Caster
+                       casters
+                     when Value::Validator
+                       # :nocov:
+                       validators
+                       # :nocov:
+                     when Value::Transformer
+                       # :nocov:
+                       transformers
+                       # :nocov:
+                     when Types::ElementProcessor
+                       # :nocov:
+                       element_processors
+                       # :nocov:
+                     else
+                       # TODO: add validator that these are all fine so we don't have to bother here...
+                       # :nocov:
+                       raise "Not sure where to put #{processor}"
+                       # :nocov:
+                     end
+
+          symbol = processor.symbol
+          category.delete_if { |p| p.symbol == symbol }
+
+          category << processor
+        end
+      end
+
+      def each_processor_class_requiring_type(&block)
+        base_type&.each_processor_class_requiring_type(&block)
+
+        processor_classes_requiring_type&.each do |processor_class|
+          block.call(processor_class)
+        end
+      end
+
       def validate_processors!
         all = [casters, transformers, validators, element_processors]
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.38
+  version: 0.0.39
 platform: ruby
+original_platform: ''
 authors:
 - Miles Georgi
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-11 00:00:00.000000000 Z
+date: 2024-12-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foobara-util
@@ -218,6 +218,7 @@ files:
 - projects/entity/src/entity.rb
 - projects/entity/src/extensions/builtin_types/entity.rb
 - projects/entity/src/extensions/builtin_types/entity/casters/hash.rb
+- projects/entity/src/extensions/builtin_types/entity/casters/primary_key.rb
 - projects/entity/src/extensions/builtin_types/entity/validators/attributes_declaration.rb
 - projects/entity/src/extensions/type_declarations/handlers/extend_entity_type_declaration.rb
 - projects/entity/src/extensions/type_declarations/handlers/extend_entity_type_declaration/attributes_handler_desugarizer.rb
@@ -260,7 +261,7 @@ files:
 - projects/model/src/concerns/reflection.rb
 - projects/model/src/concerns/types.rb
 - projects/model/src/extensions/builtin_types/model/casters/hash.rb
-- projects/model/src/extensions/builtin_types/model/transformers/mutable.rb
+- projects/model/src/extensions/builtin_types/model/supported_transformers/mutable.rb
 - projects/model/src/extensions/builtin_types/model/validators/attributes_declaration.rb
 - projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration.rb
 - projects/model/src/extensions/type_declarations/handlers/extend_model_type_declaration/attributes_handler_desugarizer.rb
@@ -382,7 +383,6 @@ metadata:
   source_code_uri: https://foobara.com
   changelog_uri: https://foobara.com/blob/main/CHANGELOG.md
   rubygems_mfa_required: 'true'
-post_install_message:
 rdoc_options: []
 require_paths:
 - "./projects/builtin_types/lib"
@@ -422,8 +422,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.23
-signing_key:
+rubygems_version: 3.6.0
 specification_version: 4
 summary: A command-centric and discoverable software framework with a focus on domain
   concepts and abstracting away integration code