foobara 0.0.27 → 0.0.28

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 463e274d4eb6227cdf473fc12bab4a7519db226c07f458c7bd04e8a9f84f1440
-  data.tar.gz: bfaaf65911fb2c87363ea619f58ea042b1236653797d11ab9c59793f83b26d34
+  metadata.gz: 8bfc7b95d3e92c97900136f5ddf441f5229f71d1884bc37a8439dc5e4e3e727a
+  data.tar.gz: fe04bd8fbc04cc7c8ec86aea2c4ce0390de2da79073d3f1236eaca00d63e6bb9
 SHA512:
-  metadata.gz: 34f1340468762419907715d77f6f98e13ee551b645bc94c258984458dd2120ed5e607f8ea6148f5fdda3f53ceae1ad981bf82a522060bae948869119b309fa45
-  data.tar.gz: 945c3807af1fdf55aab4e87bc635abfc8ee1bec12ff5458ee5c4336a71174f5671f768e87daa72bfc97178ad10a9ebefc3b93757a9afd8d276ee50f5bc2202b8
+  metadata.gz: 04ce017d39e5fa817da0f37402eee57a1c7cfc858ac9c88c9cda3bbf8d8515a489d7f3771d3df0ed038aa88bdfed34f3bb34ef7cb0fb56e28940fa7a7d130967
+  data.tar.gz: 5dc2e9c070253ead42dcdda5dd95100ac21a0ecd069c2b4bf8705f00b754275bb2aa87cece6473e453b4be25c918683b0e7115d9d605d33f05ad45f85bf7f5fa

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.28] - 2024-12-05
+
+- Make Domain#foobara_depends_on? give a more intuitive answer
+
 ## [0.0.27] - 2024-12-04
 
 - Add some Error DSL convenience methods (symbol/message/context)

data/projects/command/src/concerns/subcommands.rb

@@ -20,7 +20,7 @@ module Foobara
           domain = self.class.domain
           sub_domain = subcommand_class.domain
 
-          unless domain.foobara_depends_on?(sub_domain)
+          unless domain.foobara_can_call_subcommands_from?(sub_domain)
             raise CannotAccessDomain,
                   "Cannot access #{sub_domain} or its commands because #{domain} does not depend on it"
           end

data/projects/domain/src/domain_module_extension.rb

@@ -353,16 +353,14 @@ module Foobara
           nil
         end
 
-        def foobara_depends_on?(other_domain)
+        def foobara_can_call_subcommands_from?(other_domain)
           other_domain = Domain.to_domain(other_domain)
+          other_domain == self || self == GlobalDomain || foobara_depends_on?(other_domain)
+        end
 
-          # TODO: Feels awkward to have to check if we're the global domain or not here.
-          # Also awkward to check if the other domain is global.
-          # Unclear what the solution is. To fix other domain check could just automatically call
-          # depends_on with the global domain in .foobara_domain! but not as clear how to fix the check
-          # against self.
-          self == GlobalDomain || other_domain == self || other_domain == GlobalDomain ||
-            foobara_depends_on.include?(other_domain.foobara_full_domain_name)
+        def foobara_depends_on?(other_domain)
+          other_domain = Domain.to_domain(other_domain)
+          other_domain == GlobalDomain || foobara_depends_on.include?(other_domain.foobara_full_domain_name)
         end
 
         def foobara_depends_on(*domains)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.27
+  version: 0.0.28
 platform: ruby
 authors:
 - Miles Georgi
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-12-04 00:00:00.000000000 Z
+date: 2024-12-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foobara-util