foobara 0.0.141 → 0.0.142

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 338a171937c3133f7c23ce219f6c67a22f464b30727cb0987b88ef8fa2ae0cf9
-  data.tar.gz: 89ba9d99021a7914338de39be6a38520849702e33e38d20da39dcce05ce3f9d0
+  metadata.gz: a6defed2fda94d3c5f244f9f24eb9a32f4d06999bc773071dc58667565518499
+  data.tar.gz: 98a0f663a38ce6b105f78fbbefdc1e34328654ec54755daa379df824753f3214
 SHA512:
-  metadata.gz: d6b27814d890df2c4f46455a944c226b054383ec2112ee7fa937c0b25743bd6fbb8f099c973ad3b8f7bc9a0d603be39f9c59e08ada848332213baec8a1a92475
-  data.tar.gz: 67cf268318f31ea950e63cdf58f6927853d43b226c70dea0e7b42889442c2dbf1a9925927f623df6e673e386fe9ad9d53c4b823f822e3a138bc040cf1d9bc78f
+  metadata.gz: 9c42abcbd62eba3583acfd4345df530ec04efdc18d19773ce1ed5dafa9e0d43d09364b2b45355a22874b2aeaf030d476726cbd214ec1a3626812b2a20c35133f
+  data.tar.gz: 7cc3b4e13250e4cc2b3af8468b2f5774861161fcc13972ecc87f17c1682bd8a69170a080b6f9cc72249ff5756d2a7f1ca509dfaeba2ac52bbf9896c8b9a4f3e6

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# [0.0.142] - 2025-08-10
+
+- Add LruCache to IsNamespace to speed up lookups
+
 # [0.0.141] - 2025-07-31
 
 - Fix bug returning a non-strict type declaration in the command connector manifest

data/projects/common/src/error_collection.rb

@@ -27,7 +27,7 @@ module Foobara
 
     def error_array
       # :nocov:
-      warn "DEPRECATED: Do not call ErrorCollection#errors instead just use the collection directly."
+      warn "DEPRECATED: Do not call ErrorCollection#error_array instead just use the collection directly."
       self
       # :nocov:
     end

data/projects/namespace/src/is_namespace.rb

@@ -3,6 +3,16 @@ require_relative "scoped"
 module Foobara
   class Namespace
     module IsNamespace
+      class << self
+        def lru_cache
+          @lru_cache ||= Foobara::LruCache.new(100)
+        end
+
+        def clear_lru_cache!
+          @lru_cache = nil
+        end
+      end
+
       include Scoped
 
       def scoped_clear_caches
@@ -90,6 +100,8 @@ module Foobara
 
       def foobara_register(scoped)
         foobara_registry.register(scoped)
+
+        IsNamespace.clear_lru_cache!
         # awkward??
         scoped.scoped_namespace = self
 
@@ -108,6 +120,8 @@ module Foobara
         foobara_registry.unregister(scoped)
         foobara_children.delete(scoped)
         scoped.scoped_namespace = nil
+
+        IsNamespace.clear_lru_cache!
       end
 
       def foobara_unregister_all
@@ -116,17 +130,30 @@ module Foobara
         end
       end
 
+      def lru_cache
+        IsNamespace.lru_cache
+      end
+
       def foobara_lookup(
         path,
         filter: nil,
         mode: LookupMode::GENERAL,
-        visited: Set.new,
+        visited: nil,
         initial: true
       )
+        # TODO: make it so this is only necessary when initial
         path = Namespace.to_registry_path(path)
         visited_key = [path, mode, initial, self]
-        return nil if visited.include?(visited_key)
 
+        if initial
+          lru_key = [path, mode, self, filter]
+          found, value = lru_cache.get(lru_key)
+          return value if found
+        end
+
+        return nil if visited&.include?(visited_key)
+
+        visited ||= Set.new
         visited << visited_key
 
         LookupMode.validate!(mode)
@@ -139,7 +166,13 @@ module Foobara
             visited:,
             initial: false
           )
-          return scoped if scoped
+          if scoped
+            if initial
+              lru_cache.set_if_missing(lru_key, scoped)
+            end
+
+            return scoped
+          end
 
           candidates = foobara_children.map do |namespace|
             namespace.foobara_lookup(path, filter:, mode:, visited:, initial: false)
@@ -152,8 +185,14 @@ module Foobara
             # :nocov:
           end
 
-          return candidates.first ||
-                 foobara_parent_namespace&.foobara_lookup(path, filter:, mode:, visited:, initial: false)
+          scoped = candidates.first ||
+                   foobara_parent_namespace&.foobara_lookup(path, filter:, mode:, visited:, initial: false)
+
+          if initial
+            lru_cache.set_if_missing(lru_key, scoped)
+          end
+
+          return scoped
         end
 
         if path[0] == ""
@@ -171,11 +210,19 @@ module Foobara
         partial = foobara_registry.lookup(path, filter)
 
         if mode == LookupMode::DIRECT
+          if initial
+            lru_cache.set_if_missing(lru_key, partial)
+          end
+
           return partial
         end
 
         if partial
           if partial.scoped_path == path
+            if initial
+              lru_cache.set_if_missing(lru_key, partial)
+            end
+
             return partial
           end
         end
@@ -187,18 +234,39 @@ module Foobara
         end
 
         scoped = _lookup_in(path, to_consider, filter:, visited:)
-        return scoped if scoped
+
+        if scoped
+          if initial
+            lru_cache.set_if_missing(lru_key, scoped)
+          end
+
+          return scoped
+        end
 
         if [LookupMode::GENERAL, LookupMode::STRICT].include?(mode) && foobara_parent_namespace
           scoped = foobara_parent_namespace.foobara_lookup(
             path, filter:, mode: LookupMode::STRICT, visited:, initial: false
           )
-          return scoped if scoped
+
+          if scoped
+            if initial
+              lru_cache.set_if_missing(lru_key, scoped)
+            end
+
+            return scoped
+          end
         end
 
         if mode == LookupMode::GENERAL
           scoped = _lookup_in(path, foobara_depends_on_namespaces, filter:, visited:)
-          return scoped if scoped
+
+          if scoped
+            if initial
+              lru_cache.set_if_missing(lru_key, scoped)
+            end
+
+            return scoped
+          end
         end
 
         to_consider = case mode
@@ -219,7 +287,14 @@ module Foobara
         end
 
         scoped = candidates.first || partial
-        return scoped if scoped
+
+        if scoped
+          if initial
+            lru_cache.set_if_missing(lru_key, scoped)
+          end
+
+          return scoped
+        end
 
         # As a last resort we'll see if we're trying to fetch a builtin type from a different namespace
         # TODO: these lookup modes are really confusing and were designed prior to having multiple root
@@ -228,6 +303,7 @@ module Foobara
           scoped = Namespace.global.foobara_lookup(path, filter:, mode: LookupMode::ABSOLUTE, visited:, initial: false)
 
           if scoped.is_a?(Types::Type) && scoped.builtin?
+            lru_cache.set_if_missing(lru_key, scoped)
             scoped
           end
         end

data/projects/type_declarations/src/handlers/registered_type_declaration/short_type_name_desugarizer.rb

@@ -7,11 +7,10 @@ module Foobara
         class ShortTypeNameDesugarizer < TypeDeclarations::Desugarizer
           def applicable?(sugary_type_declaration)
             return false if TypeDeclarations.strict_stringified? || TypeDeclarations.strict?
+            return false unless sugary_type_declaration.is_a?(::Hash)
 
             sugary_type_declaration = sugary_type_declaration.dup
 
-            return false unless sugary_type_declaration.is_a?(::Hash)
-
             sugary_type_declaration = normalize_type(sugary_type_declaration)
 
             if sugary_type_declaration.key?(:type) &&

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.141
+  version: 0.0.142
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-07-31 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -27,44 +27,44 @@ dependencies:
   name: foobara-lru-cache
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.0.2
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.0.2
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: foobara-util
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 2.0.0
 - !ruby/object:Gem::Dependency
   name: inheritable-thread-vars
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.0.1
+        version: 2.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<"
       - !ruby/object:Gem::Version
-        version: 0.0.1
+        version: 2.0.0
 description: A command-centric and discoverable software framework with a focus on
   domain concepts and abstracting away integration code
 email:
@@ -535,7 +535,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.9
 specification_version: 4
 summary: A command-centric and discoverable software framework with a focus on domain
   concepts and abstracting away integration code