foobara 0.0.136 → 0.0.138

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f944c52f318016bd2742fb96208d11a2647d4802ee0a1ac4fbb5b353c5d6ad4
-  data.tar.gz: 5c7560766afe430188cd41053ce9f470eae20605dba8dde824432b760e6aa336
+  metadata.gz: 6b67d70479dbaf49e1fb2c7fc255e96fefb41b1952c245baf75c3e677a451604
+  data.tar.gz: 618030d55da35eb987e63473a4cf50effa7aac62fed0d617a70758099dd40f50
 SHA512:
-  metadata.gz: 3bf5da1d2282282a3d17eb44a0f8ca815c525800f71de56a05ed1c1b66babf5662293a0549df8a2ba6ee88da6cca7fe334f7a852d82b010afcf05f6d21ba1541
-  data.tar.gz: 1444d194eaa3389270cdd23422ec294a59f523e1a71291a92551951987b54c7e316ce724465f7d0fa1151e5c7c2bad84879435eac2908c402f1c3ee888224c5f
+  metadata.gz: 9645d95fdcf186a9a1575af9d7d637e0703db3fc80cab9e58a293cc97a2bb37d21f655120057dba2dc533841d5a4836cec904da8f488a22ec182266ad8cc3137
+  data.tar.gz: d72777452ea575fcb2420e8edc41240eed16e46b603d3896be84c0a9568774a12aba385bef69a15f552f9540e1c3e54be5f37d98e3791cb6f990f85711b71a16

data/CHANGELOG.md

@@ -1,3 +1,16 @@
+# [0.0.138] - 2025-07-23
+
+- Allow #foobara_unregister by symbol, string, or array path
+
+# [0.0.137] - 2025-07-22
+
+- Fix bug where update_children_with_new_parent processes a scoped with itself
+- Don't double-create Reject inputs transformers
+- Fix description bug when transforming an entity to its primary key type
+- Add .raise_if_production method to all uses of reset_all(s)
+- Move the start_with? method another repository
+- Prevent attributes transformers without attributes
+
 # [0.0.136] - 2025-07-06
 
 - Do not allow calling Foobara.reset_alls in production

data/projects/builtin_types/lib/foobara/builtin_types.rb

@@ -64,6 +64,7 @@ module Foobara
       end
 
       def reset_all
+        Foobara.raise_if_production!("reset_all")
         builtin_types.each do |builtin_type|
           builtin_type.foobara_each do |scoped|
             if scoped.scoped_namespace == builtin_type

data/projects/command/lib/foobara/command.rb

@@ -9,6 +9,7 @@ module Foobara
       end
 
       def reset_all
+        Foobara.raise_if_production!("reset_all")
         to_delete = []
 
         all.each do |command_class|

data/projects/command/src/command_pattern_implementation/concerns/reflection.rb

@@ -16,6 +16,7 @@ module Foobara
           end
 
           def reset_all
+            Foobara.raise_if_production!("reset_all")
             remove_instance_variable("@all") if instance_variable_defined?("@all")
           end
 

data/projects/command_connectors/lib/foobara/command_connectors.rb

@@ -24,6 +24,7 @@ module Foobara
       end
 
       def reset_all
+        Foobara.raise_if_production!("reset_all")
         remove_instance_variable("@desugarizer") if defined?(@desugarizer)
         remove_instance_variable("@desugarizers") if defined?(@desugarizers)
       end

data/projects/command_connectors/src/serializers/errors_serializer.rb

@@ -11,8 +11,7 @@ module Foobara
         end
 
         def serialize(error_collection)
-          errors = error_collection.errors
-          errors.map(&:to_h)
+          error_collection.map(&:to_h)
         end
       end
     end

data/projects/command_connectors/src/transformers/entity_to_primary_key_inputs_transformer.rb

@@ -52,13 +52,19 @@ module Foobara
 
               unless to_type.extends_directly?(Foobara::BuiltinTypes[:detached_entity]) ||
                      to_type.extends_directly?(Foobara::BuiltinTypes[:entity])
+
                 description = [
                   description,
-                  to_type.description
+                  *to_type.description
                 ].join(" : ")
               end
+
               declaration[:description] = description
 
+              if to_type.declaration_data.key?(:allow_nil)
+                declaration[:allow_nil] = to_type.declaration_data[:allow_nil]
+              end
+
               declaration
             elsif to_type.extends?(Foobara::BuiltinTypes[:model])
               attributes_type = to_type.target_class.attributes_type

data/projects/common/src/error_collection.rb

@@ -1,22 +1,15 @@
 module Foobara
-  # TODO: inherit array instead of delegating
-  class ErrorCollection
+  class ErrorCollection < Array
     class ErrorAlreadySetError < StandardError; end
 
     class << self
       def to_h(errors)
         new.tap do |collection|
           collection.add_errors(errors)
-        end.to_h
+        end.errors_hash
       end
     end
 
-    attr_reader :error_array
-
-    def initialize
-      @error_array = []
-    end
-
     def success?
       empty?
     end
@@ -25,14 +18,18 @@ module Foobara
       !empty?
     end
 
-    foobara_delegate :empty?, :partition, :size, :clear, to: :error_array
-
     def errors
-      error_array
+      # :nocov:
+      warn "DEPRECATED: Do not call ErrorCollection#errors instead just use the collection directly."
+      self
+      # :nocov:
     end
 
     def each_error(&)
-      error_array.each(&)
+      # :nocov:
+      warn "DEPRECATED: This method will be deprecated in the coming version"
+      each(&)
+      # :nocov:
     end
 
     def has_error?(error)
@@ -42,15 +39,13 @@ module Foobara
         # :nocov:
       end
 
-      error_array.include?(error)
+      include?(error)
     end
 
     def add_error(error_or_collection_or_error_hash)
       error = case error_or_collection_or_error_hash
               when Error
                 error_or_collection_or_error_hash
-              when ErrorCollection
-                return add_errors(error_or_collection_or_error_hash.errors)
               when Hash
                 if error_or_collection_or_error_hash.key?(:symbol) &&
                    error_or_collection_or_error_hash.key?(:message)
@@ -73,25 +68,32 @@ module Foobara
         raise ErrorAlreadySetError, "cannot set #{error} more than once"
       end
 
-      error_array << error
+      self << error
     end
 
     def add_errors(errors)
       Util.array(errors).each { |error| add_error(error) }
     end
 
-    def to_h
-      error_array.to_h do |error|
-        [error.key, error.to_h]
+    def errors_hash
+      each_with_object({}) do |error, hash|
+        hash[error.key] = error.to_h
       end
     end
 
     def to_sentence
-      Util.to_sentence(error_array.map(&:message))
+      Util.to_sentence(map(&:message))
     end
 
     def keys
-      error_array.map(&:key)
+      map(&:key)
+    end
+
+    def to_h
+      # :nocov:
+      warn "DEPRECATED: Use #errors_hash instead"
+      errors_hash
+      # :nocov:
     end
   end
 end

data/projects/common/src/outcome.rb

@@ -56,29 +56,35 @@ module Foobara
     end
 
     foobara_delegate :has_errors?,
-                     :errors,
-                     :each_error,
                      :has_error?,
                      :add_error,
                      :add_errors,
                      to: :error_collection
 
+    def errors
+      error_collection
+    end
+
+    def each_error(&)
+      error_collection.each(&)
+    end
+
     def success?
       !has_errors?
     end
 
     def fatal?
-      errors.any?(&:fatal?)
+      error_collection.any?(&:fatal?)
     end
 
     def raise!
       return if success?
 
-      error = errors.first
+      error = error_collection.first
       original_backtrace = error.backtrace_when_initialized
 
-      if errors.size > 1
-        error = UnsuccessfulOutcomeError.new(errors)
+      if error_collection.size > 1
+        error = UnsuccessfulOutcomeError.new(error_collection)
       end
 
       error.set_backtrace(original_backtrace)
@@ -93,7 +99,7 @@ module Foobara
     end
 
     def errors_hash
-      error_collection.to_h
+      error_collection.errors_hash
     end
 
     def errors_sentence

data/projects/detached_entity/lib/foobara/detached_entity.rb

@@ -16,6 +16,7 @@ module Foobara
       end
 
       def reset_all
+        Foobara.raise_if_production!("reset_all")
         install!
       end
     end

data/projects/domain/src/domain_module_extension.rb

@@ -63,6 +63,8 @@ module Foobara
         attr_writer :foobara_domain_name, :foobara_full_domain_name
 
         def foobara_unregister(scoped)
+          scoped = to_scoped(scoped)
+
           foobara_type_builder.clear_cache
 
           if scoped.is_a?(Foobara::Types::Type)

data/projects/entity/lib/foobara/entity.rb

@@ -21,6 +21,7 @@ module Foobara
       end
 
       def reset_all
+        Foobara.raise_if_production!("reset_all")
         Entity::Concerns::Callbacks.reset_all
 
         install!

data/projects/entity/src/association_depth.rb

@@ -2,6 +2,6 @@ module Foobara
   module AssociationDepth
     ATOM = :atom
     AGGREGATE = :aggregate
-    PRIMARY_KEY_ONLY = :primary_key
+    PRIMARY_KEY_ONLY = :primary_key_only
   end
 end

data/projects/entity/src/concerns/callbacks.rb

@@ -6,6 +6,7 @@ module Foobara
 
         class << self
           def reset_all
+            Foobara.raise_if_production!("reset_all")
             Entity.instance_variable_set("@class_callback_registry", nil)
           end
         end

data/projects/foobara/src/project.rb

@@ -34,6 +34,7 @@ module Foobara
     end
 
     def reset_all
+      Foobara.raise_if_production!("reset_all")
       if self.module.respond_to?(:reset_all)
         self.module.reset_all
       end

data/projects/model/lib/foobara/model.rb

@@ -28,6 +28,7 @@ module Foobara
       end
 
       def reset_all
+        Foobara.raise_if_production!("reset_all")
         install!
       end
     end

data/projects/model/src/model.rb

@@ -309,7 +309,7 @@ module Foobara
     end
 
     def validation_errors
-      attributes_type.process_value(attributes).errors
+      attributes_type.process_value(attributes).error_collection
     end
 
     def validate!

data/projects/namespace/src/is_namespace.rb

@@ -74,6 +74,20 @@ module Foobara
         foobara_parent_namespace.nil?
       end
 
+      def to_scoped(scopedish)
+        if scopedish.is_a?(::String) || scopedish.is_a?(::Symbol) || scopedish.is_a?(::Array)
+          scopedish = foobara_lookup(scopedish)
+
+          unless scopedish
+            # :nocov:
+            raise ArgumentError, "Cannot unregister non-existent #{scopedish}"
+            # :nocov:
+          end
+        end
+
+        scopedish
+      end
+
       def foobara_register(scoped)
         foobara_registry.register(scoped)
         # awkward??
@@ -89,6 +103,8 @@ module Foobara
       end
 
       def foobara_unregister(scoped)
+        scoped = to_scoped(scoped)
+
         foobara_registry.unregister(scoped)
         foobara_children.delete(scoped)
         scoped.scoped_namespace = nil

data/projects/namespace/src/namespace_helpers.rb

@@ -248,10 +248,12 @@ module Foobara
             next if parent == mod
 
             if parent && !parent.scoped_full_path.empty?
-              next if _start_with?(parent.scoped_full_path, mod.scoped_full_path)
+              next if Foobara::Util.start_with?(parent.scoped_full_path, mod.scoped_full_path)
             end
 
-            if _start_with?(scoped.scoped_full_path, mod.scoped_full_path)
+            next if scoped.scoped_full_path == mod.scoped_full_path
+
+            if Foobara::Util.start_with?(scoped.scoped_full_path, mod.scoped_full_path)
               scoped.scoped_path = scoped.scoped_full_path[mod.scoped_full_path.size..]
 
               if parent
@@ -268,17 +270,6 @@ module Foobara
             end
           end
         end
-
-        # TODO: move to util
-        def _start_with?(large_array, small_array)
-          return false unless large_array.size > small_array.size
-
-          small_array.each.with_index do |item, index|
-            return false unless large_array[index] == item
-          end
-
-          true
-        end
       end
 
       def foobara_namespace!(scoped_path: nil, ignore_modules: nil)

data/projects/persistence/lib/foobara/persistence.rb

@@ -2,6 +2,7 @@ module Foobara
   module Persistence
     class << self
       def reset_all
+        Foobara.raise_if_production!("reset_all")
         @tables_for_entity_class_name = @bases = @default_crud_driver = @default_base = nil
         EntityBase::Transaction::Concerns::EntityCallbackHandling.reset_all
         EntityBase::Transaction.reset_all

data/projects/persistence/src/entity_base/transaction/concerns/entity_callback_handling.rb

@@ -10,6 +10,7 @@ module Foobara
           module EntityCallbackHandling
             class << self
               def reset_all
+                Foobara.raise_if_production!("reset_all")
                 install!
               end
 

data/projects/persistence/src/entity_base/transaction/concerns/transaction_tracking.rb

@@ -21,6 +21,7 @@ module Foobara
               end
 
               def reset_all
+                Foobara.raise_if_production!("reset_all")
                 @open_transactions = nil
               end
 

data/projects/type_declarations/lib/foobara/type_declarations.rb

@@ -2,6 +2,7 @@ module Foobara
   module TypeDeclarations
     class << self
       def reset_all
+        Foobara.raise_if_production!("reset_all")
         # TODO: this doesn't really belong here. I think we need to maybe call reset in reverse order?
         Foobara::Domain::DomainModuleExtension.all.each do |domain|
           var = "@foobara_type_builder"

data/projects/type_declarations/src/attributes_transformers/from_yaml.rb

@@ -3,6 +3,12 @@ module Foobara
     class << self
       # TODO: dry this up with a .subclass method in AttributesTransformers?
       def from_yaml(*attribute_names)
+        if attribute_names.empty?
+          # :nocov:
+          raise ArgumentError, "You must specify at least one attribute name"
+          # :nocov:
+        end
+
         symbol = symbol_for_attribute_names(attribute_names)
         existing = FromYaml.foobara_lookup(symbol, mode: Namespace::LookupMode::DIRECT)
 

data/projects/type_declarations/src/attributes_transformers/only.rb

@@ -2,10 +2,18 @@ module Foobara
   class AttributesTransformers < TypeDeclarations::TypedTransformer
     class << self
       def only(*attribute_names)
+        if attribute_names.empty?
+          # :nocov:
+          raise ArgumentError, "You must specify at least one attribute name"
+          # :nocov:
+        end
+
         symbol = symbol_for_attribute_names(attribute_names)
         existing = Only.foobara_lookup(symbol, mode: Namespace::LookupMode::DIRECT)
 
-        return existing if existing
+        if existing
+          return existing
+        end
 
         transformer_class = Class.new(Only)
         transformer_class.only_attributes = attribute_names

data/projects/type_declarations/src/attributes_transformers/reject.rb

@@ -2,6 +2,17 @@ module Foobara
   class AttributesTransformers < TypeDeclarations::TypedTransformer
     class << self
       def reject(*attribute_names)
+        if attribute_names.empty?
+          # :nocov:
+          raise ArgumentError, "You must specify at least one attribute name"
+          # :nocov:
+        end
+
+        symbol = symbol_for_attribute_names(attribute_names)
+        existing = Reject.foobara_lookup(symbol, mode: Namespace::LookupMode::DIRECT)
+
+        return existing if existing
+
         transformer_class = Class.new(Reject)
         transformer_class.reject_attributes = attribute_names
 

data/projects/value/src/processor.rb

@@ -235,7 +235,7 @@ module Foobara
         return old_outcome unless applicable?(value)
 
         process_value(value).tap do |outcome|
-          outcome.add_errors(old_outcome.errors)
+          outcome.add_errors(old_outcome.error_collection)
         end
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.136
+  version: 0.0.138
 platform: ruby
 authors:
 - Miles Georgi