foobara 0.0.126 → 0.0.127

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 1d3daa4a78757b936511e8ed15cf5226c243d0fcb1c8cc28e7dafd466127bff0
-  data.tar.gz: 7c58b71185cb2ccffed937aa922170f70186295933e65586f57b1c8429d0875f
+  metadata.gz: 531c75e332f6e7cc297b0b56689d91f59737040fe533814a8b780defc937b2aa
+  data.tar.gz: 16dd8725423abe9155c1fd5b89c752271ce568ec83cca52c7654204ee114f559
 SHA512:
-  metadata.gz: f1a61199416081a65ae3dda56809859fc0d036818d817bdc2885f627742ec81db2f31c3b599e8aad0de4dbb7a139b027e51e3a77e897013c2d4e2ca2391267bb
-  data.tar.gz: 6e245ef28b841f54e9f84353cf4b689fc29edee3b41ab997436788835676299bd6f78a9708643f1cab2293edfbb6a53bd6841bf5bfbe61668c5950c2229d23f0
+  metadata.gz: 9c97ed1f00a114ea3ff8e1932cb32a13e8e538b1a0dc694f542060febafcae9e515e4888695cdbeede192e490ea280e6bddf8bf54b64e6339fe7adeaaeaa42a1
+  data.tar.gz: 4e414afd9090bc83685ce1b2e30fb31948963f4d57cff4d77ba4aa698547e716fd5a562442845f60cd8e6affb06263797fcf0c539a7f5478fceb9dec6b1412de

data/CHANGELOG.md

@@ -1,6 +1,13 @@
+# [0.0.127] - 2025-05-25
+
+- Add better support for using ruby classes as types
+- Support using :attributes as a type directly
+- Make TransformedCommand#inputs reflect actual received inputs not transformed inputs
+- Add NestedTransactionable.with_needed_transactions_for_type
+
 # [0.0.126] - 2025-05-21
 
-- Fix bugs with transations, Command.depends_on
+- Fix bugs with transactions, Command.depends_on
 - Allow anonymous commands
 - Add CommandConnector#all_exposed_type_names
 

data/projects/builtin_types/src/attributes/supported_transformers/defaults/type_declaration_extension/extend_attributes_type_declaration/desugarizers/move_defaults_from_element_types_to_root.rb

@@ -8,7 +8,7 @@ module Foobara
               module Desugarizers
                 class MoveDefaultsFromElementTypesToRoot < TypeDeclarations::Desugarizer
                   def applicable?(value)
-                    value.is_a?(::Hash) && value[:type] == :attributes
+                    value.is_a?(::Hash) && value[:type] == :attributes && value.key?(:element_type_declarations)
                   end
 
                   def desugarize(rawish_type_declaration)

data/projects/builtin_types/src/attributes/supported_validators/required/type_declaration_extension/extend_attributes_type_declaration/desugarizers/move_required_from_element_types_to_root.rb

@@ -8,7 +8,7 @@ module Foobara
               module Desugarizers
                 class MoveRequiredFromElementTypesToRoot < TypeDeclarations::Desugarizer
                   def applicable?(value)
-                    value.is_a?(::Hash) && value[:type] == :attributes
+                    value.is_a?(::Hash) && value[:type] == :attributes && value.key?(:element_type_declarations)
                   end
 
                   def desugarize(rawish_type_declaration)

data/projects/builtin_types/src/duck/supported_validators/instance_of/type_declaration_extension/extend_registered_type_declaration/desugarizers/class_type_desugarizer.rb

@@ -0,0 +1,32 @@
+module Foobara
+  module BuiltinTypes
+    module Duck
+      module SupportedValidators
+        class InstanceOf < TypeDeclarations::Validator
+          module TypeDeclarationExtension
+            module ExtendRegisteredTypeDeclaration
+              module Desugarizers
+                class ClassTypeDesugarizer < TypeDeclarations::Desugarizer
+                  def applicable?(rawish_type_declaration)
+                    return false unless rawish_type_declaration.is_a?(::Hash)
+
+                    rawish_type_declaration[:type].is_a?(::Class)
+                  end
+
+                  def desugarize(rawish_type_declaration)
+                    klass = rawish_type_declaration[:type]
+                    rawish_type_declaration.merge(type: :duck, instance_of: klass.name)
+                  end
+
+                  def priority
+                    Priority::LOWEST + 1
+                  end
+                end
+              end
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/projects/builtin_types/src/duck/supported_validators/instance_of.rb

@@ -14,6 +14,16 @@ module Foobara
             end
           end
 
+          class << self
+            def requires_parent_declaration_data?
+              true
+            end
+          end
+
+          def applicable?(value)
+            !value.nil? || !parent_declaration_data[:allow_nil]
+          end
+
           def expected_class_name
             declaration_data
           end

data/projects/command/src/command_pattern_implementation/concerns/inputs.rb

@@ -31,8 +31,6 @@ module Foobara
           inputs_type&.element_types&.key?(method_name)
         end
 
-        foobara_delegate :inputs_type, to: :class
-
         def cast_and_validate_inputs
           if inputs_type.nil? && (raw_inputs.nil? || raw_inputs.empty?)
             @inputs = {}

data/projects/command/src/command_pattern_implementation/concerns/runtime.rb

@@ -67,7 +67,8 @@ module Foobara
         end
 
         def run_execute
-          result = process_result_using_result_type(execute)
+          raw_result = execute
+          result = process_result_using_result_type(raw_result)
           @outcome = Outcome.success(result)
         end
 

data/projects/command_connectors/src/transformed_command.rb

@@ -578,6 +578,7 @@ module Foobara
     def run
       apply_allowed_rule
       apply_pre_commit_transformers
+      set_inputs
       run_command
       # this gives us primary keys
       flush_transactions
@@ -609,6 +610,22 @@ module Foobara
                                 end
     end
 
+    def inputs
+      return @inputs if defined?(@inputs)
+
+      @inputs = if inputs_type
+                  outcome = inputs_type.process_value(untransformed_inputs)
+
+                  if outcome.success?
+                    outcome.result
+                  else
+                    untransformed_inputs
+                  end
+                else
+                  {}
+                end
+    end
+
     def transform_result
       if self.class.result_transformer
         self.outcome = Outcome.success(self.class.result_transformer.process_value!(result))
@@ -723,6 +740,14 @@ module Foobara
       end
     end
 
+    def set_inputs
+      if self.class.inputs_type
+        command.after_cast_and_validate_inputs do |**|
+          inputs
+        end
+      end
+    end
+
     def run_command
       outcome = command.run
       self.outcome = outcome if outcome

data/projects/detached_entity/src/concerns/associations.rb

@@ -187,7 +187,7 @@ module Foobara
                 construct_associations(element_type, path.append(:"#"), result, initial: false)
               end
             elsif type.extends?(BuiltinTypes[:attributes]) # TODO: matches attributes itself instead of only subtypes
-              type.element_types.each_pair do |attribute_name, element_type|
+              type.element_types&.each_pair do |attribute_name, element_type|
                 if remove_sensitive && element_type.sensitive?
                   next
                 end

data/projects/domain_mapper/src/domain_mapper_lookups.rb

@@ -89,9 +89,9 @@ module Foobara
 
         unless strict
           if from
-            lookup_matching_domain_mapper(from: nil, to:)
+            lookup_matching_domain_mapper(from: nil, to:, criteria:)
           elsif to
-            lookup_matching_domain_mapper(from:, to: nil)
+            lookup_matching_domain_mapper(from:, to: nil, criteria:)
           end
         end
       end

data/projects/model/src/extensions/type_declarations/handlers/extend_registered_model_type_declaration.rb

@@ -10,6 +10,7 @@ module Foobara
             type_symbol = strict_type_declaration[:type]
 
             return false if type_symbol == expected_type_symbol
+            return false unless type_symbol.is_a?(::Symbol) || type_symbol.is_a?(::String)
 
             if type_registered?(type_symbol)
               type = lookup_type!(type_symbol)

data/projects/nested_transactionable/lib/foobara/nested_transactionable.rb

@@ -17,6 +17,33 @@ module Foobara
 
         entity_classes.uniq
       end
+
+      def with_needed_transactions_for_type(type, &)
+        relevant_entity_classes = relevant_entity_classes_for_type(type)
+
+        if relevant_entity_classes.empty?
+          return yield
+        end
+
+        tx_class = Class.new
+        tx_class.include NestedTransactionable
+
+        tx_class.define_method(:relevant_entity_classes) do
+          relevant_entity_classes
+        end
+
+        tx_instance = tx_class.new
+
+        begin
+          tx_instance.open_transaction
+          result = Persistence::EntityBase.using_transactions(tx_instance.transactions, &)
+          tx_instance.commit_transaction
+          result
+        rescue
+          tx_instance.rollback_transaction
+          raise
+        end
+      end
     end
 
     def relevant_entity_classes_for_type(type)

data/projects/type_declarations/src/handlers/extend_attributes_type_declaration/hash_desugarizer.rb

@@ -17,7 +17,8 @@ module Foobara
             type_symbol = sugary_type_declaration[:type]
 
             if [:attributes, "attributes"].include?(type_symbol)
-              Util.all_symbolizable_keys?(sugary_type_declaration[:element_type_declarations])
+              sugary_type_declaration.key?(:element_type_declarations) &&
+                Util.all_symbolizable_keys?(sugary_type_declaration[:element_type_declarations])
             elsif type_symbol.is_a?(::Symbol)
               # Why is this done?
               !type_registered?(type_symbol)

data/projects/type_declarations/src/handlers/extend_attributes_type_declaration/to_type_transformer.rb

@@ -9,7 +9,7 @@ module Foobara
           def transform(strict_type_declaration)
             super.tap do |type|
               type_declarations = type.declaration_data[:element_type_declarations]
-              type.element_types = type_declarations.transform_values do |attribute_declaration|
+              type.element_types = type_declarations&.transform_values do |attribute_declaration|
                 type_for_declaration(attribute_declaration)
               end
             end

data/projects/type_declarations/src/handlers/registered_type_declaration.rb

@@ -13,7 +13,9 @@ module Foobara
           # we only handle case where it's a builtin type not an extension of one
           if strict_type_declaration.keys == [:type]
             type_symbol = strict_type_declaration[:type]
-            type_registered?(type_symbol)
+            if type_symbol.is_a?(::Symbol) || type_symbol.is_a?(::String)
+              type_registered?(type_symbol)
+            end
           end
         end
 

data/projects/types/src/type.rb

@@ -35,7 +35,7 @@ module Foobara
                   :element_type
 
       def initialize(
-        *,
+        declaration_data,
         target_classes:,
         base_type:,
         description: nil,
@@ -52,10 +52,12 @@ module Foobara
         sensitive_exposed: nil,
         **opts
       )
+        self.declaration_data = declaration_data
         self.sensitive = sensitive
         self.sensitive_exposed = sensitive_exposed
         self.base_type = base_type
         self.description = description
+        self.name = name
         self.casters = [*casters, *base_type&.casters]
         self.transformers = [*transformers, *base_type&.transformers]
         self.validators = [*validators, *base_type&.validators]
@@ -65,11 +67,10 @@ module Foobara
         # TODO: combine these maybe with the term "children_types"?
         self.element_types = element_types
         self.element_type = element_type
-        self.name = name
         self.target_classes = Util.array(target_classes)
         self.processor_classes_requiring_type = processor_classes_requiring_type
 
-        super(*, **opts.merge(processors:, prioritize: false))
+        super(declaration_data, **opts.merge(processors:, prioritize: false))
 
         apply_all_processors_needing_type!
 
@@ -274,8 +275,25 @@ module Foobara
       end
 
       def value_caster
-        # TODO: how can declaration_data be blank? That seems really strange...
-        Value::Processor::Casting.new({ cast_to: declaration_data }, casters:, target_classes:)
+        # TODO: figure out what would be needed to successfully memoize this
+        # return @value_caster if defined?(@value_caster)
+
+        # We make this exception for :duck because it will match any instance of
+        # Object but AllowNil will match nil which is also an instance of Object.
+        # This results in two matching casters. Instead of figuring out a way to make one
+        # conditional on the other we will just turn off this unique enforcement for :duck
+        enforce_unique = if declaration_data.is_a?(::Hash)
+                           declaration_data[:type] != :duck
+                         else
+                           true
+                         end
+
+        Value::Processor::Casting.new(
+          { cast_to: declaration_data },
+          casters:,
+          target_classes:,
+          enforce_unique:
+        )
       end
 
       def applicable?(value)

data/projects/value/src/processor/casting.rb

@@ -39,7 +39,7 @@ module Foobara
 
         attr_accessor :target_classes
 
-        def initialize(*, casters:, target_classes: nil)
+        def initialize(*, casters:, target_classes: nil, **)
           self.target_classes = Util.array(target_classes)
 
           processors = [
@@ -47,7 +47,7 @@ module Foobara
             *casters
           ]
 
-          super(*, processors:)
+          super(*, processors:, **)
         end
 
         def needs_cast?(value)
@@ -113,7 +113,7 @@ module Foobara
             build_error(*args)
           elsif error_class == MoreThanOneApplicableProcessorError
             # :nocov:
-            raise "Matched too many casters for #{args.inspect} with #{opts.inspect}"
+            raise "Matched too many casters for #{args.map(&:inspect).join(",")} with #{opts.inspect}"
             # :nocov:
           else
             super

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.126
+  version: 0.0.127
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-05-21 00:00:00.000000000 Z
+date: 2025-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bigdecimal
@@ -116,6 +116,7 @@ files:
 - projects/builtin_types/src/duck/supported_casters/allow_nil.rb
 - projects/builtin_types/src/duck/supported_validators/instance_of.rb
 - projects/builtin_types/src/duck/supported_validators/instance_of/type_declaration_extension/extend_registered_type_declaration/desugarizers/class_desugarizer.rb
+- projects/builtin_types/src/duck/supported_validators/instance_of/type_declaration_extension/extend_registered_type_declaration/desugarizers/class_type_desugarizer.rb
 - projects/builtin_types/src/duck/supported_validators/instance_of/type_declaration_extension/extend_registered_type_declaration/desugarizers/instance_of_class_desugarizer.rb
 - projects/builtin_types/src/duck/supported_validators/instance_of/type_declaration_extension/extend_registered_type_declaration/desugarizers/instance_of_symbol_desugarizer.rb
 - projects/builtin_types/src/duck/supported_validators/instance_of/type_declaration_extension/extend_registered_type_declaration/type_declaration_validators/is_valid_class.rb