foobara 0.0.110 → 0.0.112

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71a254889aa452b7a219cb8d9b4c7d1c2eb2c21ea452ae783e62d601720c387b
-  data.tar.gz: 451cf0735d2c75026c92b92381e0e8a3766ed69a8a08eed739e6866e88f5b134
+  metadata.gz: a36c133c68acf0ea569d20a21409921f0c5dfe0e147c830f2572b84bda6d77b2
+  data.tar.gz: e0e44b5fb75ab902e32b8200ef8a19420f1aaee94f8786c6af63731463e78318
 SHA512:
-  metadata.gz: 6d758bae9e990d477c7775966b69dd1a51ae1878b938fec278a76ebbb8dd88a417e6c68f3a11174929cb86f858294bf1207206704bba70c458035e3798b12597
-  data.tar.gz: 9f7c770b990f942884aaa79f45f7ce344aaabaa8a939536d869802c25ccc2ada3b7ddb476119a543d5546019874ae44929af29d5437d0574e447a4f8acc398ed
+  metadata.gz: f2d7343f12f57901d9d60c9ef419e35938bf77e2a9552ea0ef095d33cd07fd0f648d9d8f78698842c94ffb0fcc447fbe1a64ea62d5d5ae5569ea0c127fba8d60
+  data.tar.gz: 97edd6f9217b2fd7651f72643671ad7ce191772d6472f4a1715eb66ca93506181c43614ddef6c3405de3f579d9765e5a135ce0383e5547a19b1b7e21faead8a8

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+# [0.0.112] - 2025-04-25
+
+- Fix bugs preventing generating manifest for connector with mutator instances instead of classes
+
+# [0.0.111] - 2025-04-25
+
+- Fix bug in DomainMapper.depends_on
+- Allow mutator instances to be used by connectors not just classes
+- Some WeakObjectSet tweaks
+
 # [0.0.110] - 2025-04-23
 
 - Automatically load associations needed for delegated attributes for

data/projects/command/src/command_pattern_implementation/concerns/subcommands.rb

@@ -59,7 +59,8 @@ module Foobara
             if subcommand_classes.empty?
               return @depends_on if defined?(@depends_on)
 
-              @depends_on = if self == Foobara::Command
+              # TODO: get Command and DomainMapper out of here!
+              @depends_on = if self == Foobara::Command || self == Foobara::DomainMapper
                               Set.new
                             else
                               superclass.depends_on.dup

data/projects/command/src/transformed_command.rb

@@ -122,8 +122,14 @@ module Foobara
 
         mutated_result_type = result_type
 
-        response_mutators&.reverse&.each do |mutator|
-          mutated_result_type = mutator.instance.result_type_from(mutated_result_type)
+        mutators = if response_mutators.size == 1
+                     [response_mutator]
+                   else
+                     response_mutator&.processors&.reverse
+                   end
+
+        mutators&.each do |mutator|
+          mutated_result_type = mutator.result_type_from(mutated_result_type)
         end
 
         @result_type_for_manifest = mutated_result_type
@@ -134,8 +140,14 @@ module Foobara
 
         mutated_inputs_type = inputs_type
 
-        request_mutators&.each do |mutator|
-          mutated_inputs_type = mutator.instance.inputs_type_from(mutated_inputs_type)
+        mutators = if request_mutators.size == 1
+                     [request_mutator]
+                   else
+                     request_mutator&.processors&.reverse
+                   end
+
+        mutators&.each do |mutator|
+          mutated_inputs_type = mutator.inputs_type_from(mutated_inputs_type)
         end
 
         @inputs_type_for_manifest = mutated_inputs_type
@@ -284,10 +296,8 @@ module Foobara
           end
         end
 
-        response_mutators = self.response_mutators.map(&:foobara_manifest)
-        request_mutators = TypeDeclarations.with_manifest_context(remove_sensitive: false) do
-          self.request_mutators.map(&:foobara_manifest)
-        end
+        response_mutators = mutators_to_manifest_symbols(self.response_mutators, to_include:)
+        request_mutators = mutators_to_manifest_symbols(self.request_mutators, to_include:)
 
         authenticator_manifest = if authenticator
                                    if authenticator.respond_to?(:foobara_manifest)
@@ -333,6 +343,42 @@ module Foobara
         )
       end
 
+      def mutators_to_manifest_symbols(mutators, to_include:)
+        return nil if mutators.nil? || mutators.empty?
+
+        mutators.map do |mutator|
+          if mutator.scoped_path_set?
+            to_include << mutator
+            mutator.foobara_manifest_reference
+          elsif mutator.is_a?(Value::Mutator)
+            klass = mutator.class
+
+            if klass.scoped_path_set?
+              to_include << klass
+              klass.foobara_manifest_reference
+              # TODO: Delete this nocov block
+              # TODO: make anonymous scoped path's have better names instead of random hexadecimal
+              # :nocov:
+            elsif mutator.symbol
+              mutator.symbol
+            else
+
+              to_include << klass if klass.scoped_path_set?
+
+              name = klass.name
+
+              while name.nil?
+                klass = klass.superclass
+                name = klass.name
+              end
+
+              "Anonymous#{Util.non_full_name(name)}"
+              # :nocov:
+            end
+          end
+        end
+      end
+
       def inputs_transformer
         return @inputs_transformer if defined?(@inputs_transformer)
 

data/projects/persistence/src/entity_base/transaction_table/concerns/record_tracking.rb

@@ -64,9 +64,6 @@ module Foobara
             end
 
             def updated(record)
-              # Hacky way to handle situation where the primary key might have changed.
-              # TODO: make a better way of handling this.
-              tracked_records.delete(record)
               tracked_records << record
 
               # TODO: is this check redundant? Maybe have the entity explode directly instead?

data/projects/persistence/src/entity_base/transaction_table.rb

@@ -519,8 +519,6 @@ module Foobara
 
         def flush_created!
           marked_created.each do |record|
-            tracked_records.delete(record)
-
             flush_created_associations!(record)
 
             # TODO: do this in bulk
@@ -540,8 +538,6 @@ module Foobara
         end
 
         def flush_created_record!(record)
-          tracked_records.delete(record)
-
           flush_created_associations!(record)
 
           unmark_created(record)

data/projects/weak_object_set/src/weak_object_set.rb

@@ -97,22 +97,40 @@ module Foobara
     end
 
     def <<(object)
-      garbage_cleaner.track(object)
-
       object_id = object.object_id
 
-      objects[object_id] = WeakRef.new(object)
+      if include?(object)
+        if @key_method
+          key = object.send(@key_method)
+          old_key = object_id_to_key[object_id]
 
-      if @key_method
-        key = object.send(@key_method)
+          if key != old_key
+            key_to_object_id.delete(old_key)
 
-        if key
-          key_to_object_id[key] = object_id
-          object_id_to_key[object_id] = key
+            if key
+              key_to_object_id[key] = object_id
+              object_id_to_key[object_id] = key
+            else
+              object_id_to_key.delete(object_id)
+            end
+          end
         end
-      end
+      else
+        garbage_cleaner.track(object)
 
-      object
+        objects[object_id] = WeakRef.new(object)
+
+        if @key_method
+          key = object.send(@key_method)
+
+          if key
+            key_to_object_id[key] = object_id
+            object_id_to_key[object_id] = key
+          end
+        end
+
+        object
+      end
     end
 
     def include?(object_or_object_id)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.110
+  version: 0.0.112
 platform: ruby
 authors:
 - Miles Georgi