foobara 0.0.109 → 0.0.111

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ee346090e6fcaa8a036f4edd3df0eda6ca76b55d600906b86226aa8c4a13862d
-  data.tar.gz: 403fd19ededf68298e03087abeb747a23e7015d4f45981bf0afefab64a5bd204
+  metadata.gz: 0ff2cd0b6537dbf44f0ef865a8fc6c8ac339d7b306cb67ddfcb744b74d2cb73d
+  data.tar.gz: cc3a822e6a43b1f2f27070c85fe2a4c07bc6a0274b963816fa3ef55bb531b597
 SHA512:
-  metadata.gz: 70dba1fa9bbed33a1cee53a7b64c1d36b417b1a148f678a1a52878b9677b550f7bd0d47f644c4df4bb7c08591bc0d288ad13423c9af88a61e613f9ca82dd216e
-  data.tar.gz: 8aeb22a52568439b29b0ba823a7add6b18301b0bd08f2532ca5829c36364634c5d7145894d694c7dab8af1b63229a1c3bc7ffcc06881e52b28b4ea6c51ef0b2c
+  metadata.gz: 4f1a8853b814a569aeaa4ac67d53363fe5349658f9e9f8214f2c05d649154fcc6b60be0f249e2912485dbc0689ade4ae1e67e2e5b913f478ff8a4151756a1542
+  data.tar.gz: c52ccae166bf419ba503653a29aa4bde3b8094c2ba190f611e877eec13ada47bd787c448db5506def4f5cebb73748a215d4de0d2d6dc30325f5c110347ad12bd

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+# [0.0.111] - 2025-04-25
+
+- Fix bug in DomainMapper.depends_on
+- Allow mutator instances to be used by connectors not just classes
+- Some WeakObjectSet tweaks
+
+# [0.0.110] - 2025-04-23
+
+- Automatically load associations needed for delegated attributes for
+  result of commands exposed via command connectors
+
 # [0.0.109] - 2025-04-22
 
 - Support CommandConnector transformers that don't take declaration_data

data/projects/command/src/command_pattern_implementation/concerns/subcommands.rb

@@ -59,7 +59,8 @@ module Foobara
             if subcommand_classes.empty?
               return @depends_on if defined?(@depends_on)
 
-              @depends_on = if self == Foobara::Command
+              # TODO: get Command and DomainMapper out of here!
+              @depends_on = if self == Foobara::Command || self == Foobara::DomainMapper
                               Set.new
                             else
                               superclass.depends_on.dup

data/projects/command/src/transformed_command.rb

@@ -122,8 +122,14 @@ module Foobara
 
         mutated_result_type = result_type
 
-        response_mutators&.reverse&.each do |mutator|
-          mutated_result_type = mutator.instance.result_type_from(mutated_result_type)
+        mutators = if response_mutators.size == 1
+                     [response_mutator]
+                   else
+                     response_mutator&.processors&.reverse
+                   end
+
+        mutators&.each do |mutator|
+          mutated_result_type = mutator.result_type_from(mutated_result_type)
         end
 
         @result_type_for_manifest = mutated_result_type
@@ -134,8 +140,14 @@ module Foobara
 
         mutated_inputs_type = inputs_type
 
-        request_mutators&.each do |mutator|
-          mutated_inputs_type = mutator.instance.inputs_type_from(mutated_inputs_type)
+        mutators = if request_mutators.size == 1
+                     [request_mutator]
+                   else
+                     request_mutator&.processors&.reverse
+                   end
+
+        mutators&.each do |mutator|
+          mutated_inputs_type = mutator.inputs_type_from(mutated_inputs_type)
         end
 
         @inputs_type_for_manifest = mutated_inputs_type

data/projects/command_connectors/src/command_connector.rb

@@ -36,7 +36,7 @@ module Foobara
 
         unless authenticator.symbol
           # :nocov:
-          raise ArgumentError, "Expected an authenticator to have a symbol"
+          raise ArgumentError, "Expected authenticator to have a symbol"
           # :nocov:
         end
 

data/projects/command_connectors/src/command_registry/exposed_command.rb

@@ -90,6 +90,22 @@ module Foobara
         self.allowed_rule = allowed_rule
         self.requires_authentication = requires_authentication
         self.authenticator = authenticator
+
+        # A bit hacky... we should check if we need to shim in a LoadDelegatedAttributesEntitiesPreCommitTransformer
+        unless aggregate_entities
+          # It's possible delegates have been added or removed via the result transformers...
+          # We should figure out a way to check the transformed result type instead.
+          if _has_delegated_attributes?(command_class.result_type)
+            self.pre_commit_transformers = [
+              *self.pre_commit_transformers,
+              CommandConnectors::Transformers::LoadDelegatedAttributesEntitiesPreCommitTransformer
+            ].uniq
+          end
+        end
+      end
+
+      def _has_delegated_attributes?(type)
+        type&.extends?(BuiltinTypes[:model]) && type.target_class&.has_delegated_attributes?
       end
 
       def full_command_name

data/projects/model/src/concerns/types.rb

@@ -155,6 +155,10 @@ module Foobara
             @delegates ||= {}
           end
 
+          def has_delegated_attributes?
+            !delegates.empty?
+          end
+
           def private_attribute_names
             @private_attribute_names ||= []
           end

data/projects/persistence/src/entity_base/transaction_table/concerns/record_tracking.rb

@@ -64,9 +64,6 @@ module Foobara
             end
 
             def updated(record)
-              # Hacky way to handle situation where the primary key might have changed.
-              # TODO: make a better way of handling this.
-              tracked_records.delete(record)
               tracked_records << record
 
               # TODO: is this check redundant? Maybe have the entity explode directly instead?

data/projects/persistence/src/entity_base/transaction_table.rb

@@ -519,8 +519,6 @@ module Foobara
 
         def flush_created!
           marked_created.each do |record|
-            tracked_records.delete(record)
-
             flush_created_associations!(record)
 
             # TODO: do this in bulk
@@ -540,8 +538,6 @@ module Foobara
         end
 
         def flush_created_record!(record)
-          tracked_records.delete(record)
-
           flush_created_associations!(record)
 
           unmark_created(record)

data/projects/weak_object_set/src/weak_object_set.rb

@@ -97,22 +97,40 @@ module Foobara
     end
 
     def <<(object)
-      garbage_cleaner.track(object)
-
       object_id = object.object_id
 
-      objects[object_id] = WeakRef.new(object)
+      if include?(object)
+        if @key_method
+          key = object.send(@key_method)
+          old_key = object_id_to_key[object_id]
 
-      if @key_method
-        key = object.send(@key_method)
+          if key != old_key
+            key_to_object_id.delete(old_key)
 
-        if key
-          key_to_object_id[key] = object_id
-          object_id_to_key[object_id] = key
+            if key
+              key_to_object_id[key] = object_id
+              object_id_to_key[object_id] = key
+            else
+              object_id_to_key.delete(object_id)
+            end
+          end
         end
-      end
+      else
+        garbage_cleaner.track(object)
 
-      object
+        objects[object_id] = WeakRef.new(object)
+
+        if @key_method
+          key = object.send(@key_method)
+
+          if key
+            key_to_object_id[key] = object_id
+            object_id_to_key[object_id] = key
+          end
+        end
+
+        object
+      end
     end
 
     def include?(object_or_object_id)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.109
+  version: 0.0.111
 platform: ruby
 authors:
 - Miles Georgi
@@ -508,7 +508,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.7
+rubygems_version: 3.6.8
 specification_version: 4
 summary: A command-centric and discoverable software framework with a focus on domain
   concepts and abstracting away integration code