foobara 0.0.102 → 0.0.104

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c472d0a6d4c5d306bf6510632edc586079912f8d389eee47ce7857889cab92e4
-  data.tar.gz: b4b42fe4f0952cf5322350de3677e7012856bd1ced93c8f72765519c1aab2c14
+  metadata.gz: be41d74ce30f423271c0b160d955d9ea7422e5d4337ab1d3c17deb0dae395d53
+  data.tar.gz: 51f8a06a9468870be7e2db0dd2116a8bca141852f27d462b4ce01b74df490710
 SHA512:
-  metadata.gz: 310bdd43d7858b4f548d62bce8acc58d66f139a2e48b315781ef29623118ddd647258e81e75170a673af050652959b310a87d98c49a3433f76841372453ba564
-  data.tar.gz: e722a9828ea78374fb63107d44a1bb79b5ff2e0c06699671eb033a1492f5b5279ce047543a256ca953f6560734a4936bed4af5aeab59fa9b02c514b16676f893
+  metadata.gz: 49e75de0f35a1a1eb257efd6e1304ed39d340ee8531e1b768ca8fc58ab4a0bc8e4422e3c50c379565c899708ac7a0768aa87aca326240933771147c285212894
+  data.tar.gz: 6d3234ee0c549fd91d21fe11e16968a5fe56da263eafa90474b20baa2b091ec33b57b439891eeeccf7149e4a9d1995ebab8a3ecc864e1eb796a1a8bef60f1d63

data/CHANGELOG.md

@@ -1,3 +1,14 @@
+# [0.0.104] - 2025-04-17
+
+- Fix manifest bug when command has no possible errors
+
+# [0.0.103] - 2025-04-17
+
+- Fix bugs in complicated entity query calls involving mixtures of models/records/primary keys/attributes
+- Fix bugs re: .construct_associations/_deep_associations resulting in terribad performance in some projects
+- Allow lambdas to be used as allowed rules
+- Improve .delegate_attribute interface
+
 # [0.0.102] - 2025-04-13
 
 - Extract ThreadParent to its own repository/gem

data/projects/command/src/command_pattern_implementation/concerns/transactions.rb

@@ -35,6 +35,10 @@ module Foobara
               entity_classes += Entity.construct_associations(
                 result_type
               ).values.uniq.map(&:target_class)
+
+              if result_type.extends?(BuiltinTypes[:entity])
+                entity_classes << result_type.target_class
+              end
             end
 
             entity_classes += entity_classes.uniq.map do |entity_class|

data/projects/command/src/transformed_command.rb

@@ -556,9 +556,7 @@ module Foobara
 
       if rule
         command.after_load_records do |command:, **|
-          # NOTE: apparently no way to convert a lambda to a proc but lambda's won't work here...
-          # TODO: raise exception here if rule.lambda? is true, if this starts becoming a common error
-          is_allowed = instance_eval(&rule)
+          is_allowed = instance_exec(&rule)
 
           unless is_allowed
             explanation = allowed_rule.explanation
@@ -568,7 +566,18 @@ module Foobara
             end
 
             if explanation.nil?
-              explanation = allowed_rule.block.source || "No explanation."
+              source = begin
+                allowed_rule.block.source
+              rescue MethodSource::SourceNotFoundError
+                # This path is hit if the way the source code is extracted
+                # doesn't result in valid Ruby, for example, as part of a hash such as:
+                # allowed_rule: -> () { whatever?(something) },
+                # :nocov:
+                allowed_rule.block.source_location.join(":")
+                # :nocov:
+              end
+
+              explanation = source || "No explanation."
             end
 
             error = CommandConnector::NotAllowedError.new(rule_symbol: rule.symbol, explanation:)

data/projects/command_connectors/src/command_connector.rb

@@ -374,7 +374,7 @@ module Foobara
       request_command = request.command
 
       request_command.after_load_records do |command:, **|
-        authenticated_user = request.instance_eval(&authenticator)
+        authenticated_user = request.instance_exec(&authenticator)
 
         request_command.authenticated_user = authenticated_user
 

data/projects/detached_entity/src/concerns/associations.rb

@@ -154,8 +154,13 @@ module Foobara
           def construct_associations(
             type = attributes_type,
             path = DataPath.new,
-            result = {}
+            result = {},
+            initial: true
           )
+            if initial && type.extends?(BuiltinTypes[:detached_entity])
+              return construct_associations(type.element_types, path, result, initial: false)
+            end
+
             remove_sensitive = TypeDeclarations.foobara_manifest_context_remove_sensitive?
 
             if type.extends?(BuiltinTypes[:entity])
@@ -171,7 +176,7 @@ module Foobara
               end
 
               element_types&.each&.with_index do |element_type, index|
-                construct_associations(element_type, path.append(index), result)
+                construct_associations(element_type, path.append(index), result, initial: false)
               end
             elsif type.extends?(BuiltinTypes[:array])
               # TODO: what to do about an associative array type?? Unclear how to make a key from that...
@@ -179,7 +184,7 @@ module Foobara
               element_type = type.element_type
 
               if element_type && (!remove_sensitive || !element_type.sensitive?)
-                construct_associations(element_type, path.append(:"#"), result)
+                construct_associations(element_type, path.append(:"#"), result, initial: false)
               end
             elsif type.extends?(BuiltinTypes[:attributes]) # TODO: matches attributes itself instead of only subtypes
               type.element_types.each_pair do |attribute_name, element_type|
@@ -187,7 +192,7 @@ module Foobara
                   next
                 end
 
-                construct_associations(element_type, path.append(attribute_name), result)
+                construct_associations(element_type, path.append(attribute_name), result, initial: false)
               end
             elsif type.extends?(BuiltinTypes[:model])
               target_class = type.target_class
@@ -196,7 +201,7 @@ module Foobara
               attributes_type = target_class.send(method)
 
               if !remove_sensitive || !attributes_type.sensitive?
-                construct_associations(attributes_type, path, result)
+                construct_associations(attributes_type, path, result, initial: false)
               end
             elsif type.extends?(BuiltinTypes[:associative_array])
               # not going to bother testing this for now

data/projects/foobara/lib/foobara/all.rb

@@ -9,7 +9,7 @@ module Foobara
 
   module Monorepo
     # could be independent projects
-    projects "delegate",
+    projects "delegate", # Let's just kill delegate
              "concerns",
              "weak_object_set",
              "enumerated",

data/projects/manifest/src/foobara/manifest/command.rb

@@ -3,6 +3,8 @@ module Foobara
     class Command < BaseManifest
       self.category_symbol = :command
 
+      optional_key :possible_errors
+
       def requires_authentication?
         !!self[:requires_authentication]
       end
@@ -30,7 +32,7 @@ module Foobara
       end
 
       def possible_errors
-        super.keys.to_h do |key|
+        (super || {}).keys.to_h do |key|
           [key, PossibleError.new(root_manifest, [*path, :possible_errors, key])]
         end
       end

data/projects/model/src/concerns/types.rb

@@ -173,11 +173,16 @@ module Foobara
 
           def delegate_attributes(delegates)
             delegates.each_pair do |attribute_name, delegate_info|
-              delegate_attribute(attribute_name, delegate_info[:data_path], writer: delegate_info[:writer])
+              data_path = DataPath.for(delegate_info[:data_path])
+              delegate_attribute(attribute_name, data_path, writer: delegate_info[:writer])
             end
           end
 
           def delegate_attribute(attribute_name, data_path, writer: false)
+            if data_path.is_a?(::Symbol) || data_path.is_a?(::String)
+              data_path = [data_path, attribute_name]
+            end
+
             data_path = DataPath.for(data_path)
 
             delegate_manifest = { data_path: data_path.to_s }

data/projects/persistence/src/entity_attributes_crud_driver.rb

@@ -1,4 +1,5 @@
 module Foobara
+  # Might be best to rename this to CrudDrivers or CrudDriver instead of Persistence?
   module Persistence
     class EntityAttributesCrudDriver
       attr_accessor :raw_connection, :tables
@@ -156,29 +157,39 @@ module Foobara
 
         def matches_attributes_filter?(attributes, attributes_filter)
           attributes_filter.all? do |attribute_name_or_path, value|
-            type = nil
+            value = normalize_attribute_filter_value(value)
 
             if attribute_name_or_path.is_a?(::Array)
               values = DataPath.values_at(attribute_name_or_path, attributes)
 
-              if values.include?(value)
-                true
-              else
-                type ||= entity_class.model_type.type_at_path(attribute_name_or_path)
-                if type.extends?(:detached_entity)
-                  values.any? do |v|
-                    value.primary_key == v
-                  end
-                end
+              values.any? do |attribute_value|
+                normalize_attribute_filter_value(attribute_value) == value
               end
-            elsif attributes[attribute_name_or_path] == value
-              true
             else
-              type ||= entity_class.model_type.type_at_path(attribute_name_or_path)
-              if type.extends?(:detached_entity)
-                value.primary_key == attributes[attribute_name_or_path]
-              end
+              attribute_value = attributes[attribute_name_or_path]
+              normalize_attribute_filter_value(attribute_value) == value
+            end
+          end
+        end
+
+        def normalize_attribute_filter_value(value)
+          case value
+          when ::Array
+            value.map { |v| normalize_attribute_filter_value(v) }
+          when ::Hash
+            value.to_h do |k, v|
+              [normalize_attribute_filter_value(k), normalize_attribute_filter_value(v)]
+            end
+          when DetachedEntity
+            if value.persisted?
+              normalize_attribute_filter_value(value.primary_key)
+            else
+              value
             end
+          when Model
+            normalize_attribute_filter_value(value.attributes)
+          else
+            value
           end
         end
 

data/projects/persistence/src/entity_base/transaction_table.rb

@@ -258,8 +258,6 @@ module Foobara
             [attribute_name,  element_types[attribute_name].process_value!(value)]
           end
 
-          attributes_filter = to_persistable(attributes_filter, false)
-
           tracked_records.each do |record|
             next if hard_deleted?(record)
 

data/projects/types/src/type.rb

@@ -20,8 +20,6 @@ module Foobara
                     :validators,
                     :element_processors,
                     :structure_count,
-                    :element_types,
-                    :element_type,
                     :is_builtin,
                     :raw_declaration_data,
                     :name,
@@ -33,6 +31,9 @@ module Foobara
 
       attr_reader :type_symbol
 
+      attr_writer :element_types,
+                  :element_type
+
       def initialize(
         *,
         target_classes:,
@@ -83,6 +84,14 @@ module Foobara
         sensitive_exposed
       end
 
+      def element_type
+        @element_type || base_type&.element_type
+      end
+
+      def element_types
+        @element_types || base_type&.element_types
+      end
+
       def has_sensitive_types?
         return true if sensitive?
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara
 version: !ruby/object:Gem::Version
-  version: 0.0.102
+  version: 0.0.104
 platform: ruby
 authors:
 - Miles Georgi