foobara-typescript-remote-command-generator 1.2.4 → 1.2.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7d547512385bac27319b644bb141ab01c46a53020b10e8aaf59f97f281733bc4
-  data.tar.gz: 0b5156e84353c299cd9b9076ad416f420306993181d9984e01b62fbbb2b4dbbe
+  metadata.gz: 0e9da9e5402f377488227d8a3d9911e0b5aaecb17c377e7209668993fcac7580
+  data.tar.gz: 7910689c819504d3d902ee61b433f1b10765c67b75f24cfad052f55141a89c8f
 SHA512:
-  metadata.gz: 076de1fb493fa9ad32f00fce13fef08f92da9dd9864efb17dd9137ea939737ada06485c0de0552d4d6ef59b7e4c5ae5ea541d3bc122bd8a088dbdfcd510efd42
-  data.tar.gz: 378f783a3dba0e843b5409414f2eb553aab1099555a9443c48d2ccdd3c8d67ef54b8d473c780bc83c44a469250445f9a624546915cde317d5ffc3fd6fc2d2e15
+  metadata.gz: fd073a89e550986306bcf2ba57d2cb5c7bf7b13e0d3c244517e09223b9106000c429cec615e4f985359f6548c7aca8b3533e7bf0f4e53dd777228a4bb999367b
+  data.tar.gz: 36dd52e22fbaf4c2cc193fa67ac7a7de8126e75b950a4850e9c1d896bf7e814ba4eb8b4b4936879d8cf8d508e5584153ccedad726834e13a76c6a9a6d55f1e44

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [1.2.6] - 2026-02-16
+
+- Make use of guaranteed_to_exist to avoid marking present delegates as optional
+- Make queries automatically run regardless of inputs presence
+
+## [1.2.5] - 2026-01-27
+
+- Fix circular dependency that happens if an item from this domain collides
+
 ## [1.2.4] - 2026-01-26
 
 - Fix bug where we include models/entities from command inputs

data/src/remote_generator/services/aggregate_entity_generator.rb

@@ -34,10 +34,6 @@ module Foobara
           [*super, superclass_generator]
         end
 
-        def collision_winners
-          superclass_generator
-        end
-
         def superclass_generator
           @superclass_generator ||= LoadedEntityGenerator.new(relevant_manifest)
         end

data/src/remote_generator/services/typescript_from_manifest_base_generator.rb

@@ -145,7 +145,15 @@ module Foobara
           @dependency_roots = dependency_group.non_colliding_dependency_roots.sort_by(&:scoped_full_name)
         end
 
-        def collision_winners = nil
+        def collision_winners
+          # TODO: odd that root_manifest exists but isn't decorated. We need a decorated and undecorated method
+          root_manifest = Manifest::RootManifest.new(self.root_manifest)
+
+          [*dependencies].select do |dependency|
+            root_manifest.contains?(dependency.domain_reference, :domain) &&
+              dependency.domain == domain
+          end
+        end
 
         def ts_instance_path
           scoped_path
@@ -277,21 +285,26 @@ module Foobara
                               if model_and_entity_free
                                 model_type = type_declaration.to_type
 
-                                translated_type = if type_declaration.detached_entity?
-                                                    model_type.primary_key_type
-                                                  else
-                                                    model_type.attributes_type
-                                                  end
-
-                                foobara_type_to_ts_type(
-                                  translated_type,
-                                  association_depth:,
-                                  dependency_group:,
-                                  initial:,
-                                  model_and_entity_free:,
-                                  is_output:,
-                                  parent: model_type
-                                )
+                                if type_declaration.detached_entity?
+                                  foobara_type_to_ts_type(
+                                    model_type.primary_key_type,
+                                    association_depth:,
+                                    dependency_group:,
+                                    initial:,
+                                    model_and_entity_free:,
+                                    is_output:,
+                                    parent: model_type
+                                  )
+                                else
+                                  attributes_to_ts_type(
+                                    model_type.attributes_type,
+                                    association_depth:,
+                                    dependency_group:,
+                                    model_and_entity_free:,
+                                    is_output:,
+                                    parent: model_type
+                                  )
+                                end
                               else
                                 model_to_ts_model_name(type_declaration, association_depth:, initial:)
                               end
@@ -334,18 +347,22 @@ module Foobara
           # or something.
           if attributes.has_attribute_declarations?
             guts = attributes.attribute_declarations.map do |attribute_name, attribute_declaration|
-              is_required = attributes.required?(attribute_name)
+              exists = attributes.required?(attribute_name)
+
+              if !exists && parent&.model?
+                exists = parent.guaranteed_to_exist?(attribute_name)
+              end
 
-              if !is_required && is_output
+              if !exists && is_output
                 default = attributes.default_for(attribute_name)
 
                 if default || default == false ||
                    (parent&.detached_entity? && attribute_name == parent.primary_key_name.to_sym)
-                  is_required = true
+                  exists = true
                 end
               end
 
-              "  #{attribute_name}#{"?" unless is_required}: #{
+              "  #{attribute_name}#{"?" unless exists}: #{
               foobara_type_to_ts_type(
                 attribute_declaration,
                 dependency_group:,

data/templates/Foobara/Auth/LoginCommand.ts.erb

@@ -7,7 +7,7 @@ export default class LoginCommand<Inputs, Result, Error extends FoobaraError<any
   extends RemoteCommand<Inputs, Result, Error> {
   async _handleResponse (response: Response): Promise<Outcome<Result, Error>> {
     if (response.ok) {
-      const accessToken: string | null = response.headers.get('X-Access-Token')
+      const accessToken: string | null = response.headers.get('x-access-token')
 
       if (accessToken != null) {
         handleLogin(this.urlBase, accessToken)

data/templates/Foobara/Auth/utils/accessTokens.ts.erb

@@ -2,6 +2,7 @@ import type Query from '../../../base/Query'
 import type RemoteCommand from '../../../base/RemoteCommand'
 import { forEachQuery } from '../../../base/QueryCache'
 
+// TODO: Why is this in here? It seems general-purpose not auth-specific
 function dirtyAllQueries () {
   forEachQuery((query: Query<RemoteCommand<any, any, any>>) => {
     query.setDirty()
@@ -10,28 +11,49 @@ function dirtyAllQueries () {
 
 const accessTokens = new Map<string, string>()
 
+interface AuthMessage {
+  type: 'login' | 'logout'
+  baseUrl: string
+}
+
+const login = (baseUrl: string, accessToken: string): void => {
+  accessTokens.set(baseUrl, accessToken)
+  dirtyAllQueries()
+}
+
 const logout = (urlBase: string): void => {
   accessTokens.delete(urlBase)
   dirtyAllQueries()
 }
+
+// These functions gets overridden with a form that broadcasts the event if BroadcastChannel is available
+let handleLogin: (baseUrl: string, accessToken: string) => void = login
 let handleLogout: (baseUrl: string) => void = logout
 
 const tokenForUrl = (baseUrl: string): string | undefined => accessTokens.get(baseUrl)
-const handleLogin: (baseUrl: string, accessToken: string) => void = (baseUrl, accessToken) => {
-  accessTokens.set(baseUrl, accessToken)
-  dirtyAllQueries()
-}
 
 if (typeof BroadcastChannel !== 'undefined') {
   const logoutChannel = new BroadcastChannel('foobara-auth-events')
 
-  logoutChannel.addEventListener('message', (event: MessageEvent<string>) => {
-    accessTokens.delete(event.data)
+  logoutChannel.addEventListener('message', (event: MessageEvent<AuthMessage>) => {
+    const { type, baseUrl } = event.data
+
+    if (type === 'login') {
+      dirtyAllQueries()
+    } else if (type === 'logout') {
+      logout(baseUrl)
+    } else {
+      throw new Error(`Unknown auth message type: ${JSON.stringify(type)}`)
+    }
   })
 
   handleLogout = (baseUrl: string) => {
     logout(baseUrl)
-    logoutChannel.postMessage(baseUrl)
+    logoutChannel.postMessage({ baseUrl, type: 'logout' })
+  }
+  handleLogin = (baseUrl: string, accessToken: string) => {
+    login(baseUrl, accessToken)
+    logoutChannel.postMessage({ baseUrl, type: 'login' })
   }
 }
 

data/templates/base/QueryCache.ts

@@ -16,6 +16,7 @@ export function getQuery<CommandT extends RemoteCommand<any, any, any>> (
   }
 
   let query: Query<CommandT>
+
   if (arguments.length === 2) {
     query = new Query<CommandT>(CommandClass, inputs)
     query.run()

data/templates/hooks/useQuery.ts

@@ -48,12 +48,7 @@ export default function useQuery<CommandT extends RemoteCommand<any, any, any>>
   let query = queryRef.current
 
   if (query == null) {
-    if (arguments.length === 2) {
-      query = getQuery(CommandClass, inputs as InputsOf<CommandT>)
-    } else {
-      query = getQuery(CommandClass)
-    }
-
+    query = getQuery(CommandClass, inputs)
     queryRef.current = query
   }
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara-typescript-remote-command-generator
 version: !ruby/object:Gem::Version
-  version: 1.2.4
+  version: 1.2.6
 platform: ruby
 authors:
 - Miles Georgi