foobara-typescript-remote-command-generator 0.0.8 → 0.0.9

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27cb6ef7f6663334fbcc7c69452e640433ac4ad1f3625936c5f3831bd3188df5
-  data.tar.gz: 4d82620538e0785816f0162866245a733bc07d2408532b5924e7b5973375e947
+  metadata.gz: cc6158bda17aa24741a79802c5e0016120801eed6a7f73a4c26eb68040fbd0ed
+  data.tar.gz: 8803880e3bd4463b21be3a08b09d33387a43f5d6a497af42cc59b9aa5dd764bb
 SHA512:
-  metadata.gz: b3beba79567383ff5e840473670a8f42e7844f44d6f5f8b83c6bebafac325fb3a12129f4c9e801fe33d6c41c49cf35bd12108be72b5200a9430e0468050fbeb8
-  data.tar.gz: dec1d11f0255485c8670eaaa08181b1115b062c55e1e9f4d430c0294b255e4390d772af12a5771517308777463c038314179b687c7b4f5a8406baf10fcc7c330
+  metadata.gz: 2c62a4e4597c9774b894747137a834d9a5aaff70269f322e20e93192ee6d34dff8bb88c0cd8a1fd488320eb373b9002d3523d6ee51b48f1887a5f4cedf4cb9ee
+  data.tar.gz: ec1a895e62d555c58b1ffe0a2161b4c422dc2222ae0d762da4adfb34631a7d8369a824021fd7fd36242101e281bbc5a7ac97d13fa5f48fdedf751836c905f4a6

data/CHANGELOG.md

@@ -1,4 +1,8 @@
-## [0.0.8] - 2025-02-02
+## [0.0.9] - 2025-02-21
+
+- Fix a bug where we don't use the name of a custom type when we could
+
+## [0.0.8] - 2025-02-21
 
 - Make sure entity/detached_entity/model are used properly in several places
 

data/src/remote_generator/generate_typescript.rb

@@ -17,6 +17,7 @@ module Foobara
         include_non_templated_files
 
         add_root_manifest_to_set_of_elements_to_generate
+        # TODO: allow specifying subset of commands
         add_all_commands_to_set_of_elements_to_generate
 
         each_element_to_generate do

data/src/remote_generator/services/typescript_from_manifest_base_generator.rb

@@ -222,10 +222,8 @@ module Foobara
                           else
                             if type_declaration.model?
                               model_to_ts_model_name(type_declaration, association_depth:, initial:)
-                            elsif can_convert_type_declaration_to_ts_type?(type_declaration)
-                              type = type_declaration.to_type
-
-                              custom_type_to_ts_type_name(type)
+                            elsif type_declaration.custom?
+                              custom_type_to_ts_type_name(type_declaration)
                             end
                           end
                         end
@@ -247,22 +245,6 @@ module Foobara
           end
         end
 
-        def can_convert_type_declaration_to_ts_type?(type_declaration)
-          type = type_declaration.to_type
-
-          return false if BuiltinTypes.builtin_reference?(type.reference)
-
-          allowed_keys = %w[type one_of allows_nil]
-
-          declaration_data = type.declaration_data
-
-          bad_keys = declaration_data.keys - allowed_keys
-
-          return false unless bad_keys.empty?
-
-          BuiltinTypes.builtin_reference?(declaration_data["type"])
-        end
-
         def attributes_to_ts_type(attributes, dependency_group:, association_depth: AssociationDepth::AMBIGUOUS)
           guts = attributes.attribute_declarations.map do |attribute_name, attribute_declaration|
             "  #{attribute_name}#{"?" unless attributes.required?(attribute_name)}: #{

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara-typescript-remote-command-generator
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-02-02 00:00:00.000000000 Z
+date: 2025-02-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foobara