foobara-typescript-react-command-form-generator 0.0.10 → 0.0.12

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2d7c7f198d85e6df346ff8e9c79223a9800229515015fd453113d361ae1cb39e
-  data.tar.gz: 9459d9006a463ad36994ec0414b471bd8032403d80d2285c495083f0ad038676
+  metadata.gz: 89eda43a93ac1f7704e90f6505078d6dca634f8e327836ad27559cfdfd3abc05
+  data.tar.gz: 04befdc1aabc41b17ede232116cb34382a187e414b1da4194a1a16f91eed1dd8
 SHA512:
-  metadata.gz: 3591a8eea3c09f47c0de440b8b12d17830e2a95b307bf0d53f0db69591fdc69d11a010c76a1b0b4da765bd7de432dc6f9f9f54ea44c1a9392816044b2729cf2d
-  data.tar.gz: f4f32288a3b7b18b9ca44bd493862e56f4b9f3be5f729bbfddd78d5f4cc30422ac8f1d1333f079864a790c1e9532a3d1a74862b4e1cdffbef979e435921c9062
+  metadata.gz: d3f84bb2d7d26485ab18b697f1bc90354632a7f94f89a4800252f50dc90601970e48753b4712be5af5727ee17fe921d57b9f79f42e6abf173acf1f3e3dd54b3d
+  data.tar.gz: 916539dcd2b832027969f7c191a67e9bc5878a32a60d7210b30d919ea569da2930cb9d556301c59fbd70a7a365f2b963a5aa1deb028ce83835cadc24d094a63b

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+## [0.0.12] - 2025-04-15
+
+- Fix non-camelized get/set useState names for nested types
+- Do not include Model/Entity classes in inputs types to simplify things for now
+
+## [0.0.11] - 2025-04-08
+
+- Print out stringified errors for unexpected errors
+- Cast e.target.value with parseInt/parseFloat when appropriate
+
 ## [0.0.10] - 2025-04-08
 
 - Do not double up hashes on Outcome import

data/src/typescript_react_command_form_generator.rb

@@ -36,11 +36,16 @@ module Foobara
             return @type_generators if defined?(@type_generators)
 
             generators = if type_declaration.entity?
-                           generator_class = RemoteGenerator::Services::UnloadedEntityGenerator
-                           [generator_class.new(type_declaration.to_entity)]
+                           # For now, we'll not bother with entity/model classes in the inputs.
+                           # This simplifies things a bit re: form generation and setting UI
+                           # inputs into the inputs value.
+                           type_generators(type_declaration.to_type.primary_key_type, false)
+                           # generator_class = RemoteGenerator::Services::UnloadedEntityGenerator
+                           # [generator_class.new(type_declaration.to_entity)]
                          elsif type_declaration.model?
-                           generator_class = RemoteGenerator::Services::AtomModelGenerator
-                           [generator_class.new(type_declaration.to_model)]
+                           type_generators(type_declaration.to_type.attributes_type, false)
+                           # generator_class = RemoteGenerator::Services::AtomModelGenerator
+                           # [generator_class.new(type_declaration.to_model)]
                          elsif type_declaration.type.to_sym == :attributes
                            type_declaration.attribute_declarations.values.map do |attribute_declaration|
                              type_generators(attribute_declaration, false)
@@ -198,7 +203,7 @@ module Foobara
               first, *rest = path
 
               first = Util.camelize(first)
-              rest = rest.map { |part| Util.camelize(part) }
+              rest = rest.map { |part| Util.classify(part) }
 
               [first, *rest].join
             end
@@ -242,10 +247,23 @@ module Foobara
                   #{one_of.map { |value| "<option value=\"#{value}\">#{value}</option>" }.join}
                 </select>"
               else
+                type = type_declaration.to_type
+
+                cast_value = if type.name.to_s == "integer" || type.extends_symbol?(:integer)
+                               "parseInt(e.target.value)"
+                             elsif type.name.to_s == "float" || type.extends_symbol?(:float)
+                               # TODO: test this path
+                               # :nocov:
+                               "parseFloat(e.target.value)"
+                               # :nocov:
+                             else
+                               "e.target.value"
+                             end
+
                 "<input
                     #{"type=\"password\"" if sensitive?}
                     value={#{name} ?? \"\"}
-                    onChange={(e) => { set#{name_upcase}(e.target.value) }}
+                    onChange={(e) => { set#{name_upcase}(#{cast_value}) }}
                     placeholder=\"#{name_english}\"
                   />"
               end

data/templates/CommandForm.tsx.erb

@@ -6,6 +6,7 @@ import { <%= command_name %> } from "<%= path_to_root %><%= command_generator.im
 <% unless empty_inputs? %>
 import <%= inputs_class_name %> from "<%= path_to_root %><%= command_generator.import_path %>/Inputs"
 <% end %>
+<%# TODO: why isn't the result type handled via dependency_roots to avoid collisions with other types? %>
 import <%= result_class_name %> from "<%= path_to_root %><%= command_generator.import_path %>/Result"
 import { Error as <%= error_class_name %> } from "<%= path_to_root %><%= command_generator.import_path %>/Errors"
 
@@ -60,7 +61,7 @@ export default function <%= command_name %>Form (): JSX.Element {
         setResult(null)
       }
     } catch (error) {
-      setError('Error executing command')
+      setError(`Error executing command: ${JSON.stringify(error)}`)
       setResult(null)
     }
   })

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara-typescript-react-command-form-generator
 version: !ruby/object:Gem::Version
-  version: 0.0.10
+  version: 0.0.12
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-04-09 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foobara-typescript-remote-command-generator
@@ -60,7 +60,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Generates Typescript React forms for Foobara remote commands
 test_files: []