foobara-remote-imports 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '06594c54e2d31ffa36c92ff55fd09287bfb56c241e68c5200874874772fb12d0'
-  data.tar.gz: 7dac9df9efd8d6809b9dbe781674173f59b9151c4dba8c88de1e3dbe0f859118
+  metadata.gz: 74a7b47ff503e5d7bf90b2100497e1c07998efda26baf2f2ea0d7bdab3f978b8
+  data.tar.gz: 0c78bac42ce7fb38c9d5362d73827786148421e27c2ff0425e4c6a8875a0dbf9
 SHA512:
-  metadata.gz: dbdf6ccb93791927cefb3b1e8aae1a7a2caadfe58cb2c11a703853e13297140cd4e25b543f0e333f8f1dcd7063c80bdae0f00e82628f0db8c5bcbf319273191c
-  data.tar.gz: 1c76bdd14f2589e68f812696cf796c7a7d01525ca9461ced5fa3853a19692cb733f97e2890ca7a0e54bab493eb9ca9235811817387f2f13a71a99604013af814
+  metadata.gz: 7f2dc5b69968131bf1e5588c861e9a2cfa25bf6dd394b2a3e76090ed54ea86feef3ad8ee936ff4872d90a5fb83adcdd93b323ca9337fb64afc8f6ebf37d32579
+  data.tar.gz: e26f245c4dcf3b66d9b5683e89beef8a30c5df19688afb4de2653c569dd5be0ae6d330a59a1a28ef8a3c9973b9fd6a169ce88928a0ae777aba24f7df071a5925

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## [0.0.3] - 2024-12-03
+
+- Convert entities into models
+
 ## [0.0.2] - 2024-12-02
 
 - Release as a gem

data/src/foobara/remote_imports/import_type.rb

@@ -15,6 +15,8 @@ module Foobara
           mode: Namespace::LookupMode::ABSOLUTE
         )
 
+        # TODO: might this be a sign of a name collision? Maybe better to give a meaningful error if the type isn't in
+        # #already_imported ??
         return if existing_type
 
         domain_manifest = manifest_to_import.domain
@@ -51,9 +53,47 @@ module Foobara
           Util.make_module_p(containing_module_name, tag: true)
         end
 
-        type = domain.foobara_type_from_strict_stringified_declaration(manifest_to_import.declaration_data)
+        # Warning: cannot desugarize this because unfortunately desugarizing an entity declaration will actually
+        # create the entity class, which should be considered a bug.
+        declaration_data = manifest_to_import.declaration_data
+
+        if entity?(declaration_data)
+          declaration_data = entity_to_model(declaration_data)
+        end
+
+        type = domain.foobara_type_from_strict_stringified_declaration(declaration_data)
         domain.foobara_register_type(manifest_to_import.scoped_path, type)
       end
+
+      def entity?(declaration_data)
+        declaration_data["type"] == "entity"
+      end
+
+      # TODO: use a domain mapper??
+      def entity_to_model(declaration_data)
+        declaration_data = Util.deep_dup(declaration_data)
+
+        primary_key_attribute = declaration_data.delete("primary_key")
+
+        unless primary_key_attribute
+          # :nocov:
+          raise "Missing primary key attribute"
+          # :nocov:
+        end
+
+        unless declaration_data["model_base_class"] == "Foobara::Entity"
+          # :nocov:
+          raise "Expected model base class to be Foobara::Entity"
+          # :nocov:
+        end
+
+        declaration_data["type"] = "model"
+        declaration_data["model_base_class"] = "Foobara::Model"
+        declaration_data["attributes_declaration"]["element_type_declarations"][primary_key_attribute]["required"] =
+          true
+
+        declaration_data
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara-remote-imports
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Miles Georgi