foobara-postgresql-crud-driver 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: c6ce8966a4872d4a3e81a1bcfec564df6be8903cd20e7bf8b998b9fc6ba423b8
-  data.tar.gz: ead889be3b61d1293dd8c78ada43f3b2f3c68cbaa11af81ef6fbc3ce975fdc5f
+  metadata.gz: 9da1f2e3a8d5170f4badb5d1ec0eeb8b6f443da56ce17b4b97911767620ae099
+  data.tar.gz: b12f27eca628e62f38c7f8d2a1af415d1ab3c72006a18d17f983b4fbb03eea91
 SHA512:
-  metadata.gz: 3d7bdb1286bc1a27ad62217f278155225722e88cb01c8faa193c80a932f1b07d441ef78bc0dac56ade1ce7e29c51d85e63f28e4b77c7913184ccd695a077caca
-  data.tar.gz: a4509b915954600c4c7001e0e078856a8ef38063298877ff076cdfd94bf76c1b37b08a2488453e54084c7458189189a19881762406b4019a8d186e4de2f032b9
+  metadata.gz: d7d0d2d19bc3cd5d3c1625b7b4958b0f160f9c733bdac7adc3f39ec09010ddad3f7fe8ce02aa9a9d4c9c6a7bc8216a731c13d299209947cf7ebb8a327a35fdb6
+  data.tar.gz: 8f4c6fa9014c60caef166ecdff36a22e7d87543276d36604da42ec8f7e95ff421547256e1d4e58b02f7ac789c5e5070b3f5fe0b3ec500406a1780fec49426fc7

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+## [0.0.5] - 2025-11-10
+
+- Improve error messages for foobara type/pg column incompatibilities
+- Validate strings used as integers represent valid integers
+
 ## [0.0.4] - 2025-11-09
 
 - Support a few more column types

data/src/postgresql_crud_driver.rb

@@ -23,6 +23,23 @@ module Foobara
       end
     end
 
+    class ColumnTypeMismatchError < StandardError
+      attr_accessor :pg_type, :foobara_type, :entity_class, :attribute_name
+
+      def initialize(pg_type:, foobara_type:, entity_class:, attribute_name: nil)
+        # TODO: figure out a way to test this code path
+        # :nocov:
+        self.pg_type = pg_type
+        self.foobara_type = foobara_type
+        self.entity_class = entity_class
+        self.attribute_name = attribute_name
+
+        super("Column type mismatch between foobara #{foobara_type.type_symbol} " \
+              "and postgres #{pg_type} for #{entity_class.entity_name}.#{attribute_name}")
+        # :nocov:
+      end
+    end
+
     class << self
       def get_transaction_number
         @get_transaction_number ||= 0
@@ -237,6 +254,7 @@ module Foobara
         SQL
 
         raw_connection.exec(sql)
+
         find(record_id)
       end
 
@@ -323,6 +341,7 @@ module Foobara
         foobara_type = entity_class.model_type.element_types.element_types[attribute_name]
 
         value = begin
+          check_type_compatibility!(foobara_type, info, attribute_name:)
           pg_cast_value(value, foobara_type, info)
         rescue UnsupportedPgColumnTypeError => e
           # :nocov:
@@ -373,62 +392,86 @@ module Foobara
             # :nocov:
           end
         elsif foobara_type.extends?(:number)
-          case pg_type
-          when "integer", "bigint"
-            value.to_i
+          validate_intable!(value)
+          value.to_i
+        elsif foobara_type.extends?(:string) || foobara_type.extends?(:symbol)
+          "'#{PG::Connection.escape(value.to_s)}'"
+        elsif foobara_type.extends?(:datetime)
+          "'#{PG::Connection.escape(value.inspect)}'"
+        elsif foobara_type.extends?(:detached_entity)
+          pg_cast_value(value, foobara_type.target_class.primary_key_type, pg_info)
+        elsif foobara_type.extends?(:model) || foobara_type.extends?(:attributes) ||
+              foobara_type == BuiltinTypes[:duck]
+          "'#{PG::Connection.escape(JSON.fast_generate(value))}'"
+        elsif foobara_type.extends?(:array)
+          element_type = foobara_type.element_type
+
+          if element_type.extends?(:detached_entity)
+            if element_type.target_class.primary_key_type.extends?(:integer)
+              value.each { validate_intable!(it) }
+            end
+            elements_type = ARRAY_ELEMENT_ENCODERS[pg_info[:element_type]]
+            array_string = PG::TextEncoder::Array.new(elements_type:).encode(value)
+            escaped = PG::Connection.escape(array_string)
+
+            "'#{escaped}'"
           else
             # :nocov:
             raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
             # :nocov:
           end
+        else
+          # :nocov:
+          raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+          # :nocov:
+        end
+      end
+
+      def validate_intable!(value)
+        if value.is_a?(::String) || value.is_a?(::Symbol)
+          unless value =~ /\A[+-]?\d+\z/
+            # :nocov:
+            raise "Expected something that could be cast to an integer but got #{value}"
+            # :nocov:
+          end
+        end
+      end
+
+      def check_type_compatibility!(foobara_type, pg_info, pg_type: pg_info[:type], attribute_name: nil)
+        if foobara_type.extends?(:integer)
+          unless pg_type == "integer" || pg_type == "bigint" || pg_type == "_int4"
+            # :nocov:
+            raise ColumnTypeMismatchError.new(pg_type:, foobara_type:, attribute_name:, entity_class:)
+            # :nocov:
+          end
         elsif foobara_type.extends?(:string) || foobara_type.extends?(:symbol)
-          case pg_type
-          when "text", "character varying"
-            "'#{PG::Connection.escape(value.to_s)}'"
-          else
+          unless pg_type == "text" || pg_type == "character varying"
             # :nocov:
-            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+            raise ColumnTypeMismatchError.new(pg_type:, foobara_type:, attribute_name:, entity_class:)
             # :nocov:
           end
         elsif foobara_type.extends?(:datetime)
-          case pg_type
-          when "timestamp without time zone"
-            "'#{PG::Connection.escape(value.inspect)}'"
-          else
+          unless pg_type == "timestamp without time zone"
             # :nocov:
-            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+            raise ColumnTypeMismatchError.new(pg_type:, foobara_type:, attribute_name:, entity_class:)
             # :nocov:
           end
         elsif foobara_type.extends?(:detached_entity)
-          pg_cast_value(value, foobara_type.target_class.primary_key_type, pg_info)
-        elsif foobara_type.extends?(:model) || foobara_type.extends?(:attributes)
-          case pg_type
-          when "jsonb", "json"
-            "'#{PG::Connection.escape(JSON.fast_generate(value))}'"
-          else
+          check_type_compatibility!(foobara_type.target_class.primary_key_type, pg_info, pg_type:, attribute_name:)
+        elsif foobara_type.extends?(:model) || foobara_type.extends?(:attributes) ||
+              foobara_type == BuiltinTypes[:duck]
+          unless pg_type == "jsonb" || pg_type == "json"
             # :nocov:
-            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+            raise ColumnTypeMismatchError.new(pg_type:, foobara_type:, attribute_name:, entity_class:)
             # :nocov:
           end
         elsif foobara_type.extends?(:array)
-          element_type = foobara_type.element_type
-
-          if element_type.extends?(:detached_entity)
-            case pg_type
-            when "ARRAY"
-              elements_type = ARRAY_ELEMENT_ENCODERS[pg_info[:element_type]]
-              array_string = PG::TextEncoder::Array.new(elements_type:).encode(value)
-              escaped = PG::Connection.escape(array_string)
-
-              "'#{escaped}'"
-            else
-              # :nocov:
-              raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
-              # :nocov:
-            end
-          else
+          if pg_type == "ARRAY"
+            element_type = foobara_type.element_type
+            check_type_compatibility!(element_type, pg_info, pg_type: pg_info[:element_type], attribute_name:)
             # :nocov:
-            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+          elsif pg_type != json && pg_type != jsonb
+            raise ColumnTypeMismatchError.new(pg_type:, foobara_type:, attribute_name:, entity_class:)
             # :nocov:
           end
         else

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara-postgresql-crud-driver
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Miles Georgi