foobara-postgresql-crud-driver 0.0.2 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2c60c0ece1c82cdea8fea28a1579d58be6d2973b1d6fc735be40f2e0c72ebda2
-  data.tar.gz: 91377b7fac30132168e9a2bddd5bc61461ce63b1fbaf729f8211493d39532904
+  metadata.gz: c6ce8966a4872d4a3e81a1bcfec564df6be8903cd20e7bf8b998b9fc6ba423b8
+  data.tar.gz: ead889be3b61d1293dd8c78ada43f3b2f3c68cbaa11af81ef6fbc3ce975fdc5f
 SHA512:
-  metadata.gz: ca410fcf04cbdb9c848907d2bbb659fceec19b6ced4076de1111d7587f2574601abac17f2654761b1bdbd2e12c251f7da58f6c937dd77848894f0d292e7dea80
-  data.tar.gz: 809b958eadea2ff275d8ac8ee45d99c68ed6d5cf918025bd6487c5d8976bae0f6fba5f1186a52673769f2f11bd99b145222a770a944bafaa498d28f17036683d
+  metadata.gz: 3d7bdb1286bc1a27ad62217f278155225722e88cb01c8faa193c80a932f1b07d441ef78bc0dac56ade1ce7e29c51d85e63f28e4b77c7913184ccd695a077caca
+  data.tar.gz: a4509b915954600c4c7001e0e078856a8ef38063298877ff076cdfd94bf76c1b37b08a2488453e54084c7458189189a19881762406b4019a8d186e4de2f032b9

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [0.0.4] - 2025-11-09
+
+- Support a few more column types
+- Make sure an entity -> entity association is cast properly
+
+## [0.0.3] - 2025-10-21
+
+- Pass through options to EntityAttributesCrudDriver instead of disallowing them
+
 ## [0.0.2] - 2025-08-22
 
 - Mark as compatible with Foobara 0.1.0

data/src/postgresql_crud_driver.rb

@@ -4,6 +4,18 @@ module Foobara
     class NoSuchColumnOrTableError < StandardError; end
 
     class UnsupportedPgColumnTypeError < StandardError
+      attr_accessor :pg_type, :attribute_name, :entity_class
+
+      def initialize(pg_type, entity_class)
+        # :nocov:
+        super("Unsupported column type #{pg_type} on #{entity_class.entity_name}")
+        # :nocov:
+      end
+    end
+
+    class UnsupportedPgColumnTypeForAttributeError < StandardError
+      attr_accessor :pg_type, :attribute_name, :entity_class
+
       def initialize(pg_type, attribute_name, entity_class)
         # :nocov:
         super("Unsupported column type #{pg_type} for attribute #{attribute_name} on #{entity_class.entity_name}")
@@ -16,7 +28,7 @@ module Foobara
         @get_transaction_number ||= 0
         @get_transaction_number += 1
         if @get_transaction_number > 65_535
-          # TODO: test this codepath somehow
+          # TODO: test this code path somehow
           # :nocov:
           @get_transaction_number = 1
           # :nocov:
@@ -39,10 +51,10 @@ module Foobara
 
     attr_accessor :creds, :transaction_number
 
-    # We intentionally don't call super because super would open a connection which we do not want
-    # since we want one connection per transaction.
-    # rubocop:disable Lint/MissingSuper
-    def initialize(connection_or_credentials = nil)
+    def initialize(connection_or_credentials = nil, **)
+      # We will manage the connections ourselves and don't want to automatically open one now
+      super(**, connect: false)
+
       self.transaction_number = self.class.get_transaction_number
       self.tables = {}
       self.creds = case connection_or_credentials
@@ -59,7 +71,6 @@ module Foobara
                      # :nocov:
                    end
     end
-    # rubocop:enable Lint/MissingSuper
 
     def open_connection
       PG.connect(creds)
@@ -268,9 +279,11 @@ module Foobara
           info = column_info[attribute_name.to_s]
 
           value = case info[:type]
-                  when "integer", "text", "timestamp without time zone"
+                  when "integer", "bigint",
+                       "text", "character varying",
+                       "timestamp without time zone"
                     value
-                  when "jsonb"
+                  when "jsonb", "json"
                     if value.nil?
                       unless info[:is_nullable]
                         # :nocov:
@@ -307,79 +320,19 @@ module Foobara
           # :nocov:
         end
 
-        pg_type = info[:type]
         foobara_type = entity_class.model_type.element_types.element_types[attribute_name]
 
-        value = if value.nil?
-                  if info[:is_nullable]
-                    "NULL"
-                  else
-                    # :nocov:
-                    raise "Unexpected nil value for #{attribute_name}"
-                    # :nocov:
-                  end
-                elsif foobara_type.extends?(:number)
-                  case pg_type
-                  when "integer"
-                    value.to_i
-                  else
-                    # :nocov:
-                    raise UnsupportedPgColumnTypeError.new(pg_type, attribute_name, entity_class)
-                    # :nocov:
-                  end
-                elsif foobara_type.extends?(:string) || foobara_type.extends?(:symbol)
-                  case pg_type
-                  when "text"
-                    "'#{PG::Connection.escape(value.to_s)}'"
-                  else
-                    # :nocov:
-                    raise UnsupportedPgColumnTypeError.new(pg_type, attribute_name, entity_class)
-                    # :nocov:
-                  end
-                elsif foobara_type.extends?(:datetime)
-                  case pg_type
-                  when "timestamp without time zone"
-                    "'#{PG::Connection.escape(value.inspect)}'"
-                  else
-                    # :nocov:
-                    raise UnsupportedPgColumnTypeError.new(pg_type, attribute_name, entity_class)
-                    # :nocov:
-                  end
-                elsif foobara_type.extends?(:model) || foobara_type.extends?(:attributes)
-                  case pg_type
-                  when "jsonb"
-                    "'#{PG::Connection.escape(JSON.fast_generate(value))}'"
-                  else
-                    # :nocov:
-                    raise UnsupportedPgColumnTypeError.new(pg_type, attribute_name, entity_class)
-                    # :nocov:
-                  end
-                elsif foobara_type.extends?(:array)
-                  element_type = foobara_type.element_type
-
-                  if element_type.extends?(:detached_entity)
-                    case pg_type
-                    when "ARRAY"
-                      elements_type = ARRAY_ELEMENT_ENCODERS[info[:element_type]]
-                      array_string = PG::TextEncoder::Array.new(elements_type:).encode(value)
-                      escaped = PG::Connection.escape(array_string)
-
-                      "'#{escaped}'"
-                    else
-                      # :nocov:
-                      raise UnsupportedPgColumnTypeError.new(pg_type, attribute_name, entity_class)
-                      # :nocov:
-                    end
-                  else
-                    # :nocov:
-                    raise UnsupportedPgColumnTypeError.new(pg_type, attribute_name, entity_class)
-                    # :nocov:
-                  end
-                else
-                  # :nocov:
-                  raise UnsupportedPgColumnTypeError.new(pg_type, attribute_name, entity_class)
-                  # :nocov:
-                end
+        value = begin
+          pg_cast_value(value, foobara_type, info)
+        rescue UnsupportedPgColumnTypeError => e
+          # :nocov:
+          raise UnsupportedPgColumnTypeForAttributeError.new(
+            e.pg_type,
+            attribute_name,
+            entity_class
+          )
+          # :nocov:
+        end
 
         [PostgresqlCrudDriver.escape_identifier(attribute_name), value]
       end
@@ -407,6 +360,83 @@ module Foobara
           ]
         end
       end
+
+      def pg_cast_value(value, foobara_type, pg_info)
+        pg_type = pg_info[:type]
+
+        if value.nil?
+          if pg_info[:is_nullable]
+            "NULL"
+          else
+            # :nocov:
+            raise "Unexpected nil value for #{attribute_name}"
+            # :nocov:
+          end
+        elsif foobara_type.extends?(:number)
+          case pg_type
+          when "integer", "bigint"
+            value.to_i
+          else
+            # :nocov:
+            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+            # :nocov:
+          end
+        elsif foobara_type.extends?(:string) || foobara_type.extends?(:symbol)
+          case pg_type
+          when "text", "character varying"
+            "'#{PG::Connection.escape(value.to_s)}'"
+          else
+            # :nocov:
+            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+            # :nocov:
+          end
+        elsif foobara_type.extends?(:datetime)
+          case pg_type
+          when "timestamp without time zone"
+            "'#{PG::Connection.escape(value.inspect)}'"
+          else
+            # :nocov:
+            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+            # :nocov:
+          end
+        elsif foobara_type.extends?(:detached_entity)
+          pg_cast_value(value, foobara_type.target_class.primary_key_type, pg_info)
+        elsif foobara_type.extends?(:model) || foobara_type.extends?(:attributes)
+          case pg_type
+          when "jsonb", "json"
+            "'#{PG::Connection.escape(JSON.fast_generate(value))}'"
+          else
+            # :nocov:
+            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+            # :nocov:
+          end
+        elsif foobara_type.extends?(:array)
+          element_type = foobara_type.element_type
+
+          if element_type.extends?(:detached_entity)
+            case pg_type
+            when "ARRAY"
+              elements_type = ARRAY_ELEMENT_ENCODERS[pg_info[:element_type]]
+              array_string = PG::TextEncoder::Array.new(elements_type:).encode(value)
+              escaped = PG::Connection.escape(array_string)
+
+              "'#{escaped}'"
+            else
+              # :nocov:
+              raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+              # :nocov:
+            end
+          else
+            # :nocov:
+            raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+            # :nocov:
+          end
+        else
+          # :nocov:
+          raise UnsupportedPgColumnTypeError.new(pg_type, entity_class)
+          # :nocov:
+        end
+      end
     end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: foobara-postgresql-crud-driver
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.4
 platform: ruby
 authors:
 - Miles Georgi