foobara-http-command-connector 0.0.19 → 0.0.21

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ceebd7c1212f94fca4e4906d36e0c1b13490d0815279b81f9508ff88052934b7
-  data.tar.gz: 73140a63c34db0eee71bcf3794fb98e77d4aa9f61ce5b2c251f9898a17eec65e
+  metadata.gz: 5eb43075a767f1e385f262e2d15e1fa497a6835239fcd31ddeb684557f46d7cf
+  data.tar.gz: 13368b595132e123cfa2cb96510713e6ac282ca8fa55fbb052e529b98a58aee4
 SHA512:
-  metadata.gz: 362371773eebe74e9f902235e6fb76fa07f2f9d8abf32dd1acd192cc6a2f8ffd1d7963ebe8e34fc9bfc037f05008d26390bb0d421ed06084b5bb647b0491d4b9
-  data.tar.gz: 66a799995e7a052703c303e5225c258b5ce7cf170861142d699c5fb47184f474a7b501df397a3f089faf30ee58ee5dc9e6cd37a369f3d888380222fcf4c35f10
+  metadata.gz: 22be5baa2d2174b415a37db548f53af808b2f6d84b43692636a380e5d508f9b10ff1853b62ddea0734e336a2d84302043599baa5c785646efc92b65fe9c76c25
+  data.tar.gz: 07a3d553c35bef5eea9e929f3d91ac0b68785648af4169666c1debc159da2257d2dbe17511ecfec73c827435b9d20fd576454e62a6c8374927dd0e48513e81c7

data/CHANGELOG.md

@@ -1,3 +1,11 @@
+## [0.0.21] - 2025-04-15
+
+- Fix incorrect content-type for help action 
+
+## [0.0.20] - 2025-04-14
+
+- Handle more cors scenarios
+
 ## [0.0.19] - 2025-03-31
 
 - Add SetHeader response mutator

data/src/http/commands/describe.rb

@@ -14,7 +14,7 @@ module Foobara
           end
 
           def in_detached_context(&)
-            Thread.foobara_with_var("foobara_manifest_context", detached: true, &)
+            TypeDeclarations.with_manifest_context(detached: true, &)
           end
 
           def build_manifest

data/src/http/commands/get_options.rb

@@ -4,11 +4,49 @@ module Foobara
       module Commands
         # TODO: this is a bit of a hack, just a total no-op... shouldn't really need this command at all ideally
         class GetOptions < Foobara::Command
+          inputs do
+            request :duck, :required
+          end
           result :string
 
           def execute
+            initialize_response_headers
+
+            set_allow_methods
+            set_allow_headers
+            set_access_control_max_age
+
+            # TODO: what's with this empty string?
             ""
           end
+
+          def initialize_response_headers
+            request.response_headers ||= {}
+          end
+
+          def set_allow_methods
+            allow_methods = ENV.fetch("FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_METHODS", nil)
+            if allow_methods
+              request.response_headers["access-control-allow-methods"] = allow_methods
+            end
+          end
+
+          def set_allow_headers
+            allow_headers = ENV.fetch("FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_HEADERS", nil)
+            if allow_headers
+              if allow_headers == "*"
+                allow_headers = request.headers["access-control-request-headers"]
+              end
+              request.response_headers["access-control-allow-headers"] = allow_headers
+            end
+          end
+
+          def set_access_control_max_age
+            access_control_max_age = ENV.fetch("FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_MAX_AGE", nil)
+            if access_control_max_age
+              request.response_headers["access-control-max-age"] = access_control_max_age
+            end
+          end
         end
       end
     end

data/src/http/request.rb

@@ -109,6 +109,14 @@ module Foobara
                                path
                              end
         end
+
+        def set_response_header(name, value)
+          name = name.to_s
+          name = name.downcase
+
+          self.response_headers ||= {}
+          self.response_headers = response_headers.merge(name => value)
+        end
       end
     end
   end

data/src/http.rb

@@ -60,14 +60,13 @@ module Foobara
 
       def request_to_command(request)
         if request.method == "OPTIONS"
-          # TODO: this feels a bit hacky and like overkill...
-          return Foobara::CommandConnectors::Http::Commands::GetOptions.new
+          return Foobara::CommandConnectors::Http::Commands::GetOptions.new(request:)
         end
 
         command = super
 
-        # TODO: We should kill these case statements and require connecting these commands
         if request.action == "help"
+          request.set_response_header("content-type", "text/html")
           command.class.serializers = [Commands::Help::ResultSerializer]
         end
 
@@ -136,6 +135,12 @@ module Foobara
 
       def static_headers
         @static_headers ||= ENV.each_with_object({}) do |(key, value), headers|
+          next if %w[
+            FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_HEADERS
+            FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_ALLOW_METHODS
+            FOOBARA_HTTP_RESPONSE_HEADER_ACCESS_CONTROL_MAX_AGE
+          ].include?(key)
+
           match = key.match(/\AFOOBARA_HTTP_RESPONSE_HEADER_(.*)\z/)
 
           if match

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobara-http-command-connector
 version: !ruby/object:Gem::Version
-  version: 0.0.19
+  version: 0.0.21
 platform: ruby
 authors:
 - Miles Georgi
 bindir: bin
 cert_chain: []
-date: 2025-03-31 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: foobara
@@ -94,7 +94,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.6
+rubygems_version: 3.6.7
 specification_version: 4
 summary: No description. Add one.
 test_files: []