foobar_templates 2.0.0 → 2.0.1.rc2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8ce07f040ecc4ee93a6ee5b6d091af7fdecda0d95f36d17404f900cb48086fa9
-  data.tar.gz: dd0c320b9a1176f5873889fc18b9304923a2771383f426bc053a9158ed98e76a
+  metadata.gz: ef1e2cd0e959fef6c0ac4f5e4475675f8ea8c9b4c60d818ff3606ca94d2638a7
+  data.tar.gz: e5d6e2ef6a066ad687a0509eb80d199f7d381307bf4ea2470f8f45f9c6eca274
 SHA512:
-  metadata.gz: 9ed9a0c22a22e58eb73124062cd444bc547e1ce0d5ad48bf10942d68c571b3c3d15395aaeef732406ca77fe6e56ce561aa94ccefce39837ac170ebe513eb54eb
-  data.tar.gz: 1c09a14c319a55532052e0ece16582b7876a34f73377de7821c4ed0a40927483ffa675f56f843422cf8a31670d9cf3c26a4e97b29a0d99e54cc034e8dac7912b
+  metadata.gz: 59087e7c7d265a35bc574ef126d11ff253b3c4970ce156e1d3edc0bbfb67d73f39f0894498f6594f9eb2e63e1fc7307803fe9e243bfe000fae7bc985d14b3484
+  data.tar.gz: cd0ee89ddd0b52b6ab18c222deb7af07a933cc253428861ffd6e276943b9f70225e95ca8a95e4a502a89989358596d372020d75628fe532bfab9c048fe70f336

data/.github/workflows/build.yml

@@ -0,0 +1,24 @@
+name: Build
+
+on:
+  push:
+    branches: [main]
+
+jobs:
+  build:
+    name: Build gem
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: '3.3'
+          bundler-cache: true
+      - name: Build gem
+        run: bundle exec rake build
+      - name: Upload gem artifact
+        uses: actions/upload-artifact@v4
+        with:
+          name: foobar_templates-gem
+          path: pkg/*.gem
+          if-no-files-found: error

data/.github/workflows/ci.yml

@@ -0,0 +1,27 @@
+name: CI
+
+on:
+  pull_request:
+  push:
+    branches: [main]
+
+jobs:
+  test:
+    name: Test (Ruby ${{ matrix.ruby }})
+    runs-on: ubuntu-latest
+    continue-on-error: ${{ matrix.experimental || false }}
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby: ['3.0', '3.2', '3.3', '3.4', '4.0']
+        include:
+          - ruby: head
+            experimental: true
+    steps:
+      - uses: actions/checkout@v4
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+          bundler-cache: true
+      - name: Run specs
+        run: bundle exec rake spec

data/README.md

@@ -1,5 +1,5 @@
 # Foobar Templates: A Pain-Free Project Templator
-[![Gem Version](https://badge.fury.io/rb/foobar_templates.svg)](https://badge.fury.io/rb/foobar_templates)
+[![Gem Version](https://badge.fury.io/rb/foobar_templates.svg?icon=si%3Arubygems)](https://badge.fury.io/rb/foobar_templates)
 
 Foobar Templates allow users to define project templates in the most native form to all technologist: Directory Structures, short commands, and helpful commands that make the tool's usage completely visible!
 
@@ -14,6 +14,7 @@ I highly recommend the `foobar` alias!
 ```bash
 gem install foobar_templates
 foobar_templates --install-public-templates
+foobar_templates --setup-personal-templates
 
 echo "alias foobar='foobar_templates'" >> ~/.bashrc
 source ~/.bashrc

data/Rakefile

@@ -1,13 +1,119 @@
 require 'rake'
+require 'rubygems'
 require 'rspec/core/rake_task'
 
 GEM_NAME = "foobar_templates"
 GEM_SPEC = "#{GEM_NAME}.gemspec"
+VERSION_FILE = "lib/#{GEM_NAME}/version.rb"
+
+module ReleaseHelper
+  module_function
+
+  # Prerelease syntax: `MAJOR.MINOR.PATCH.rcN` (e.g. `2.0.1.rc1`).
+  # Gem apparently doesn't support semver's `-` syntax =/
+  RC_RE = /\A(\d+)\.(\d+)\.(\d+)\.rc(\d+)\z/
+  REL_RE = /\A(\d+)\.(\d+)\.(\d+)\z/
+
+  def dry_run?
+    ENV['RELEASE_DRY_RUN'] == '1'
+  end
+
+  def current_version
+    src = File.read(VERSION_FILE)
+    m = src.match(/VERSION\s*=\s*"([^"]+)"/)
+    abort "Could not parse VERSION from #{VERSION_FILE}" unless m
+    m[1]
+  end
+
+  def next_version(v)
+    if (m = v.match(RC_RE))
+      maj, min, pat, rc = m.captures.map(&:to_i)
+      "#{maj}.#{min}.#{pat}.rc#{rc + 1}"
+    elsif (m = v.match(REL_RE))
+      maj, min, pat = m.captures.map(&:to_i)
+      "#{maj}.#{min}.#{pat + 1}.rc1"
+    else
+      abort "Unrecognized version format: #{v.inspect} (expected MAJOR.MINOR.PATCH or MAJOR.MINOR.PATCH.rcN)"
+    end
+  end
+
+  def write_version!(new_version)
+    src = File.read(VERSION_FILE)
+    updated = src.sub(/VERSION\s*=\s*"[^"]+"/, %(VERSION = "#{new_version}"))
+    File.write(VERSION_FILE, updated)
+  end
+
+  def confirm!(prompt, default: false)
+    suffix = default ? "[Y/n]" : "[y/N]"
+    print "#{prompt} #{suffix} "
+    answer = $stdin.gets&.strip
+    return default if answer.nil? || answer.empty?
+    %w[y yes].include?(answer.downcase)
+  end
+
+  def sh!(cmd)
+    puts "+ #{cmd}"
+    abort "command failed: #{cmd}" unless system(cmd)
+  end
+
+  def push!(cmd)
+    if dry_run?
+      puts "[DRY-RUN] would run: #{cmd}"
+    else
+      sh!(cmd)
+    end
+  end
+
+  def ensure_clean_git!
+    out = `git status --porcelain`
+    return if out.strip.empty?
+    abort "Working tree is dirty. Commit or stash changes before releasing.\n#{out}"
+  end
+
+  def ensure_on_default_branch!
+    branch = `git rev-parse --abbrev-ref HEAD`.strip
+    return if %w[main master].include?(branch)
+    return if confirm!("You are on branch '#{branch}', not main/master. Continue?", default: false)
+    abort "Aborted by user."
+  end
+
+  def working_tree_changed?
+    !`git status --porcelain`.strip.empty?
+  end
+
+  # Make sure this machine has push access to the gem repository
+  def preflight!
+    problems = []
+
+    cred_paths = [
+      File.expand_path("~/.gem/credentials"),
+      File.expand_path("~/.local/share/gem/credentials"),
+    ]
+    cred_path = cred_paths.find { |p| File.exist?(p) }
+    if cred_path.nil?
+      problems << "No rubygems credentials found (looked in #{cred_paths.join(', ')}). Run `gem signin`."
+    elsif (File.stat(cred_path).mode & 0o077) != 0
+      problems << "Rubygems credentials at #{cred_path} are world/group-readable. Run: chmod 0600 #{cred_path}"
+    end
+
+    unless problems.empty?
+      abort "Release preflight failed:\n  - #{problems.join("\n  - ")}"
+    end
+
+    puts "Checking rubygems push access for #{GEM_NAME}..."
+    owners_out = `gem owner #{GEM_NAME} </dev/null 2>&1`
+    unless $?.success?
+      abort "Cannot query rubygems owners for #{GEM_NAME}:\n#{owners_out}\nRun `gem signin` and ensure your API key has push scope."
+    end
+  end
+end
 
 desc "Build #{GEM_NAME} gem"
 task :build do
-  system "gem build #{GEM_SPEC}"
   FileUtils.mkdir_p "pkg"
+  FileUtils.rm_f Dir.glob("pkg/#{GEM_NAME}-*.gem")
+  FileUtils.rm_f Dir.glob("#{GEM_NAME}-*.gem")
+  system "gem build #{GEM_SPEC}"
   FileUtils.mv Dir.glob("#{GEM_NAME}-*.gem"), "pkg/"
 end
 
@@ -16,10 +122,50 @@ task install: :build do
   system "gem install pkg/#{Dir.children('pkg').sort.last}"
 end
 
-desc "Build and push #{GEM_NAME} gem to RubyGems"
-task release: :build do
-  gem_file = Dir.glob("pkg/#{GEM_NAME}-*.gem").sort.last
-  system "gem push #{gem_file}"
+desc "Interactive local release: confirm version, run specs, build, tag, push, and bump"
+task :release do
+  include_helper = ReleaseHelper
+
+  include_helper.ensure_clean_git!
+  include_helper.ensure_on_default_branch!
+  include_helper.preflight!
+
+  version = include_helper.current_version
+  puts "Current version in #{VERSION_FILE}: #{version}"
+  unless include_helper.confirm!("Release version #{version}?", default: false)
+    puts "Aborted. Edit #{VERSION_FILE} to change the version, then re-run `rake release`."
+    exit 0
+  end
+
+  Rake::Task[:spec].invoke
+  Rake::Task[:build].invoke
+
+  gem_file = "pkg/#{GEM_NAME}-#{version}.gem"
+  abort "Built gem not found at #{gem_file}" unless File.exist?(gem_file)
+
+  if include_helper.working_tree_changed?
+    include_helper.sh! "git add #{VERSION_FILE}"
+    include_helper.sh! %(git commit -m "Release v#{version}")
+  end
+
+  tag = "v#{version}"
+  include_helper.sh! %(git tag -a #{tag} -m "Release #{tag}")
+  include_helper.push! "git push origin HEAD"
+  include_helper.push! "git push origin #{tag}"
+  include_helper.push! "gem push #{gem_file}"
+
+  next_v = include_helper.next_version(version)
+  include_helper.write_version!(next_v)
+  include_helper.sh! "git add #{VERSION_FILE}"
+  include_helper.sh! %(git commit -m "Bump to v#{next_v}")
+  include_helper.push! "git push origin HEAD"
+
+  puts ""
+  puts "=" * 60
+  puts "Released: #{tag}"
+  puts "Next development version: #{next_v}"
+  puts "Tag: https://github.com/TheNotary/#{GEM_NAME}/releases/tag/#{tag}"
+  puts "=" * 60
 end
 
 desc "Run unit specs"

data/changelog

@@ -1,5 +1,6 @@
 ** Unreleased **
   - Rename: project renamed from `bundlegem` to `foobar_templates`. Module is now `FoobarTemplates`, executable is `foobar_templates`, per-template config file is `foobar.yml`, and user config/templates live under `~/.foobar/`. No backward-compatibility shims.
+  - Bugfix: fixes `Arg list too long` crash when generating from templates containing many gitignored files (e.g. node_modules); ignored directories are now pruned during a breadth-first traversal and path checks are streamed to `git check-ignore` via NUL-delimited stdin instead of argv.
 
 ** Planned 0.2.x **
   - Feature: templates can declare a `name_validation:` block in bundlegem.yml with two optional keys: `reserved_names` (exact-match denylist) and `regex_validator` (a Ruby regex the project name must match). Validation runs after the built-in regex check and before any files are written. All checks happen in pure Ruby — no shell, no cross-platform concerns.

data/config/config

@@ -3,6 +3,6 @@
 default_template: cli_gem
 public_templates: https://github.com/TheNotary/template-builtins
 registry_domain: null
-repo_domain: null
-k8s_domain: null
+repo_domain: null     # github.com
+k8s_domain: null      # k8s.example.com
 always_perform_git_init: false

data/lib/foobar_templates/cli/template_generator.rb

@@ -1,7 +1,6 @@
 require 'pathname'
 require 'yaml'
 require 'open3'
-require 'shellwords'
 require 'set'
 
 $TRACE = false
@@ -271,39 +270,67 @@ module FoobarTemplates::CLI
 
     # Returns a hash of source directory names and their destination mappings
     def dynamically_generate_template_directories
-      template_dirs = Dir.glob("#{@template_src}/**/*", File::FNM_DOTMATCH).filter_map do |f|
-        base_path = f[@template_src.length+1..-1]
-        next if base_path.start_with?(".git" + File::SEPARATOR) || base_path == ".git"
-        next if f == "#{@template_src}/." || f == "#{@template_src}/.."
-        next unless File.directory?(f)
-        # next if ignored_by_git?(@template_src, base_path)
-
-        [base_path, substitute_template_values(base_path)]
-      end.to_h
-      filter_ignored_files!(@template_src, template_dirs)
+      template_relative_paths.each_with_object({}) do |rel, dirs|
+        next unless File.directory?(File.join(@template_src, rel))
 
-      template_dirs
+        dirs[rel] = substitute_template_values(rel)
+      end
     end
 
     # Figures out the translation between all template files and their
     # destination names
     def dynamically_generate_templates_files
-      template_files = Dir.glob("#{@template_src}/**/*", File::FNM_DOTMATCH).filter_map do |f|
-        base_path = f[@template_src.length+1..-1]
-        next if base_path.nil?
-        next if base_path.start_with?(".git" + File::SEPARATOR) || base_path == ".git"
-        next if base_path == "foobar.yml"
-        next unless File.file?(f)
+      template_files = template_relative_paths.each_with_object({}) do |rel, files|
+        next if rel == "foobar.yml"
+        next unless File.file?(File.join(@template_src, rel))
 
-        [base_path, substitute_template_values(base_path)]
-      end.to_h
+        files[rel] = substitute_template_values(rel)
+      end
 
       raise_no_files_in_template_error! if template_files.empty?
-      filter_ignored_files!(@template_src, template_files)
 
       return template_files
     end
 
+    # Enumerates every relative path under the template source, skipping the
+    # .git directory and any gitignored paths. Ignored directories are pruned
+    # during traversal so their (potentially huge) contents are never walked.
+    def template_relative_paths
+      @template_relative_paths ||= collect_non_ignored_paths(@template_src)
+    end
+
+    # Breadth-first walk that prunes ignored directories. One batched
+    # `git check-ignore` call is made per directory depth level, so we never
+    # descend into (or enumerate) an ignored subtree such as node_modules.
+    def collect_non_ignored_paths(root)
+      results = []
+      frontier = [nil] # relative dirs to scan at the current level; nil == root
+
+      until frontier.empty?
+        level_children = []
+        frontier.each do |rel_dir|
+          abs_dir = rel_dir ? File.join(root, rel_dir) : root
+          Dir.children(abs_dir).each do |name|
+            next if name == ".git"
+
+            level_children << (rel_dir ? File.join(rel_dir, name) : name)
+          end
+        end
+        break if level_children.empty?
+
+        ignored = ignored_paths(root, level_children)
+        next_frontier = []
+        level_children.each do |rel|
+          next if ignored.include?(rel)
+
+          results << rel
+          next_frontier << rel if File.directory?(File.join(root, rel))
+        end
+        frontier = next_frontier
+      end
+
+      results
+    end
 
     # Applies literal foo-bar variant substitutions to path strings
     def substitute_template_values(path_str)
@@ -351,12 +378,19 @@ module FoobarTemplates::CLI
       chunk.nil? || chunk.include?("\x00")
     end
 
-    def filter_ignored_files!(repo_root, path_hash)
-      cmd = "git -C #{repo_root} check-ignore #{Shellwords.join(path_hash.keys)}"
-      stdout, _, status = Open3.capture3(cmd)
-      filter_these_paths = stdout.split
-
-      path_hash.delete_if { |key, _| filter_these_paths.include?(key) }
+    # Returns the subset of the given relative paths that git considers ignored.
+    # Paths are streamed via NUL-delimited stdin rather than argv to avoid the
+    # OS ARG_MAX limit ("Arg list too long") and to handle paths containing
+    # spaces or newlines. Returns an empty set when root is not a git repo.
+    def ignored_paths(root, rel_paths)
+      return Set.new if rel_paths.empty?
+
+      stdin_data = rel_paths.join("\x00")
+      stdout, _, _status = Open3.capture3(
+        "git", "-C", root.to_s, "check-ignore", "-z", "--stdin",
+        stdin_data: stdin_data
+      )
+      stdout.split("\x00").to_set
     end
 
     def create_template_directories(template_directories, target)

data/lib/foobar_templates/version.rb

@@ -1,3 +1,3 @@
 module FoobarTemplates
-  VERSION = "2.0.0"
+  VERSION = "2.0.1.rc2"
 end

data/spec/foobar_templates_spec.rb

@@ -128,6 +128,26 @@ describe FoobarTemplates do
     expect(src_dst_map['simple_dir']).to eq 'simple_dir'
   end
 
+  it "collect_non_ignored_paths walks files but prunes gitignored directories" do
+    template_dir = create_user_defined_template("testing", "template-user-supplied")
+    options = { bin: false, ext: false, coc:  false, template: "template-user-supplied" }
+    my_gem = FoobarTemplates::CLI::TemplateGenerator.new(options, "good-dog")
+
+    File.write("#{template_dir}/.gitignore", "node_modules/\n")
+    File.write("#{template_dir}/README.md", "Hello")
+    FileUtils.mkdir_p("#{template_dir}/src")
+    File.write("#{template_dir}/src/main.rb", "puts 1")
+    FileUtils.mkdir_p("#{template_dir}/node_modules/big_pkg")
+    File.write("#{template_dir}/node_modules/big_pkg/index.js", "ignored")
+    `git init #{template_dir}`
+
+    paths = my_gem.send('collect_non_ignored_paths', template_dir)
+
+    expect(paths).to include("README.md", "src", "src/main.rb")
+    expect(paths).not_to include("node_modules")
+    expect(paths.grep(/node_modules/)).to be_empty
+  end
+
   it "returns the expected interpolated string when substitute_template_values is called" do
     options = { bin: false, ext: false, coc:  false, template: "test_template" }
     gem_name = "good-dog"
@@ -173,6 +193,26 @@ describe FoobarTemplates do
     expect(File).not_to exist "#{@dst_dir}/#{gem_name}/node_modules"
   end
 
+  it "handles templates with a large number of gitignored files without overflowing the arg list" do
+    template_dir = create_user_defined_template("testing", "template-user-supplied")
+    options = { bin: false, ext: false, coc:  false, template: "template-user-supplied" }
+    gem_name = "good-dog"
+
+    File.write("#{template_dir}/.gitignore", "node_modules/")
+    File.write("#{template_dir}/README.md", "Hello")
+    FileUtils.mkdir("#{template_dir}/node_modules")
+    # Enough files to blow past ARG_MAX if paths were passed as argv.
+    5000.times { |i| File.write("#{template_dir}/node_modules/file_#{i}.rb", "ignored #{i}") }
+    `git init #{template_dir}`
+
+    capture_stdout do 
+      FoobarTemplates.generate_template(options, gem_name)
+    end
+
+    expect(File).to exist "#{@dst_dir}/#{gem_name}/README.md"
+    expect(File).not_to exist "#{@dst_dir}/#{gem_name}/node_modules"
+  end
+
   it "executes the bootstrap_command if supplied" do
     template_dir = create_user_defined_template("testing", "template-user-supplied")
     options = { bin: false, ext: false, coc:  false, template: "template-user-supplied" }
@@ -506,7 +546,7 @@ describe FoobarTemplates do
 
     before :each do
       # Default: no remote — skip network calls.
-      allow(FoobarTemplates).to receive(:remote_repo_exists?).and_return(false)
+      allow(FoobarTemplates::CLI::SetupPersonalTemplatesRepo).to receive(:remote_repo_exists?).and_return(false)
     end
 
     it "errors when repo_domain is not configured" do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: foobar_templates
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1.rc2
 platform: ruby
 authors:
 - TheNotary
 bindir: bin
 cert_chain: []
-date: 2026-05-09 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -83,6 +83,8 @@ files:
 - ".beader/issues/6-add-monorepo-discovery-and-generation-test-coverage.yaml"
 - ".beader/issues/7-document-monorepo-template-configuration-and-selection.yaml"
 - ".beader/meta.yaml"
+- ".github/workflows/build.yml"
+- ".github/workflows/ci.yml"
 - ".gitignore"
 - ".rspec"
 - Gemfile
@@ -128,9 +130,9 @@ licenses:
 - MIT
 metadata:
   bug_tracker_uri: https://github.com/TheNotary/foobar_templates/issues
-  changelog_uri: https://github.com/TheNotary/foobar_templates/releases/tag/v2.0.0
+  changelog_uri: https://github.com/TheNotary/foobar_templates/releases/tag/v2.0.1.rc2
   documentation_uri: https://github.com/TheNotary/foobar_templates
-  source_code_uri: https://github.com/TheNotary/foobar_templates/tree/v2.0.0
+  source_code_uri: https://github.com/TheNotary/foobar_templates/tree/v2.0.1.rc2
 rdoc_options: []
 require_paths:
 - lib
@@ -145,7 +147,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.2
+rubygems_version: 4.0.10
 specification_version: 4
 summary: This gem makes more gems!
 test_files: