fontist 3.0.32 → 3.0.33

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ccd5b693c5cc7ffa551f7a24c4e1366cee390bba84c2cdd2969fda96fdb8798d
-  data.tar.gz: 493d3d3683bf368eaa553602084c8a457ddcb911d3e73be0308423263a176a2a
+  metadata.gz: 9138df3c46f325e2909f1312ffbe906d3b6bd6b70b695a751af1576f68cd8903
+  data.tar.gz: a496ef4bac70d7b1c414f17d07514bece411a7fc9e8dd1e4901e8fcc8e9d55b5
 SHA512:
-  metadata.gz: 2d13031416210a2c8996623593c27c93bb963dac09b108c55a6a80833262c664c7e478a8e8eb316f69963e73b77c2295790da77e8bad07289ca24ab1865371be
-  data.tar.gz: f2e34e0d2946338a0a2ab047ab48dbe5e5701899c2ed2731867d3389fcbc1caa0f92107ba8a8a992db2b74a78920f4b8105f8191d5636e1ec4b2a88952e80bc5
+  metadata.gz: 6a179916eb34c002c5635b8e7e6ee9ec6602e8aa1a7a6ab02174fdd6f25a5f183ed307f4db04911f62901a5f44d034850a4225827062503bf606587593918ec0
+  data.tar.gz: 23e184310fc3ab3da8b99fa9dc5c3f506f29962d837c36a46f09211873014eadc46379bea2f5788cfdbec7e5cdc80d610458266c9a33985c8fba217875d38d16

data/lib/fontist/import/helpers/hash_helper.rb

@@ -3,8 +3,28 @@ module Fontist
     module Helpers
       module HashHelper
         class << self
+          # Converts a formula hash to string-keyed plain data. Values
+          # that are lutaml-model models join the document through their
+          # own to_hash serializer (the json gem used to call to_json on
+          # them implicitly during traversal; Yeptris::JSON does not).
           def stringify_keys(hash)
-            Fontist::JSON.parse(Fontist::JSON.dump(hash))
+            deep_stringify(hash)
+          end
+
+          private
+
+          def deep_stringify(value)
+            case value
+            when Hash then value.to_h { |k, v| [k.to_s, deep_stringify(v)] }
+            when Array then value.map { |v| deep_stringify(v) }
+            else deep_stringify_model(value)
+            end
+          end
+
+          def deep_stringify_model(value)
+            return value unless value.respond_to?(:to_hash)
+
+            deep_stringify(value.to_hash)
           end
         end
       end

data/lib/fontist/repo.rb

@@ -115,16 +115,19 @@ module Fontist
         end
       end
 
-      def update(name)
+      def update(name, rebuild: true)
         path = repo_path(name)
         unless Dir.exist?(path)
           raise(Errors::RepoNotFoundError, "No such repo '#{name}'.")
         end
 
         git = Git.open(path)
+        before = git.rev_parse("HEAD")
         git.pull("origin", git.current_branch)
+        changed = git.rev_parse("HEAD") != before
 
-        rebuild_index_if_needed
+        rebuild_index_if_needed if rebuild && changed
+        changed
       rescue StandardError => e
         # Catch all git-related errors
         if e.class.name.include?("Git") || e.message.match?(/git|pull|repository/i)

data/lib/fontist/update.rb

@@ -9,23 +9,35 @@ module Fontist
     end
 
     def call
-      update_main_repo
-      update_private_repos
+      main_changed = update_main_repo
+      private_changed = update_private_repos
     ensure
-      rebuild_index
+      # The index is a projection of the corpus: a pull that brought no
+      # changes leaves it valid, and a failed pull leaves the corpus
+      # untouched. Rebuilding costs a full pass over every formula, so
+      # it only runs when some repo actually moved — or when no index
+      # exists yet (a fresh clone never had one; lookups self-heal by
+      # rebuilding on demand, but an explicit update should leave one
+      # behind).
+      rebuild_index if main_changed || private_changed || index_missing?
     end
 
     private
 
+    def index_missing?
+      !File.exist?(Fontist.formula_filename_index_path)
+    end
+
     def update_main_repo
       dir = File.dirname(Fontist.formulas_repo_path)
       FileUtils.mkdir_p(dir)
 
       unless Dir.exist?(Fontist.formulas_repo_path)
-        return Git.clone(Fontist.formulas_repo_url,
-                         Fontist.formulas_repo_path,
-                         branch: @branch,
-                         depth: 1)
+        Git.clone(Fontist.formulas_repo_url,
+                  Fontist.formulas_repo_path,
+                  branch: @branch,
+                  depth: 1)
+        return true
       end
 
       git = if Dir.exist?(Fontist.formulas_repo_path.join(".git"))
@@ -36,21 +48,34 @@ module Fontist
               end
             end
 
-      return git.pull("origin", @branch) if git.current_branch == @branch
+      if git.current_branch != @branch
+        git.config_set("remote.origin.fetch",
+                       "+refs/heads/#{@branch}:refs/remotes/origin/#{@branch}")
+        git.fetch
+        git.checkout(@branch)
+        git.pull("origin", @branch)
+        return true
+      end
 
-      git.config_set("remote.origin.fetch",
-                     "+refs/heads/#{@branch}:refs/remotes/origin/#{@branch}")
-      git.fetch
-      git.checkout(@branch)
+      # A freshly init-ed repo has no commits yet; nil before the first
+      # pull means "changed", since the pull then creates the corpus
+      before = head_sha(git)
       git.pull("origin", @branch)
+      head_sha(git) != before
     end
 
     def update_private_repos
-      Repo.list.each do |name|
-        Repo.update(name)
+      Repo.list.reduce(false) do |changed, name|
+        Repo.update(name, rebuild: false) || changed
       end
     end
 
+    def head_sha(git)
+      git.rev_parse("HEAD")
+    rescue Git::FailedError, Git::GitError
+      nil
+    end
+
     def rebuild_index
       Index.rebuild
     end

data/lib/fontist/version.rb

@@ -1,3 +1,3 @@
 module Fontist
-  VERSION = "3.0.32".freeze
+  VERSION = "3.0.33".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fontist
 version: !ruby/object:Gem::Version
-  version: 3.0.32
+  version: 3.0.33
 platform: ruby
 authors:
 - Ribose Inc.