fontist 2.2.1 → 3.0.1

data/lib/fontist/cache/store.rb

@@ -57,7 +57,7 @@ module Fontist
       attr_reader :cache_dir
 
       def ensure_cache_dir
-        FileUtils.mkdir_p(@cache_dir) unless Dir.exist?(@cache_dir)
+        FileUtils.mkdir_p(@cache_dir)
       end
 
       def cache_path(key)

data/lib/fontist/cli.rb

@@ -338,7 +338,8 @@ module Fontist
                                 "Uses `fnmatch` patterns."
     option :name_prefix, desc: "Prefix to add to all font family names, " \
                                "e.g. 'Wine ' for compatibility fonts"
-    option :schema_version, type: :numeric, default: 5, desc: "Formula schema version (default: 5)"
+    option :schema_version, type: :numeric, default: 5,
+                            desc: "Formula schema version (default: 5)"
     def create_formula(url)
       handle_class_options(options)
       name = Fontist::Import::CreateFormula.new(url, options).call

data/lib/fontist/errors.rb

@@ -159,9 +159,9 @@ module Fontist
 
       def build_message(font_name)
         "Font '#{font_name}' is only available for: #{@required_platforms.join(', ')}. " \
-        "Your current platform is: #{@current_platform}. " \
-        "This font is licensed exclusively for the specified platform(s) and " \
-        "cannot be installed on your system."
+          "Your current platform is: #{@current_platform}. " \
+          "This font is licensed exclusively for the specified platform(s) and " \
+          "cannot be installed on your system."
       end
     end
 

data/lib/fontist/extract.rb

@@ -32,6 +32,7 @@ module Fontist
       return true if options.nil?
       return options.empty? if options.respond_to?(:empty?)
       return options.file.nil? && options.fonts_sub_dir.nil? if options.is_a?(ExtractOptions)
+
       false
     end
   end

data/lib/fontist/font.rb

@@ -338,9 +338,9 @@ module Fontist
       all_fonts = [fontist_fonts, user_fonts, system_fonts].compact.flatten
       return unless all_fonts && !all_fonts.empty?
 
-      uninstalled_paths = all_fonts.map do |font|
+      uninstalled_paths = all_fonts.filter_map do |font|
         uninstall_font_at_location(font.path)
-      end.compact
+      end
 
       return if uninstalled_paths.empty?
 

data/lib/fontist/font_finder.rb

@@ -75,7 +75,7 @@ module Fontist
     def extract_resource_names(formula)
       return [] unless formula.resources
 
-      Array(formula.resources).map(&:name).compact
+      Array(formula.resources).filter_map(&:name)
     end
 
     def build_font_match(formula, name, resource)
@@ -123,7 +123,6 @@ module Fontist
       matcher = FormatMatcher.new(@format_spec)
       matcher.filter_resources(resources)
     end
-
   end
 
   # Result object for font matches

data/lib/fontist/font_installer.rb

@@ -98,16 +98,14 @@ module Fontist
     end
 
     def resource_options
-      @resource_options ||= begin
-        if @formula.resources.size == 1 || !@formula.v5?
-          @formula.resources.first
-        elsif @format_spec&.has_constraints?
-          matcher = FormatMatcher.new(@format_spec)
-          matcher.select_preferred_resource(@formula.resources)
-        else
-          find_desktop_resource || @formula.resources.first
-        end
-      end
+      @resource_options ||= if @formula.resources.size == 1 || !@formula.v5?
+                              @formula.resources.first
+                            elsif @format_spec&.has_constraints?
+                              matcher = FormatMatcher.new(@format_spec)
+                              matcher.select_preferred_resource(@formula.resources)
+                            else
+                              find_desktop_resource || @formula.resources.first
+                            end
     end
 
     def find_desktop_resource
@@ -135,7 +133,9 @@ module Fontist
         file_names = styles.map { |s| s.source_font || s.font }
 
         if @formula.v5? && resource_options&.source == "google" && file_names.any?
-          resource_basenames = Array(resource_options.files).map { |f| File.basename(f) }
+          resource_basenames = Array(resource_options.files).map do |f|
+            File.basename(f)
+          end
           unless file_names.any? { |f| resource_basenames.include?(f) }
             return resource_basenames
           end
@@ -169,7 +169,7 @@ module Fontist
       @subdirectories ||= begin
         extracts = [@formula.extract].flatten.compact
         # options is a collection, so we need to flatten it too
-        options = extracts.flat_map { |e| e.options }.compact
+        options = extracts.flat_map(&:options).compact
         options.filter_map(&:fonts_sub_dir)
       end
     end
@@ -296,12 +296,12 @@ module Fontist
     def temp_path_for(source_path, format)
       base = File.basename(source_path, ".*")
       dir = @format_spec&.transcode_path || Dir.mktmpdir
-      FileUtils.mkdir_p(dir) unless Dir.exist?(dir)
+      FileUtils.mkdir_p(dir)
       File.join(dir, "#{base}.#{format}")
     end
 
     def cleanup_temp_file(path)
-      File.delete(path) if File.exist?(path)
+      FileUtils.rm_f(path)
     rescue StandardError
       # Ignore cleanup errors
     end

data/lib/fontist/format_matcher.rb

@@ -116,7 +116,9 @@ module Fontist
       end
 
       # Check if Fontisan can convert from any available format
-      convertible = available_formats.find { |f| self.class.can_convert?(f, requested) }
+      convertible = available_formats.find do |f|
+        self.class.can_convert?(f, requested)
+      end
       if convertible
         return {
           strategy: :convert,
@@ -163,7 +165,7 @@ module Fontist
     def find_variable_resource(resources)
       return nil unless @spec.prefer_variable
 
-      resources.find { |r| r.variable_font? }
+      resources.find(&:variable_font?)
     end
 
     def axes_match?(available_axes)

data/lib/fontist/format_spec.rb

@@ -47,7 +47,7 @@ module Fontist
       return nil if value.nil?
       return value if value.is_a?(Array)
 
-      value.to_s.split(",").map(&:strip).compact
+      value.to_s.split(",").filter_map(&:strip)
     end
 
     # Check if any format constraints are specified

data/lib/fontist/formula.rb

@@ -50,7 +50,8 @@ module Fontist
 
     key_value do
       # Only serialize schema_version if it's v5 (5), not for v4 formulas
-      map "schema_version", to: :schema_version, render_nil: false, render_default: false
+      map "schema_version", to: :schema_version, render_nil: false,
+                            render_default: false
       map "name", to: :name
       map "description", to: :description
       map "homepage", to: :homepage
@@ -96,9 +97,9 @@ module Fontist
       end
 
       def all
-        formulas = Dir[Fontist.formulas_path.join("**/*.yml").to_s].map do |path|
+        formulas = Dir[Fontist.formulas_path.join("**/*.yml").to_s].filter_map do |path|
           Formula.from_file(path)
-        end.compact
+        end
 
         FormulaCollection.new(formulas)
       end

data/lib/fontist/formula_picker.rb

@@ -48,14 +48,14 @@ module Fontist
     def filter_by_format_spec(formulas)
       matcher = FormatMatcher.new(@format_spec)
 
-      formulas.map do |formula|
+      formulas.filter_map do |formula|
         next formula unless formula.v5?
 
         matching = matcher.filter_resources(formula.resources)
         if matching.any?
           formula.dup.tap { |f| f.resources = matching }
         end
-      end.compact
+      end
     end
 
     def ensure_fontist_version(formulas)
@@ -99,7 +99,9 @@ module Fontist
     end
 
     def raise_format_not_available_error(formulas)
-      available = formulas.flat_map { |f| Array(f.resources).map(&:format) }.compact.uniq
+      available = formulas.flat_map do |f|
+        Array(f.resources).map(&:format)
+      end.compact.uniq
       raise Errors::FormatNotAvailableError.new(
         @font_name,
         @format_spec.format || @format_spec.prefer_format,

data/lib/fontist/import/formula_builder.rb

@@ -203,7 +203,7 @@ family_id:)
             result[k] = compacted unless compacted.nil?
           end
         when Array
-          value.map { |item| deep_compact(item) }.compact
+          value.filter_map { |item| deep_compact(item) }
         else
           value
         end

data/lib/fontist/import/google/data_sources/github.rb

@@ -69,7 +69,7 @@ module Fontist
 
             unless ofl_path.exist? || apache_path.exist? || ufl_path.exist?
               raise ArgumentError,
-                    "Source path does not contain expected font directories: "\
+                    "Source path does not contain expected font directories: " \
                     "#{@source_path}"
             end
           end
@@ -183,7 +183,7 @@ module Fontist
                   description: font_file.description,
                 }
               rescue StandardError => e
-                warn "Warning: Failed to parse font file #{filename}: "\
+                warn "Warning: Failed to parse font file #{filename}: " \
                      "#{e.message}"
               end
             end
@@ -199,11 +199,11 @@ module Fontist
             return [] unless metadata.fonts
 
             fonts_array = metadata.fonts.is_a?(Array) ? metadata.fonts : [metadata.fonts]
-            fonts_array.map do |font|
+            fonts_array.filter_map do |font|
               weight = font.respond_to?(:weight) ? font.weight : font["weight"]
               style = font.respond_to?(:style) ? font.style : font["style"]
               variant_name(weight, style)
-            end.compact.uniq
+            end.uniq
           end
 
           # Generate variant name from weight and style

data/lib/fontist/import/google/font_database.rb

@@ -136,7 +136,7 @@ github_data: nil, version: 4, source_path: nil)
 
         # Get all unique categories
         def categories
-          all_fonts.map(&:category).compact.uniq.sort
+          all_fonts.filter_map(&:category).uniq.sort
         end
 
         # Get fonts available in TTF format
@@ -190,7 +190,7 @@ github_data: nil, version: 4, source_path: nil)
 
         # Generate formulas for all fonts
         def to_formulas
-          all_fonts.map { |f| to_formula(f.family) }.compact
+          all_fonts.filter_map { |f| to_formula(f.family) }
         end
 
         # Save formulas to disk
@@ -198,12 +198,12 @@ github_data: nil, version: 4, source_path: nil)
           families = family_name ? [font_by_name(family_name)] : all_fonts
           families = families.compact
 
-          families.map do |family|
+          families.filter_map do |family|
             formula = to_formula(family.family)
             next unless formula
 
             save_formula(formula, family.family, output_dir)
-          end.compact
+          end
         end
 
         # Find filename for a variant
@@ -322,8 +322,8 @@ github_data: nil, version: 4, source_path: nil)
         def index_github_data
           return {} if @github_data_raw.empty?
 
-          @github_data_raw.each_with_object({}) do |family, hash|
-            hash[family.family] = family
+          @github_data_raw.to_h do |family|
+            [family.family, family]
           end
         end
 
@@ -367,8 +367,8 @@ github_data: nil, version: 4, source_path: nil)
 
         # Index fonts by family name
         def index_by_family(fonts)
-          fonts.each_with_object({}) do |font, hash|
-            hash[font.family] = font
+          fonts.to_h do |font|
+            [font.family, font]
           end
         end
 

data/lib/fontist/import/google/formula_builders/formula_builder_v4.rb

@@ -2,7 +2,7 @@
 
 require_relative "base_formula_builder"
 require_relative "../../../utils/downloader"
-require_relative "../../font_metadata_extractor"  # lib/fontist/import/font_metadata_extractor.rb
+require_relative "../../font_metadata_extractor" # lib/fontist/import/font_metadata_extractor.rb
 
 module Fontist
   module Import

data/lib/fontist/import/google/formula_builders/formula_builder_v5.rb

@@ -111,8 +111,11 @@ module Fontist
           end
 
           def detect_actual_format(urls, declared_format)
-            extensions = urls.map { |url| url.split("/").last[/\.(\w+)$/, 1]&.downcase }.compact.uniq
-            if extensions.size == 1 && %w[ttf otf woff woff2].include?(extensions.first)
+            extensions = urls.filter_map do |url|
+              url.split("/").last[/\.(\w+)$/, 1]&.downcase
+            end.uniq
+            if extensions.size == 1 && %w[ttf otf woff
+                                          woff2].include?(extensions.first)
               extensions.first
             else
               declared_format
@@ -174,7 +177,10 @@ module Fontist
             # For variable fonts, ALL styles should be marked as variable
             if family.variable_font?
               style["variable_font"] = true
-              style["variable_axes"] = family.axes.map(&:tag) if family.axes&.any?
+              if family.axes&.any?
+                style["variable_axes"] =
+                  family.axes.map(&:tag)
+              end
             else
               style["variable_font"] = false
             end

data/lib/fontist/import/google/metadata_adapter.rb

@@ -77,7 +77,7 @@ module Fontist
           font_fields = message.find_fields("fonts")
           return nil if font_fields.empty?
 
-          font_fields.map do |field|
+          font_fields.filter_map do |field|
             next unless field.message_field?
 
             # field.value is a Hash for message fields in unibuf
@@ -94,7 +94,7 @@ module Fontist
               "full_name" => field_value(font_msg, "full_name"),
               "copyright" => field_value(font_msg, "copyright"),
             }.compact
-          end.compact
+          end
         end
 
         # Extract axes array
@@ -102,7 +102,7 @@ module Fontist
           axis_fields = message.find_fields("axes")
           return nil if axis_fields.empty?
 
-          axis_fields.map do |field|
+          axis_fields.filter_map do |field|
             next unless field.message_field?
 
             axis_hash = field.value
@@ -115,7 +115,7 @@ module Fontist
               "max_value" => field_float(axis_msg, "max_value"),
               "default_value" => field_float(axis_msg, "default_value"),
             }.compact
-          end.compact
+          end
         end
 
         # Extract source information
@@ -142,7 +142,7 @@ module Fontist
           file_fields = source_msg.find_fields("files")
           return nil if file_fields.empty?
 
-          file_fields.map do |field|
+          file_fields.filter_map do |field|
             next unless field.message_field?
 
             file_hash = field.value
@@ -153,7 +153,7 @@ module Fontist
               "source_file" => field_value(file_msg, "source_file"),
               "dest_file" => field_value(file_msg, "dest_file"),
             }.compact
-          end.compact
+          end
         end
 
         # Extract registry default overrides as hash

data/lib/fontist/import/google/models/font_family.rb

@@ -43,7 +43,7 @@ module Fontist
               files_value = attributes.delete(:files)
               attributes[:files_data] = files_value
             end
-            super(**attributes)
+            super
           end
 
           # Get files as a Hash

data/lib/fontist/import/import_display.rb

@@ -113,7 +113,7 @@ module Fontist
       # @param title [String] Section title (deprecated - use header instead)
       def self.section(title)
         Fontist.ui.say("")
-        Fontist.ui.say("── #{title} " + "─" * (76 - title.length))
+        Fontist.ui.say("── #{title} " + ("─" * (76 - title.length)))
         Fontist.ui.say("")
       end
 
@@ -247,7 +247,7 @@ module Fontist
           return unless results[:errors]&.any?
 
           Fontist.ui.say("  #{Paint['⚠',
-                                    :yellow]} Note: #{results[:failed]} font#{results[:failed] > 1 ? 's' : ''} failed during import.")
+                                    :yellow]} Note: #{results[:failed]} font#{'s' if results[:failed] > 1} failed during import.")
           Fontist.ui.say("")
         end
 
@@ -266,10 +266,10 @@ module Fontist
           return if total.zero?
 
           if results[:successful] > (total * 0.5)
-            Fontist.ui.say(Paint["  🎉 Great success! #{results[:successful]} formula#{results[:successful] > 1 ? 's' : ''} created!",
+            Fontist.ui.say(Paint["  🎉 Great success! #{results[:successful]} formula#{'s' if results[:successful] > 1} created!",
                                  :green, :bright])
           elsif results[:successful].positive?
-            Fontist.ui.say(Paint["  👍 Keep going! #{results[:successful]} formula#{results[:successful] > 1 ? 's' : ''} created.",
+            Fontist.ui.say(Paint["  👍 Keep going! #{results[:successful]} formula#{'s' if results[:successful] > 1} created.",
                                  :yellow, :bright])
           end
 
@@ -277,7 +277,7 @@ module Fontist
         end
 
         def calculate_total(results)
-          results[:total] || (results[:successful] || 0) + (results[:failed] || 0) + (results[:skipped] || 0)
+          results[:total] || ((results[:successful] || 0) + (results[:failed] || 0) + (results[:skipped] || 0))
         end
       end
     end

data/lib/fontist/import/macos_importer.rb

@@ -111,7 +111,7 @@ force: false, verbose: false, import_cache: nil, schema_version: 4)
         Fontist.ui.say("#{Paint[progress,
                                 :white]} #{Paint["#{percentage}%",
                                                  :yellow]} | #{Paint[family_name, :cyan,
-                                                                     :bright]} #{Paint["(#{fonts_count} font#{fonts_count > 1 ? 's' : ''})", :black,
+                                                                     :bright]} #{Paint["(#{fonts_count} font#{'s' if fonts_count > 1})", :black,
                                                                                        :bright]}")
 
         start_time = Time.now

data/lib/fontist/import/upgrade_formulas.rb

@@ -438,9 +438,7 @@ module Fontist
 
           entry_path = File.join(extract_dir, entry.full_name)
           FileUtils.mkdir_p(File.dirname(entry_path))
-          File.open(entry_path, "wb") do |f|
-            f.write(entry.read)
-          end
+          File.binwrite(entry_path, entry.read)
         end
       end
 

data/lib/fontist/import/v4_to_v5_migrator.rb

@@ -93,7 +93,8 @@ module Fontist
       private
 
       def load_yaml_without_aliases(path)
-        data = YAML.safe_load(File.read(path), aliases: true, permitted_classes: [Date])
+        data = YAML.safe_load(File.read(path), aliases: true,
+                                               permitted_classes: [Date])
         JSON.parse(JSON.generate(data))
       end
 

data/lib/fontist/import.rb

@@ -4,7 +4,8 @@ module Fontist
     autoload :CreateFormula, "#{__dir__}/import/create_formula"
     autoload :Files, "#{__dir__}/import/files"
     autoload :FontMetadataExtractor, "#{__dir__}/import/font_metadata_extractor"
-    autoload :FontParsingErrorCollector, "#{__dir__}/import/font_parsing_error_collector"
+    autoload :FontParsingErrorCollector,
+             "#{__dir__}/import/font_parsing_error_collector"
     autoload :FontStyle, "#{__dir__}/import/font_style"
     autoload :FormulaBuilder, "#{__dir__}/import/formula_builder"
     autoload :FormulaSerializer, "#{__dir__}/import/formula_serializer"

data/lib/fontist/indexes/directory_snapshot.rb

@@ -57,8 +57,8 @@ module Fontist
       def initialize(directory_path, files, scanned_at)
         @directory_path = directory_path
         @files = files.freeze # Immutable
-        @files_by_filename = files.each_with_object({}) do |f, h|
-          h[f[:filename]] = f
+        @files_by_filename = files.to_h do |f|
+          [f[:filename], f]
         end.freeze
         @scanned_at = scanned_at
       end

data/lib/fontist/indexes/incremental_scanner.rb

@@ -53,14 +53,14 @@ module Fontist
       # cache: Optional hash of path => cached_version
       # Returns: Array of font metadata hashes
       def self.scan_batch(paths, cache: {})
-        paths.map do |path|
+        paths.filter_map do |path|
           cached = cache[path]
           if cached
             scan_with_cache(path, cached)
           else
             scan_font_file(path)
           end
-        end.compact
+        end
       end
 
       # Compute SHA256 signature of first 1KB for quick change detection

data/lib/fontist/indexes.rb

@@ -1,17 +1,21 @@
 module Fontist
   module Indexes
-    autoload :BaseFontCollectionIndex, "#{__dir__}/indexes/base_font_collection_index"
-    autoload :DefaultFamilyFontIndex, "#{__dir__}/indexes/default_family_font_index"
+    autoload :BaseFontCollectionIndex,
+             "#{__dir__}/indexes/base_font_collection_index"
+    autoload :DefaultFamilyFontIndex,
+             "#{__dir__}/indexes/default_family_font_index"
     autoload :DirectoryChange, "#{__dir__}/indexes/directory_change"
     autoload :DirectorySnapshot, "#{__dir__}/indexes/directory_snapshot"
     autoload :FilenameIndex, "#{__dir__}/indexes/filename_index"
     autoload :FontIndex, "#{__dir__}/indexes/font_index"
     autoload :FontistIndex, "#{__dir__}/indexes/fontist_index"
     autoload :FormulaKeyToPath, "#{__dir__}/indexes/formula_key_to_path"
-    autoload :IncrementalIndexUpdater, "#{__dir__}/indexes/incremental_index_updater"
+    autoload :IncrementalIndexUpdater,
+             "#{__dir__}/indexes/incremental_index_updater"
     autoload :IncrementalScanner, "#{__dir__}/indexes/incremental_scanner"
     autoload :IndexMixin, "#{__dir__}/indexes/index_mixin"
-    autoload :PreferredFamilyFontIndex, "#{__dir__}/indexes/preferred_family_font_index"
+    autoload :PreferredFamilyFontIndex,
+             "#{__dir__}/indexes/preferred_family_font_index"
     autoload :SystemIndex, "#{__dir__}/indexes/system_index"
     autoload :UserIndex, "#{__dir__}/indexes/user_index"
   end

data/lib/fontist/macos/catalog/asset.rb

@@ -29,11 +29,11 @@ module Fontist
         end
 
         def postscript_names
-          fonts.map(&:postscript_name).compact
+          fonts.filter_map(&:postscript_name)
         end
 
         def font_families
-          fonts.map(&:font_family_name).compact.uniq
+          fonts.filter_map(&:font_family_name).uniq
         end
 
         def primary_family_name

data/lib/fontist/macos_import_source.rb

@@ -1,4 +1,3 @@
-
 module Fontist
   # Import source for macOS supplementary fonts
   #

data/lib/fontist/repo.rb

@@ -194,7 +194,7 @@ module Fontist
 
         # Normalize git@ style to https style for comparison
         # git@github.com:user/repo -> github.com/user/repo
-        normalized.sub(/:/, "/")
+        normalized.sub(":", "/")
       end
 
       def ensure_private_formulas_path_exists

data/lib/fontist/system_index.rb

@@ -426,7 +426,7 @@ module Fontist
 
     def scan_directory_mtimes
       dirs = extract_font_directories
-      dirs.map { |dir| [dir, directory_mtime(dir)] }.to_h
+      dirs.to_h { |dir| [dir, directory_mtime(dir)] }
     end
 
     def directory_mtime(dir)
@@ -444,10 +444,10 @@ module Fontist
       templates = SystemFont.system_config["system"][os]["paths"]
 
       # Extract directory part before wildcards
-      base_dirs = templates.map do |pattern|
+      base_dirs = templates.filter_map do |pattern|
         # Remove glob patterns to get base directory
         pattern.split("/*").first
-      end.compact.uniq
+      end.uniq
 
       # Add fontist fonts directory
       base_dirs << Fontist.fonts_path.to_s
@@ -458,10 +458,10 @@ module Fontist
     def parse_directory_mtimes
       return {} unless directory_mtimes
 
-      Hash[directory_mtimes.map do |entry|
+      directory_mtimes.to_h do |entry|
         dir, mtime = entry.split(":", 2)
         [dir, mtime.to_i]
-      end]
+      end
     end
 
     def save_metadata

data/lib/fontist/utils/downloader.rb

@@ -135,9 +135,9 @@ module Fontist
 
       def headers
         obj = Helpers.url_object(@file)
-        obj.respond_to?(:headers) &&
+        (obj.respond_to?(:headers) &&
           obj.headers &&
-          obj.headers.to_h.map { |k, v| [k.to_s, v] }.to_h || # rubocop:disable Style/HashTransformKeys, Metrics/LineLength
+          obj.headers.to_h.to_h { |k, v| [k.to_s, v] }) || # rubocop:disable Style/HashTransformKeys, Metrics/LineLength
           {}
       end
 

data/lib/fontist/utils/system.rb

@@ -3,7 +3,7 @@ module Fontist
     module System
       # Platform override from environment (ONLY platform tags supported)
       def self.platform_override
-        ENV["FONTIST_PLATFORM_OVERRIDE"]
+        ENV.fetch("FONTIST_PLATFORM_OVERRIDE", nil)
       end
 
       def self.platform_override?
@@ -154,7 +154,7 @@ module Fontist
 
         # Convert to comparable integer: major * 10000 + minor * 100 + patch
         # This allows: 10.11.6 = 101106, 26.0.0 = 260000
-        major * 10000 + minor * 100 + patch
+        (major * 10000) + (minor * 100) + patch
       end
 
       def self.version_in_range?(min_version, max_version)