fontist 1.13.2 → 1.14.2

data/lib/fontist/cli.rb

@@ -2,7 +2,7 @@ require "thor"
 require "fontist/cli/class_options"
 require "fontist/repo_cli"
 require "fontist/import_cli"
-require "fontist/google_cli"
+require "fontist/fontconfig_cli"
 
 module Fontist
   class CLI < Thor
@@ -22,6 +22,8 @@ module Fontist
     STATUS_MANUAL_FONT_ERROR = 11
     STATUS_SIZE_LIMIT_ERROR = 12
     STATUS_FORMULA_NOT_FOUND = 13
+    STATUS_FONTCONFIG_NOT_FOUND = 14
+    STATUS_FONTCONFIG_FILE_NOT_FOUND = 15
 
     ERROR_TO_STATUS = {
       Fontist::Errors::UnsupportedFontError => [STATUS_NON_SUPPORTED_FONT_ERROR],
@@ -44,6 +46,9 @@ module Fontist
       Fontist::Errors::RepoNotFoundError => [STATUS_REPO_NOT_FOUND],
       Fontist::Errors::MainRepoNotFoundError => [STATUS_MAIN_REPO_NOT_FOUND],
       Fontist::Errors::FormulaNotFoundError => [STATUS_FORMULA_NOT_FOUND],
+      Fontist::Errors::FontconfigNotFoundError => [STATUS_FONTCONFIG_NOT_FOUND],
+      Fontist::Errors::FontconfigFileNotFoundError =>
+        [STATUS_FONTCONFIG_FILE_NOT_FOUND],
     }.freeze
 
     def self.exit_on_failure?
@@ -63,9 +68,9 @@ module Fontist
 
     desc "install FONT", "Install font"
     option :force, type: :boolean, aliases: :f,
-                   desc: "Install even if it's already installed in system"
+                   desc: "Install even if already installed in system"
     option :formula, type: :boolean, aliases: :F,
-                     desc: "Install by formula instead of font"
+                     desc: "Install whole formula instead of a font"
     option :accept_all_licenses, type: :boolean,
                                  aliases: ["--confirm-license", :a],
                                  desc: "Accept all license agreements"
@@ -76,13 +81,15 @@ module Fontist
     option :version, type: :string, aliases: :V,
                      desc: "Specify particular version of a font"
     option :smallest, type: :boolean, aliases: :s,
-                      desc: "Install the smallest formula if several"
+                      desc: "Install the smallest font by file size if several"
     option :newest, type: :boolean, aliases: :n,
                     desc: "Install the newest version of a font if several"
     option :size_limit,
            type: :numeric, aliases: :S,
-           desc: "Specify size limit for formula " \
+           desc: "Specify upper limit for file size of a formula to be installed" \
                  "(default is #{Fontist.formula_size_limit_in_megabytes} MB)"
+    option :update_fontconfig, type: :boolean, aliases: :u,
+                               desc: "Update fontconfig"
     def install(font)
       handle_class_options(options)
       confirmation = options[:accept_all_licenses] ? "yes" : "no"
@@ -196,21 +203,14 @@ module Fontist
       STATUS_SUCCESS
     end
 
-    desc "import-sil", "Import formulas from SIL"
-    def import_sil
-      handle_class_options(options)
-      require "fontist/import/sil_import"
-      Fontist::Import::SilImport.new.call
-    end
-
     desc "repo SUBCOMMAND ...ARGS", "Manage custom repositories"
     subcommand "repo", Fontist::RepoCLI
 
     desc "import SUBCOMMAND ...ARGS", "Manage imports"
     subcommand "import", Fontist::ImportCLI
 
-    desc "google SUBCOMMAND ...ARGS", "Manage Google formulas"
-    subcommand "google", Fontist::GoogleCLI
+    desc "fontconfig SUBCOMMAND ...ARGS", "Manage fontconfig"
+    subcommand "fontconfig", Fontist::FontconfigCLI
 
     private
 

data/lib/fontist/errors.rb

@@ -4,6 +4,18 @@ module Fontist
 
     class BinaryCallError < GeneralError; end
 
+    class FontconfigNotFoundError < GeneralError
+      def initialize
+        super("Could not find fontconfig.")
+      end
+    end
+
+    class FontconfigFileNotFoundError < GeneralError
+      def initialize
+        super("Fontist file could not be found in fontconfig configuration.")
+      end
+    end
+
     class FontIndexCorrupted < GeneralError; end
 
     class FontNotFoundError < GeneralError; end

data/lib/fontist/font.rb

@@ -1,6 +1,7 @@
 require "fontist/font_installer"
 require "fontist/font_path"
 require "fontist/formula_picker"
+require "fontist/fontconfig"
 
 module Fontist
   class Font
@@ -15,6 +16,7 @@ module Fontist
       @newest = options[:newest]
       @size_limit = options[:size_limit]
       @by_formula = options[:formula]
+      @update_fontconfig = options[:update_fontconfig]
 
       check_or_create_fontist_path!
     end
@@ -166,9 +168,13 @@ module Fontist
     def download_font
       return if sufficient_formulas.empty?
 
-      sufficient_formulas.flat_map do |formula|
+      paths = sufficient_formulas.flat_map do |formula|
         request_formula_installation(formula)
       end
+
+      update_fontconfig
+
+      paths
     end
 
     def request_formula_installation(formula)
@@ -220,6 +226,12 @@ module Fontist
       MSG
     end
 
+    def update_fontconfig
+      return unless @update_fontconfig
+
+      Fontconfig.update
+    end
+
     def manual_font
       return if manual_formulas.empty?
 

data/lib/fontist/fontconfig.rb

@@ -0,0 +1,87 @@
+module Fontist
+  class Fontconfig
+    def self.update
+      new.update
+    end
+
+    def self.remove(options = {})
+      new(options).remove
+    end
+
+    def initialize(options = {})
+      @options = options
+    end
+
+    def update
+      ensure_fontconfig_installed
+      create_config
+      regenerate_fontconfig_cache
+    end
+
+    def remove
+      return handle_file_not_found unless config_exists?
+
+      regenerate_fontconfig_cache if fontconfig_installed?
+      remove_config
+    end
+
+    private
+
+    def ensure_fontconfig_installed
+      raise Errors::FontconfigNotFoundError unless fontconfig_installed?
+    end
+
+    def fontconfig_installed?
+      Utils::System.fontconfig_installed?
+    end
+
+    def create_config
+      return if File.exist?(config_path)
+
+      FileUtils.mkdir_p(File.dirname(config_path))
+      File.write(config_path, config_content)
+    end
+
+    def config_path
+      File.join(xdg_config_home, "fontconfig", "conf.d", "10-fontist.conf")
+    end
+
+    def xdg_config_home
+      ENV["XDG_CONFIG_HOME"] || File.join(Dir.home, ".config")
+    end
+
+    def config_content
+      <<~CONTENT
+        <?xml version='1.0'?>
+        <!DOCTYPE fontconfig SYSTEM 'fonts.dtd'>
+        <fontconfig>
+          <dir>#{Fontist.fonts_path}</dir>
+        </fontconfig>
+      CONTENT
+    end
+
+    def regenerate_fontconfig_cache
+      Helpers.run("fc-cache -f")
+    end
+
+    def ensure_file_exists
+      return if @options[:force]
+
+      raise Errors::FontconfigFileNotFoundError unless File.exist?(config_path)
+    end
+
+    def config_exists?
+      File.exist?(config_path)
+    end
+
+    def handle_file_not_found
+      return if @options[:force]
+
+      raise Errors::FontconfigFileNotFoundError
+    end
+
+    def remove_config
+      FileUtils.rm(config_path)
+    end
+  end
+end

data/lib/fontist/fontconfig_cli.rb

@@ -0,0 +1,29 @@
+module Fontist
+  class FontconfigCLI < Thor
+    include CLI::ClassOptions
+
+    desc "update", "Update fontconfig configuration to use fontist fonts"
+    def update
+      handle_class_options(options)
+      Fontconfig.update
+      Fontist.ui.success("Fontconfig file has been successfully updated.")
+      CLI::STATUS_SUCCESS
+    rescue Errors::FontconfigNotFoundError => e
+      Fontist.ui.error(e.message)
+      CLI::STATUS_FONTCONFIG_NOT_FOUND
+    end
+
+    desc "remove", "Remove fontist file in fontconfig configuration"
+    option :force, type: :boolean, aliases: :f,
+                   desc: "Proceed even if does not exist"
+    def remove
+      handle_class_options(options)
+      Fontconfig.remove(options)
+      Fontist.ui.success("Fontconfig file has been successfully removed.")
+      CLI::STATUS_SUCCESS
+    rescue Errors::FontconfigFileNotFoundError => e
+      Fontist.ui.error(e.message)
+      CLI::STATUS_FONTCONFIG_FILE_NOT_FOUND
+    end
+  end
+end

data/lib/fontist/helpers.rb

@@ -3,5 +3,26 @@ module Fontist
     def self.parse_to_object(data)
       JSON.parse(data.to_json, object_class: OpenStruct)
     end
+
+    def self.run(command)
+      Fontist.ui.debug("Run `#{command}`")
+
+      result = `#{command}`
+      unless $CHILD_STATUS.to_i.zero?
+        raise Errors::BinaryCallError,
+              "Failed to run #{command}, status: #{$CHILD_STATUS}"
+      end
+
+      result
+    end
+
+    def self.silence_stream(stream)
+      old_stream = stream.dup
+      stream.reopen(RbConfig::CONFIG["host_os"] =~ /mswin|mingw/ ? "NUL:" : "/dev/null") # rubocop:disable Performance/RegexpMatch, Metrics/LineLength
+      stream.sync = true
+      yield
+    ensure
+      stream.reopen(old_stream)
+    end
   end
 end

data/lib/fontist/import/create_formula.rb

@@ -55,12 +55,32 @@ module Fontist
       end
 
       def save(builder)
-        filename = Import.name_to_filename(builder.name)
-        path = @options[:formula_dir] ? File.join(@options[:formula_dir], filename) : filename
+        path = vacant_path
         yaml = YAML.dump(Helpers::HashHelper.stringify_keys(builder.formula))
         File.write(path, yaml)
         path
       end
+
+      def vacant_path
+        path = path_from_name
+        return path unless @options[:keep_existing] && File.exist?(path)
+
+        2.upto(9) do |i|
+          candidate = path.sub(/\.yml$/, "#{i}.yml")
+          return candidate unless File.exist?(candidate)
+        end
+
+        raise Errors::GeneralError, "Formula #{path} already exists."
+      end
+
+      def path_from_name
+        filename = Import.name_to_filename(builder.name)
+        if @options[:formula_dir]
+          File.join(@options[:formula_dir], filename)
+        else
+          filename
+        end
+      end
     end
   end
 end

data/lib/fontist/import/files/collection_file.rb

@@ -26,9 +26,9 @@ module Fontist
 
         def read
           switch_to_temp_dir do |tmp_dir|
-            extract_ttfs(tmp_dir).map do |path|
-              Otf::FontFile.new(path)
-            end
+            extract_ttfs(tmp_dir)
+              .map { |path| Otf::FontFile.new(path) }
+              .reject { |font_file| hidden_or_pua_encoded?(font_file) }
           end
         end
 
@@ -47,6 +47,10 @@ module Fontist
           end
         end
 
+        def hidden_or_pua_encoded?(font_file)
+          font_file.family_name.start_with?(".")
+        end
+
         def detect_extension
           base_extension = "ttc"
 

data/lib/fontist/import/formula_builder.rb

@@ -4,9 +4,10 @@ require_relative "text_helper"
 module Fontist
   module Import
     class FormulaBuilder
-      FORMULA_ATTRIBUTES = %i[description homepage resources
+      FORMULA_ATTRIBUTES = %i[platforms description homepage resources
                               font_collections fonts extract copyright
-                              license_url open_license digest command].freeze
+                              license_url requires_license_agreement
+                              open_license digest command].freeze
 
       attr_writer :archive,
                   :url,
@@ -28,9 +29,15 @@ module Fontist
       def name
         return @options[:name] if @options[:name]
 
-        unique_names = both_fonts.map(&:family_name).uniq
-        TextHelper.longest_common_prefix(unique_names) ||
-          both_fonts.first.family_name
+        common = %i[family_name type]
+          .map { |attr| both_fonts.map(&attr).uniq }
+          .map { |names| TextHelper.longest_common_prefix(names) }
+          .map { |prefix| prefix unless prefix == "Regular" }
+          .compact
+          .join(" ")
+        return common unless common.empty?
+
+        both_fonts.map(&:family_name).first
       end
 
       private
@@ -50,6 +57,10 @@ module Fontist
         files
       end
 
+      def platforms
+        @options[:platforms]
+      end
+
       def description
         name
       end
@@ -175,12 +186,17 @@ module Fontist
         both_fonts.map(&:license_url).compact.first
       end
 
+      def requires_license_agreement
+        @options[:requires_license_agreement]
+      end
+
       def open_license
-        unless @license_text
+        unless @license_text || requires_license_agreement
           Fontist.ui.error("WARN: please add license manually")
-          return
         end
 
+        return unless @license_text
+
         Fontist.ui.error("WARN: ensure it's an open license, otherwise " \
                          "change the 'open_license' attribute to " \
                          "'requires_license_agreement'")

data/lib/fontist/import/google/new_fonts_fetcher.rb

@@ -121,6 +121,10 @@ module Fontist
           Down.open("https://fonts.google.com/download?family=#{name}")
           true
         rescue Down::NotFound
+          false
+        rescue Down::ClientError => e
+          raise unless e.message == "403 Forbidden"
+
           false
         rescue Down::TimeoutError
           retry unless retries >= 3

data/lib/fontist/import/helpers/system_helper.rb

@@ -4,15 +4,7 @@ module Fontist
       module SystemHelper
         class << self
           def run(command)
-            Fontist.ui.debug("Run `#{command}`")
-
-            result = `#{command}`
-            unless $CHILD_STATUS.to_i.zero?
-              raise Errors::BinaryCallError,
-                    "Failed to run #{command}, status: #{$CHILD_STATUS}"
-            end
-
-            result
+            Fontist::Helpers.run(command)
           end
         end
       end