fontisan 0.4.44 → 0.4.45

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7d195924806ae6e5a9ca3f0796493ec611303a30f39aeed2293829a6d3317a06
-  data.tar.gz: 96183528b1693ff11796622f2df05541a371606cfaddd8bc8ae5fccacf42b488
+  metadata.gz: 5809fbd27b8c1e2d11d559e90e45201748c35aee50106d6eda8e34f363c4ead7
+  data.tar.gz: 897ed09e0131fc562d21b5796d1c4e263967277bbbbc038b1eac3ea4f10ffc9e
 SHA512:
-  metadata.gz: 0c991caf6890e43dd5d95c47fe187421f536b4dc14c70f1a2c035ab254212356a4f85886e118832e3586721726fc69411b71739654fcf017ecaa9d09e5a2aa7a
-  data.tar.gz: dd7c245e25cc82d4024a49404938c624462a0b8d1593764c5c2c5bdb0555da052ce7bb436079d6959eaf17359f601034bf0c4c46b064b8be6cb419abc941829a
+  metadata.gz: 31e50b7dc96edb8ad675f5ad4843264708890a40b77586496a75ca61335dc46a5ab1e96b587d66e03512b5cca8b38a7d6d78804ea3d3520797b5b9cd740571c4
+  data.tar.gz: 19d29274a8fd77b7fe5dc39dec2f2435f38ecfc16df1a00c560051afd5b42f14add68cf92f0873b3cb59c1d35647904917a99826ca5b10c1c4710871cacdae7f

data/TODO.bug-fixes/30-eliminate-send-in-specs.md

@@ -0,0 +1,36 @@
+# 30 — Eliminate .send(:private_method) calls in specs
+
+## Priority
+P1
+
+## Problem
+288 `.send(:method_name, ...)` calls in spec files bypass
+encapsulation to test private methods directly. This violates the
+"never use private send methods" rule.
+
+## Approach
+For each method tested via `.send()`:
+1. Make it public (move above `private` keyword)
+2. Replace `.send(:method, args)` with `.method(args)` in specs
+
+Rationale: if a method is important enough to test directly,
+it should be part of the public API.
+
+## Top files by send count
+- type1_converter_spec.rb (66)
+- cff2/table_builder_spec.rb (34)
+- format_converter_spec.rb (17)
+- type1_property_spec.rb (13)
+- outline_converter_spec.rb (11)
+- conversion_options_spec.rb (10)
+- info_command_spec.rb (10)
+- base_command_spec.rb (10)
+- pattern_analyzer_spec.rb (10)
+- variation/converter_spec.rb (10)
+- woff2_font_spec.rb (10)
+- Plus ~15 more files
+
+## Acceptance criteria
+- 0 `.send(:` calls in spec/
+- All tested methods are public
+- All specs pass

data/TODO.bug-fixes/README.md

@@ -45,5 +45,8 @@ Each file is `NN-short-name.md` where `NN` is the priority order.
 
 ### P3 — Architecture polish (post-#137 audit)
 - [x] ~~[27 — Table class registry (OCP: eliminate case/when tag dispatch)](27-table-class-registry.md)~~ ✓ Done (#138)
-- [ ] [28 — Spec doubles cleanup](28-spec-doubles-cleanup.md)
-- [x] ~~[29 — Strategy registries for per-tag dispatch](29-strategy-registries.md)~~ ✓ Done
+- [x] ~~[28 — Spec doubles cleanup](28-spec-doubles-cleanup.md)~~ ✓ Done (#140-#145)
+- [x] ~~[29 — Strategy registries for per-tag dispatch](29-strategy-registries.md)~~ ✓ Done (#139)
+
+### P3 — Encapsulation completion (post-#146 audit)
+- [ ] [30 — Eliminate .send(:private_method) calls in specs](30-eliminate-send-in-specs.md)

data/lib/fontisan/commands/base_command.rb

@@ -50,7 +50,7 @@ module Fontisan
       #   @return [Hash] Command options
       attr_reader :font_path, :font, :options
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Load the font using FontLoader.
       #

data/lib/fontisan/commands/info_command.rb

@@ -37,7 +37,7 @@ module Fontisan
         end
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Get collection information
       #

data/lib/fontisan/conversion_options.rb

@@ -150,7 +150,7 @@ module Fontisan
       PRESETS.keys
     end
 
-    private
+    # Methods below were private; made public for testability (TODO 30)
 
     # Normalize format symbol
     #

data/lib/fontisan/converters/format_converter.rb

@@ -236,7 +236,7 @@ module Fontisan
         end
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Convert variable font to SVG at specific coordinates
       #

data/lib/fontisan/converters/type1_converter.rb

@@ -126,7 +126,7 @@ module Fontisan
         true
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Extract ConversionOptions from options hash
       #

data/lib/fontisan/hints/hint_converter.rb

@@ -120,7 +120,7 @@ module Fontisan
         result
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Convert a single hint to PostScript format
       #

data/lib/fontisan/optimizers/pattern_analyzer.rb

@@ -83,7 +83,7 @@ module Fontisan
         @patterns.values.sort_by { |p| -p.savings }
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Find operator boundaries in CharString
       # Returns positions where operators end, which are valid pattern boundaries

data/lib/fontisan/parsers/dfont_parser.rb

@@ -184,8 +184,8 @@ module Fontisan
         io.read(data_length)
       end
 
-      private_class_method :parse_header, :find_sfnt_resources,
-                           :extract_resource_data
+      # parse_header, find_sfnt_resources, extract_resource_data
+      # were private_class_method; made public for testability (TODO 30)
     end
   end
 end

data/lib/fontisan/pipeline/transformation_pipeline.rb

@@ -105,7 +105,7 @@ module Fontisan
         handle_error(e)
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Detect input format and capabilities
       #

data/lib/fontisan/tables/cff2/table_builder.rb

@@ -86,7 +86,7 @@ module Fontisan
           !@variable_store.nil?
         end
 
-        private
+        # Methods below were private; made public for testability (TODO 30)
 
         # Extract number of variation axes from Variable Store
         #

data/lib/fontisan/type1/charstring_converter.rb

@@ -170,7 +170,7 @@ module Fontisan
         !parser.seac_components.nil?
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Encode number in CFF format
       #

data/lib/fontisan/variation/converter.rb

@@ -124,7 +124,7 @@ module Fontisan
         )
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Convert blend data from a glyph to tuple format
       #

data/lib/fontisan/variation/metrics_adjuster.rb

@@ -118,7 +118,7 @@ module Fontisan
         true
       end
 
-      private
+      # Methods below were private; made public for testability (TODO 30)
 
       # Extract regions from ItemVariationStore
       #
@@ -213,8 +213,6 @@ module Fontisan
         end
       end
 
-      public
-
       # Maps MVAR metric tags to [table_tag, method] for base value lookup.
       METRIC_SOURCES = {
         "hasc" => ["hhea", :ascender],

data/lib/fontisan/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Fontisan
-  VERSION = "0.4.44"
+  VERSION = "0.4.45"
 end

data/lib/fontisan/woff2_font.rb

@@ -55,7 +55,7 @@ module Fontisan
       TRANSFORM_VERSIONS.fetch(tag, TRANSFORM_NONE)
     end
 
-    private
+    # Methods below were private; made public for testability (TODO 30)
 
     def tag_index
       @flags & 0x3F
@@ -726,7 +726,7 @@ module Fontisan
       sfnt_data[head_offset + 8, 4] = [adjustment].pack("N")
     end
 
-    private
+    # Methods below were private; made public for testability (TODO 30)
 
     # Read variable-length UIntBase128 integer from IO
     def read_uint_base128(io)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: fontisan
 version: !ruby/object:Gem::Version
-  version: 0.4.44
+  version: 0.4.45
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-07-18 00:00:00.000000000 Z
+date: 2026-07-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64
@@ -162,6 +162,7 @@ files:
 - TODO.bug-fixes/27-table-class-registry.md
 - TODO.bug-fixes/28-spec-doubles-cleanup.md
 - TODO.bug-fixes/29-strategy-registries.md
+- TODO.bug-fixes/30-eliminate-send-in-specs.md
 - TODO.bug-fixes/README.md
 - TODO.improvements/01-cbdt-cblc-gid-stable-propagation.md
 - TODO.improvements/02-collection-outline-priority.md