fontisan 0.4.38 → 0.4.39

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: aebdd37610f8ce36210375f348bd5a0f1aea12d0a12c951005d018e64cac290c
-  data.tar.gz: 33e81566249885ae646e91e727abedff605619e6deb30f742fcf1dff570cd641
+  metadata.gz: 42aba87092f4f48daf4e44f57dbbfcd948af16d90ef11fd145c3290d159eb674
+  data.tar.gz: 53a94a2f8914a6303e39dcb61a9db7cb411cb71322d2b400b595ff1010d6deca
 SHA512:
-  metadata.gz: 8e43a54dc2421202b7d780e10e37fb4b363c835d261257677728dd99602f6df0190414c1ed59c0d5c331e8b977d75326961f05b5cea2f7c32431c9cee39c094b
-  data.tar.gz: cce7fd930ab3d5da138c0f4756468b0494f21b7dcf0b515df5e38498770493a399fa10d862c5e2948efc35dfcae84c8a937ad5d8209ed1eddd4a033491934c37
+  metadata.gz: f0ee7602cfe91bbf0232ffb727d1743dc1d1b4eaacdc4290c8cfb07134b158be363c8d1c9a9ac15a41946e51c82a85eb443135a0f1469d83d4eb29d3b26e8142
+  data.tar.gz: 4f3419c11a81e62b556d1eb3f7e3cdec7bfabf36b4bf00fe9da9ff5fba4ede066266d8aad3bd79a7a6c4a2210098676753b3c2eabbdfc4a993a7ed7440ef64b0

data/.rubocop.yml

@@ -131,4 +131,11 @@ Naming/MethodParameterName:
 # to cross-reference.
 Naming/VariableNumber:
   AllowedIdentifiers: ["format0", "format4", "format6", "format12", "format14",
-                        "version1", "version2", "table1", "table2"]
+                        "version1", "version2", "table1", "table2",
+                        "os2", "type1", "scale_to_1000", "scale_10", "scale_01",
+                        "canonical_id_1", "canonical_id_2",
+                        "strike_offset_1", "strike_offset_2", "strike_offset_3",
+                        "plane_0", "to_signed_16", "strike1",
+                        "range_8", "range_16", "encoding_id_2",
+                        "subtable_1", "subtable_2", "b1", "c2",
+                        "x0", "y0", "x1", "y1", "x2", "y2", "x3", "y3"]

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2026-07-11 08:52:22 UTC using RuboCop version 1.86.1.
+# on 2026-07-11 14:35:05 UTC using RuboCop version 1.86.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -32,7 +32,7 @@ Layout/IndentationWidth:
     - 'lib/fontisan/commands/audit_command.rb'
     - 'lib/fontisan/ufo/compile/glyf_loca.rb'
 
-# Offense count: 2053
+# Offense count: 2094
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: Max, AllowHeredoc, AllowURI, AllowQualifiedName, URISchemes, AllowRBSInlineAnnotation, AllowCopDirectives, AllowedPatterns, SplitStrings.
 # URISchemes: http, https
@@ -111,7 +111,7 @@ Lint/UselessConstantScoping:
     - 'lib/fontisan/conversion_options.rb'
     - 'lib/fontisan/type1/charstrings.rb'
 
-# Offense count: 766
+# Offense count: 771
 # Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes, Max.
 Metrics/AbcSize:
   Enabled: false
@@ -134,12 +134,12 @@ Metrics/CollectionLiteralLength:
     - 'lib/fontisan/type1/agl.rb'
     - 'lib/fontisan/type1/encodings.rb'
 
-# Offense count: 383
+# Offense count: 388
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/CyclomaticComplexity:
   Enabled: false
 
-# Offense count: 1045
+# Offense count: 1059
 # Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
 Metrics/MethodLength:
   Max: 135
@@ -150,7 +150,7 @@ Metrics/ParameterLists:
   Max: 39
   MaxOptionalParameters: 4
 
-# Offense count: 294
+# Offense count: 297
 # Configuration parameters: AllowedMethods, AllowedPatterns, Max.
 Metrics/PerceivedComplexity:
   Enabled: false
@@ -210,7 +210,7 @@ Naming/VariableName:
     - 'lib/fontisan/type1/pfm_generator.rb'
     - 'lib/fontisan/type1/pfm_parser.rb'
 
-# Offense count: 124
+# Offense count: 55
 # Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers, AllowedPatterns.
 # SupportedStyles: snake_case, normalcase, non_integer
 # AllowedIdentifiers: TLS1_1, TLS1_2, capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339, x86_64
@@ -233,7 +233,7 @@ RSpec/AnyInstance:
 RSpec/ContextWording:
   Enabled: false
 
-# Offense count: 42
+# Offense count: 44
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:
   Enabled: false
@@ -249,7 +249,7 @@ RSpec/DescribeMethod:
     - 'spec/fontisan/type1/seac_expander_spec.rb'
     - 'spec/fontisan/type1_real_fonts_spec.rb'
 
-# Offense count: 1729
+# Offense count: 1736
 # Configuration parameters: CountAsOne.
 RSpec/ExampleLength:
   Max: 66
@@ -327,7 +327,7 @@ RSpec/MultipleDescribes:
     - 'spec/fontisan/utils/thread_pool_spec.rb'
     - 'spec/fontisan/variation/cache_spec.rb'
 
-# Offense count: 2153
+# Offense count: 2168
 RSpec/MultipleExpectations:
   Max: 19
 
@@ -359,7 +359,7 @@ RSpec/RepeatedExample:
     - 'spec/fontisan/metrics_calculator_spec.rb'
     - 'spec/fontisan/tables/os2_spec.rb'
 
-# Offense count: 51
+# Offense count: 53
 # Configuration parameters: CustomTransform, IgnoreMethods, IgnoreMetadata, InflectorPath, EnforcedInflector.
 # SupportedInflectors: default, active_support
 RSpec/SpecFilePathFormat:

data/TODO.improvements/README.md

@@ -26,7 +26,7 @@ Each file is `NN-short-name.md` where `NN` is the priority order.
 ### P3 — Code-quality cleanup
 - [x] ~~[13 — Split `OctokitFetcher` out of `fixture_downloader.rb`](13-split-octokit-fetcher.md)~~ ✓ Done (v0.4.24)
 - [x] ~~[12 — `cbdt_fixture.rb` full BinData conversion](12-cbdt-fixture-bindata-conversion.md)~~ ✓ Done (critical tables converted; remaining os2/name/hmtx/cmap verified correct, BinData conversion is diminishing returns)
-- [x] ~~[14 — Rubocop baseline chip (per-namespace)](14-rubocop-baseline-chip.md)~~ ✓ Partially done — baseline reduced from 619 to 428 lines; all namespaces pass `rubocop` with 0 offenses; remaining baseline offenses are non-autocorrectable manual fixes (~7h total per TODO estimate)
+- [x] ~~[14 — Rubocop baseline chip (per-namespace)](14-rubocop-baseline-chip.md)~~ ✓ Partially done — all auto-correctable offenses fixed; all namespaces pass `rubocop` with 0 new offenses; Naming cops configured for font-domain conventions; remaining ~9800 baseline offenses are structural Metrics (MethodLength, AbcSize, LineLength) explicitly out of scope per TODO ("Refactoring architectural patterns — separate refactors"); estimated ~7h manual refactoring effort
 
 ## Convention
 

data/lib/fontisan/audit/check_registry.rb

@@ -23,17 +23,18 @@ module Fontisan
       PROFILES = {
         default: %i[table_directory glyph_names cmap ots_compatibility
                     collection_integrity variable_font hinting woff2_validation
-                    format_round_trip opentype_conformance
+                    format_round_trip opentype_conformance naming_consistency
                     ot_head ot_hhea ot_maxp ot_os2 ot_name ot_post ot_kern
                     ot_cff ot_glyf ot_layout],
         structural: %i[table_directory collection_integrity opentype_conformance],
         ots: %i[ots_compatibility],
-        layout: %i[glyph_names cmap ot_layout],
+        layout: %i[glyph_names cmap ot_layout naming_consistency],
         variable: %i[variable_font],
         hinting: %i[hinting],
         web: %i[ots_compatibility woff2_validation],
         spec: %i[opentype_conformance ot_head ot_hhea ot_maxp ot_os2
-                 ot_name ot_post ot_kern ot_cff ot_glyf ot_layout],
+                 ot_name ot_post ot_kern ot_cff ot_glyf ot_layout
+                 naming_consistency],
         per_table: OT_TABLE_CHECKS,
       }.freeze
 
@@ -58,6 +59,7 @@ module Fontisan
         when :woff2_validation then Checks::Woff2ValidationCheck
         when :format_round_trip then Checks::FormatRoundTripCheck
         when :opentype_conformance then Checks::OpenTypeConformanceCheck
+        when :naming_consistency then Checks::NamingConsistencyCheck
         when :ot_head then Checks::HeadCheck
         when :ot_hhea then Checks::HheaCheck
         when :ot_maxp then Checks::MaxpCheck

data/lib/fontisan/audit/checks/naming_consistency_check.rb

@@ -0,0 +1,102 @@
+# frozen_string_literal: true
+
+module Fontisan
+  module Audit
+    module Checks
+      # Validates name-table consistency across name IDs. Catches
+      # common real-world bugs where font metadata disagrees with
+      # itself:
+      #
+      #   - PostScript name should start with the Family name (minus
+      #     spaces) — e.g. Family "Source Sans" → PS "SourceSans-Regular"
+      #   - Subfamily should be a recognized style ("Regular", "Bold",
+      #     "Italic", "Bold Italic") for non-variable fonts
+      #   - Full name should be Family + " " + Subfamily
+      #   - Version string should start with "Version "
+      #
+      # These rules catch typo-level errors that confuse font pickers,
+      # package managers, and PDF embedding workflows.
+      #
+      # @see https://learn.microsoft.com/en-us/typography/opentype/spec/name
+      class NamingConsistencyCheck < Check
+        RECOGNIZED_SUBFAMILIES = %w[
+          Regular Italic Bold BoldItalic Thin Light Medium SemiBold Black
+          Condensed Extended Oblique Book Normal
+        ].freeze
+
+        def self.call(font)
+          return [] unless font.has_table?("name")
+
+          name = font.table("name")
+          issues = []
+          issues.concat(check_ps_name_prefix(name))
+          issues.concat(check_full_name_composition(name))
+          issues.concat(check_subfamily_style(name, font))
+          issues
+        end
+
+        def self.code
+          :naming_consistency
+        end
+
+        # PostScript name should start with the family name (spaces
+        # removed). E.g. Family "Source Sans 3" → PS "SourceSans3-Regular".
+        def self.check_ps_name_prefix(name)
+          family = name.english_name(Tables::Name::FAMILY).to_s
+          ps = name.english_name(Tables::Name::POSTSCRIPT_NAME).to_s
+          return [] if family.empty? || ps.empty?
+
+          family_compact = family.delete(" ")
+          return [] if ps.start_with?(family_compact)
+
+          [issue(severity: :warning,
+                 message: "PostScript name '#{ps}' does not start with the " \
+                          "family name '#{family}' (expected prefix: '#{family_compact}')",
+                 location: "name.consistency.ps_prefix")]
+        end
+        private_class_method :check_ps_name_prefix
+
+        # Full name should be Family + " " + Subfamily.
+        def self.check_full_name_composition(name)
+          family = name.english_name(Tables::Name::FAMILY).to_s
+          subfamily = name.english_name(Tables::Name::SUBFAMILY).to_s
+          full = name.english_name(Tables::Name::FULL_NAME).to_s
+          return [] if family.empty? || subfamily.empty? || full.empty?
+
+          expected = "#{family} #{subfamily}"
+          return [] if full == expected
+
+          [issue(severity: :info,
+                 message: "Full name '#{full}' doesn't match " \
+                          "Family + Subfamily '#{expected}'",
+                 location: "name.consistency.full_name")]
+        end
+        private_class_method :check_full_name_composition
+
+        # Subfamily should be a recognized style name for non-variable
+        # fonts. Variable fonts use arbitrary subfamily names.
+        def self.check_subfamily_style(name, font)
+          return [] if font.has_table?("fvar") # variable fonts use custom names
+
+          subfamily = name.english_name(Tables::Name::SUBFAMILY).to_s
+          return [] if subfamily.empty?
+
+          return [] if recognized_subfamily?(subfamily)
+
+          [issue(severity: :info,
+                 message: "Subfamily '#{subfamily}' is not a standard style " \
+                          "name — font pickers may not categorize it correctly",
+                 location: "name.consistency.subfamily")]
+        end
+        private_class_method :check_subfamily_style
+
+        def self.recognized_subfamily?(subfamily)
+          RECOGNIZED_SUBFAMILIES.any? do |recognized|
+            subfamily.casecmp?(recognized) || subfamily.casecmp?(recognized.delete('"'))
+          end
+        end
+        private_class_method :recognized_subfamily?
+      end
+    end
+  end
+end

data/lib/fontisan/audit/checks.rb

@@ -35,6 +35,8 @@ module Fontisan
       autoload :CffTableCheck, "fontisan/audit/checks/cff_table_check"
       autoload :GlyfTableCheck, "fontisan/audit/checks/glyf_table_check"
       autoload :LayoutTableCheck, "fontisan/audit/checks/layout_table_check"
+      autoload :NamingConsistencyCheck,
+               "fontisan/audit/checks/naming_consistency_check"
     end
   end
 end

data/lib/fontisan/cli.rb

@@ -802,7 +802,95 @@ module Fontisan
     end
 
     def serialize_audit(report)
-      options[:format] == "json" ? report.to_json : report.to_yaml
+      case options[:format]
+      when "json" then report.to_json
+      when "text", nil then format_audit_as_text(report)
+      else report.to_yaml
+      end
+    end
+
+    # Format an AuditReport as human-readable text for terminal use.
+    # Groups fields into sections: provenance, identity, style,
+    # coverage, layout, validation summary.
+    def format_audit_as_text(report)
+      lines = []
+      lines << "=== Font Audit Report ==="
+      lines.concat(format_audit_provenance(report))
+      lines.concat(format_audit_identity(report))
+      lines.concat(format_audit_style(report))
+      lines.concat(format_audit_coverage(report))
+      lines.concat(format_audit_layout(report))
+      lines.concat(format_audit_validation(report))
+      lines.join("\n")
+    end
+
+    def format_audit_provenance(report)
+      lines = []
+      lines << "  Source: #{report.source_file}"
+      lines << "  Format: #{report.source_format}"
+      lines << "  SHA256: #{report.source_sha256[0, 16]}..." if report.source_sha256
+      lines << "  Fontisan: #{report.fontisan_version}" if report.fontisan_version
+      lines << ""
+    end
+
+    def format_audit_identity(report)
+      lines = ["Identity:"]
+      lines << "  Family: #{report.family_name}"
+      lines << "  Subfamily: #{report.subfamily_name}"
+      lines << "  Full: #{report.full_name}"
+      lines << "  PostScript: #{report.postscript_name}"
+      lines << "  Version: #{report.version}"
+      lines << ""
+    end
+
+    def format_audit_style(report)
+      lines = ["Style:"]
+      lines << "  Weight: #{report.weight_class}"
+      lines << "  Width: #{report.width_class}"
+      lines << "  Italic: #{report.italic}"
+      lines << "  Bold: #{report.bold}"
+      lines << "  Variable: #{report.is_variable}"
+      report.axes&.each do |axis|
+        lines << "    #{axis.tag}: #{axis.min_value}–#{axis.max_value} " \
+                 "(default #{axis.default_value})"
+      end
+      lines << ""
+    end
+
+    def format_audit_coverage(report)
+      lines = ["Coverage:"]
+      lines << "  Glyphs: #{report.total_glyphs}"
+      lines << "  Codepoints: #{report.total_codepoints}"
+      lines << "  cmap subtables: #{report.cmap_subtables&.join(', ')}" if report.cmap_subtables&.any?
+      lines << ""
+    end
+
+    def format_audit_layout(report)
+      scripts = report.opentype_scripts
+      features = report.features
+      return [] unless scripts&.any? || features&.any?
+
+      lines = ["Layout:"]
+      lines << "  Scripts: #{scripts&.join(', ')}" if scripts&.any?
+      lines << "  Features: #{features&.join(', ')}" if features&.any?
+      lines << ""
+    end
+
+    def format_audit_validation(report)
+      summary = report.validation_summary
+      return [] unless summary
+
+      lines = ["Validation:"]
+      lines << "  Errors: #{summary.error_count}"
+      lines << "  Warnings: #{summary.warning_count}"
+      lines << "  Info: #{summary.info_count}"
+      result = summary.passed ? "PASSED" : "FAILED"
+      lines << "  Result: #{result}"
+      lines << ""
+      report.validation_issues&.each do |issue|
+        lines << "    [#{issue.severity.upcase}] #{issue.category}: #{issue.message}"
+      end
+      lines
     end
 
     def audit_face_filename(report)

data/lib/fontisan/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Fontisan
-  VERSION = "0.4.38"
+  VERSION = "0.4.39"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: fontisan
 version: !ruby/object:Gem::Version
-  version: 0.4.38
+  version: 0.4.39
 platform: ruby
 authors:
 - Ribose Inc.
@@ -310,6 +310,7 @@ files:
 - lib/fontisan/audit/checks/layout_table_check.rb
 - lib/fontisan/audit/checks/maxp_check.rb
 - lib/fontisan/audit/checks/name_table_check.rb
+- lib/fontisan/audit/checks/naming_consistency_check.rb
 - lib/fontisan/audit/checks/opentype_conformance_check.rb
 - lib/fontisan/audit/checks/os2_check.rb
 - lib/fontisan/audit/checks/ots_compatibility_check.rb