fontisan 0.2.4 → 0.2.5

data/lib/fontisan/tables/maxp.rb

@@ -157,6 +157,66 @@ module Fontisan
         true
       end
 
+      # Validation helper: Check if version is valid (0.5 or 1.0)
+      #
+      # @return [Boolean] True if version is 0.5 or 1.0
+      def valid_version?
+        version_0_5? || version_1_0?
+      end
+
+      # Validation helper: Check if number of glyphs is valid
+      #
+      # Must be at least 1 (.notdef glyph must exist)
+      #
+      # @return [Boolean] True if num_glyphs >= 1
+      def valid_num_glyphs?
+        num_glyphs && num_glyphs >= 1
+      end
+
+      # Validation helper: Check if maxZones is valid (version 1.0 only)
+      #
+      # For TrueType fonts, maxZones must be 1 or 2
+      #
+      # @return [Boolean] True if maxZones is valid or not applicable
+      def valid_max_zones?
+        return true if version_0_5?  # Not applicable for CFF
+
+        max_zones && max_zones.between?(1, 2)
+      end
+
+      # Validation helper: Check if all TrueType metrics are present
+      #
+      # For version 1.0, all max* fields should be present
+      #
+      # @return [Boolean] True if all required fields are present
+      def has_truetype_metrics?
+        version_1_0? &&
+          !max_points.nil? &&
+          !max_contours.nil? &&
+          !max_composite_points.nil? &&
+          !max_composite_contours.nil?
+      end
+
+      # Validation helper: Check if metrics are reasonable
+      #
+      # Checks that values don't exceed reasonable limits
+      #
+      # @return [Boolean] True if metrics are within reasonable bounds
+      def reasonable_metrics?
+        # num_glyphs should not exceed 65535
+        return false if num_glyphs > 65535
+
+        if version_1_0?
+          # Check reasonable limits for TrueType metrics
+          # These are generous limits to allow for complex fonts
+          return false if max_points && max_points > 50000
+          return false if max_contours && max_contours > 10000
+          return false if max_stack_elements && max_stack_elements > 1000
+        end
+
+        true
+      end
+
       # Validate the table and raise error if invalid
       #
       # @raise [Fontisan::CorruptedTableError] If table is invalid

data/lib/fontisan/tables/name.rb

@@ -199,6 +199,82 @@ module Fontisan
         false
       end
 
+      # Validation helper: Check if version is valid (0 or 1)
+      #
+      # @return [Boolean] True if version is 0 or 1
+      def valid_version?
+        format == 0 || format == 1
+      end
+
+      # Validation helper: Check if encoding combinations are valid
+      #
+      # According to OpenType spec, certain platform/encoding combinations are valid:
+      # - Platform 0 (Unicode): encoding 0-6
+      # - Platform 1 (Mac): encoding 0-32
+      # - Platform 3 (Windows): encoding 0-10
+      #
+      # @return [Boolean] True if all encoding heuristics are valid
+      def valid_encoding_heuristics?
+        name_records.all? do |rec|
+          case rec.platform_id
+          when PLATFORM_UNICODE
+            rec.encoding_id.between?(0, 6)
+          when PLATFORM_MACINTOSH
+            rec.encoding_id.between?(0, 32)
+          when PLATFORM_WINDOWS
+            rec.encoding_id.between?(0, 10)
+          else
+            # Unknown platform - consider invalid
+            false
+          end
+        end
+      end
+
+      # Validation helper: Check if required platform combinations exist
+      #
+      # @param combos [Array<Array<Integer>>] Array of [platform_id, encoding_id, language_id] arrays
+      # @return [Boolean] True if all required combinations are present
+      #
+      # @example Check for Windows English name
+      #   name.has_valid_platform_combos?([3, 1, 0x0409])
+      def has_valid_platform_combos?(*combos)
+        combos.all? do |platform_id, encoding_id, language_id|
+          name_records.any? do |rec|
+            rec.platform_id == platform_id &&
+              rec.encoding_id == encoding_id &&
+              rec.language_id == language_id
+          end
+        end
+      end
+
+      # Validation helper: Check if family name is present and non-empty
+      #
+      # @return [Boolean] True if family name exists and is not empty
+      def family_name_present?
+        name = english_name(FAMILY)
+        !name.nil? && !name.empty?
+      end
+
+      # Validation helper: Check if PostScript name is present and non-empty
+      #
+      # @return [Boolean] True if PostScript name exists and is not empty
+      def postscript_name_present?
+        name = english_name(POSTSCRIPT_NAME)
+        !name.nil? && !name.empty?
+      end
+
+      # Validation helper: Check if PostScript name is valid
+      #
+      # PostScript names must contain only ASCII alphanumerics and hyphens
+      #
+      # @return [Boolean] True if PostScript name matches the required pattern
+      def postscript_name_valid?
+        name = english_name(POSTSCRIPT_NAME)
+        return false if name.nil? || name.empty?
+
+        name.match?(/^[A-Za-z0-9-]+$/)
+      end
+
       private
 
       # Find a name record matching the criteria

data/lib/fontisan/tables/os2.rb

@@ -170,6 +170,119 @@ module Fontisan
 
         us_upper_optical_point_size / 20.0
       end
+
+      # Validation helper: Check if version is valid
+      #
+      # Valid versions are 0 through 5
+      #
+      # @return [Boolean] True if version is 0-5
+      def valid_version?
+        version && version.between?(0, 5)
+      end
+
+      # Validation helper: Check if weight class is valid
+      #
+      # Valid values are 1-1000, common values are multiples of 100
+      #
+      # @return [Boolean] True if weight class is valid
+      def valid_weight_class?
+        us_weight_class && us_weight_class.between?(1, 1000)
+      end
+
+      # Validation helper: Check if width class is valid
+      #
+      # Valid values are 1-9
+      #
+      # @return [Boolean] True if width class is 1-9
+      def valid_width_class?
+        us_width_class && us_width_class.between?(1, 9)
+      end
+
+      # Validation helper: Check if vendor ID is present
+      #
+      # Vendor ID should be a 4-character code
+      #
+      # @return [Boolean] True if vendor ID exists and is non-empty
+      def has_vendor_id?
+        !vendor_id.empty?
+      end
+
+      # Validation helper: Check if typo metrics are reasonable
+      #
+      # Ascent should be positive, descender negative, line gap non-negative
+      #
+      # @return [Boolean] True if typo metrics have correct signs
+      def valid_typo_metrics?
+        s_typo_ascender > 0 && s_typo_descender < 0 && s_typo_line_gap >= 0
+      end
+
+      # Validation helper: Check if Win metrics are valid
+      #
+      # Both should be positive (unsigned in spec)
+      #
+      # @return [Boolean] True if Win ascent and descent are positive
+      def valid_win_metrics?
+        us_win_ascent > 0 && us_win_descent > 0
+      end
+
+      # Validation helper: Check if Unicode ranges are set
+      #
+      # At least one Unicode range bit should be set
+      #
+      # @return [Boolean] True if any Unicode range bits are set
+      def has_unicode_ranges?
+        (ul_unicode_range1 | ul_unicode_range2 | ul_unicode_range3 | ul_unicode_range4) != 0
+      end
+
+      # Validation helper: Check if PANOSE data is present
+      #
+      # All PANOSE values should not be zero
+      #
+      # @return [Boolean] True if PANOSE seems to be set
+      def has_panose?
+        panose && panose.any? { |val| val != 0 }
+      end
+
+      # Validation helper: Check if embedding permissions are set
+      #
+      # fs_type indicates embedding and subsetting permissions
+      #
+      # @return [Boolean] True if embedding permissions are defined
+      def has_embedding_permissions?
+        !fs_type.nil?
+      end
+
+      # Validation helper: Check if selection flags are valid
+      #
+      # Checks for valid combinations of selection flags
+      #
+      # @return [Boolean] True if fs_selection has valid flags
+      def valid_selection_flags?
+        return false if fs_selection.nil?
+
+        # Bits 0-9 are defined, others should be zero
+        (fs_selection & 0xFC00).zero?
+      end
+
+      # Validation helper: Check if x_height and cap_height are present (v2+)
+      #
+      # For version 2+, these should be set
+      #
+      # @return [Boolean] True if metrics are present (or not required)
+      def has_x_height_cap_height?
+        return true if version < 2  # Not required for v0-1
+
+        !sx_height.nil? && !s_cap_height.nil? && sx_height > 0 && s_cap_height > 0
+      end
+
+      # Validation helper: Check if first/last char indices are reasonable
+      #
+      # first should be <= last
+      #
+      # @return [Boolean] True if character range is valid
+      def valid_char_range?
+        us_first_char_index <= us_last_char_index
+      end
     end
   end
 end

data/lib/fontisan/tables/post.rb

@@ -143,6 +143,63 @@ module Fontisan
         end
       end
       # rubocop:enable Metrics/PerceivedComplexity
+
+      public
+
+      # Validation helper: Check if version is valid
+      #
+      # Common versions: 1.0, 2.0, 2.5, 3.0, 4.0
+      #
+      # @return [Boolean] True if version is recognized
+      def valid_version?
+        [1.0, 2.0, 2.5, 3.0, 4.0].include?(version)
+      end
+
+      # Validation helper: Check if italic angle is reasonable
+      #
+      # Italic angle should be between -60 and 60 degrees
+      #
+      # @return [Boolean] True if italic angle is within reasonable bounds
+      def valid_italic_angle?
+        italic_angle.abs <= 60.0
+      end
+
+      # Validation helper: Check if underline values are present
+      #
+      # Both position and thickness should be non-zero for valid underline
+      #
+      # @return [Boolean] True if underline metrics exist
+      def has_underline_metrics?
+        underline_position != 0 && underline_thickness != 0
+      end
+
+      # Validation helper: Check if fixed pitch flag is consistent
+      #
+      # @return [Boolean] True if is_fixed_pitch is 0 or 1
+      def valid_fixed_pitch_flag?
+        is_fixed_pitch == 0 || is_fixed_pitch == 1
+      end
+
+      # Validation helper: Check if glyph names are available
+      #
+      # For versions 1.0 and 2.0, glyph names should be accessible
+      #
+      # @return [Boolean] True if glyph names can be retrieved
+      def has_glyph_names?
+        names = glyph_names
+        !names.nil? && !names.empty?
+      end
+
+      # Validation helper: Check if version 2.0 data is complete
+      #
+      # For version 2.0, we should have glyph count and name data
+      #
+      # @return [Boolean] True if version 2.0 data is present and complete
+      def complete_version_2_data?
+        return true unless version == 2.0
+
+        !num_glyphs_v2.nil? && num_glyphs_v2 > 0 && !remaining_data.empty?
+      end
     end
   end
 end

data/lib/fontisan/validators/basic_validator.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+require_relative "validator"
+
+module Fontisan
+  module Validators
+    # BasicValidator provides minimal validation for fast font indexing
+    #
+    # This validator implements only essential checks needed for font discovery
+    # and indexing systems (e.g., Fontist). It is optimized for speed with a
+    # target performance of < 50ms per font.
+    #
+    # The validator checks only critical font identification and structural
+    # integrity, making it suitable for:
+    # - Font discovery and indexing
+    # - Quick font database updates
+    # - Large-scale font scanning
+    #
+    # @example Using BasicValidator
+    #   validator = BasicValidator.new
+    #   report = validator.validate(font)
+    #   puts "Font is valid for indexing" if report.valid?
+    #
+    # @example Target performance
+    #   # Should complete in < 50ms
+    #   start_time = Time.now
+    #   report = BasicValidator.new.validate(font)
+    #   elapsed = Time.now - start_time
+    #   puts "Validated in #{elapsed * 1000}ms"
+    class BasicValidator < Validator
+      private
+
+      # Define essential validation checks
+      #
+      # This validator implements 8 checks covering:
+      # - Required tables presence
+      # - Name table identification
+      # - Head table integrity
+      # - Maxp table glyph count
+      #
+      # All checks use helpers from Week 1 table implementations.
+      def define_checks
+        # Check 1: Required tables must be present
+        check_structure :required_tables, severity: :error do |font|
+          %w[name head maxp hhea].all? { |tag| font.table(tag) }
+        end
+
+        # Check 2: Name table version must be valid (0 or 1)
+        check_table :name_version, "name", severity: :error do |table|
+          table.valid_version?
+        end
+
+        # Check 3: Family name must be present and non-empty
+        check_table :family_name, "name", severity: :error do |table|
+          table.family_name_present?
+        end
+
+        # Check 4: PostScript name must be valid (alphanumeric + hyphens)
+        check_table :postscript_name, "name", severity: :error do |table|
+          table.postscript_name_valid?
+        end
+
+        # Check 5: Head table magic number must be correct
+        check_table :head_magic, "head", severity: :error do |table|
+          table.valid_magic?
+        end
+
+        # Check 6: Units per em must be valid (16-16384)
+        check_table :units_per_em, "head", severity: :error do |table|
+          table.valid_units_per_em?
+        end
+
+        # Check 7: Number of glyphs must be at least 1 (.notdef)
+        check_table :num_glyphs, "maxp", severity: :error do |table|
+          table.valid_num_glyphs?
+        end
+
+        # Check 8: Maxp metrics should be reasonable (not absurd values)
+        check_table :reasonable_metrics, "maxp", severity: :warning do |table|
+          table.reasonable_metrics?
+        end
+      end
+    end
+  end
+end

data/lib/fontisan/validators/font_book_validator.rb

@@ -0,0 +1,130 @@
+# frozen_string_literal: true
+
+require_relative "basic_validator"
+
+module Fontisan
+  module Validators
+    # FontBookValidator provides macOS Font Book installation compatibility checks
+    #
+    # This validator extends BasicValidator with additional checks needed for
+    # fonts to be successfully installed and used in macOS Font Book. It ensures
+    # proper encoding combinations, OS/2 metrics, and other macOS-specific
+    # requirements.
+    #
+    # The validator inherits all 8 checks from BasicValidator and adds 12 new
+    # checks focusing on:
+    # - Name table encoding combinations (Windows and Mac)
+    # - OS/2 table metrics and metadata
+    # - Head table bounding box
+    # - Hhea table metrics
+    # - Post table metadata
+    # - Cmap subtables
+    #
+    # @example Using FontBookValidator
+    #   validator = FontBookValidator.new
+    #   report = validator.validate(font)
+    #   puts "Font is Font Book compatible" if report.valid?
+    class FontBookValidator < BasicValidator
+      private
+
+      # Define Font Book compatibility checks
+      #
+      # Calls super to inherit BasicValidator's 8 checks, then adds 12 new checks.
+      # All checks use helpers from Week 1 table implementations.
+      def define_checks
+        # Inherit BasicValidator checks (8 checks)
+        super
+
+        # Check 9: Name table Windows Unicode English encoding
+        check_table :name_windows_encoding, 'name', severity: :error do |table|
+          table.has_valid_platform_combos?([3, 1, 0x0409]) # Windows Unicode English
+        end
+
+        # Check 10: Name table Mac Roman English encoding
+        check_table :name_mac_encoding, 'name', severity: :warning do |table|
+          table.has_valid_platform_combos?([1, 0, 0]) # Mac Roman English
+        end
+
+        # Check 11: OS/2 table version must be valid
+        check_table :os2_version, 'OS/2', severity: :error do |table|
+          table.valid_version?
+        end
+
+        # Check 12: OS/2 weight class must be valid (1-1000)
+        check_table :os2_weight_class, 'OS/2', severity: :error do |table|
+          table.valid_weight_class?
+        end
+
+        # Check 13: OS/2 width class must be valid (1-9)
+        check_table :os2_width_class, 'OS/2', severity: :error do |table|
+          table.valid_width_class?
+        end
+
+        # Check 14: OS/2 vendor ID should be present
+        check_table :os2_vendor_id, 'OS/2', severity: :warning do |table|
+          table.has_vendor_id?
+        end
+
+        # Check 15: OS/2 PANOSE classification should be present
+        check_table :os2_panose, 'OS/2', severity: :info do |table|
+          table.has_panose?
+        end
+
+        # Check 16: OS/2 typographic metrics must be valid
+        check_table :os2_typo_metrics, 'OS/2', severity: :error do |table|
+          table.valid_typo_metrics?
+        end
+
+        # Check 17: OS/2 Windows metrics must be valid
+        check_table :os2_win_metrics, 'OS/2', severity: :error do |table|
+          table.valid_win_metrics?
+        end
+
+        # Check 18: OS/2 Unicode ranges should be present
+        check_table :os2_unicode_ranges, 'OS/2', severity: :warning do |table|
+          table.has_unicode_ranges?
+        end
+
+        # Check 19: Head table bounding box must be valid
+        check_table :head_bounding_box, 'head', severity: :error do |table|
+          table.valid_bounding_box?
+        end
+
+        # Check 20: Hhea ascent/descent must be valid
+        check_table :hhea_ascent_descent, 'hhea', severity: :error do |table|
+          table.valid_ascent_descent?
+        end
+
+        # Check 21: Hhea line gap should be valid
+        check_table :hhea_line_gap, 'hhea', severity: :warning do |table|
+          table.valid_line_gap?
+        end
+
+        # Check 22: Hhea horizontal metrics count must be valid
+        check_table :hhea_metrics_count, 'hhea', severity: :error do |table|
+          table.valid_number_of_h_metrics?
+        end
+
+        # Check 23: Post table version must be valid
+        check_table :post_version, 'post', severity: :error do |table|
+          table.valid_version?
+        end
+
+        # Check 24: Post table italic angle should be valid
+        check_table :post_italic_angle, 'post', severity: :warning do |table|
+          table.valid_italic_angle?
+        end
+
+        # Check 25: Post table underline metrics should be present
+        check_table :post_underline, 'post', severity: :info do |table|
+          table.has_underline_metrics?
+        end
+
+        # Check 26: Cmap table must have subtables
+        check_table :cmap_subtables, 'cmap', severity: :error do |table|
+          table.has_subtables?
+        end
+      end
+    end
+  end
+end

data/lib/fontisan/validators/opentype_validator.rb

@@ -0,0 +1,112 @@
+# frozen_string_literal: true
+
+require_relative "font_book_validator"
+
+module Fontisan
+  module Validators
+    # OpenTypeValidator provides comprehensive OpenType specification compliance checks
+    #
+    # This validator extends FontBookValidator with additional checks ensuring full
+    # OpenType specification compliance. It validates glyph data, character mappings,
+    # and cross-table consistency.
+    #
+    # The validator inherits all checks from FontBookValidator (18 checks from
+    # FontBookValidator + 8 from BasicValidator = 26 total) and adds 10 new checks:
+    # - Maxp TrueType metrics validation
+    # - Glyf table structure and accessibility
+    # - Cmap Unicode mapping and coverage
+    # - Cross-table consistency checks
+    #
+    # @example Using OpenTypeValidator
+    #   validator = OpenTypeValidator.new
+    #   report = validator.validate(font)
+    #   puts "Font is OpenType compliant" if report.valid?
+    class OpenTypeValidator < FontBookValidator
+      private
+
+      # Define OpenType specification compliance checks
+      #
+      # Calls super to inherit FontBookValidator's checks, then adds 10 new checks.
+      # All checks use helpers from Week 1 table implementations.
+      def define_checks
+        # Inherit FontBookValidator checks (26 checks total)
+        super
+
+        # Check 27: Maxp TrueType metrics (only for version 1.0)
+        check_table :maxp_truetype_metrics, 'maxp', severity: :warning do |table|
+          !table.version_1_0? || table.has_truetype_metrics?
+        end
+
+        # Check 28: Maxp max zones must be valid
+        check_table :maxp_zones, 'maxp', severity: :error do |table|
+          table.valid_max_zones?
+        end
+
+        # Check 29: Glyf glyphs must be accessible (TrueType fonts only)
+        check_glyphs :glyf_accessible, severity: :error do |font|
+          glyf = font.table('glyf')
+          next true unless glyf # Skip if CFF font
+
+          loca = font.table('loca')
+          head = font.table('head')
+          maxp = font.table('maxp')
+          glyf.all_glyphs_accessible?(loca, head, maxp.num_glyphs)
+        end
+
+        # Check 30: Glyf glyphs should not be clipped
+        check_glyphs :glyf_no_clipping, severity: :warning do |font|
+          glyf = font.table('glyf')
+          next true unless glyf
+
+          loca = font.table('loca')
+          head = font.table('head')
+          maxp = font.table('maxp')
+          glyf.no_clipped_glyphs?(loca, head, maxp.num_glyphs)
+        end
+
+        # Check 31: Glyf contour counts must be valid
+        check_glyphs :glyf_valid_contours, severity: :error do |font|
+          glyf = font.table('glyf')
+          next true unless glyf
+
+          loca = font.table('loca')
+          head = font.table('head')
+          maxp = font.table('maxp')
+
+          (0...maxp.num_glyphs).all? do |glyph_id|
+            glyf.valid_contour_count?(glyph_id, loca, head)
+          end
+        end
+
+        # Check 32: Cmap must have Unicode mapping
+        check_table :cmap_unicode_mapping, 'cmap', severity: :error do |table|
+          table.has_unicode_mapping?
+        end
+
+        # Check 33: Cmap should have BMP coverage
+        check_table :cmap_bmp_coverage, 'cmap', severity: :warning do |table|
+          table.has_bmp_coverage?
+        end
+
+        # Check 34: Cmap must have format 4 subtable
+        check_table :cmap_format4, 'cmap', severity: :error do |table|
+          table.has_format_4_subtable?
+        end
+
+        # Check 35: Cmap glyph indices must be valid
+        check_structure :cmap_glyph_indices, severity: :error do |font|
+          cmap = font.table('cmap')
+          maxp = font.table('maxp')
+          cmap.valid_glyph_indices?(maxp.num_glyphs)
+        end
+
+        # Check 36: Table checksums (info level - many fonts have mismatches)
+        check_structure :checksum_valid, severity: :info do |font|
+          # Table checksum validation (info level - for reference)
+          # Most fonts have checksum mismatches, so we make it info not error
+          true # Placeholder - actual checksum validation if desired
+        end
+      end
+    end
+  end
+end