fog 1.23.0 → 1.24.0

data/lib/fog/vcloud_director/requests/compute/post_configure_edge_gateway_services.rb

@@ -41,7 +41,10 @@ module Fog
                   )
           end
 
-          owner = {:href => '', :name => nil, :type => nil} #known-bug: admin-api does not return owner.
+          owner = {
+            :href => make_href("admin/edgeGateway/#{id}"),
+            :type => 'application/vnd.vmware.vcloud.gateway+xml'
+          }
           task_id = enqueue_task(
               "Configuring edgegateway(#{id})", 'networkConfigureEdgeGatewayServices', owner,
               :on_success => lambda do
@@ -49,11 +52,14 @@ module Fog
               end
           )
 
+          task = task_body(task_id)
+          task.delete(:Owner)  # known bug - admin tasks do not return Owner
+
           body = {
               :xmlns => xmlns,
               :xmlns_xsi => xmlns_xsi,
               :xsi_schemaLocation => xsi_schema_location,
-          }.merge(task_body(task_id))
+          }.merge(task)
 
           Excon::Response.new(
               :status => 202,

data/lib/fog/vcloud_director/requests/compute/put_network.rb

@@ -131,19 +131,23 @@ module Fog
             network_body[:FenceMode] = configuration[:FenceMode] if ip_scope.key?(:FenceMode)
           end
 
-          owner = {:href => '', :name => nil, :type => nil} #known-bug: admin-api does not return owner.
+          owner = {
+            :href => make_href("#{type}/#{id}"),
+            :type => "application/vnd.vmware.vcloud.#{type}+xml"
+          }
           task_id = enqueue_task(
             "Updating #{type} #{name} (#{id})", 'networkUpdateNetwork', owner,
             :on_success => lambda do
               data[:networks][id] = network_body
             end
           )
-
+          task = task_body(task_id)
+          task.delete(:Owner) #known-bug: admin-api does not return owner.
           body = {
               :xmlns => xmlns,
               :xmlns_xsi => xmlns_xsi,
               :xsi_schemaLocation => xsi_schema_location,
-          }.merge(task_body(task_id))
+          }.merge(task)
 
           Excon::Response.new(
             :status => 202,

data/lib/fog/version.rb

@@ -1,3 +1,3 @@
 module Fog
-  VERSION = '1.23.0'
+  VERSION = '1.24.0'
 end

data/lib/fog/vsphere/requests/compute/vm_clone.rb

@@ -145,6 +145,7 @@ module Fog
           # Build up all the crappy tiered objects like the perl method
           # Collect your variables ifset (writing at 11pm revist me)
           # * domain <~String> - *REQUIRED* - Sets the server's domain for customization
+          # * dnsSuffixList <~Array> - Optional - Sets the dns search paths in resolv - Example: ["dev.example.com", "example.com"]
           # * ipsettings <~Hash> - Optional - If not set defaults to dhcp
           #  * ip <~String> - *REQUIRED* Sets the ip address of the VM - Example: 10.0.0.10
           #  * dnsServerList <~Array> - Optional - Sets the nameservers in resolv - Example: ["10.0.0.2", "10.0.0.3"]
@@ -165,7 +166,7 @@ module Fog
             cust_ip_settings.dnsDomain = cust_domain
             cust_global_ip_settings = RbVmomi::VIM::CustomizationGlobalIPSettings.new
             cust_global_ip_settings.dnsServerList = cust_ip_settings.dnsServerList
-            cust_global_ip_settings.dnsSuffixList = [cust_domain]
+            cust_global_ip_settings.dnsSuffixList = cust_options['dnsSuffixList'] || [cust_domain]
             cust_hostname = RbVmomi::VIM::CustomizationFixedName.new(:name => cust_options['hostname']) if cust_options.key?('hostname')
             cust_hostname ||= RbVmomi::VIM::CustomizationFixedName.new(:name => options['name'])
             cust_hwclockutc = cust_options['hw_clock_utc']

data/lib/fog/xenserver/compute.rb

@@ -113,6 +113,9 @@ module Fog
       request :snapshot_revert
 
       class Real
+          
+        attr_reader :connection
+
         def initialize(options={})
           @host        = options[:xenserver_url]
           @username    = options[:xenserver_username]

data/lib/fog/xenserver/core.rb

@@ -13,6 +13,8 @@ module Fog
 
     class Connection
       require 'xmlrpc/client'
+      
+      attr_reader :credentials
 
       def initialize(host, timeout)
         @factory = XMLRPC::Client.new(host, '/')

data/lib/tasks/changelog_task.rb

@@ -104,6 +104,7 @@ Watchers      | #{watchers}
       def former_mvp?(committer)
          [
            'Aaron Suggs',
+           'ller', #"Achim Ledermüller" UTF-8 fail?
            'Ash Wilson',
            'Benson Kalahar',
            'Brian Hartsock',
@@ -121,6 +122,7 @@ Watchers      | #{watchers}
            'Kyle Rames',
            'Lincoln Stoll',
            'Luqman Amjad',
+           'Michael Hale',
            'Michael Zeng',
            'Mike Hagedorn',
            'Mike Pountney',

data/tests/aws/models/auto_scaling/instance_tests.rb

@@ -0,0 +1,15 @@
+require 'fog/aws/models/auto_scaling/instance'
+
+Shindo.tests("Fog::AWS::AutoScaling::Instance", 'aws') do
+  @instance = Fog::AWS::AutoScaling::Instance.new
+
+  test('#healthy? = true') do
+    @instance.health_status = 'Healthy'
+    @instance.healthy? == true
+  end
+
+  test('#heatlhy? = false') do
+    @instance.health_status = 'Unhealthy'
+    @instance.healthy? == false
+  end
+end

data/tests/aws/models/storage/file_tests.rb

@@ -74,6 +74,16 @@ Shindo.tests("Storage[:aws] | file", ["aws"]) do
 
     end
 
+    acl = Fog::Storage[:aws].get_object_acl(@directory.key, @instance.key).body["AccessControlList"]
+
+    tests("#acl").returns(acl) do
+      @instance.acl
+    end
+
+    tests("#public?").returns(acl.any? {|grant| grant['Grantee']['URI'] == 'http://acs.amazonaws.com/groups/global/AllUsers' && grant['Permission'] == 'READ'}) do
+      @instance.public?
+    end
+
   end
 
   @directory.versions.each(&:destroy)

data/tests/aws/requests/compute/region_tests.rb

@@ -24,11 +24,29 @@ Shindo.tests('Fog::Compute[:aws] | region requests', ['aws']) do
         Fog::Compute::AWS.new({:aws_access_key_id => 'dummykey',
                 :aws_secret_access_key => 'dummysecret',
                 :aws_session_token => 'dummytoken',
-                :region => "world-antarctica-1"})
+                :region => 'world-antarctica-1'})
       end
 
     end
 
+    tests("#unknown_endpoint").formats(@regions_format) do
+      Fog::Compute::AWS.new({:aws_access_key_id => 'dummykey',
+                             :aws_secret_access_key => 'dummysecret',
+                             :aws_session_token => 'dummytoken',
+                             :region => 'world-antarctica-1',
+                             :endpoint => 'http://aws-clone.example'}).describe_regions.body
+    end
+
+    tests("#invalid_endpoint") do
+      raises(Fog::Compute::AWS::InvalidURIError) do
+        Fog::Compute::AWS.new({:aws_access_key_id => 'dummykey',
+                             :aws_secret_access_key => 'dummysecret',
+                             :aws_session_token => 'dummytoken',
+                             :region => 'world-antarctica-1',
+                             :endpoint => 'aws-clone.example'})
+      end
+    end
+
   end
 
 end

data/tests/aws/requests/dns/health_check_tests.rb

@@ -0,0 +1,159 @@
+Shindo.tests('Fog::DNS[:aws] | DNS requests', ['aws', 'dns']) do
+
+  pending if Fog.mocking?
+
+  @r53_connection = Fog::DNS[:aws]
+
+  tests('success') do
+
+    tests('create a health check') do
+      after do
+        @r53_connection.delete_health_check(@response.body['HealthCheck']['Id'])
+      end
+
+      test('create an IP TCP based health check') do
+        @response = @r53_connection.create_health_check('8.8.8.8', '53', 'TCP')
+        @response.status == 201 &&
+          @response.body['HealthCheck']['HealthCheckConfig']['IPAddress'] == '8.8.8.8' &&
+          @response.body['HealthCheck']['HealthCheckConfig']['Port'] == '53'
+      end
+
+      test('create a FQDN HTTP based health check') do
+        @options = {
+          :fqdn => "www.amazon.com",
+          :resource_path => "/gp/cart/view.html/ref=nav_cart"
+        }
+        @response = @r53_connection.create_health_check(nil, '80', 'HTTP', @options)
+        @response.status == 201 &&
+          @response.body['HealthCheck']['HealthCheckConfig']['IPAddress'].nil? &&
+          @response.body['HealthCheck']['HealthCheckConfig']['Port'] == '80' &&
+          @response.body['HealthCheck']['HealthCheckConfig']['FullyQualifiedDomainName'] == 'www.amazon.com'
+      end
+    end
+
+    tests('get a health check') do
+      @options = {
+        :fqdn => "www.amazon.com",
+        :resource_path => "/gp/cart/view.html/ref=nav_cart",
+        :search_string => "Amazon",
+        :request_interval => 10,
+        :failure_threshold => "7"
+      }
+      create_response = @r53_connection.create_health_check('8.8.8.8', '443', 'HTTPS_STR_MATCH', @options)
+      @health_check_id = create_response.body['HealthCheck']['Id']
+      @response = @r53_connection.get_health_check(@health_check_id)
+
+      sleep 2
+      @r53_connection.delete_health_check(@health_check_id)
+
+      test('id') do
+        @response.body['HealthCheck']['Id'] == @health_check_id
+      end
+
+      {
+        'IPAddress' => '8.8.8.8',
+        'Port' => '443',
+        'Type' => 'HTTPS_STR_MATCH',
+        'FullyQualifiedDomainName' => @options[:fqdn],
+        'ResourcePath' => @options[:resource_path],
+        'RequestInterval' => @options[:request_interval],
+        'FailureThreshold' => @options[:failure_threshold]
+      }.each do |key, value|
+        test("and check property #{key}") do
+          @response.body['HealthCheck']['HealthCheckConfig'][key] == value
+        end
+      end
+    end
+
+    tests('delete a health check') do
+      before do
+        response = @r53_connection.create_health_check('8.8.8.8', '53', 'TCP')
+        @health_check_id = response.body['HealthCheck']['Id']
+      end
+
+      test('setup as IP TCP') do
+        response = @r53_connection.delete_health_check(@health_check_id)
+        response.status == 200
+      end
+    end
+
+    tests('listing health checks') do
+      test('succeeds') do
+        response = @r53_connection.list_health_checks
+        response.status == 200
+      end
+
+      before do
+        response_1 = @r53_connection.create_health_check('8.8.8.8', '53', 'TCP')
+        @health_check_1_id = response_1.body['HealthCheck']['Id']
+        options = {
+          :fqdn => "www.amazon.com",
+          :resource_path => "/gp/cart/view.html/ref=nav_cart"
+        }
+        response_2 = @r53_connection.create_health_check(nil, '80', 'HTTP', options)
+        @health_check_2_id = response_2.body['HealthCheck']['Id']
+        @health_check_ids = [@health_check_1_id, @health_check_2_id]
+      end
+
+      after do
+        @health_check_ids.each { |id| @r53_connection.delete_health_check id }
+      end
+
+      test('contains 2 new health checks') do
+        sleep 2
+        response = @r53_connection.list_health_checks
+        health_checks_by_id = response.body['HealthChecks'].map do |health_check|
+          health_check['Id']
+        end.to_a
+        @health_check_ids.all? { |id| health_checks_by_id.include?(id) }
+      end
+
+      test('contains properties') do
+        sleep 2
+        response = @r53_connection.list_health_checks
+        list_response_2 = response.body['HealthChecks'].find { |health_check| health_check['Id'] == @health_check_2_id }
+
+        list_response_2['HealthCheckConfig']['Type'] == 'HTTP' &&
+          list_response_2['HealthCheckConfig']['FullyQualifiedDomainName'] == 'www.amazon.com' &&
+          list_response_2['HealthCheckConfig']['IPAddress'].nil?
+      end
+    end
+
+    tests('assign a health check to a DNS record') do
+      after do
+        @r53_connection.change_resource_record_sets(@zone_id, [@resource_record.merge(:action => 'DELETE')])
+        @r53_connection.delete_hosted_zone(@zone_id)
+        @r53_connection.delete_health_check @health_check_id
+      end
+
+      health_check_response = @r53_connection.create_health_check('8.8.8.8', '53', 'TCP')
+      raise "Health check was not created" unless health_check_response.status == 201
+      @health_check_id = health_check_response.body['HealthCheck']['Id']
+
+      @domain_name = generate_unique_domain
+      zone_response = @r53_connection.create_hosted_zone(@domain_name)
+      raise "Zone was not created for #{@domain_name}" unless zone_response.status == 201
+      @zone_id = zone_response.body['HostedZone']['Id']
+
+      @resource_record = {
+        :name => "www.#{@domain_name}.",
+        :type => 'A',
+        :ttl => 3600,
+        :resource_records => ['8.8.4.4'],
+        :health_check_id => @health_check_id,
+        :set_identifier => SecureRandom.hex(8),
+        :weight => 50
+      }
+      resource_record_set = [@resource_record.merge(:action => 'CREATE')]
+      record_response = @r53_connection.change_resource_record_sets @zone_id, resource_record_set
+      raise "A record was not created" unless record_response.status == 200
+
+      test('succeeds') do
+        new_record = @r53_connection.list_resource_record_sets(@zone_id).body['ResourceRecordSets'].find do |record|
+          record['Name'] == @resource_record[:name]
+        end
+        new_record['HealthCheckId'] == @health_check_id
+      end
+    end
+  end
+end

data/tests/aws/requests/iam/account_policy_tests.rb

@@ -0,0 +1,20 @@
+Shindo.tests('AWS::IAM | account policy requests', ['aws']) do
+
+  tests('success') do
+    tests("#update_account_password_policy(minimum_password_length, max_password_age, password_reuse_prevention,require_symbols,require_numbers,require_uppercase_characters, require_lowercase_characters,allow_users_to_change_password, hard_expiry, expire_passwords)").formats(AWS::IAM::Formats::BASIC) do
+      minimum_password_length, password_reuse_prevention, max_password_age = 5
+      require_symbols, require_numbers, require_uppercase_characters, require_lowercase_characters, allow_users_to_change_password, hard_expiry, expire_passwords = false
+   
+      Fog::AWS[:iam].update_account_password_policy(minimum_password_length, max_password_age, password_reuse_prevention,require_symbols,require_numbers,require_uppercase_characters, require_lowercase_characters,allow_users_to_change_password, hard_expiry, expire_passwords).body
+    end
+
+    tests("#get_account_password_policy()") do
+      Fog::AWS[:iam].get_account_password_policy().body['AccountPasswordPolicy']
+    end
+
+    tests("#delete_account_password_policy()").formats(AWS::IAM::Formats::BASIC) do
+  
+      Fog::AWS[:iam].delete_account_password_policy().body
+    end    
+  end
+end

data/tests/aws/requests/storage/bucket_tests.rb

@@ -66,6 +66,10 @@ Shindo.tests('Fog::Storage[:aws] | bucket requests', ["aws"]) do
       Fog::Storage[:aws].get_bucket(@aws_bucket_name).body
     end
 
+    tests("#head_bucket('#{@aws_bucket_name}')").succeeds do
+      Fog::Storage[:aws].head_bucket(@aws_bucket_name)
+    end 
+
     file.destroy
 
     file1 = Fog::Storage[:aws].directories.get(@aws_bucket_name).files.create(:body => 'a',    :key => 'a/a1/file1')

data/tests/google/helpers/google_tests_helper.rb

@@ -15,6 +15,74 @@ def create_test_disk(connection, zone)
   disk
 end
 
+def create_test_http_health_check(connection)
+  random_string = SecureRandom.hex
+  health_check = connection.http_health_checks.create({
+      :name => "fog-test-check-#{random_string}"
+      })
+  health_check
+end
+
+def create_test_backend_service(connection)
+  random_string = SecureRandom.hex
+  health_check = create_test_http_health_check(connection)
+  backend_service = connection.backend_services.create({
+      :name => "fog-test-backend-service-#{random_string}",
+      :health_checks => [health_check]
+      })
+end
+
+def create_test_url_map(connection)
+  random_string = SecureRandom.hex
+  backend_service = create_test_backend_service(connection)
+  url_map = connection.url_maps.create({
+      :name => "fog-test-url-map-#{random_string}",
+      :defaultService => backend_service.self_link
+      })
+end
+
+def create_test_server(connection, zone)
+  random_string = SecureRandom.hex
+  disk = create_test_disk(connection,zone)
+  server = connection.servers.create({
+      :name => "fog-test-server-#{random_string}",
+      :disks => [disk],
+      :zone => zone,
+      :machine_type => 'n1-standard-1'
+      })
+end
+
+def create_test_target_http_proxy(connection)
+  random_string = SecureRandom.hex
+  url_map = create_test_url_map(connection)
+  proxy = connection.target_http_proxies.create({
+      :name => "fog-test-target-http-proxy-#{random_string}",
+      :urlMap => url_map.self_link
+      })
+end
+
+def create_test_zone_view(connection, zone)
+  random_string = SecureRandom.hex
+  zone_view = connection.zone_views.create({
+      :name => "fog-test-zone-view-#{random_string}",
+      :zone => zone
+      })
+  zone_view.wait_for {ready?}
+  zone_view
+end
+
+def create_test_target_pool(connection, region)
+  random_string = SecureRandom.hex
+  http_health_check = create_test_http_health_check(connection)
+  instance = create_test_server(connection, 'us-central1-a')
+  target_pool = connection.target_pools.create({
+      :name => "fog-test-target-pool-#{random_string}",
+      :region => region,
+      :healthChecks => [http_health_check.self_link],
+      :instances => [instance.self_link]\
+      })
+end
+
 def wait_operation(connection, response)
   operation = connection.operations.get(response['name'], response['zone'], response['region'])
   operation.wait_for { ready? }